Re: [PATCH] davinci: vpfe: fix error path in probe

2013-05-10 Thread Prabhakar Lad
Hi Hans, On Fri, May 10, 2013 at 4:25 PM, Hans Verkuil wrote: > On Fri May 10 2013 06:48:38 Lad Prabhakar wrote: >> From: Lad, Prabhakar [Snip] >> > > Just FYI: > > After applying this patch I get a compiler warning that the probe_free_lock > label is unused. I've added a patch removing that lab

Re: [PATCH] davinci: vpfe: fix error path in probe

2013-05-10 Thread Hans Verkuil
On Fri May 10 2013 06:48:38 Lad Prabhakar wrote: > From: Lad, Prabhakar > > The error path on failure was calling mutex_unlock(), but there was > no actuall call before for mutex_lock(). This patch fixes this issue > by pointing it to proper go label. > > Reported-by: Jose Pablo Carballo > Sign

[PATCH] davinci: vpfe: fix error path in probe

2013-05-09 Thread Lad Prabhakar
From: Lad, Prabhakar The error path on failure was calling mutex_unlock(), but there was no actuall call before for mutex_lock(). This patch fixes this issue by pointing it to proper go label. Reported-by: Jose Pablo Carballo Signed-off-by: Lad, Prabhakar --- drivers/media/platform/davinci/vp