Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-05 Thread Guennadi Liakhovetski
On Wed, 4 Jan 2012, Guennadi Liakhovetski wrote: > On Wed, 4 Jan 2012, Laurent Pinchart wrote: > > > On Wednesday 04 January 2012 18:13:58 Guennadi Liakhovetski wrote: > > > On Wed, 4 Jan 2012, Laurent Pinchart wrote: > > > > On Wednesday 04 January 2012 17:35:27 Guennadi Liakhovetski wrote: > >

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-04 Thread Guennadi Liakhovetski
On Wed, 4 Jan 2012, Laurent Pinchart wrote: > On Wednesday 04 January 2012 18:13:58 Guennadi Liakhovetski wrote: > > On Wed, 4 Jan 2012, Laurent Pinchart wrote: > > > On Wednesday 04 January 2012 17:35:27 Guennadi Liakhovetski wrote: > > > > On Wed, 4 Jan 2012, javier Martin wrote: > > > > > > >

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-04 Thread Laurent Pinchart
On Wednesday 04 January 2012 18:13:58 Guennadi Liakhovetski wrote: > On Wed, 4 Jan 2012, Laurent Pinchart wrote: > > On Wednesday 04 January 2012 17:35:27 Guennadi Liakhovetski wrote: > > > On Wed, 4 Jan 2012, javier Martin wrote: > > > > > > [snip] > > > > > > > For ov7725 it is a natural thing

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-04 Thread Guennadi Liakhovetski
On Wed, 4 Jan 2012, Laurent Pinchart wrote: > Hi Guennadi, > > On Wednesday 04 January 2012 17:35:27 Guennadi Liakhovetski wrote: > > On Wed, 4 Jan 2012, javier Martin wrote: > > > > [snip] > > > > > For ov7725 it is a natural thing to do since it was originally > > > developed for soc-camera a

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-04 Thread Laurent Pinchart
Hi Guennadi, On Wednesday 04 January 2012 17:35:27 Guennadi Liakhovetski wrote: > On Wed, 4 Jan 2012, javier Martin wrote: > > [snip] > > > For ov7725 it is a natural thing to do since it was originally > > developed for soc-camera and it can easily do the following to access > > platform data:

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-04 Thread Guennadi Liakhovetski
On Wed, 4 Jan 2012, javier Martin wrote: [snip] > For ov7725 it is a natural thing to do since it was originally > developed for soc-camera and it can easily do the following to access > platform data: > > struct soc_camera_link*icl = soc_camera_i2c_to_link(client); > pdata = icl->priv;

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-04 Thread javier Martin
Hi Guennadi. Thanks for your help. On 3 January 2012 16:05, Guennadi Liakhovetski wrote: > Hi Javier > > On Tue, 3 Jan 2012, javier Martin wrote: > >> Guennadi, >> probably you could answer me some question: >> >> as we agreed I'm trying to implement ENUM_INPUT support to soc-camera >> through pa

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-03 Thread Guennadi Liakhovetski
Hi Javier On Tue, 3 Jan 2012, javier Martin wrote: > Guennadi, > probably you could answer me some question: > > as we agreed I'm trying to implement ENUM_INPUT support to soc-camera > through pads. No, you probably mean in the subdev driver, not in soc-camera core. > This means I must be able

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2012-01-03 Thread javier Martin
Guennadi, probably you could answer me some question: as we agreed I'm trying to implement ENUM_INPUT support to soc-camera through pads. This means I must be able to pass the tvp5150 decoder some platform_data in order to configure what inputs are really routed in my board. For that purpose I do

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread Mauro Carvalho Chehab
On 19-12-2011 09:25, javier Martin wrote: > On 19 December 2011 11:58, Guennadi Liakhovetski > wrote: >> On Mon, 19 Dec 2011, javier Martin wrote: >> >>> On 19 December 2011 11:41, Guennadi Liakhovetski >>> wrote: On Mon, 19 Dec 2011, Laurent Pinchart wrote: > Hi Guennadi, > >

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread Laurent Pinchart
Hi Mauro, On Monday 19 December 2011 17:28:18 Mauro Carvalho Chehab wrote: > On 19-12-2011 09:52, Laurent Pinchart wrote: > > On Monday 19 December 2011 12:43:28 Guennadi Liakhovetski wrote: > >> On Mon, 19 Dec 2011, javier Martin wrote: > >>> On 19 December 2011 11:58, Guennadi Liakhovetski wrote

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread Mauro Carvalho Chehab
On 19-12-2011 09:52, Laurent Pinchart wrote: > Hi, > > On Monday 19 December 2011 12:43:28 Guennadi Liakhovetski wrote: >> On Mon, 19 Dec 2011, javier Martin wrote: >>> On 19 December 2011 11:58, Guennadi Liakhovetski wrote: On Mon, 19 Dec 2011, javier Martin wrote: > On 19 December 2011

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread javier Martin
>> I agree that input enumeration is needed, but I really think this should be >> handled through pads, no with a new subdev operation. I don't like the idea >> of >> introducing a new operation that will already be deprecated from the very >> beginning. >> >> Implementing this through pads isn't

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread Guennadi Liakhovetski
On Mon, 19 Dec 2011, Laurent Pinchart wrote: > Hi, > > On Monday 19 December 2011 12:43:28 Guennadi Liakhovetski wrote: > > On Mon, 19 Dec 2011, javier Martin wrote: > > > On 19 December 2011 11:58, Guennadi Liakhovetski wrote: > > > > On Mon, 19 Dec 2011, javier Martin wrote: > > > >> On 19 Dece

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread Laurent Pinchart
Hi, On Monday 19 December 2011 12:43:28 Guennadi Liakhovetski wrote: > On Mon, 19 Dec 2011, javier Martin wrote: > > On 19 December 2011 11:58, Guennadi Liakhovetski wrote: > > > On Mon, 19 Dec 2011, javier Martin wrote: > > >> On 19 December 2011 11:41, Guennadi Liakhovetski wrote: > > >> > On Mo

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread Guennadi Liakhovetski
On Mon, 19 Dec 2011, javier Martin wrote: > On 19 December 2011 11:58, Guennadi Liakhovetski > wrote: > > On Mon, 19 Dec 2011, javier Martin wrote: > > > >> On 19 December 2011 11:41, Guennadi Liakhovetski > >> wrote: > >> > On Mon, 19 Dec 2011, Laurent Pinchart wrote: > >> > > >> >> Hi Guenna

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread javier Martin
On 19 December 2011 11:58, Guennadi Liakhovetski wrote: > On Mon, 19 Dec 2011, javier Martin wrote: > >> On 19 December 2011 11:41, Guennadi Liakhovetski >> wrote: >> > On Mon, 19 Dec 2011, Laurent Pinchart wrote: >> > >> >> Hi Guennadi, >> >> >> >> On Monday 19 December 2011 11:13:58 Guennadi L

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread Guennadi Liakhovetski
On Mon, 19 Dec 2011, javier Martin wrote: > On 19 December 2011 11:41, Guennadi Liakhovetski > wrote: > > On Mon, 19 Dec 2011, Laurent Pinchart wrote: > > > >> Hi Guennadi, > >> > >> On Monday 19 December 2011 11:13:58 Guennadi Liakhovetski wrote: > >> > On Mon, 19 Dec 2011, Laurent Pinchart wro

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread javier Martin
On 19 December 2011 11:41, Guennadi Liakhovetski wrote: > On Mon, 19 Dec 2011, Laurent Pinchart wrote: > >> Hi Guennadi, >> >> On Monday 19 December 2011 11:13:58 Guennadi Liakhovetski wrote: >> > On Mon, 19 Dec 2011, Laurent Pinchart wrote: >> > > On Monday 19 December 2011 09:09:34 Guennadi Liak

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread Guennadi Liakhovetski
On Mon, 19 Dec 2011, Laurent Pinchart wrote: > Hi Guennadi, > > On Monday 19 December 2011 11:13:58 Guennadi Liakhovetski wrote: > > On Mon, 19 Dec 2011, Laurent Pinchart wrote: > > > On Monday 19 December 2011 09:09:34 Guennadi Liakhovetski wrote: > > > > On Mon, 19 Dec 2011, Laurent Pinchart wr

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread Laurent Pinchart
Hi Guennadi, On Monday 19 December 2011 11:13:58 Guennadi Liakhovetski wrote: > On Mon, 19 Dec 2011, Laurent Pinchart wrote: > > On Monday 19 December 2011 09:09:34 Guennadi Liakhovetski wrote: > > > On Mon, 19 Dec 2011, Laurent Pinchart wrote: > > > > On Friday 16 December 2011 10:50:21 Guennadi

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread Guennadi Liakhovetski
On Mon, 19 Dec 2011, Laurent Pinchart wrote: > Hi Guennadi, > > On Monday 19 December 2011 09:09:34 Guennadi Liakhovetski wrote: > > On Mon, 19 Dec 2011, Laurent Pinchart wrote: > > > On Friday 16 December 2011 10:50:21 Guennadi Liakhovetski wrote: > > > > On Fri, 16 Dec 2011, Scott Jiang wrote:

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread Laurent Pinchart
Hi Javier, On Monday 19 December 2011 08:44:58 javier Martin wrote: > Hi, > thank you for your comments. > > Let me try to summarize the conclusions we've agreed here: > 1.- soc-camera can support S_INPUT as long as I provide backwards > compatibility in case subdev does not support s_routing (i.

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread Laurent Pinchart
Hi Guennadi, On Monday 19 December 2011 09:09:34 Guennadi Liakhovetski wrote: > On Mon, 19 Dec 2011, Laurent Pinchart wrote: > > On Friday 16 December 2011 10:50:21 Guennadi Liakhovetski wrote: > > > On Fri, 16 Dec 2011, Scott Jiang wrote: > > > > >> How about this implementation? I know it's not

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-19 Thread Guennadi Liakhovetski
On Mon, 19 Dec 2011, Laurent Pinchart wrote: > Hi Guennadi, > > On Friday 16 December 2011 10:50:21 Guennadi Liakhovetski wrote: > > On Fri, 16 Dec 2011, Scott Jiang wrote: > > > >> How about this implementation? I know it's not for soc, but I post it > > > >> to give my idea. > > > >> Bridge kno

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-18 Thread javier Martin
Hi, thank you for your comments. Let me try to summarize the conclusions we've agreed here: 1.- soc-camera can support S_INPUT as long as I provide backwards compatibility in case subdev does not support s_routing (i.e. I must resend my patch returning input 0 in case s_routing is not supported).

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-18 Thread Laurent Pinchart
Hi Guennadi, On Friday 16 December 2011 10:50:21 Guennadi Liakhovetski wrote: > On Fri, 16 Dec 2011, Scott Jiang wrote: > > >> How about this implementation? I know it's not for soc, but I post it > > >> to give my idea. > > >> Bridge knows the layout, so it doesn't need to query the subdevice. >

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread Guennadi Liakhovetski
On Fri, 16 Dec 2011, Scott Jiang wrote: > >> How about this implementation? I know it's not for soc, but I post it > >> to give my idea. > >> Bridge knows the layout, so it doesn't need to query the subdevice. > > > > Where from? AFAIU, we are talking here about subdevice inputs, right? In > > thi

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread javier Martin
On 16 December 2011 10:36, Scott Jiang wrote: >>> How about this implementation? I know it's not for soc, but I post it >>> to give my idea. >>> Bridge knows the layout, so it doesn't need to query the subdevice. >> >> Where from? AFAIU, we are talking here about subdevice inputs, right? In >> thi

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread Scott Jiang
>> How about this implementation? I know it's not for soc, but I post it >> to give my idea. >> Bridge knows the layout, so it doesn't need to query the subdevice. > > Where from? AFAIU, we are talking here about subdevice inputs, right? In > this case about various inputs of the TV decoder. How sh

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread javier Martin
On 16 December 2011 09:47, Guennadi Liakhovetski wrote: > Hi Javier > > On Fri, 16 Dec 2011, Javier Martin wrote: > >> Some v4l-subdevs such as tvp5150 have multiple >> inputs. This patch allows the user of a soc-camera >> device to select between them. > > Sure, we can support it. But I've got a

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread javier Martin
On 16 December 2011 09:34, Scott Jiang wrote: > 2011/12/16 Javier Martin : >> Some v4l-subdevs such as tvp5150 have multiple >> inputs. This patch allows the user of a soc-camera >> device to select between them. >> >> Signed-off-by: Javier Martin >> --- >>  drivers/media/video/soc_camera.c |    

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread Guennadi Liakhovetski
On Fri, 16 Dec 2011, Scott Jiang wrote: > Hi Guennadi, > > > First question: you probably also want to patch soc_camera_g_input() and > > soc_camera_enum_input(). But no, I do not know how. The video subdevice > > operations do not seem to provide a way to query subdevice routing > > capabilities

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread Scott Jiang
Hi Guennadi, > First question: you probably also want to patch soc_camera_g_input() and > soc_camera_enum_input(). But no, I do not know how. The video subdevice > operations do not seem to provide a way to query subdevice routing > capabilities, so, I've got no idea how we're supposed to support

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread Guennadi Liakhovetski
Hi Javier On Fri, 16 Dec 2011, Javier Martin wrote: > Some v4l-subdevs such as tvp5150 have multiple > inputs. This patch allows the user of a soc-camera > device to select between them. Sure, we can support it. But I've got a couple of remarks: First question: you probably also want to patch s

Re: [PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread Scott Jiang
2011/12/16 Javier Martin : > Some v4l-subdevs such as tvp5150 have multiple > inputs. This patch allows the user of a soc-camera > device to select between them. > > Signed-off-by: Javier Martin > --- >  drivers/media/video/soc_camera.c |    6 +++--- >  1 files changed, 3 insertions(+), 3 deletion

[PATCH] V4L: soc-camera: provide support for S_INPUT.

2011-12-16 Thread Javier Martin
Some v4l-subdevs such as tvp5150 have multiple inputs. This patch allows the user of a soc-camera device to select between them. Signed-off-by: Javier Martin --- drivers/media/video/soc_camera.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/soc