Re: [PATCH] RFC: v4l2-ctrls: Inmplement v4l2_ctrl_new_std_compound()

2019-09-20 Thread Hans Verkuil
On 9/20/19 12:33 PM, Ricardo Ribalda Delgado wrote: > Hello Hans > > Thanks for your review! I will implement the changes and resend, just > one comment. > > > On Fri, Sep 20, 2019 at 12:07 PM Hans Verkuil wrote: >> >> On 9/17/19 6:21 PM, Ricardo Ribalda Delgado wrote: >>> Hi Hans >>> >>> Is t

Re: [PATCH] RFC: v4l2-ctrls: Inmplement v4l2_ctrl_new_std_compound()

2019-09-20 Thread Ricardo Ribalda Delgado
Hello Hans Thanks for your review! I will implement the changes and resend, just one comment. On Fri, Sep 20, 2019 at 12:07 PM Hans Verkuil wrote: > > On 9/17/19 6:21 PM, Ricardo Ribalda Delgado wrote: > > Hi Hans > > > > Is this something close to what you were having in mind? Right now it >

Re: [PATCH] RFC: v4l2-ctrls: Inmplement v4l2_ctrl_new_std_compound()

2019-09-20 Thread Hans Verkuil
On 9/17/19 6:21 PM, Ricardo Ribalda Delgado wrote: > Hi Hans > > Is this something close to what you were having in mind? Right now it > sits on > https://github.com/ribalda/linux/commit/de21dbc2f57b58b22f5d73bc314dd8e59dff5c7d > but I will make it as the beginning of my patchset if you think tha

Re: [PATCH] RFC: v4l2-ctrls: Inmplement v4l2_ctrl_new_std_compound()

2019-09-17 Thread Ricardo Ribalda Delgado
Hi Hans Is this something close to what you were having in mind? Right now it sits on https://github.com/ribalda/linux/commit/de21dbc2f57b58b22f5d73bc314dd8e59dff5c7d but I will make it as the beginning of my patchset if you think that I am on the right track. Thanks! On Tue, Sep 17, 2019 at 6:

[PATCH] RFC: v4l2-ctrls: Inmplement v4l2_ctrl_new_std_compound()

2019-09-17 Thread Ricardo Ribalda Delgado
Implement v4l2_ctrl_new_std_compound. This is just a discussion patch, do not merge as is, and be gentle with the author ;P. Signed-off-by: Ricardo Ribalda Delgado --- drivers/media/i2c/imx214.c | 13 +++-- drivers/media/v4l2-core/v4l2-ctrls.c | 79 +--- include