Re: [PATCH] OV5642: fix VIDIOC_S_GROP ioctl

2012-11-28 Thread Anatolij Gustschin
Hi Guennadi, On Mon, 26 Nov 2012 16:20:14 +0100 (CET) Guennadi Liakhovetski wrote: ... > > --- a/drivers/media/platform/soc_camera/soc_camera.c > > +++ b/drivers/media/platform/soc_camera/soc_camera.c > > @@ -902,6 +902,8 @@ static int soc_camera_s_crop(struct file *file, void > > *fh, > >

Re: [PATCH] OV5642: fix VIDIOC_S_GROP ioctl

2012-11-26 Thread Guennadi Liakhovetski
Hi Anatolij Sorry for a delay On Tue, 6 Nov 2012, Anatolij Gustschin wrote: > On Tue, 6 Nov 2012 12:45:51 +0100 (CET) > Guennadi Liakhovetski wrote: > > > On Tue, 6 Nov 2012, Anatolij Gustschin wrote: > > > > > VIDIOC_S_GROP ioctl doesn't work, soc-camera driver reports: > > > > > > soc-came

Re: [PATCH] OV5642: fix VIDIOC_S_GROP ioctl

2012-11-06 Thread Anatolij Gustschin
On Tue, 6 Nov 2012 12:45:51 +0100 (CET) Guennadi Liakhovetski wrote: > On Tue, 6 Nov 2012, Anatolij Gustschin wrote: > > > VIDIOC_S_GROP ioctl doesn't work, soc-camera driver reports: > > > > soc-camera-pdrv soc-camera-pdrv.0: S_CROP denied: getting current crop > > failed > > > > The issue i

Re: [PATCH] OV5642: fix VIDIOC_S_GROP ioctl

2012-11-06 Thread Guennadi Liakhovetski
On Tue, 6 Nov 2012, Anatolij Gustschin wrote: > VIDIOC_S_GROP ioctl doesn't work, soc-camera driver reports: > > soc-camera-pdrv soc-camera-pdrv.0: S_CROP denied: getting current crop failed > > The issue is caused by checking for V4L2_BUF_TYPE_VIDEO_CAPTURE type > in driver's g_crop callback. T

[PATCH] OV5642: fix VIDIOC_S_GROP ioctl

2012-11-05 Thread Anatolij Gustschin
VIDIOC_S_GROP ioctl doesn't work, soc-camera driver reports: soc-camera-pdrv soc-camera-pdrv.0: S_CROP denied: getting current crop failed The issue is caused by checking for V4L2_BUF_TYPE_VIDEO_CAPTURE type in driver's g_crop callback. This check should be in s_crop instead, g_crop should just s