Re: [PATCH] Mantis: append tasklet maintenance for DVB stream delivery

2010-07-09 Thread Marko Ristola
Resending into linux-media, for confirming authorship: I have personally done this patch. Acked-by: Marko M Ristola Regards, Marko 20.06.2010 16:51, Bjørn Mork kirjoitti: > Note that mantis_core_exit() is never called. Unless I've missed > something, the drivers/media/dvb/mantis/mantis_core.{

Re: [PATCH] Mantis: append tasklet maintenance for DVB stream delivery

2010-07-09 Thread Bjørn Mork
Marko Ristola writes: > 20.06.2010 16:51, Bjørn Mork kirjoitti: >> Note that mantis_core_exit() is never called. Unless I've missed >> something, the drivers/media/dvb/mantis/mantis_core.{h,c} files can >> just be deleted. They look like some development leftovers? >> >> > I see. mantis_core

Re: [PATCH] Mantis: append tasklet maintenance for DVB stream delivery

2010-06-20 Thread Marko Ristola
20.06.2010 16:51, Bjørn Mork kirjoitti: Note that mantis_core_exit() is never called. Unless I've missed something, the drivers/media/dvb/mantis/mantis_core.{h,c} files can just be deleted. They look like some development leftovers? I see. mantis_core.ko kernel module exists though. Maybe

Re: [PATCH] Mantis: append tasklet maintenance for DVB stream delivery

2010-06-20 Thread Bjørn Mork
Marko Ristola writes: > The following schedule might also be a problem: > 1. mantis_core_exit: mantis_dma_stop() > 2. mantis_core_exit: mantis_dma_exit(). Note that mantis_core_exit() is never called. Unless I've missed something, the drivers/media/dvb/mantis/mantis_core.{h,c} files can just be

[PATCH] Mantis: append tasklet maintenance for DVB stream delivery

2010-06-20 Thread Marko Ristola
Hi I have a patch that should fix possible memory corruption problems in Mantis drivers with tasklets after DMA transfer has been stopped. In the patch tasklet is enabled only for DVB stream delivery, at end of DVB stream delivery tasklet is disabled again. The lack of tasklet maintenance mig