Re: [PATCH] Inlined functions should be static.

2011-05-25 Thread Mauro Carvalho Chehab
Em 23-05-2011 15:50, Hans Petter Selasky escreveu: > On Monday 23 May 2011 20:29:28 Mauro Carvalho Chehab wrote: >> Em 23-05-2011 15:23, Guennadi Liakhovetski escreveu: >>> On Mon, 23 May 2011, Hans Petter Selasky wrote: --HPS >>> >>> (again, inlining would save me copy-pasting) >> >> Yeah...

Re: [PATCH] Inlined functions should be static.

2011-05-23 Thread Hans Petter Selasky
On Monday 23 May 2011 20:29:28 Mauro Carvalho Chehab wrote: > Em 23-05-2011 15:23, Guennadi Liakhovetski escreveu: > > On Mon, 23 May 2011, Hans Petter Selasky wrote: > >> --HPS > > > > (again, inlining would save me copy-pasting) > > Yeah... hard to comment not-inlined patches... > > >> -inline

Re: [PATCH] Inlined functions should be static.

2011-05-23 Thread Mauro Carvalho Chehab
Em 23-05-2011 15:23, Guennadi Liakhovetski escreveu: > On Mon, 23 May 2011, Hans Petter Selasky wrote: > >> --HPS >> > > (again, inlining would save me copy-pasting) Yeah... hard to comment not-inlined patches... > >> -inline u32 stb0899_do_div(u64 n, u32 d) >> +static inline u32 stb0899_do_di

Re: [PATCH] Inlined functions should be static.

2011-05-23 Thread Guennadi Liakhovetski
On Mon, 23 May 2011, Hans Petter Selasky wrote: > --HPS > (again, inlining would save me copy-pasting) > -inline u32 stb0899_do_div(u64 n, u32 d) > +static inline u32 stb0899_do_div(u64 n, u32 d) while at it you could as well remove the unneeded in a C file "inline" attribute. Thanks Guennad

[PATCH] Inlined functions should be static.

2011-05-23 Thread Hans Petter Selasky
--HPS From 446037f0f999759b4b801b6512d18bae769465bb Mon Sep 17 00:00:00 2001 From: Hans Petter Selasky Date: Mon, 23 May 2011 16:06:22 +0200 Subject: [PATCH] Inlined functions should be static. Signed-off-by: Hans Petter Selasky --- drivers/media/dvb/frontends/stb0899_algo.c |2 +- 1 files