Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

2010-04-06 Thread Hans Verkuil
On Wednesday 24 March 2010 14:45:50 Douglas Schilling Landgraf wrote: > Hello Ricardo, > > On Wed, Mar 24, 2010 at 10:27 AM, Ricardo Maraschini > wrote: > > Signed-off-by: Ricardo Maraschini > > > > --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:52:23 2010 > > -0300 > > +++ b/li

Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

2010-03-24 Thread Douglas Schilling Landgraf
Hello Ricardo, On Wed, Mar 24, 2010 at 10:27 AM, Ricardo Maraschini wrote: > Signed-off-by: Ricardo Maraschini > > --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:52:23 2010 -0300 > +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Wed Mar 24 09:57:06 2010 -0300 > @@ -1401,8 +1401,6

Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

2010-03-24 Thread Ricardo Maraschini
Signed-off-by: Ricardo Maraschini --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:52:23 2010 -0300 +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Wed Mar 24 09:57:06 2010 -0300 @@ -1401,8 +1401,6 @@ case CX88_BOARD_SAMSUNG_SMT_7020: dev->ts_gen_cntrl = 0x08;

Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

2010-03-23 Thread Ricardo Maraschini
On Tue, Mar 23, 2010 at 5:48 PM, Devin Heitmueller wrote: > How do you think this actually addresses the warning in question?  You > still have the declaration of the variable in the middle of the switch > statement. My mistake, sorry. I'm working on it. Thanks for your tip, I really appreciate t

Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

2010-03-23 Thread Ricardo Maraschini
Hi Randy, On Tue, Mar 23, 2010 at 4:45 PM, Randy Dunlap wrote: > Did you test this patch (by building this driver)? > I think not. I tried to compile with the patch, but in a wrong way. Sorry. I'm going to adjust the patch and send again. > Also, the Signed-off-by: line should be before the pat

Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

2010-03-23 Thread Devin Heitmueller
On Tue, Mar 23, 2010 at 4:42 PM, Ricardo Maraschini wrote: > --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 16:17:11 2010 -0300 > +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:29:29 2010 -0300 > @@ -1401,7 +1401,8 @@ >       case CX88_BOARD_SAMSUNG_SMT_7020: >          

Re: [PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

2010-03-23 Thread Randy Dunlap
Ricardo Maraschini wrote: > --- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 16:17:11 2010 -0300 > +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:29:29 2010 -0300 > @@ -1401,7 +1401,8 @@ >case CX88_BOARD_SAMSUNG_SMT_7020: >dev->ts_gen_cntrl = 0x08; >

[PATCH] Fix Warning ISO C90 forbids mixed declarations and code - cx88-dvb

2010-03-23 Thread Ricardo Maraschini
--- a/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 16:17:11 2010 -0300 +++ b/linux/drivers/media/video/cx88/cx88-dvb.c Tue Mar 23 17:29:29 2010 -0300 @@ -1401,7 +1401,8 @@ case CX88_BOARD_SAMSUNG_SMT_7020: dev->ts_gen_cntrl = 0x08; - struct cx88_core *co