Re: [PATCH] Bttv: move check on unsigned

2009-01-29 Thread Mauro Carvalho Chehab
On Sat, 24 Jan 2009 17:27:09 -0800 (PST) Trent Piepho wrote: > On Mon, 19 Jan 2009, Trent Piepho wrote: > > On Sat, 17 Jan 2009, Roel Kluin wrote: > > > Please review, this patch was not tested. > > > > > > The static function set_tvnorm is called in > > > drivers/media/video/bt8xx/bttv-driver.c:

Re: [PATCH] Bttv: move check on unsigned

2009-01-24 Thread Trent Piepho
On Mon, 19 Jan 2009, Trent Piepho wrote: > On Sat, 17 Jan 2009, Roel Kluin wrote: > > Please review, this patch was not tested. > > > > The static function set_tvnorm is called in > > drivers/media/video/bt8xx/bttv-driver.c: > > > > 1355: set_tvnorm(btv, norm); > > 1868: set_tvnorm(btv, i); > >

Re: [PATCH] Bttv: move check on unsigned

2009-01-19 Thread Trent Piepho
On Sat, 17 Jan 2009, Roel Kluin wrote: > Please review, this patch was not tested. > > The static function set_tvnorm is called in > drivers/media/video/bt8xx/bttv-driver.c: > > 1355: set_tvnorm(btv, norm); > 1868: set_tvnorm(btv, i); > 3273: set_tvnorm(btv,btv->tvnorm); > > in the first two

[PATCH] Bttv: move check on unsigned

2009-01-17 Thread Roel Kluin
Please review, this patch was not tested. The static function set_tvnorm is called in drivers/media/video/bt8xx/bttv-driver.c: 1355: set_tvnorm(btv, norm); 1868: set_tvnorm(btv, i); 3273: set_tvnorm(btv,btv->tvnorm); in the first two with an unsigned, but bttv->tvnorm is signed. see vi dr