Re: [PATCH] Add GS1662 driver (a SPI video serializer)

2016-04-15 Thread Charles-Antoine Couret
Le 15/04/2016 10:38, Hans Verkuil a écrit : > I think the media subsystem is definitely the right place for this. > > I would use the cs3308.c driver as a starting point. This is also a minimal > driver > (and you can remove the code under CONFIG_VIDEO_ADV_DEBUG for your driver), > but it > uses

Re: [PATCH] Add GS1662 driver (a SPI video serializer)

2016-04-15 Thread Hans Verkuil
On 04/04/2016 02:35 PM, Jean-Michel Hautbois wrote: >>> Next, you should add a complete description to your commit. Just >>> having an object and a signed-off-by line is not enough. >> Oh, I'm sorry, I don't have any idea to explicit more details. I will >> find something for that. > > Just get th

Re: [PATCH] Add GS1662 driver (a SPI video serializer)

2016-04-04 Thread Jean-Michel Hautbois
>> Next, you should add a complete description to your commit. Just >> having an object and a signed-off-by line is not enough. > Oh, I'm sorry, I don't have any idea to explicit more details. I will > find something for that. Just get the description from the datasheet as a start ;-). >> You als

Re: [PATCH] Add GS1662 driver (a SPI video serializer)

2016-04-04 Thread Charles-Antoine Couret
Le 01/04/2016 21:11, Jean-Michel Hautbois a écrit : > Hi Charles-Antoine, Hi, > FIrst of all, we, on the ML, do prefer reading patches as sent by git > send-email tool. Ok, I will configure that. > Next, you should add a complete description to your commit. Just > having an object and a signed-o

Re: [PATCH] Add GS1662 driver (a SPI video serializer)

2016-04-01 Thread Jean-Michel Hautbois
Hi Charles-Antoine, Thank you for the patch. FIrst of all, we, on the ML, do prefer reading patches as sent by git send-email tool. It is easier to comment the patch. Next, you should add a complete description to your commit. Just having an object and a signed-off-by line is not enough. You also

Fwd: [PATCH] Add GS1662 driver (a SPI video serializer)

2016-04-01 Thread Charles-Antoine Couret
>From 65b48bf1c77801c210bf93c07bc7f513efdbcbb5 Mon Sep 17 00:00:00 2001 From: Charles-Antoine Couret Date: Fri, 1 Apr 2016 17:19:26 +0200 Subject: [PATCH] Add GS1662 driver (a SPI video serializer) Signed-off-by: Charles-Antoine Couret --- drivers/media/Kconfig | 1 + drivers/me

[PATCH] Add GS1662 driver (a SPI video serializer)

2016-04-01 Thread Charles-Antoine Couret
>From 65b48bf1c77801c210bf93c07bc7f513efdbcbb5 Mon Sep 17 00:00:00 2001 From: Charles-Antoine Couret Date: Fri, 1 Apr 2016 17:19:26 +0200 Subject: [PATCH] Add GS1662 driver (a SPI video serializer) Signed-off-by: Charles-Antoine Couret --- drivers/media/Kconfig | 1 + drivers/me

[PATCH] Add GS1662 driver (a SPI video serializer)

2016-04-01 Thread Charles-Antoine Couret
>From 65b48bf1c77801c210bf93c07bc7f513efdbcbb5 Mon Sep 17 00:00:00 2001 From: Charles-Antoine Couret Date: Fri, 1 Apr 2016 17:19:26 +0200 Subject: [PATCH] Add GS1662 driver (a SPI video serializer) Signed-off-by: Charles-Antoine Couret --- drivers/media/Kconfig | 1 + drivers/me