Em Mon, 25 Apr 2016 12:26:40 -0300
Ezequiel Garcia escreveu:
> Hi Mauro, Hans:
>
> Thanks for the fixes to this driver :-)
>
> On 25 Apr 09:40 AM, Mauro Carvalho Chehab wrote:
> > Ezequiel,
> >
> > Btw, I'm not seeing support for fps != 25 (or 30 fps) on this driver.
> > As the device seems to
Hi Mauro, Hans:
Thanks for the fixes to this driver :-)
On 25 Apr 09:40 AM, Mauro Carvalho Chehab wrote:
> Ezequiel,
>
> Btw, I'm not seeing support for fps != 25 (or 30 fps) on this driver.
> As the device seems to support setting the fps, you should be adding
> support on it for VIDIOC_S_PARM
Em Mon, 25 Apr 2016 14:42:31 +0200
Hans Verkuil escreveu:
> > So, I would go to the following enclosed patch.
>
> Looks good to me. Acked below. Amazing how many bugs one can make in one
> simple patch...
Applied, thanks!
Yeah, simple patches are harder than complex ones ;)
>
> >
> > Eze
On 04/25/2016 02:40 PM, Mauro Carvalho Chehab wrote:
> Em Mon, 25 Apr 2016 13:36:57 +0200
> Hans Verkuil escreveu:
>
>> Since my patch exchanges the sparse warning with a smatch warning, it's
>> OK to take this one, with a few corrections:
>>
>> Please update the subject line (it says tvp686x ins
Em Mon, 25 Apr 2016 13:36:57 +0200
Hans Verkuil escreveu:
> Since my patch exchanges the sparse warning with a smatch warning, it's
> OK to take this one, with a few corrections:
>
> Please update the subject line (it says tvp686x instead of tw686x).
Gah...
>
> On 04/23/2016 11:23 AM, Mauro C
Since my patch exchanges the sparse warning with a smatch warning, it's
OK to take this one, with a few corrections:
Please update the subject line (it says tvp686x instead of tw686x).
On 04/23/2016 11:23 AM, Mauro Carvalho Chehab wrote:
> Depending on the compiler version, currently it produces
On 04/23/2016 11:23 AM, Mauro Carvalho Chehab wrote:
> Depending on the compiler version, currently it produces the
> following warnings:
> tw686x-video.c: In function 'tw686x_video_init':
> tw686x-video.c:65:543: warning: array subscript is above array bounds
> [-Warray-bounds]
I pos
Depending on the compiler version, currently it produces the
following warnings:
tw686x-video.c: In function 'tw686x_video_init':
tw686x-video.c:65:543: warning: array subscript is above array bounds
[-Warray-bounds]
This is actually bogus with the current code, as it currently
ha
