Re: [PATCH] [media] si4713: Remove "select SI4713"

2014-02-09 Thread Hans Verkuil
On 02/09/2014 06:37 PM, Paul Bolle wrote: > On Sun, 2014-02-09 at 18:04 +0100, Hans Verkuil wrote: >> The i2c module is loaded by v4l2_i2c_new_subdev_board(). > > I see. Thanks. > > But now I wonder: is I2C_SI4713 useful on itself? Would anyone use > si4713.ko without using either radio-usb-si471

Re: [PATCH] [media] si4713: Remove "select SI4713"

2014-02-09 Thread Paul Bolle
On Sun, 2014-02-09 at 18:04 +0100, Hans Verkuil wrote: > The i2c module is loaded by v4l2_i2c_new_subdev_board(). I see. Thanks. But now I wonder: is I2C_SI4713 useful on itself? Would anyone use si4713.ko without using either radio-usb-si4713.ko or radio-platform-si4713.ko? Because it seems that

Re: [PATCH] [media] si4713: Remove "select SI4713"

2014-02-09 Thread Hans Verkuil
On 02/09/2014 04:27 PM, Paul Bolle wrote: > Hans, > > On Sun, 2014-02-09 at 16:18 +0100, Hans Verkuil wrote: >> USB_SI4713 and PLATFORM_SI4713 both depend on I2C_SI4713. So the select >> should be I2C_SI4713. > > Are you sure? I've actually scanned si4713.c before submitting this > patch and I co

Re: [PATCH] [media] si4713: Remove "select SI4713"

2014-02-09 Thread Paul Bolle
Hans, On Sun, 2014-02-09 at 16:18 +0100, Hans Verkuil wrote: > USB_SI4713 and PLATFORM_SI4713 both depend on I2C_SI4713. So the select > should be I2C_SI4713. Are you sure? I've actually scanned si4713.c before submitting this patch and I couldn't find anything in it that these other two modules

Re: [PATCH] [media] si4713: Remove "select SI4713"

2014-02-09 Thread Hans Verkuil
On 02/09/2014 03:56 PM, Paul Bolle wrote: > Commits 7391232e1215 ("[media] si4713: Reorganized drivers/media/radio > directory") and b874b39fcd2f ("[media] si4713: Added the USB driver for > Si4713") both added a "select SI4713". But there's no Kconfig symbol > SI4713, so these selects are nops. It

[PATCH] [media] si4713: Remove "select SI4713"

2014-02-09 Thread Paul Bolle
Commits 7391232e1215 ("[media] si4713: Reorganized drivers/media/radio directory") and b874b39fcd2f ("[media] si4713: Added the USB driver for Si4713") both added a "select SI4713". But there's no Kconfig symbol SI4713, so these selects are nops. It's not clear why they were added but it's safe to