Re: [PATCH] [media] si2165: Fix possible leak in si2165_upload_firmware()

2015-02-11 Thread Luis de Bethencourt
On Thu, Feb 12, 2015 at 01:42:45AM +0200, Antti Palosaari wrote: > On 02/12/2015 01:38 AM, Luis de Bethencourt wrote: > >On Wed, Feb 11, 2015 at 10:45:01PM +0100, Matthias Schwarzott wrote: > >>On 11.02.2015 21:58, Christian Engelmayer wrote: > >>>In case of an error function si2165_upload_firmware

Re: [PATCH] [media] si2165: Fix possible leak in si2165_upload_firmware()

2015-02-11 Thread Antti Palosaari
On 02/12/2015 01:38 AM, Luis de Bethencourt wrote: On Wed, Feb 11, 2015 at 10:45:01PM +0100, Matthias Schwarzott wrote: On 11.02.2015 21:58, Christian Engelmayer wrote: In case of an error function si2165_upload_firmware() releases the already requested firmware in the exit path. However, there

Re: [PATCH] [media] si2165: Fix possible leak in si2165_upload_firmware()

2015-02-11 Thread Luis de Bethencourt
On Wed, Feb 11, 2015 at 10:45:01PM +0100, Matthias Schwarzott wrote: > On 11.02.2015 21:58, Christian Engelmayer wrote: > > In case of an error function si2165_upload_firmware() releases the already > > requested firmware in the exit path. However, there is one deviation where > > the function dire

Re: [PATCH] [media] si2165: Fix possible leak in si2165_upload_firmware()

2015-02-11 Thread Matthias Schwarzott
On 11.02.2015 21:58, Christian Engelmayer wrote: > In case of an error function si2165_upload_firmware() releases the already > requested firmware in the exit path. However, there is one deviation where > the function directly returns. Use the correct cleanup so that the firmware > memory gets free

[PATCH] [media] si2165: Fix possible leak in si2165_upload_firmware()

2015-02-11 Thread Christian Engelmayer
In case of an error function si2165_upload_firmware() releases the already requested firmware in the exit path. However, there is one deviation where the function directly returns. Use the correct cleanup so that the firmware memory gets freed correctly. Detected by Coverity CID 1269120. Signed-of