Re: [PATCH] [media] saa7164: use an MSI interrupt when available

2015-02-26 Thread Kyle Sanderson
This isn't my patch, however shouldn't these bridges already exist in drivers/pci/quirks.c? Kyle. On Thu, Feb 26, 2015 at 12:45 PM, Steven Toth wrote: >> I am under the impression it was against the spec to have a PCI-E card >> without MSI support. Wouldn't the fallback code as well work in this

Re: [PATCH] [media] saa7164: use an MSI interrupt when available

2015-02-26 Thread Steven Toth
> I am under the impression it was against the spec to have a PCI-E card > without MSI support. Wouldn't the fallback code as well work in this > regard? Not if the motherboard MSI implementation is flakey, like we've seen in the past with other PCIe bridges and their interaction with root control

Re: [PATCH] [media] saa7164: use an MSI interrupt when available

2015-02-26 Thread Kyle Sanderson
The patch allows the card to support using both internal tuners without crashing out. I've been recording significantly since the 23rd, it just works now in comparison to constant maintenance. I am under the impression it was against the spec to have a PCI-E card without MSI support. Wouldn't the

Re: [PATCH] [media] saa7164: use an MSI interrupt when available

2015-02-26 Thread Steven Toth
> I believe the root cause of the crash is due to a DMA/IRQ race condition. It > most commonly occurs when the saa7164 driver is dealing with more than one > saa7164 chip (the HVR-2200 and HVR-2250 for example have two - one for each > tuner). Given MSI avoids DMA/IRQ race conditions - this would e

[PATCH] [media] saa7164: use an MSI interrupt when available

2015-02-25 Thread Brendan McGrath
From: Brendan McGrath [media] saa7164: use an MSI interrupt when available Fixes a known crash which most commonly occurs when multiple saa7164 chips are in use. Signed-off-by: Brendan McGrath --- drivers/media/pci/saa7164/saa7164-core.c | 34 ++-- drivers/med