Hi, Sylwester
On 3/20/2014 10:44 PM, Sylwester Nawrocki wrote:
Hi Josh,
On 19/03/14 10:17, Josh Wu wrote:
On 3/15/2014 5:17 AM, Sylwester Nawrocki wrote:
On 03/14/2014 11:12 AM, Josh Wu wrote:
+clk = v4l2_clk_get(&client->dev, "mclk");
+if (IS_ERR(clk))
+return -EPROBE_DEFER;
Hi Josh,
On 19/03/14 10:17, Josh Wu wrote:
> On 3/15/2014 5:17 AM, Sylwester Nawrocki wrote:
>> > On 03/14/2014 11:12 AM, Josh Wu wrote:
>>> >> +clk = v4l2_clk_get(&client->dev, "mclk");
>>> >> +if (IS_ERR(clk))
>>> >> +return -EPROBE_DEFER;
>> >
>> > You should instead make it:
>>
Hi, Sylwester
Thanks for your review.
On 3/15/2014 5:17 AM, Sylwester Nawrocki wrote:
Hi Josh,
On 03/14/2014 11:12 AM, Josh Wu wrote:
+clk = v4l2_clk_get(&client->dev, "mclk");
+if (IS_ERR(clk))
+return -EPROBE_DEFER;
You should instead make it:
return PTR_ERR(clk);
Hi Josh,
On 03/14/2014 11:12 AM, Josh Wu wrote:
+ clk = v4l2_clk_get(&client->dev, "mclk");
+ if (IS_ERR(clk))
+ return -EPROBE_DEFER;
You should instead make it:
return PTR_ERR(clk);
But you will need this patch for that to work:
http://git.kernel.o
Move the clock detection code to the beginning of the probe().
If we meet any error in the clock detecting, then defer the probe.
Signed-off-by: Josh Wu
---
drivers/media/i2c/soc_camera/ov2640.c | 43 +
1 file changed, 28 insertions(+), 15 deletions(-)
diff --g
