Re: [PATCH] [media] mantis: merge both vp2033 and vp2040 drivers

2012-08-16 Thread Bjørn Mork
Manu Abraham writes: > That's just peanuts you are talking about. The memory usage appears only > if you are using the module. 200 lines of .text is nothing. OK. Deleting 200 completely useless lines of code is nothing? I don't think we live in the same world. > That exists to > differentiate

Re: [PATCH] [media] mantis: merge both vp2033 and vp2040 drivers

2012-08-06 Thread Manu Abraham
On Tue, Aug 7, 2012 at 1:50 AM, Mauro Carvalho Chehab wrote: > Em 06-08-2012 17:07, Manu Abraham escreveu: >> On Tue, Aug 7, 2012 at 12:32 AM, Mauro Carvalho Chehab >> wrote: >>> As noticed at: >>> >>> http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/48034 >>> >>>

Re: [PATCH] [media] mantis: merge both vp2033 and vp2040 drivers

2012-08-06 Thread Mauro Carvalho Chehab
Em 06-08-2012 17:07, Manu Abraham escreveu: > On Tue, Aug 7, 2012 at 12:32 AM, Mauro Carvalho Chehab > wrote: >> As noticed at: >> >> http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/48034 >> >> Both drivers are identical, except for the name. So, there's no >> sen

Re: [PATCH] [media] mantis: merge both vp2033 and vp2040 drivers

2012-08-06 Thread Manu Abraham
On Tue, Aug 7, 2012 at 12:32 AM, Mauro Carvalho Chehab wrote: > As noticed at: > > http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/48034 > > Both drivers are identical, except for the name. So, there's no > sense on keeping both. Instead of forking the entire code

[PATCH] [media] mantis: merge both vp2033 and vp2040 drivers

2012-08-06 Thread Mauro Carvalho Chehab
As noticed at: http://comments.gmane.org/gmane.linux.drivers.video-input-infrastructure/48034 Both drivers are identical, except for the name. So, there's no sense on keeping both. Instead of forking the entire code, just fork the vp3033_config struct, saving some space, and cleaning up t