Re: [PATCH] [media]: Driver for Toshiba et8ek8 5MP sensor

2016-06-09 Thread Sakari Ailus
Hi Ivaylo, On Sat, Jun 04, 2016 at 10:54:58PM +0300, Ivaylo Dimitrov wrote: > Hi, > > On 26.05.2016 00:45, Sakari Ailus wrote: > >Hi Ivaylo, > > > >I've got some comments here but I haven't reviewed everything yet. What's > >missing is > > > >- the user space interface for selecting the sensor co

Re: [PATCH] [media]: Driver for Toshiba et8ek8 5MP sensor

2016-06-06 Thread Sylwester Nawrocki
On 05/24/2016 01:19 PM, Pavel Machek wrote: >> +/* >> > + * Write a list of registers to i2c device. >> > + * >> > + * The list of registers is terminated by ET8EK8_REG_TERM. >> > + * Returns zero if successful, or non-zero otherwise. >> > + */ >> > +static int et8ek8_i2c_write_regs(struct i2c_clie

Re: [PATCH] [media]: Driver for Toshiba et8ek8 5MP sensor

2016-06-04 Thread Ivaylo Dimitrov
Hi, On 26.05.2016 00:45, Sakari Ailus wrote: Hi Ivaylo, I've got some comments here but I haven't reviewed everything yet. What's missing is - the user space interface for selecting the sensor configuration "mode", - passing information on the sensor configuration to the user space. I'll try

Re: [PATCH] [media]: Driver for Toshiba et8ek8 5MP sensor

2016-06-04 Thread Ivaylo Dimitrov
Hi, On 24.05.2016 14:19, Pavel Machek wrote: Hi! The sensor is found in Nokia N900 main camera Signed-off-by: Ivaylo Dimitrov +/* + * A buffered write method that puts the wanted register write + * commands in a message list and passes the list to the i2c framework + */ +static int et8ek8

Re: [PATCH] [media]: Driver for Toshiba et8ek8 5MP sensor

2016-05-25 Thread Sakari Ailus
Hi Ivaylo, I've got some comments here but I haven't reviewed everything yet. What's missing is - the user space interface for selecting the sensor configuration "mode", - passing information on the sensor configuration to the user space. I'll try to take a look at those some time in the near f

Re: [PATCH] [media]: Driver for Toshiba et8ek8 5MP sensor

2016-05-24 Thread Pavel Machek
Hi! > The sensor is found in Nokia N900 main camera > > Signed-off-by: Ivaylo Dimitrov > +/* > + * A buffered write method that puts the wanted register write > + * commands in a message list and passes the list to the i2c framework > + */ > +static int et8ek8_i2c_buffered_write_regs(struct i2c

Re: [PATCH] [media]: Driver for Toshiba et8ek8 5MP sensor

2016-05-22 Thread Ivaylo Dimitrov
On 3.05.2016 17:50, Ivaylo Dimitrov wrote: The sensor is found in Nokia N900 main camera Signed-off-by: Ivaylo Dimitrov --- .../bindings/media/i2c/toshiba,et8ek8.txt | 53 + drivers/media/i2c/Kconfig |1 + drivers/media/i2c/Makefile

[PATCH] [media]: Driver for Toshiba et8ek8 5MP sensor

2016-05-03 Thread Ivaylo Dimitrov
The sensor is found in Nokia N900 main camera Signed-off-by: Ivaylo Dimitrov --- .../bindings/media/i2c/toshiba,et8ek8.txt | 53 + drivers/media/i2c/Kconfig |1 + drivers/media/i2c/Makefile |1 + drivers/media/i2c/et8ek8/Kconfig