Re: [PATCH] [RESEND] media: tea5764: reconcile Kconfig symbol and macro

2011-11-03 Thread Mauro Carvalho Chehab
Em 30-10-2011 15:31, Paul Bolle escreveu: > On Sun, 2011-10-30 at 10:24 -0700, Randy Dunlap wrote: >> On 10/30/11 10:12, Paul Bolle wrote: >>> 2) I'm not sure why things are done that way. Why can't builtin drivers >>> and loadable drivers default to identical values? But perhaps I'm just >>> misun

Re: [PATCH] [RESEND] media: tea5764: reconcile Kconfig symbol and macro

2011-10-30 Thread Paul Bolle
On Sun, 2011-10-30 at 10:24 -0700, Randy Dunlap wrote: > On 10/30/11 10:12, Paul Bolle wrote: > > 2) I'm not sure why things are done that way. Why can't builtin drivers > > and loadable drivers default to identical values? But perhaps I'm just > > misunderstanding the code. > > They could default

Re: [PATCH] [RESEND] media: tea5764: reconcile Kconfig symbol and macro

2011-10-30 Thread Randy Dunlap
On 10/30/11 10:12, Paul Bolle wrote: > On Sun, 2011-10-30 at 09:43 -0700, Randy Dunlap wrote: >> On 10/30/11 05:08, Paul Bolle wrote: >>> The Kconfig symbol RADIO_TEA5764_XTAL is unused. The code does use a >>> RADIO_TEA5764_XTAL macro, but does that rather peculiar. But there seems >>> to be a way

Re: [PATCH] [RESEND] media: tea5764: reconcile Kconfig symbol and macro

2011-10-30 Thread Paul Bolle
On Sun, 2011-10-30 at 09:43 -0700, Randy Dunlap wrote: > On 10/30/11 05:08, Paul Bolle wrote: > > The Kconfig symbol RADIO_TEA5764_XTAL is unused. The code does use a > > RADIO_TEA5764_XTAL macro, but does that rather peculiar. But there seems > > to be a way to keep both. (The easiest way out woul

Re: [PATCH] [RESEND] media: tea5764: reconcile Kconfig symbol and macro

2011-10-30 Thread Randy Dunlap
On 10/30/11 05:08, Paul Bolle wrote: > The Kconfig symbol RADIO_TEA5764_XTAL is unused. The code does use a > RADIO_TEA5764_XTAL macro, but does that rather peculiar. But there seems > to be a way to keep both. (The easiest way out would be to rip out both > the Kconfig symbol and the macro.) > >

[PATCH] [RESEND] media: tea5764: reconcile Kconfig symbol and macro

2011-10-30 Thread Paul Bolle
The Kconfig symbol RADIO_TEA5764_XTAL is unused. The code does use a RADIO_TEA5764_XTAL macro, but does that rather peculiar. But there seems to be a way to keep both. (The easiest way out would be to rip out both the Kconfig symbol and the macro.) Note there's also a module parameter 'use_xtal' t