Re: [PATCH][davinci] ccdc_update_raw_params() frees the wrong thing

2016-01-06 Thread Lad, Prabhakar
On Wed, Jan 6, 2016 at 4:34 PM, Al Viro wrote: > On Tue, Jan 05, 2016 at 05:37:06PM +, Lad, Prabhakar wrote: >> On Sun, Dec 13, 2015 at 12:32 AM, Al Viro wrote: >> > Passing a physical address to free_pages() is a bad idea. >> > config_params->fault_pxl.fpc_table_addr is set to virt_t

Re: [PATCH][davinci] ccdc_update_raw_params() frees the wrong thing

2016-01-06 Thread Al Viro
On Tue, Jan 05, 2016 at 05:37:06PM +, Lad, Prabhakar wrote: > On Sun, Dec 13, 2015 at 12:32 AM, Al Viro wrote: > > Passing a physical address to free_pages() is a bad idea. > > config_params->fault_pxl.fpc_table_addr is set to virt_to_phys() > > of __get_free_pages() return value; what

Re: [PATCH][davinci] ccdc_update_raw_params() frees the wrong thing

2016-01-05 Thread Lad, Prabhakar
On Sun, Dec 13, 2015 at 12:32 AM, Al Viro wrote: > Passing a physical address to free_pages() is a bad idea. > config_params->fault_pxl.fpc_table_addr is set to virt_to_phys() > of __get_free_pages() return value; what we should pass to free_pages() > is its phys_to_virt(). ccdc_close() d

[PATCH][davinci] ccdc_update_raw_params() frees the wrong thing

2015-12-12 Thread Al Viro
Passing a physical address to free_pages() is a bad idea. config_params->fault_pxl.fpc_table_addr is set to virt_to_phys() of __get_free_pages() return value; what we should pass to free_pages() is its phys_to_virt(). ccdc_close() does that properly, but ccdc_update_raw_params() doesn't.