Re: [PATCH][MEDIA]i.MX6 CSI: Fix MIPI camera operation in RAW/Bayer mode

2017-10-17 Thread Philipp Zabel
On Tue, 2017-10-17 at 14:53 +0100, Russell King - ARM Linux wrote: > On Tue, Oct 17, 2017 at 03:26:19PM +0200, Krzysztof Hałasa wrote: > > Fabio Estevam writes: > > > > > > --- a/drivers/staging/media/imx/imx-media-csi.c > > > > +++ b/drivers/staging/media/imx/imx-media-csi.c > > > > @@ -340,7 +3

Re: [PATCH][MEDIA]i.MX6 CSI: Fix MIPI camera operation in RAW/Bayer mode

2017-10-17 Thread Fabio Estevam
On Tue, Oct 17, 2017 at 11:53 AM, Russell King - ARM Linux wrote: > I do wish the patch was merged (which fixes a real problem) rather than > hanging around for optimisation questions. We can always increase it > in the future if it's deemed that a larger burst size is beneficial. Agreed.

Re: [PATCH][MEDIA]i.MX6 CSI: Fix MIPI camera operation in RAW/Bayer mode

2017-10-17 Thread Russell King - ARM Linux
On Tue, Oct 17, 2017 at 03:26:19PM +0200, Krzysztof Hałasa wrote: > Fabio Estevam writes: > > >> --- a/drivers/staging/media/imx/imx-media-csi.c > >> +++ b/drivers/staging/media/imx/imx-media-csi.c > >> @@ -340,7 +340,7 @@ static int csi_idmac_setup_channel(struct csi_priv > >> *priv) > >>

Re: [PATCH][MEDIA]i.MX6 CSI: Fix MIPI camera operation in RAW/Bayer mode

2017-10-17 Thread Krzysztof Hałasa
Fabio Estevam writes: >> --- a/drivers/staging/media/imx/imx-media-csi.c >> +++ b/drivers/staging/media/imx/imx-media-csi.c >> @@ -340,7 +340,7 @@ static int csi_idmac_setup_channel(struct csi_priv *priv) >> case V4L2_PIX_FMT_SGBRG8: >> case V4L2_PIX_FMT_SGRBG8: >> case V4

Re: [PATCH][MEDIA]i.MX6 CSI: Fix MIPI camera operation in RAW/Bayer mode

2017-10-17 Thread Fabio Estevam
Hi Krzysztof, On Tue, Oct 17, 2017 at 4:27 AM, Krzysztof Hałasa wrote: > Without this fix, in 8-bit Y/Bayer mode, every other 8-byte group > of pixels is lost. > Not sure about possible side effects, though. > > Signed-off-by: Krzysztof Hałasa > > --- a/drivers/staging/media/imx/imx-media-csi.c

[PATCH][MEDIA]i.MX6 CSI: Fix MIPI camera operation in RAW/Bayer mode

2017-10-16 Thread Krzysztof Hałasa
Without this fix, in 8-bit Y/Bayer mode, every other 8-byte group of pixels is lost. Not sure about possible side effects, though. Signed-off-by: Krzysztof Hałasa --- a/drivers/staging/media/imx/imx-media-csi.c +++ b/drivers/staging/media/imx/imx-media-csi.c @@ -340,7 +340,7 @@ static int csi_id