Re: [PATCH 2/4] media: omap3isp: Handle ARM dma_iommu_mapping

2025-02-16 Thread Sakari Ailus
Hi Laurent, others, On Sat, Feb 15, 2025 at 09:43:28PM +0200, Laurent Pinchart wrote: > CC'ing Sakari. > > Sakari, would you pick this patch ? Thanks! I wonder what happened -- it wasn't visible in Linuxtv.org Patchwork but could be found via the message id. It's in m

Re: [PATCH 2/4] media: omap3isp: Handle ARM dma_iommu_mapping

2025-02-15 Thread Laurent Pinchart
CC'ing Sakari. Sakari, would you pick this patch ? On Sat, Feb 15, 2025 at 08:57:24AM +0200, Sicelo wrote: > On Mon, Oct 28, 2024 at 05:58:36PM +, Robin Murphy wrote: > > It's no longer practical for the OMAP IOMMU driver to trick > > arm_setup_iommu_dma_ops() into

Re: [PATCH 2/4] media: omap3isp: Handle ARM dma_iommu_mapping

2025-02-14 Thread Sicelo
ping) { > + arm_iommu_detach_device(isp->dev); > + arm_iommu_release_mapping(mapping); > + } > + > /* >* Create the ARM mapping, used by the ARM DMA mapping core to allocate >* VAs. This will allocate a corresponding IOM

Re: [PATCH 1/4] remoteproc/omap: Handle ARM dma_iommu_mapping

2024-12-06 Thread Mathieu Poirier
terfere with the core rproc->domain and we get the right DMA ops. > + */ > + if (pdev->dev.archdata.mapping) { > + struct dma_iommu_mapping *mapping = > to_dma_iommu_mapping(&pdev->dev); > + > + arm_iommu_detach_device(&pdev->dev); > +

Re: [PATCH 0/4] Fix omap-iommu bitrot

2024-10-30 Thread Adam Ford
es (OMA35 and DM37) are still being sold and I still run various tests on them periodically. There is also an AM3517 that I still periodically test. Once Micron kills off the RAM and they run out of supply and Beacon cannot sell them anymore, I'll submit a patch to remove the unsupported / EOL boards. > > Thanks to everyone for the amazing work. Thank you for all this. I haven't been as active lately, but I have been following this. adam > > Sincerely > Sicelo >

Re: [PATCH 0/4] Fix omap-iommu bitrot

2024-10-30 Thread Sicelo
Hi On Wed, Oct 30, 2024 at 01:38:11PM +0100, Joerg Roedel wrote: > On Wed, Oct 30, 2024 at 12:20:31PM +0100, H. Nikolaus Schaller wrote: > > Why that? There was a discussion and everyone agreed to remove omap2, > > but not omap3 and later. > > I raised this question to make sure the things we mai

Re: [PATCH 0/4] Fix omap-iommu bitrot

2024-10-30 Thread Joerg Roedel
On Wed, Oct 30, 2024 at 12:20:31PM +0100, H. Nikolaus Schaller wrote: > Why that? There was a discussion and everyone agreed to remove omap2, > but not omap3 and later. I raised this question to make sure the things we maintain are still relevant. Developer and maintainers time is limited and we s

Re: [PATCH 0/4] Fix omap-iommu bitrot

2024-10-30 Thread H. Nikolaus Schaller
> patches attempt to bring it and its consumers sufficiently up-to-date >> to work again, in a manner that's hopefully backportable. This is >> largely all written by inspection, but I have managed to lightly boot >> test patch #3 on an OMAP4 Pandaboard to confirm iommu_probe_

Re: [PATCH 0/4] Fix omap-iommu bitrot

2024-10-30 Thread Joerg Roedel
to work again, in a manner that's hopefully backportable. This is > largely all written by inspection, but I have managed to lightly boot > test patch #3 on an OMAP4 Pandaboard to confirm iommu_probe_device() > working again. My initial reflex would have been to just wipe the omap dri

Re: [PATCH 0/4] Fix omap-iommu bitrot

2024-10-29 Thread Beleswar Prasad Padhi
anner that's hopefully backportable. This is largely all written by inspection, but I have managed to lightly boot test patch #3 on an OMAP4 Pandaboard to confirm iommu_probe_device() working again. This supersedes my previous patch[1]. Patches #1 and #2 are functionally independent, and can

Re: [PATCH 0/4] Fix omap-iommu bitrot

2024-10-29 Thread Kevin Hilman
hopefully backportable. This is > largely all written by inspection, but I have managed to lightly boot > test patch #3 on an OMAP4 Pandaboard to confirm iommu_probe_device() > working again. > > This supersedes my previous patch[1]. Patches #1 and #2 are functionally > independe

Re: [PATCH 0/4] Fix omap-iommu bitrot

2024-10-28 Thread Mathieu Poirier
recent evolution of the IOMMU API internals. These > > patches attempt to bring it and its consumers sufficiently up-to-date > > to work again, in a manner that's hopefully backportable. This is > > largely all written by inspection, but I have managed to lightly boot > > t

Re: [PATCH 0/4] Fix omap-iommu bitrot

2024-10-28 Thread H. Nikolaus Schaller
fficiently up-to-date > to work again, in a manner that's hopefully backportable. This is > largely all written by inspection, but I have managed to lightly boot > test patch #3 on an OMAP4 Pandaboard to confirm iommu_probe_device() > working again. > > This supersedes my prev

[PATCH 2/4] media: omap3isp: Handle ARM dma_iommu_mapping

2024-10-28 Thread Robin Murphy
It's no longer practical for the OMAP IOMMU driver to trick arm_setup_iommu_dma_ops() into ignoring its presence, so let's use the same tactic as other IOMMU API users on 32-bit ARM and explicitly kick the arch code's dma_iommu_mapping out of the way to avoid problems. Fixes: 4720287c7bf7 ("iommu:

[PATCH 0/4] Fix omap-iommu bitrot

2024-10-28 Thread Robin Murphy
argely all written by inspection, but I have managed to lightly boot test patch #3 on an OMAP4 Pandaboard to confirm iommu_probe_device() working again. This supersedes my previous patch[1]. Patches #1 and #2 are functionally independent, and can be applied directly to their respective trees if

[PATCH 4/4] iommu: Make bus_iommu_probe() static

2024-10-28 Thread Robin Murphy
With the last external caller of bus_iommu_probe() now gone, make it internal as it really should be. Signed-off-by: Robin Murphy --- drivers/iommu/iommu.c | 3 ++- include/linux/iommu.h | 1 - 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iommu/iommu.c b/drivers/iommu/i

[PATCH 3/4] iommu/omap: Add minimal fwnode support

2024-10-28 Thread Robin Murphy
The OMAP driver uses the generic "iommus" DT binding but is the final holdout not implementing a corresponding .of_xlate method. Unfortunately this now results in __iommu_probe_device() failing to find ops due to client devices missing the expected IOMMU fwnode association. The legacy DT parsing in

[PATCH 1/4] remoteproc/omap: Handle ARM dma_iommu_mapping

2024-10-28 Thread Robin Murphy
It's no longer practical for the OMAP IOMMU driver to trick arm_setup_iommu_dma_ops() into ignoring its presence, so let's use the same tactic as other IOMMU API users on 32-bit ARM and explicitly kick the arch code's dma_iommu_mapping out of the way to avoid problems. Fixes: 4720287c7bf7 ("iommu:

Re: [PATCH 4.19 178/273] media: dvb: symbol fixup for dvb_attach()

2023-10-07 Thread Greg Kroah-Hartman
On Thu, Sep 28, 2023 at 01:36:06AM +0200, Ben Hutchings wrote: > On Wed, 2023-09-20 at 13:30 +0200, Greg Kroah-Hartman wrote: > > 4.19-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Gr

Re: [PATCH 4.19 178/273] media: dvb: symbol fixup for dvb_attach()

2023-09-27 Thread Ben Hutchings
On Wed, 2023-09-20 at 13:30 +0200, Greg Kroah-Hartman wrote: > 4.19-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Greg Kroah-Hartman > > commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. > > In co

[PATCH 5.4 218/367] media: dvb: symbol fixup for dvb_attach()

2023-09-20 Thread Greg Kroah-Hartman
5.4-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

[PATCH 4.19 178/273] media: dvb: symbol fixup for dvb_attach()

2023-09-20 Thread Greg Kroah-Hartman
4.19-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

[PATCH 4.14 108/186] media: dvb: symbol fixup for dvb_attach()

2023-09-20 Thread Greg Kroah-Hartman
4.14-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

[PATCH 5.15 338/511] media: dvb: symbol fixup for dvb_attach()

2023-09-17 Thread Greg Kroah-Hartman
5.15-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

[PATCH 5.10 285/406] media: dvb: symbol fixup for dvb_attach()

2023-09-17 Thread Greg Kroah-Hartman
5.10-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

[PATCH 6.1 547/600] media: dvb: symbol fixup for dvb_attach()

2023-09-11 Thread Greg Kroah-Hartman
6.1-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

[PATCH 6.4 674/737] media: dvb: symbol fixup for dvb_attach()

2023-09-11 Thread Greg Kroah-Hartman
6.4-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

[PATCH 6.5 679/739] media: dvb: symbol fixup for dvb_attach()

2023-09-11 Thread Greg Kroah-Hartman
6.5-stable review patch. If anyone has any objections, please let me know. -- From: Greg Kroah-Hartman commit 86495af1171e1feec79faa9b64c05c89f46e41d1 upstream. In commit 9011e49d54dc ("modules: only allow symbol_get of EXPORT_SYMBOL_GPL modules") the use of sym

Re: [PATCH v4 01/11] dt-bindings: video-interfaces: Document 'location' property

2019-10-23 Thread Pavel Machek
Hi! > > I'm skeptical about adding now a property for a device that we don't > > support, because we -now- think it's a good idea. I might be wrong, > > but my assumption is that when someone will want to support an > > 'advanced' device, it's easy to add "movable" or whatever else to the > > list

Re: [PATCH v10 03/14] media: v4l2-fwnode: add initial connector parsing support

2019-10-23 Thread Marco Felsch
; > > > > On Fri, Aug 30, 2019 at 12:16:35PM +0200, Marco Felsch wrote: > > > > The patch adds the initial connector parsing code, so we can move from a > > > > driver specific parsing code to a generic one. Currently only the > > > > generic f

Re: [PATCH v10 03/14] media: v4l2-fwnode: add initial connector parsing support

2019-10-23 Thread Sakari Ailus
Hi Marco, Apologies for the delay. On Wed, Oct 02, 2019 at 10:07:35AM +0200, Marco Felsch wrote: > Hi Sakari, > > On 19-10-02 10:03, Sakari Ailus wrote: > > Hi Marco, > > > > On Fri, Aug 30, 2019 at 12:16:35PM +0200, Marco Felsch wrote: > > > The patch add

Re: [PATCH 0/3] vimc: Allow multiple capture devices to use the same sensor

2019-10-23 Thread Niklas Söderlund
t; Regards, > > Hans > > On 5/18/19 3:07 AM, Niklas Söderlund wrote: > > Hi, > > > > This series adds support for two (or more) capture devices to be > > connected to the same senors and run simultaneously. Each capture device > > can be started a

Re: [PATCH v2] doc-rst: add more info for resolution change blocks in ipu3

2019-10-23 Thread Sakari Ailus
Hi Bingbu, On Tue, Oct 08, 2019 at 12:21:27PM +0800, bingbu@intel.com wrote: > From: Bingbu Cao > > This patch add more details for the resolution change blocks > It can help the developer to understand the main resolution > change blocks in ImgU. > > Signed-off-by:

Re: [PATCH v3 2/2] media: vimc: upon streaming, check that the pipeline starts with a source entity

2019-10-23 Thread Hans Verkuil
On 10/9/19 5:53 PM, Dafna Hirschfeld wrote: > Userspace can disable links and create pipelines that > do not start with a source entity. Trying to stream > from such a pipeline should fail with -EPIPE > currently this is not handled and cause kernel crash. > > Reproducing the crash: > media-ctl -d

Re: [PATCH 0/3] vimc: Allow multiple capture devices to use the same sensor

2019-10-23 Thread Hans Verkuil
independent of each other. > > Patch 1/3 and 2/3 deals with solving the issues that arises once two > capture devices can be part of the same pipeline. While 3/3 allows for > two capture devices to be part of the same pipeline and thus allows for > simultaneously use. > > Th

[PATCH] media: staging/intel-ipu3: remove the unnecessary compiler flags

2019-10-22 Thread bingbu . cao
From: Bingbu Cao Currently, we can build ipu3 driver code without any warnings with W=1, so the extra compiler flags in Makefile and the item in TODO file can be removed. Signed-off-by: Bingbu Cao Signed-off-by: Sakari Ailus Cc: Mauro Carvalho Chehab --- drivers/staging/media/ipu3/Makefile |

[PATCH] doc-rst: ipu3: clarification on data type conversion of IEFD CU

2019-10-22 Thread bingbu . cao
From: Bingbu Cao The data type conversion of the IEFD CU inputs in ipu3 uapi is ambiguities, add some clarification to help user to understand this conversion. Signed-off-by: Bingbu Cao Suggested-by: Sakari Ailus Cc: Sakari Ailus Cc: Tomasz Figa Cc: Laurent Pinchart --- drivers/staging/med

Re: [PATCH v4 01/11] dt-bindings: video-interfaces: Document 'location' property

2019-10-22 Thread Hans Verkuil
On 10/8/19 10:20 AM, Jacopo Mondi wrote: > On Tue, Oct 08, 2019 at 10:06:34AM +0200, Pavel Machek wrote: >> On Tue 2019-10-08 09:58:28, Jacopo Mondi wrote: >>> Pavel, >>> >>> On Tue, Oct 08, 2019 at 09:40:52AM +0200, Pavel Machek wrote: On Mon 2019-10-07 18:29:03, Jacopo Mondi wrote: > Add

Re: [PATCH v4 04/11] media: v4l2-ctrl: Document V4L2_CID_CAMERA_SENSOR_ROTATION

2019-10-22 Thread Hans Verkuil
On 10/7/19 6:29 PM, Jacopo Mondi wrote: > Add documentation for the V4L2_CID_CAMERA_SENSOR_ROTATION camera > control. The newly added read-only control reports the camera device > mounting rotation. > > Signed-off-by: Jacopo Mondi > --- > .../media/uapi/v4l/ext-ctrls-camera.rst | 116 +

[PATCH] media: dvbsky: remove unused code

2019-10-22 Thread Jan Pieter van Woerkom
remove unused code Signed-off-by: Jan Pieter van Woerkom --- diff -ru a/drivers/media/usb/dvb-usb-v2/dvbsky.c b/drivers/media/usb/dvb-usb-v2/dvbsky.c --- a/drivers/media/usb/dvb-usb-v2/dvbsky.c 2019-10-22 13:15:31.598029247 +0200 +++ b/drivers/media/usb/dvb-usb-v2/dvbsky.c 2019-10-22 12

Re: [PATCH v10 03/14] media: v4l2-fwnode: add initial connector parsing support

2019-10-22 Thread Marco Felsch
Hi Sakari, gentle ping. On 19-10-02 10:07, Marco Felsch wrote: > Hi Sakari, > > On 19-10-02 10:03, Sakari Ailus wrote: > > Hi Marco, > > > > On Fri, Aug 30, 2019 at 12:16:35PM +0200, Marco Felsch wrote: > > > The patch adds the initial connector parsing code

[PATCH 0/2] media: vimc: cleanup - remove unused code

2019-10-22 Thread Dafna Hirschfeld
This patchset removes code and declarations that are not used. - The first patch removes the declarations EXPORT_SYMBOL_GPL. Those are not needed since vimc is now a single kernel module so it does not need to export any symbol. - The second patch removes the function vimc_pipeline_s_stream in the

[PATCH 1/2] media: vimc: remove EXPORT_SYMBOL_GPL declarations

2019-10-22 Thread Dafna Hirschfeld
vimc is a single kernel module and does not need to export any symbols therefore there is no need for these declarations. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vimc/vimc-common.c | 8 drivers/media/platform/vimc/vimc-streamer.c | 1 - 2 files changed, 9 deletions(

[PATCH 2/2] media: vimc: common: remove unused function 'vimc_pipeline_s_stream'

2019-10-22 Thread Dafna Hirschfeld
The function 'vimc_pipeline_s_stream' is not used and can be removed. Signed-off-by: Dafna Hirschfeld --- drivers/media/platform/vimc/vimc-common.c | 28 --- drivers/media/platform/vimc/vimc-common.h | 11 - 2 files changed, 39 deletions(-) diff --git a/drivers/media

[PATCH 2/2] vivid: Add touch support

2019-10-22 Thread Vandana BN
Support to emulate touch devices in vivid driver. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 3 +- drivers/media/platform/vivid/vivid-core.c | 134 ++- drivers/media/platform/vivid/vivid-core.h | 18 ++ drivers/media/platform/vivid/vivid-ctrl

[PATCH 1/2] v4l2-core: fix touch support in v4l_g_fmt

2019-10-22 Thread Vandana BN
v4l_s_fmt, for VFL_TYPE_TOUCH, sets unneeded members of the v4l2_pix_format structure to default values.This was missing in v4l_g_fmt, which would lead to failures in v4l2-compliance tests. Signed-off-by: Vandana BN --- drivers/media/v4l2-core/v4l2-ioctl.c | 33 +++- 1 fi

[PATCH 0/2] vivid: Support for touch device

2019-10-22 Thread Vandana BN
This patch adds support for touch devices in the vivid driver. Current code provides a framework for touch support and passes compliance tests. TODO: Add touch emulation. Thank you. Regards, Vandana. Vandana BN (2): v4l2-core: fix touch support in v4l_g_fmt vivid: Add touch support drivers

Re: [RFC PATCH v3 1/6] media: v4l2: Extend pixel formats to unify single/multi-planar handling (and more)

2019-10-21 Thread Hans Verkuil
On 10/21/19 11:48 AM, Tomasz Figa wrote: > On Mon, Oct 21, 2019 at 6:38 PM Hans Verkuil wrote: >> >> On 10/21/19 11:26 AM, Tomasz Figa wrote: >>> On Mon, Oct 21, 2019 at 5:41 PM Hans Verkuil wrote: On 10/8/19 11:11 AM, Boris Brezillon wrote: > This is part of the multiplanar and sin

Re: [RFC PATCH v3 1/6] media: v4l2: Extend pixel formats to unify single/multi-planar handling (and more)

2019-10-21 Thread Tomasz Figa
On Mon, Oct 21, 2019 at 6:38 PM Hans Verkuil wrote: > > On 10/21/19 11:26 AM, Tomasz Figa wrote: > > On Mon, Oct 21, 2019 at 5:41 PM Hans Verkuil wrote: > >> > >> On 10/8/19 11:11 AM, Boris Brezillon wrote: > >>> This is part of the multiplanar and singleplanar unification process. > >>> v4l2_ext

Re: [RFC PATCH v3 1/6] media: v4l2: Extend pixel formats to unify single/multi-planar handling (and more)

2019-10-21 Thread Hans Verkuil
On 10/21/19 11:26 AM, Tomasz Figa wrote: > On Mon, Oct 21, 2019 at 5:41 PM Hans Verkuil wrote: >> >> On 10/8/19 11:11 AM, Boris Brezillon wrote: >>> This is part of the multiplanar and singleplanar unification process. >>> v4l2_ext_pix_format is supposed to work for both cases. >>> >>> We also add

Re: [RFC PATCH v3 1/6] media: v4l2: Extend pixel formats to unify single/multi-planar handling (and more)

2019-10-21 Thread Tomasz Figa
On Mon, Oct 21, 2019 at 5:41 PM Hans Verkuil wrote: > > On 10/8/19 11:11 AM, Boris Brezillon wrote: > > This is part of the multiplanar and singleplanar unification process. > > v4l2_ext_pix_format is supposed to work for both cases. > > > > We also add the concept of modifiers already employed in

Re: [RFC PATCH v3 1/6] media: v4l2: Extend pixel formats to unify single/multi-planar handling (and more)

2019-10-21 Thread Hans Verkuil
On 10/8/19 11:11 AM, Boris Brezillon wrote: > This is part of the multiplanar and singleplanar unification process. > v4l2_ext_pix_format is supposed to work for both cases. > > We also add the concept of modifiers already employed in DRM to expose > HW-specific formats (like tiled or compressed f

[PATCH 1/1] v4l2-fwnode: Print the node name while parsing endpoints

2019-10-21 Thread Sakari Ailus
Print the node name during endpoint parsing for better debuggability. Depends-on: ("lib/vsprintf: Add %pfw conversion specifier for printing fwnode names") Signed-off-by: Sakari Ailus --- drivers/media/v4l2-core/v4l2-fwnode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --g

[PATCH] media: exynos4-is: fix wrong mdev and v4l2 dev order in error path

2019-10-20 Thread Seung-Woo Kim
When driver is built as module and probe during insmod is deferred because of sensor subdevs, there is NULL pointer deference because mdev is cleaned up and then access it from v4l2_device_unregister(). Fix the wrong mdev and v4l2 dev odder in error path of probe. This fixes below null pointer def

Re: [PATCH 0/4] Add VIN/CSI-2 support

2019-10-20 Thread Niklas Söderlund
Hi Biju, Thanks for your work. On 2019-10-15 11:57:54 +0100, Biju Das wrote: > This patch series add VIN/CSI-2 driver support for RZ/G2N SoC. For the whole series, Reviewed-by: Niklas Söderlund > > Biju Das (4): > media: dt-bindings: rcar-vin: Add R8A774B1 support > med

[PATCH v4l-utils] ir-keytable: bpf: improve rsc imon pointer decoder

2019-10-20 Thread Sean Young
Sometimes the remotes sends 4 bits rather than 5. This makes the pointer much more reliable. Signed-off-by: Sean Young --- utils/keytable/bpf_protocols/imon_rsc.c | 66 + 1 file changed, 35 insertions(+), 31 deletions(-) diff --git a/utils/keytable/bpf_protocols/imon_rsc

[PATCH 1/1] smiapp: Destroy sensor's mutex

2019-10-18 Thread Sakari Ailus
Destroy the mutex initialised by the driver in probe. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiapp/smiapp-core.c index 24f4197cf7ad

Re: [PATCH v4 01/11] dt-bindings: video-interfaces: Document 'location' property

2019-10-18 Thread Sakari Ailus
Hi Jacopo, (Cc'ing the devicetree list.) On Mon, Oct 07, 2019 at 06:29:03PM +0200, Jacopo Mondi wrote: > Add the 'location' device property, used to specify a device mounting > position. The property is particularly meaningful for mobile devices > with a well defined usage orientation. > > Signe

Re: [PATCH v4 06/11] media: v4l2-fwnode: Add helper to parse device properties

2019-10-18 Thread Sakari Ailus
Hi Jacopo, On Mon, Oct 07, 2019 at 06:29:08PM +0200, Jacopo Mondi wrote: > Add an helper function to parse common device properties in the same > way as v4l2_fwnode_endpoint_parse() parses common endpoint properties. > > Parse the 'rotation' and 'location' properties from the firmware > interface

Re: [PATCH v4 00/11] media: Report camera sensor properties

2019-10-18 Thread Sakari Ailus
mera sensor properties > https://patchwork.kernel.org/cover/6443/ > "[PATCH v3 00/11] media: Report camera sensor properties" > https://patchwork.kernel.org/project/linux-media/list/?series=173571 > > I here included Hans' comments. Most notable changes > > v3

Re: [PATCH] media: v4l2-subdev: Don't use __u32 internally

2019-10-18 Thread Sakari Ailus
On Fri, Oct 18, 2019 at 05:31:40PM +0200, Janusz Krzysztofik wrote: > Commit a8fa55078a77 ("media: v4l2-subdev: Verify arguments in > v4l2_subdev_call()") and commit 374d62e7aa50 ("media: v4l2-subdev: > Verify v4l2_subdev_call() pad config argument") introduced a few local > functions, unfortunatel

[PATCH] media: v4l2-subdev: Don't use __u32 internally

2019-10-18 Thread Janusz Krzysztofik
Commit a8fa55078a77 ("media: v4l2-subdev: Verify arguments in v4l2_subdev_call()") and commit 374d62e7aa50 ("media: v4l2-subdev: Verify v4l2_subdev_call() pad config argument") introduced a few local functions, unfortunately with arguments of type __u32, reserved for use in Linux uAPI. Use u32 ins

[PATCH 2/3] smiapp: Avoid maintaining power state information

2019-10-18 Thread Sakari Ailus
Instead of keeping track of the power state ourselves, let runtime PM handle it. This also splits handling controls between side effect management and writing the new configuration to the sensor's registers. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 199 ++

[PATCH 3/3] smiapp: Put the device again if starting streaming fails

2019-10-18 Thread Sakari Ailus
If there was an error in starting streaming, put the runtime usage count of the device. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers/media/i2c/smiap

[PATCH 0/3] smiapp PM improvements, omap3isp system crash fix

2019-10-18 Thread Sakari Ailus
Hi folks, Here's a few patches remaining from my previous smiapp and omap3isp sets. Sakari Ailus (3): omap3isp: Don't restart CCDC if we're about to stop smiapp: Avoid maintaining power state information smiapp: Put the device again if starting streaming fails drivers/media/i2c/smiapp/smi

[PATCH 1/3] omap3isp: Don't restart CCDC if we're about to stop

2019-10-18 Thread Sakari Ailus
The omap3isp driver set the new buffer and enabled the CCDC in a situation a new buffer was available but streaming was about to be stopped on the CCDC. This lead to frequent system crashes in case there were buffers queued when streming was being stopped. Fix this by first checking whether there'

Re: [PATCH] media: exynos4-is: Fix recursive locking in isp_video_release()

2019-10-18 Thread Sylwester Nawrocki
On 10/18/19 12:20, Seung-Woo Kim wrote: >>From isp_video_release(), &isp->video_lock is held and subsequent > vb2_fop_release() tries to lock vdev->lock which is same with the > previous one. Replace vb2_fop_release() with _vb2_fop_release() to > fix the recursive locking. > > Fixes: 1380f5754cb0

[PATCH] media: exynos4-is: Fix recursive locking in isp_video_release()

2019-10-18 Thread Seung-Woo Kim
>From isp_video_release(), &isp->video_lock is held and subsequent vb2_fop_release() tries to lock vdev->lock which is same with the previous one. Replace vb2_fop_release() with _vb2_fop_release() to fix the recursive locking. Fixes: 1380f5754cb0 ("[media] videobuf2: Add missing lock held on vb2_

Re: [PATCH v4] venus: venc: Fix enum frameintervals

2019-10-17 Thread Loic Poulain
ideo_bitrate=1000;" > >> ! filesink location=gstenc.h264 > >> > >> Loic, could you give it a try on db820c too? > >> > >> Here is the info on the bug which I try to fix with current patch: > >> > >> https://bugs.96boards.org/show_bug.cgi?id=

Re: [PATCH v4] venus: venc: Fix enum frameintervals

2019-10-17 Thread Stanimir Varbanov
=NV12,width=1280,height=960,framerate=24/1 ! >> v4l2h264enc >> extra-controls="controls,h264_profile=4,h264_level="5",video_bitrate=1000;" >> ! filesink location=gstenc.h264 >> >> Loic, could you give it a try on db820c too? >> >> Here is

Re: [PATCH v4] venus: venc: Fix enum frameintervals

2019-10-17 Thread Loic Poulain
ot;controls,h264_profile=4,h264_level="5",video_bitrate=1000;" > ! filesink location=gstenc.h264 > > Loic, could you give it a try on db820c too? > > Here is the info on the bug which I try to fix with current patch: > > https://bugs.96boards.org/show_bug.cgi?id=513 &

[PATCH 7/7] omap3isp: Ignore failure of stopping streaming on external subdev

2019-10-17 Thread Sakari Ailus
The isp was marked to have failed to stop if stopping streaming on an external subdev failed. The return value from the external subdev should be ignored instead as it is not part of the ISP and thus the ISP does not need to be reset for that reason. Signed-off-by: Sakari Ailus --- drivers/media

[PATCH 5/7] smiapp: Register sensor after enabling runtime PM on the device

2019-10-17 Thread Sakari Ailus
Earlier it was possible that the parts of the driver that assumed runtime PM was enabled were being called before runtime PM was enabled in the driver's probe function. So enable runtime PM before registering the sub-device. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c

[PATCH 6/7] smiapp: Rename update_mode as pll_blanking_update

2019-10-17 Thread Sakari Ailus
Rename the confusingly named smiapp_update_mode() function as smiapp_pll_blanking_update(). The function is used to calculate new PLL and blanking configuration after binning or scaling configuration has been changed. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 6 +++

[PATCH 3/7] smiapp: Don't update sensor configuration during power-on init

2019-10-17 Thread Sakari Ailus
The sensor configuration since it was previously powered off was not changed, so no need to update the PLL configuration etc. What is necessary though is to re-apply the configuration to the sensor's registers. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 4 1 fi

[PATCH 1/7] smiapp: Don't get binning limits dynamically

2019-10-17 Thread Sakari Ailus
The driver implementation assumed the binning limits could change dynamically based on the binning configuration. This is not actually the case; these limits are static and suitable to be used with all binning configurations but possibly not optimal limit for many of those configurations. Signed-o

[PATCH 4/7] smiapp: Use non-binned and binned limits correctly

2019-10-17 Thread Sakari Ailus
Use non-binned limits when binning is disabled and binned when they're enabled. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 27 +++--- 1 file changed, 20 insertions(+), 7 deletions(-) diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/drivers

[PATCH 0/7] smiapp binning limit cleanups, runtime PM fix and a omap3isp fix

2019-10-17 Thread Sakari Ailus
Hi folks, This set cleans up binning limit handling and fixes runtime PM use by enabling runtime PM *before* any functionality requiring runtime PM may be used. Also a small omap3isp fix is included. Sakari Ailus (7): smiapp: Don't get binning limits dynamically smiapp: Move binning configur

[PATCH 2/7] smiapp: Move binning configuration to streaming start

2019-10-17 Thread Sakari Ailus
Only write the binning configuration at stream start. It has no effect otherwise. Signed-off-by: Sakari Ailus --- drivers/media/i2c/smiapp/smiapp-core.c | 43 +- 1 file changed, 22 insertions(+), 21 deletions(-) diff --git a/drivers/media/i2c/smiapp/smiapp-core.c b/driv

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Gerd Hoffmann
> > I doubt you can handle pci memory bars like regular ram when it comes to > > dma and iommu support. There is a reason we have p2pdma in the first > > place ... > > The thing is that such bars would be actually backed by regular host > RAM. Do we really need the complexity of real PCI bar hand

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Gerd Hoffmann
Hi, > That could be still a guest physical address. Like on a bare metal > system with TrustZone, there could be physical memory that is not > accessible to the CPU. Hmm. Yes, maybe. We could use the dma address of the (first page of the) guest buffer. In case of a secure buffer the guest ha

Re: [PATCH v2 2/2] rcar-vin: Add support for outputting NV12

2019-10-17 Thread Jacopo Mondi
Hi Niklas, Laurent, On Tue, Oct 15, 2019 at 01:11:07AM +0300, Laurent Pinchart wrote: > Hi Niklas, > > Thank you for the patch. > > On Mon, Oct 14, 2019 at 02:16:15AM +0200, Niklas Söderlund wrote: > > Most Gen3 boards can output frames in NV12 format, add support for th

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Tomasz Figa
On Thu, Oct 17, 2019 at 4:44 PM Gerd Hoffmann wrote: > > Hi, > > > > Also note that the guest manages the address space, so the host can't > > > simply allocate guest page addresses. > > > > Is this really true? I'm not an expert in this area, but on a bare > > metal system it's the hardware or

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Tomasz Figa
On Thu, Oct 17, 2019 at 4:19 PM Gerd Hoffmann wrote: > > Hi, > > > That said, Chrome OS would use a similar model, except that we don't > > use ION. We would likely use minigbm backed by virtio-gpu to allocate > > appropriate secure buffers for us and then import them to the V4L2 > > driver. > >

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Tomasz Figa
On Tue, Oct 15, 2019 at 11:06 PM Dmitry Morozov wrote: > > Hello Gerd, > > On Dienstag, 15. Oktober 2019 09:54:22 CEST Gerd Hoffmann wrote: > > On Mon, Oct 14, 2019 at 03:05:03PM +0200, Dmitry Morozov wrote: > > > On Montag, 14. Oktober 2019 14:34:43 CEST Gerd Hoffmann wrote: > > > > Hi, > > > >

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Gerd Hoffmann
Hi, > > Also note that the guest manages the address space, so the host can't > > simply allocate guest page addresses. > > Is this really true? I'm not an expert in this area, but on a bare > metal system it's the hardware or firmware that sets up the various > physical address allocations on

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread Gerd Hoffmann
Hi, > That said, Chrome OS would use a similar model, except that we don't > use ION. We would likely use minigbm backed by virtio-gpu to allocate > appropriate secure buffers for us and then import them to the V4L2 > driver. What exactly is a "secure buffer"? I guess a gem object where read a

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-17 Thread David Stevens
> Hmm, the cross-device buffer sharing framework I have in mind would > basically be a buffer registry. virtio-gpu would create buffers as > usual, create a identifier somehow (details to be hashed out), attach > the identifier to the dma-buf so it can be used as outlined above. Using physical ad

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-16 Thread Tomasz Figa
On Mon, Oct 14, 2019 at 9:19 PM Gerd Hoffmann wrote: > > > > Well. I think before even discussing the protocol details we need a > > > reasonable plan for buffer handling. I think using virtio-gpu buffers > > > should be an optional optimization and not a requirement. Also the > > > motivation

[PATCH v3] Documentation:media:v4l2:Add vivid metadata doc

2019-10-16 Thread Vandana BN
Adds new file for describing new metadata format V4L2_META_FMT_VIVID added in vivid driver. Signed-off-by: Vandana BN --- Change in V3 - modified pixfmt-meta-vivid.rst to have dual GFDL and GPL license. --- Documentation/media/uapi/v4l/meta-formats.rst | 1 + .../media/uapi/v4l/pixfmt-meta-viv

Re: [virtio-dev] [PATCH] [RFC RESEND] vdec: Add virtio video decode device specification

2019-10-16 Thread Tomasz Figa
On Fri, Oct 11, 2019 at 5:54 PM Dmitry Morozov wrote: > > Hi Tomasz, > > On Mittwoch, 9. Oktober 2019 05:55:45 CEST Tomasz Figa wrote: > > On Tue, Oct 8, 2019 at 12:09 AM Dmitry Morozov > > > > wrote: > > > Hi Tomasz, > > > > > > On Montag, 7. Oktober 2019 16:14:13 CEST Tomasz Figa wrote: > > > >

Re: [PATCH] Documentation:media:v4l2:Add vivid metadata doc

2019-10-16 Thread Hans Verkuil
Vandana, Can you post a v3 with this proposed license? Thanks! Hans On 10/16/19 9:45 PM, Mauro Carvalho Chehab wrote: > Em Fri, 4 Oct 2019 13:59:00 +0200 > Hans Verkuil escreveu: > >> On 10/4/19 1:55 PM, Vandana BN wrote: >>> Adds new file for describing new metadata format V4L2_META_

Re: [PATCH] media: imx.rst: Update the imx6-sabreauto ADV7180 instructions

2019-10-16 Thread Fabio Estevam
Hi Steve, On Wed, Oct 16, 2019 at 4:11 PM Steve Longerbeam wrote: > FIM is available on the above nodes (/dev/video0 and /dev/video3), after > enabling links to them. So please try: > > # media-ctl -l "'ipu1_csi0':2 -> 'ipu1_csi0 capture':0[1]" > # v4l2-ctl -d0 --list-ctrls > > # media-ctl -l "

Re: [PATCH] Documentation:media:v4l2:Add vivid metadata doc

2019-10-16 Thread Mauro Carvalho Chehab
Em Fri, 4 Oct 2019 13:59:00 +0200 Hans Verkuil escreveu: > On 10/4/19 1:55 PM, Vandana BN wrote: > > Adds new file for describing new metadata format V4L2_META_FMT_VIVID added > > in vivid driver. > > > > Signed-off-by: Vandana BN > > --- > > Documentation/media/uapi/v4l/meta-formats.rst | 1

Re: [PATCH] media: imx.rst: Update the imx6-sabreauto ADV7180 instructions

2019-10-16 Thread Steve Longerbeam
On 10/16/19 11:54 AM, Fabio Estevam wrote: On Wed, Oct 16, 2019 at 2:31 PM Steve Longerbeam wrote: If /dev/video2 is the "ipu1_ic_prpvf capture" node, it's because FIM is not yet available on those nodes. The FIM is only available on the "ipuX_csiY capture" nodes. It's on my plate to fix th

Re: [PATCH] media: imx.rst: Update the imx6-sabreauto ADV7180 instructions

2019-10-16 Thread Fabio Estevam
On Wed, Oct 16, 2019 at 2:31 PM Steve Longerbeam wrote: > If /dev/video2 is the "ipu1_ic_prpvf capture" node, it's because FIM is > not yet available on those nodes. The FIM is only available on the > "ipuX_csiY capture" nodes. It's on my plate to fix that. On a 5.3.6 kernel on imx6dl-sabreauto:

Re: [PATCH] media: imx.rst: Update the imx6-sabreauto ADV7180 instructions

2019-10-16 Thread Steve Longerbeam
On 10/16/19 6:04 AM, Fabio Estevam wrote: Hi Steve, On Tue, Oct 15, 2019 at 10:18 PM Steve Longerbeam wrote: Here's a quick example that uses the end-of-frame method to measure fi's (all other FIM controls are left at the default values): v4l2-ctl -d0 --set-ctrl=fim_enable=1 # disable inp

[PATCH] media: imon: invalid dereference in imon_touch_event

2019-10-16 Thread Sean Young
The touch timer is set up in intf1. If the second interface does not exist, the timer and touch input device are not setup and we get the following error, when touch events are reported via intf0. Reported-by: syzbot+f49d12d34f2321cf4...@syzkaller.appspotmail.com Signed-off-by: Sean Young --- dr

Re: [PATCH] media: uapi: h264: clarify num_ref_idx_l[01]_(default_)active fields

2019-10-16 Thread Philipp Zabel
ned in the API, and to have the num_ref_idx_l[01]_active_minus1 fields only be used for num_ref_idx_l[01]_active_minus1, and not have them sometimes contain the values of another field. [1] https://patchwork.linuxtv.org/patch/58580/ [2] https://github.com/intel/libva/blob/95eb8cf469367b532b391042f

Re: [PATCH 1/3] v4l2-dev/ioctl: Add V4L2_CAP_IO_MC

2019-10-16 Thread Hans Verkuil
uct file *file, void *priv, > + struct v4l2_output *o) > +{ > + struct video_device *vfd = video_devdata(file); > + > + if (o->index > 0) > + return -EINVAL; > + > + memset(o, 0, sizeof(*o)); > +

  1   2   3   4   5   6   7   8   9   10   >