Re: [PATCH/RFC v3 00/14] V4L camera control enhancements

2012-05-01 Thread Sylwester Nawrocki
Hi Hans, On 04/30/2012 06:11 PM, Hans Verkuil wrote: > Hi Sylwester! > > I've finished my review. You made excellent documentation for the new > controls! Thank you, and thanks for your time! :-) It took me quite a few hours to prepare it, and lack of proper sensor datasheets didn't make this

Re: [PATCH/RFC v3 00/14] V4L camera control enhancements

2012-04-30 Thread Hans Verkuil
Hi Sylwester! I've finished my review. You made excellent documentation for the new controls! Other than some small stuff the only thing I am unhappy about is the use of menu controls for what are currently just boolean controls. I am inclined to make them boolean controls and add a comment that

Re: [PATCH/RFC v3 00/14] V4L camera control enhancements

2012-04-30 Thread Sylwester Nawrocki
Hi, On 04/27/2012 04:23 PM, Sylwester Nawrocki wrote: > Here is one more update of the camera class controls change set. > > The changes since v2 are: > - V4L2_CID_WHITE_BALANCE_PRESET replaced with > V4L2_CID_AUTO_N_PRESET_WHITE_BALANCE >according to suggestions from Hans de Goede; > - ad

[PATCH/RFC v3 00/14] V4L camera control enhancements

2012-04-27 Thread Sylwester Nawrocki
Here is one more update of the camera class controls change set. The changes since v2 are: - V4L2_CID_WHITE_BALANCE_PRESET replaced with V4L2_CID_AUTO_N_PRESET_WHITE_BALANCE according to suggestions from Hans de Goede; - added Flurescent H white balance preset; - V4L2_CID_IMAGE_STABILIZATIO