Re: [PATCH/RFC] soc-camera: Convert to a platform driver

2009-04-24 Thread Robert Jarzmik
Guennadi Liakhovetski writes: >> > /* Board I2C devices. */ >> I would rather have : >> /* >> * Board I2C devices >> */ > > As a matter of fact (from git-blame): > > 8e7ccddf (Robert Jarzmik 2008-11-15 16:09:54 +0100 732) /* Board I2C devices. > */ Yeah, nobody is perfect I guess. It's hard t

Re: [PATCH/RFC] soc-camera: Convert to a platform driver

2009-04-24 Thread Guennadi Liakhovetski
On Tue, 7 Apr 2009, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > > diff --git a/arch/arm/mach-pxa/mioa701.c b/arch/arm/mach-pxa/mioa701.c > > index 97c93a7..5c8aabf 100644 > > --- a/arch/arm/mach-pxa/mioa701.c > > +++ b/arch/arm/mach-pxa/mioa701.c > > @@ -724,19 +724,19 @@ struct px

Re: [PATCH/RFC] soc-camera: Convert to a platform driver

2009-04-13 Thread Guennadi Liakhovetski
On Sat, 11 Apr 2009, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > > On Thu, 9 Apr 2009, Robert Jarzmik wrote: > > > >> Guennadi Liakhovetski writes: > >> > > > > Did you enable DEBUG? Looks like one of dev_dbg() had a (yet) invalid > > device pointer. I'll have to try that too. >

Re: [PATCH/RFC] soc-camera: Convert to a platform driver

2009-04-10 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > On Thu, 9 Apr 2009, Robert Jarzmik wrote: > >> Guennadi Liakhovetski writes: >> > > Did you enable DEBUG? Looks like one of dev_dbg() had a (yet) invalid > device pointer. I'll have to try that too. No, don't think so. I think that calling mclk_get_divisor() to

Re: [PATCH/RFC] soc-camera: Convert to a platform driver

2009-04-09 Thread Guennadi Liakhovetski
On Thu, 9 Apr 2009, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > > Try with the patch-stack I mentioned in the previous mail, will see then. > Euh, which mail ? I can't find a reference to it. http://www.mail-archive.com/linux-media@vger.kernel.org/msg04213.html > As a preparation

Re: [PATCH/RFC] soc-camera: Convert to a platform driver

2009-04-09 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > Try with the patch-stack I mentioned in the previous mail, will see then. Euh, which mail ? I can't find a reference to it. As a preparation for the weekend, my first try revealed that oops. I must admit I made that test without any involvement of my brain. Cheer

Re: [PATCH/RFC] soc-camera: Convert to a platform driver

2009-04-08 Thread Guennadi Liakhovetski
On Tue, 7 Apr 2009, Robert Jarzmik wrote: > Robert Jarzmik writes: > > > I'll test fully this weekend. > I just made a first try, just to prepare my weekend. Even with Ming Lei patch > reverted, and all statically built, I have no camera detected ... > > Is there something I need to know before

Re: [PATCH/RFC] soc-camera: Convert to a platform driver

2009-04-08 Thread Guennadi Liakhovetski
Hi Robert, On Tue, 7 Apr 2009, Robert Jarzmik wrote: > Guennadi Liakhovetski writes: > > > This is more or less the final version of the first step of the > > v4l2-subdev conversion, hence, all affected driver authors / platform > > maintainers are encouraged to review and test. I have elimin

Re: [PATCH/RFC] soc-camera: Convert to a platform driver

2009-04-07 Thread Robert Jarzmik
Robert Jarzmik writes: > I'll test fully this weekend. I just made a first try, just to prepare my weekend. Even with Ming Lei patch reverted, and all statically built, I have no camera detected ... Is there something I need to know before attempting the brute force method (ie. DEBUG, printks et

Re: [PATCH/RFC] soc-camera: Convert to a platform driver

2009-04-07 Thread Robert Jarzmik
Guennadi Liakhovetski writes: > This is more or less the final version of the first step of the > v4l2-subdev conversion, hence, all affected driver authors / platform > maintainers are encouraged to review and test. I have eliminated OK, here goes a preliminary review for the bits I maintain