Re: [Intel-gfx] [PATCH 01/17] dma-fence: Some kerneldoc polish for dma-fence.h

2018-05-02 Thread Daniel Vetter
On Mon, Apr 30, 2018 at 10:49:00AM -0700, Eric Anholt wrote: > Daniel Vetter writes: > > + /** > > +* @fill_driver_data: > > +* > > +* Callback to fill in free-form debug info Returns amount of bytes > > +* filled, or negative error on failure. > > Maybe this "Returns" should be

Re: [Intel-gfx] [PATCH 01/17] dma-fence: Some kerneldoc polish for dma-fence.h

2018-04-30 Thread Eric Anholt
Daniel Vetter writes: > + /** > + * @fill_driver_data: > + * > + * Callback to fill in free-form debug info Returns amount of bytes > + * filled, or negative error on failure. Maybe this "Returns" should be on a new line? Or at least a '.' in between. Other than that, R