Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-23 Thread H. Peter Anvin
Jan Engelhardt wrote: Hm, maybe g++ defaults to std? Because this works without me using "using std;" #include int main(void) { uint32_t x; } Sorry, this was a bit of a surprise... basically the g++ functionally does #include then exports the symbols into the std namespace, so i

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-23 Thread Jan Engelhardt
On Friday 2009-01-23 22:33, H. Peter Anvin wrote: >> >> I had an objection as previously stated -- namely that >> should be included to remain friendly to C++0x >> programs which should use instead. Forcing >> stdint.h is therefore not nice. > > FWIW, it's kind of pointless in that case; export

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-23 Thread H. Peter Anvin
Jan Engelhardt wrote: I had an objection as previously stated -- namely that should be included to remain friendly to C++0x programs which should use instead. Forcing stdint.h is therefore not nice. FWIW, it's kind of pointless in that case; exports it into the std:: namespace rather than

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-23 Thread Jaswinder Singh Rajput
On Fri, 2009-01-23 at 18:09 +0100, Sam Ravnborg wrote: > On Fri, Jan 23, 2009 at 10:01:44PM +0530, Jaswinder Singh Rajput wrote: > > So is this OK: > > > > -#ifdef __KERNEL__ > > #include > > -#else > > -#include > > -#endif > > That was what I expected the final change to look like. > If you

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-23 Thread Sam Ravnborg
On Fri, Jan 23, 2009 at 10:01:44PM +0530, Jaswinder Singh Rajput wrote: > On Fri, 2009-01-23 at 17:21 +0100, Sam Ravnborg wrote: > > On Fri, Jan 23, 2009 at 05:11:13PM +0100, Jan Engelhardt wrote: > > > > > > On Friday 2009-01-23 17:04, Jaswinder Singh Rajput wrote: > > > >> > diff --git a/include

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-23 Thread Jaswinder Singh Rajput
On Fri, 2009-01-23 at 17:21 +0100, Sam Ravnborg wrote: > On Fri, Jan 23, 2009 at 05:11:13PM +0100, Jan Engelhardt wrote: > > > > On Friday 2009-01-23 17:04, Jaswinder Singh Rajput wrote: > > >> > diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h > > >> > index 89412e1..758a48c 100

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-23 Thread Sam Ravnborg
On Fri, Jan 23, 2009 at 05:11:13PM +0100, Jan Engelhardt wrote: > > On Friday 2009-01-23 17:04, Jaswinder Singh Rajput wrote: > >> > diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h > >> > index 89412e1..758a48c 100644 > >> > --- a/include/linux/dvb/audio.h > >> > +++ b/include/l

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-23 Thread Jan Engelhardt
On Friday 2009-01-23 17:04, Jaswinder Singh Rajput wrote: >> > diff --git a/include/linux/dvb/audio.h b/include/linux/dvb/audio.h >> > index 89412e1..758a48c 100644 >> > --- a/include/linux/dvb/audio.h >> > +++ b/include/linux/dvb/audio.h >> > @@ -24,9 +24,8 @@ >> > #ifndef _DVBAUDIO_H_ >> > #de

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-23 Thread Jaswinder Singh Rajput
On Fri, 2009-01-23 at 21:29 +0530, Jaswinder Singh Rajput wrote: > On Wed, 2009-01-21 at 06:08 +0530, Jaswinder Singh Rajput wrote: > > On Sat, 2009-01-17 at 14:26 -0800, H. Peter Anvin wrote: > > > Sam Ravnborg wrote: > > > >>> > > > >> That patch looks wrong, and unnecessary. It was fine before

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-23 Thread Jaswinder Singh Rajput
On Wed, 2009-01-21 at 06:08 +0530, Jaswinder Singh Rajput wrote: > On Sat, 2009-01-17 at 14:26 -0800, H. Peter Anvin wrote: > > Sam Ravnborg wrote: > > >>> > > >> That patch looks wrong, and unnecessary. It was fine before. > > > Nope - include/linux/dvb/audio.h failed to include linux/types.h >

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-23 Thread Jaswinder Singh Rajput
On Sat, 2009-01-17 at 23:18 -0500, Kyle McMartin wrote: > On Sun, Jan 18, 2009 at 09:08:24AM +0530, Jaswinder Singh Rajput wrote: > > If this file is _ONLY_ for userspace and kernel cannot use it then what > > is the point of keeping this file in kernel headers. > > > > There is effectively no po

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-20 Thread Jaswinder Singh Rajput
On Sat, 2009-01-17 at 14:26 -0800, H. Peter Anvin wrote: > Sam Ravnborg wrote: > >>> > >> That patch looks wrong, and unnecessary. It was fine before. > > Nope - include/linux/dvb/audio.h failed to include linux/types.h > > despite the fact that is uses __u32 etc. > > > > But why the _kernel_ sh

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-18 Thread Jaswinder Singh Rajput
On Mon, 2009-01-19 at 11:24 +1100, Stephen Rothwell wrote: > On Sun, 18 Jan 2009 01:47:21 +0530 Jaswinder Singh Rajput > wrote: > > > > diff --git a/include/linux/nfsd/stats.h b/include/linux/nfsd/stats.h > > index 7678cfb..0b53cfe 100644 > > --- a/include/linux/nfsd/stats.h > > +++ b/include/lin

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-18 Thread Stephen Rothwell
On Sun, 18 Jan 2009 01:47:21 +0530 Jaswinder Singh Rajput wrote: > > diff --git a/include/linux/nfsd/stats.h b/include/linux/nfsd/stats.h > index 7678cfb..0b53cfe 100644 > --- a/include/linux/nfsd/stats.h > +++ b/include/linux/nfsd/stats.h > @@ -29,9 +29,11 @@ struct nfsd_stats { > unsigned

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-18 Thread Sam Ravnborg
On Sun, Jan 18, 2009 at 10:13:00AM +0100, Ingo Molnar wrote: > > * Sam Ravnborg wrote: > > > On Sun, Jan 18, 2009 at 08:37:41AM +1100, David Woodhouse wrote: > > > On Sun, 2009-01-18 at 01:47 +0530, Jaswinder Singh Rajput wrote: > > > > --- a/include/linux/dvb/audio.h > > > > +++ b/include/linux

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-18 Thread Ingo Molnar
* Sam Ravnborg wrote: > On Sun, Jan 18, 2009 at 08:37:41AM +1100, David Woodhouse wrote: > > On Sun, 2009-01-18 at 01:47 +0530, Jaswinder Singh Rajput wrote: > > > --- a/include/linux/dvb/audio.h > > > +++ b/include/linux/dvb/audio.h > > > @@ -24,9 +24,8 @@ > > > #ifndef _DVBAUDIO_H_ > > > #de

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-17 Thread Kyle McMartin
On Sun, Jan 18, 2009 at 09:08:24AM +0530, Jaswinder Singh Rajput wrote: > If this file is _ONLY_ for userspace and kernel cannot use it then what > is the point of keeping this file in kernel headers. > There is effectively no point, especially when they reference a variable that may or may not e

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-17 Thread Jaswinder Singh Rajput
On Sat, 2009-01-17 at 22:33 -0500, Kyle McMartin wrote: > On Sun, Jan 18, 2009 at 08:35:01AM +0530, Jaswinder Singh Rajput wrote: > > Hello Sam, David, > > > > /home/jaswinder/jaswinder-git/linux-2.6-tip/usr/include/mtd/jffs2-user.h:20: > > extern's make no sense in userspace > > > > This file

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-17 Thread Kyle McMartin
On Sun, Jan 18, 2009 at 08:35:01AM +0530, Jaswinder Singh Rajput wrote: > Hello Sam, David, > > /home/jaswinder/jaswinder-git/linux-2.6-tip/usr/include/mtd/jffs2-user.h:20: > extern's make no sense in userspace > This file is for userspace only, and it makes sense where it's used (mtd-utils.)

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-17 Thread Jaswinder Singh Rajput
Hello Sam, David, On Sat, 2009-01-17 at 23:19 +0100, Sam Ravnborg wrote: > On Sun, Jan 18, 2009 at 08:37:41AM +1100, David Woodhouse wrote: > > On Sun, 2009-01-18 at 01:47 +0530, Jaswinder Singh Rajput wrote: > > > --- a/include/linux/dvb/audio.h > > > +++ b/include/linux/dvb/audio.h > > > @@ -24,

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-17 Thread Jaswinder Singh Rajput
Hello David, On Sun, 2009-01-18 at 09:23 +1100, David Woodhouse wrote: > On Sat, 2009-01-17 at 23:19 +0100, Sam Ravnborg wrote: > > Nope - include/linux/dvb/audio.h failed to include linux/types.h > > despite the fact that is uses __u32 etc. > > Er, good point. I saw the and assumed it was using

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-17 Thread H. Peter Anvin
Sam Ravnborg wrote: >>> >> That patch looks wrong, and unnecessary. It was fine before. > Nope - include/linux/dvb/audio.h failed to include linux/types.h > despite the fact that is uses __u32 etc. > > But why the _kernel_ should include a userspace header is > much more questionable. > is on

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-17 Thread David Woodhouse
On Sat, 2009-01-17 at 23:19 +0100, Sam Ravnborg wrote: > Nope - include/linux/dvb/audio.h failed to include linux/types.h > despite the fact that is uses __u32 etc. Er, good point. I saw the and assumed it was using only proper C types... but then it wouldn't have triggered the warning, would it?

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-17 Thread Sam Ravnborg
On Sun, Jan 18, 2009 at 08:37:41AM +1100, David Woodhouse wrote: > On Sun, 2009-01-18 at 01:47 +0530, Jaswinder Singh Rajput wrote: > > --- a/include/linux/dvb/audio.h > > +++ b/include/linux/dvb/audio.h > > @@ -24,9 +24,8 @@ > > #ifndef _DVBAUDIO_H_ > > #define _DVBAUDIO_H_ > > > > -#ifdef __K

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-17 Thread Jan Engelhardt
On Saturday 2009-01-17 22:37, David Woodhouse wrote: >On Sun, 2009-01-18 at 01:47 +0530, Jaswinder Singh Rajput wrote: >> --- a/include/linux/dvb/audio.h >> +++ b/include/linux/dvb/audio.h >> @@ -24,9 +24,8 @@ >> #ifndef _DVBAUDIO_H_ >> #define _DVBAUDIO_H_ >> >> -#ifdef __KERNEL__ >> #includ

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-17 Thread David Woodhouse
On Sun, 2009-01-18 at 01:47 +0530, Jaswinder Singh Rajput wrote: > --- a/include/linux/dvb/audio.h > +++ b/include/linux/dvb/audio.h > @@ -24,9 +24,8 @@ > #ifndef _DVBAUDIO_H_ > #define _DVBAUDIO_H_ > > -#ifdef __KERNEL__ > #include > -#else > +#ifndef __KERNEL__ > #include > #endif > T

[GIT PULL -tip] fix 33 make headers_check warnings

2009-01-17 Thread Jaswinder Singh Rajput
The following changes since commit 03b3e5ab1d1ac93bd45a6d3b38ab81785cda0d41: Ingo Molnar (1): Merge branch 'out-of-tree' are available in the git repository at: git://git.kernel.org/pub/scm/linux/kernel/git/jaswinder/linux-2.6-tip.git master Jaswinder Singh Rajput (26): can/bc