Re: [GIT PULL] ViewCast O820E capture support added

2012-09-14 Thread Hans Verkuil
On Fri September 14 2012 04:09:42 Mauro Carvalho Chehab wrote: > Em 13-09-2012 21:59, Mauro Carvalho Chehab escreveu: > > Em Thu, 13 Sep 2012 20:23:42 -0300 > > Mauro Carvalho Chehab escreveu: > > > >> Em 13-09-2012 20:19, Mauro Carvalho Chehab escreveu: > >>> Em Sat, 18 Aug 2012 11:48:52 -0400 >

Re: [GIT PULL] ViewCast O820E capture support added

2012-09-13 Thread Mauro Carvalho Chehab
Em 13-09-2012 21:59, Mauro Carvalho Chehab escreveu: > Em Thu, 13 Sep 2012 20:23:42 -0300 > Mauro Carvalho Chehab escreveu: > >> Em 13-09-2012 20:19, Mauro Carvalho Chehab escreveu: >>> Em Sat, 18 Aug 2012 11:48:52 -0400 >>> Steven Toth escreveu: >>> Mauro, please read below, a new set of p

Re: [GIT PULL] ViewCast O820E capture support added

2012-09-13 Thread Mauro Carvalho Chehab
Em Thu, 13 Sep 2012 20:23:42 -0300 Mauro Carvalho Chehab escreveu: > Em 13-09-2012 20:19, Mauro Carvalho Chehab escreveu: > > Em Sat, 18 Aug 2012 11:48:52 -0400 > > Steven Toth escreveu: > > > >> Mauro, please read below, a new set of patches I'm submitting for merge. > >> > >> On Thu, Aug 16,

Re: [GIT PULL] ViewCast O820E capture support added

2012-09-13 Thread Mauro Carvalho Chehab
Em 13-09-2012 20:19, Mauro Carvalho Chehab escreveu: > Em Sat, 18 Aug 2012 11:48:52 -0400 > Steven Toth escreveu: > >> Mauro, please read below, a new set of patches I'm submitting for merge. >> >> On Thu, Aug 16, 2012 at 2:49 PM, Hans Verkuil wrote: >>> On Thu August 16 2012 19:39:51 Steven Tot

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-18 Thread Hans Verkuil
On Sat August 18 2012 17:48:52 Steven Toth wrote: > Mauro, please read below, a new set of patches I'm submitting for merge. > > On Thu, Aug 16, 2012 at 2:49 PM, Hans Verkuil wrote: > > On Thu August 16 2012 19:39:51 Steven Toth wrote: > >> >> So, I've ran v4l2-compliance and it pointed out a few

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-18 Thread Steven Toth
Mauro, please read below, a new set of patches I'm submitting for merge. On Thu, Aug 16, 2012 at 2:49 PM, Hans Verkuil wrote: > On Thu August 16 2012 19:39:51 Steven Toth wrote: >> >> So, I've ran v4l2-compliance and it pointed out a few things that I've >> >> fixed, but it also does a few things

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-16 Thread Hans Verkuil
On Thu August 16 2012 19:39:51 Steven Toth wrote: > >> So, I've ran v4l2-compliance and it pointed out a few things that I've > >> fixed, but it also does a few things that (for some reason) I can't > >> seem to catch. One particular test is on (iirc) s_fmt. It attempts to > >> set ATSC but by ioct

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-16 Thread Steven Toth
>> So, I've ran v4l2-compliance and it pointed out a few things that I've >> fixed, but it also does a few things that (for some reason) I can't >> seem to catch. One particular test is on (iirc) s_fmt. It attempts to >> set ATSC but by ioctl callback never receives ATSC in the norm/id arg, >> it a

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-16 Thread Hans Verkuil
On Thu August 16 2012 15:27:51 Steven Toth wrote: > >> While I don't necessarily agree with Mauro that adoption of subdev is > >> "MANDATORY" (in the larger sense of the kernel driver development - > >> and common practices throughout the entire source base), I do hear and > >> value your comments

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-16 Thread Steven Toth
>> While I don't necessarily agree with Mauro that adoption of subdev is >> "MANDATORY" (in the larger sense of the kernel driver development - >> and common practices throughout the entire source base), I do hear and >> value your comments and concerns from a peer review perspective. > > You're aw

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-15 Thread Hans Verkuil
On Tue August 14 2012 17:07:55 Steven Toth wrote: > On Mon, Aug 13, 2012 at 1:36 PM, Mauro Carvalho Chehab > wrote: > > Em 13-08-2012 12:49, Hans Verkuil escreveu: > >> On Mon August 13 2012 16:46:45 Steven Toth wrote: > >>> Hans, > >>> > >>> Thanks for your feedback. > >>> > >>> Oh dear. I don't

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-14 Thread Steven Toth
On Mon, Aug 13, 2012 at 1:36 PM, Mauro Carvalho Chehab wrote: > Em 13-08-2012 12:49, Hans Verkuil escreveu: >> On Mon August 13 2012 16:46:45 Steven Toth wrote: >>> Hans, >>> >>> Thanks for your feedback. >>> >>> Oh dear. I don't think you're going to like my response, but I think >>> we know each

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-13 Thread Mauro Carvalho Chehab
Em 13-08-2012 12:49, Hans Verkuil escreveu: > On Mon August 13 2012 16:46:45 Steven Toth wrote: >> Hans, >> >> Thanks for your feedback. >> >> Oh dear. I don't think you're going to like my response, but I think >> we know each other well enough to realize that neither of us are >> trying to antago

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-13 Thread Hans Verkuil
On Mon August 13 2012 16:46:45 Steven Toth wrote: > Hans, > > Thanks for your feedback. > > Oh dear. I don't think you're going to like my response, but I think > we know each other well enough to realize that neither of us are > trying to antagonize or upset either other. We're simply stating ou

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-13 Thread Steven Toth
Hans, Thanks for your feedback. Oh dear. I don't think you're going to like my response, but I think we know each other well enough to realize that neither of us are trying to antagonize or upset either other. We're simply stating our positions. Please read on. > I went through this driver from

Re: [GIT PULL] ViewCast O820E capture support added

2012-08-13 Thread Hans Verkuil
Hi Steve! On Mon August 13 2012 01:16:30 Steven Toth wrote: > Hi Mauro, > > A new PCIe bridge driver below. It was released a couple of months ago > to the public, probably about time > we got this into the request queue. I'll review the linux-firmware > additions shortly, I have a firmware blob

[GIT PULL] ViewCast O820E capture support added

2012-08-12 Thread Steven Toth
Hi Mauro, A new PCIe bridge driver below. It was released a couple of months ago to the public, probably about time we got this into the request queue. I'll review the linux-firmware additions shortly, I have a firmware blob and flexible license for the distros. The following changes since commit