Re: [ATTN] Please review/check the REVIEWv4 compound control patch series

2014-07-25 Thread Ricardo Ribalda Delgado
Hi Hans! > I was thinking of just the sensor driver, not the other components. > That would provide a proper use-case for both the dead pixel array > and multi-selection. > > I assume that the sensor driver is a lot smaller? Does it need fw as well? > We support multiple sensors. The one that req

Re: [ATTN] Please review/check the REVIEWv4 compound control patch series

2014-07-25 Thread Hans Verkuil
On 07/25/14 14:09, Ricardo Ribalda Delgado wrote: > Hello Hans > > I still need the multiselection support first. Right now it is done by > a modified g/s_selection ioctl. > > I would love to upstream the driver, but maybe it is not the right > moment right now. We are selling a mainly to a coupl

Re: [ATTN] Please review/check the REVIEWv4 compound control patch series

2014-07-25 Thread Ricardo Ribalda Delgado
Hello Hans I still need the multiselection support first. Right now it is done by a modified g/s_selection ioctl. I would love to upstream the driver, but maybe it is not the right moment right now. We are selling a mainly to a couple of customers and the total size of the drivers is > 16000 line

Re: [ATTN] Please review/check the REVIEWv4 compound control patch series

2014-07-25 Thread Hans Verkuil
Hi Ricardo, On 07/25/14 13:52, Ricardo Ribalda Delgado wrote: > Hello Hans > > > Guess it is too late, but just so you know. I have successfully uses > this patches to implement a dead pixel array list. > > Tested-by: Ricardo Ribalda > Thanked-by: Ricardo Ribalda :) Nevertheless nice to hea

Re: [ATTN] Please review/check the REVIEWv4 compound control patch series

2014-07-25 Thread Ricardo Ribalda Delgado
Hello Hans Guess it is too late, but just so you know. I have successfully uses this patches to implement a dead pixel array list. Tested-by: Ricardo Ribalda Thanked-by: Ricardo Ribalda :) Thanks! On Thu, Jul 17, 2014 at 3:56 PM, Ricardo Ribalda Delgado wrote: > Hello Hans > > I am plannin

Re: [ATTN] Please review/check the REVIEWv4 compound control patch series

2014-07-17 Thread Ricardo Ribalda Delgado
Hello Hans I am planning to test this patchset for dead pixels by the end of this week and the beggining of the next. I am thinking about comparing the performance a list of deadpixels against a list of all pixels with their property (ok pixel, dead pixel, white pixel, slow pixel...) Will write b

[ATTN] Please review/check the REVIEWv4 compound control patch series

2014-06-12 Thread Hans Verkuil
Mauro & anyone else with an interest, I'd appreciate it if this patch series was reviewed, in particular with respect to the handling of multi-dimensional arrays: http://www.mail-archive.com/linux-media@vger.kernel.org/msg75929.html This patch series incorporates all comments from the REVIEWv3 s