Re: [PATCH 3/4] pxa-camera: Match with device node, not the port node

Sakari Ailus writes: > V4L2 fwnode matching right now still works based on device nodes, not port > nodes. Fix this. Mmmh why does it need a fix, and what's wrong on device node matching ? This commit message is a bit too brief for me to understand why a fix is needed. Moreover, does it have an

Re: [PATCH v2] media: mt9m111: add regulator support

Mauro Carvalho Chehab writes: > From: Robert Jarzmik > > In the soc_camera removal, the board specific power callback was > dropped. This at least will remove the power optimization from ezx and > em-x270 pxa based boards. > > As to recreate the same level of functional

Re: [PATCH v2] media: mt9m111: add regulator support

Akinobu Mita writes: >> Can anyone test this patch and send a tested-by? > > In my devicetree, vdd-supply is not defined. So it falls back to the dummy > regulator and works fine. Would that work also in a non devicetree build, ie. in a platform_data based one (as this is one of the mach-pxa tar

Re: [PATCH v2] media: mt9m111: add regulator support

Mauro Carvalho Chehab writes: > Hi Sakari, > > Em Fri, 31 May 2019 14:27:24 +0300 > Sakari Ailus escreveu: > >> Hi Mauro, >> >> On Wed, May 29, 2019 at 03:25:18PM -0400, Mauro Carvalho Chehab wrote: >> > From: Robert Jarzmik > > As stated here

[PATCH v2 12/13] ARM: pxa: remove the DMA IO resources

As the last driver using the former mechanism to acquire the DMA requestor line has be converted to the dma_slave_map, remove all these resources from the PXA devices. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/devices.c | 136 1 file

[PATCH v2 06/13] net: smc911x: remove the dmaengine compat need

-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc911x.c | 16 ++-- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/drivers/net/ethernet/smsc/smc911x.c b/drivers/net/ethernet/smsc/smc911x.c index 05157442a980..4c3713bd5caa 100644 --- a/drivers/net/ethernet/smsc

[PATCH v2 02/13] ARM: pxa: add dma slave map

In order to remove the specific knowledge of the dma mapping from PXA drivers, add a default slave map for pxa architectures. This is the first step, and once all drivers are converted, pxad_filter_fn() will be made static, and the DMA resources removed from device.c. Signed-off-by: Robert

[PATCH v2 09/13] ata: pata_pxa: remove the dmaengine compat need

-off-by: Robert Jarzmik Acked-by: Bartlomiej Zolnierkiewicz --- drivers/ata/pata_pxa.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c index f6c46e9a4dc0..e8b6a2e464c9 100644 --- a/drivers/ata/pata_pxa.c +++ b/drivers

[PATCH v2 08/13] ASoC: pxa: remove the dmaengine compat need

-off-by: Robert Jarzmik --- sound/arm/pxa2xx-ac97.c | 14 ++ sound/arm/pxa2xx-pcm-lib.c | 6 +++--- sound/soc/pxa/pxa2xx-ac97.c | 32 +--- sound/soc/pxa/pxa2xx-i2s.c | 6 ++ 4 files changed, 12 insertions(+), 46 deletions(-) diff --git a/sound

[PATCH v2 03/13] mmc: pxamci: remove the dmaengine compat need

-off-by: Robert Jarzmik Acked-by: Ulf Hansson --- drivers/mmc/host/pxamci.c | 29 +++-- 1 file changed, 3 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index c763b404510f..6c94474e36f4 100644 --- a/drivers/mmc/host

[PATCH v2 11/13] dmaengine: pxa: make the filter function internal

As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 5 ++--- include/linux/dma

[PATCH v2 10/13] dmaengine: pxa: document pxad_param

Add some documentation for the pxad_param structure, and describe the contract behind the minimal required priority of a DMA channel. Signed-off-by: Robert Jarzmik --- include/linux/dma/pxa-dma.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/dma/pxa-dma.h b/include

[PATCH v2 05/13] mtd: rawnand: marvell: remove the dmaengine compat need

-off-by: Signed-off-by: Daniel Mack Signed-off-by: Robert Jarzmik --- drivers/mtd/nand/raw/marvell_nand.c | 17 + 1 file changed, 1 insertion(+), 16 deletions(-) diff --git a/drivers/mtd/nand/raw/marvell_nand.c b/drivers/mtd/nand/raw/marvell_nand.c index 10e953218948

[PATCH v2 04/13] media: pxa_camera: remove the dmaengine compat need

-off-by: Robert Jarzmik Acked-by: Hans Verkuil Acked-by: Mauro Carvalho Chehab --- drivers/media/platform/pxa_camera.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media/platform/pxa_camera.c index

[PATCH v2 01/13] dmaengine: pxa: use a dma slave map

tatic, and the DMA resources removed from device.c. Signed-off-by: Robert Jarzmik Reported-by: Arnd Bergmann Acked-by: Vinod Koul --- drivers/dma/pxa_dma.c | 10 +- include/linux/platform_data/mmp_dma.h | 4 2 files changed, 13 insertions(+), 1 deletion(-) diff --

[PATCH v2 13/13] ARM: pxa: change SSP DMA channels allocation

x" or "tx". - for device tree platforms, the dma node should be hooked into the pxa2xx-ac97 or pxa-ssp-dai node. Signed-off-by: Robert Jarzmik --- Since v1: Removed channel names from platform_data --- arch/arm/plat-pxa/ssp.c| 47 -

[PATCH v2 07/13] net: smc91x: remove the dmaengine compat need

-off-by: Robert Jarzmik --- drivers/net/ethernet/smsc/smc91x.c | 12 +--- drivers/net/ethernet/smsc/smc91x.h | 1 - 2 files changed, 1 insertion(+), 12 deletions(-) diff --git a/drivers/net/ethernet/smsc/smc91x.c b/drivers/net/ethernet/smsc/smc91x.c index 080428762858..4c600f430f6d

[PATCH v2 00/13] ARM: pxa: switch to DMA slave maps

that the cpu device provides the DMA - I added pxa2xx-i2s which was forgotten Therefore I need a new ack - Arnd and Daniel / SSP topic / 0013 Review and ack of this one Happy review. -- Robert Robert Jarzmik (13): dmaengine: pxa: use a dma slave map ARM: pxa: add dma slave map

Re: [PATCH 04/15] media: pxa_camera: remove the dmaengine compat need

Robert Jarzmik writes: > From: Robert Jarzmik > > As the pxa architecture switched towards the dmaengine slave map, the > old compatibility mechanism to acquire the dma requestor line number and > priority are not needed anymore. > > This patch simplifies the dma resource a

Re: [PATCH 1/7] i2c: i2c-gpio: move header to platform_data

Wolfram Sang writes: > This header only contains platform_data. Move it to the proper directory. > > Signed-off-by: Wolfram Sang For mach-pxa: Acked-by: Robert Jarzmik Take it through your tree, no problem for the pxa part. Cheers. -- Robert

Re: [PATCH 08/15] ASoC: pxa: remove the dmaengine compat need

Mark Brown writes: > On Mon, Apr 02, 2018 at 04:26:49PM +0200, Robert Jarzmik wrote: >> As the pxa architecture switched towards the dmaengine slave map, the >> old compatibility mechanism to acquire the dma requestor line number and >> priority are not needed anymore. >

Re: [PATCH 00/15] ARM: pxa: switch to DMA slave maps

Ulf Hansson writes: > On 2 April 2018 at 16:26, Robert Jarzmik wrote: >> Hi, >> >> This serie is aimed at removing the dmaengine slave compat use, and transfer >> knowledge of the DMA requestors into architecture code. >> As this looks like a patch bomb, each m

Re: [PATCH 02/15] ARM: pxa: add dma slave map

Arnd Bergmann writes: >> + { "smc911x.0", "rx", PDMA_FILTER_PARAM(LOWEST, -1) }, >> + { "smc911x.0", "tx", PDMA_FILTER_PARAM(LOWEST, -1) }, >> + { "smc91x.0", "data", PDMA_FILTER_PARAM(LOWEST, -1) }, > > This one is interesting, as you are dealing with an off-chip device, > and

[PATCH 08/15] ASoC: pxa: remove the dmaengine compat need

-off-by: Robert Jarzmik --- sound/arm/pxa2xx-ac97.c | 14 ++ sound/arm/pxa2xx-pcm-lib.c | 6 +++--- sound/soc/pxa/pxa2xx-ac97.c | 32 +--- 3 files changed, 10 insertions(+), 42 deletions(-) diff --git a/sound/arm/pxa2xx-ac97.c b/sound/arm/pxa2xx-ac97.c

[PATCH 00/15] ARM: pxa: switch to DMA slave maps

ware, including : - pxamci - pxa_camera - smc* - ASoC and SSP Happy review. Robert Jarzmik (15): dmaengine: pxa: use a dma slave map ARM: pxa: add dma slave map mmc: pxamci: remove the dmaengine compat need media: pxa_camera: remove the dmaengine compat need mtd: nand: pxa3xx: remov

[PATCH 02/15] ARM: pxa: add dma slave map

In order to remove the specific knowledge of the dma mapping from PXA drivers, add a default slave map for pxa architectures. This is the first step, and once all drivers are converted, pxad_filter_fn() will be made static, and the DMA resources removed from device.c. Signed-off-by: Robert

[PATCH 01/15] dmaengine: pxa: use a dma slave map

tatic, and the DMA resources removed from device.c. Signed-off-by: Robert Jarzmik Reported-by: Arnd Bergmann --- drivers/dma/pxa_dma.c | 10 +- include/linux/platform_data/mmp_dma.h | 4 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/dma/pxa_

[PATCH 03/15] mmc: pxamci: remove the dmaengine compat need

-off-by: Robert Jarzmik --- drivers/mmc/host/pxamci.c | 29 +++-- 1 file changed, 3 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/host/pxamci.c b/drivers/mmc/host/pxamci.c index c763b404510f..6c94474e36f4 100644 --- a/drivers/mmc/host/pxamci.c +++ b/drivers/mmc

[PATCH 06/15] net: smc911x: remove the dmaengine compat need

From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function

[PATCH 07/15] net: smc91x: remove the dmaengine compat need

From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function

[PATCH 09/15] net: irda: pxaficp_ir: remove the dmaengine compat need

-off-by: Robert Jarzmik --- drivers/staging/irda/drivers/pxaficp_ir.c | 14 ++ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/drivers/staging/irda/drivers/pxaficp_ir.c b/drivers/staging/irda/drivers/pxaficp_ir.c index 2ea00a6531f9..9dd6e21dc11e 100644 --- a/drivers

[PATCH 10/15] ata: pata_pxa: remove the dmaengine compat need

-off-by: Robert Jarzmik --- drivers/ata/pata_pxa.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/drivers/ata/pata_pxa.c b/drivers/ata/pata_pxa.c index f6c46e9a4dc0..e8b6a2e464c9 100644 --- a/drivers/ata/pata_pxa.c +++ b/drivers/ata/pata_pxa.c @@ -25,7 +25,6

[PATCH 11/15] dmaengine: pxa: document pxad_param

Add some documentation for the pxad_param structure, and describe the contract behind the minimal required priority of a DMA channel. Signed-off-by: Robert Jarzmik --- include/linux/dma/pxa-dma.h | 9 + 1 file changed, 9 insertions(+) diff --git a/include/linux/dma/pxa-dma.h b/include

[PATCH 12/15] dmaengine: pxa: make the filter function internal

As the pxa architecture and all its related drivers do not rely anymore on the filter function, thanks to the slave map conversion, make pxad_filter_fn() static, and remove it from the global namespace. Signed-off-by: Robert Jarzmik --- drivers/dma/pxa_dma.c | 5 ++--- include/linux/dma

[PATCH 15/15] ARM: pxa: change SSP DMA channels allocation

device tree platforms, the dma node should be hooked into the pxa-pcm-audio node. Signed-off-by: Robert Jarzmik --- arch/arm/plat-pxa/ssp.c| 50 +- include/linux/pxa2xx_ssp.h | 4 ++-- sound/soc/pxa/pxa-ssp.c| 5 ++--- 3 files changed, 9

[PATCH 14/15] ARM: pxa: change SSP devices allocation

In order to prepare for the dma_slave_map change for SSP DMA channels allocation, the SSP platform devices will now include a platform data structure which in turn selects which dma channel has to be used for data transfers, especially the PCM ones. Signed-off-by: Robert Jarzmik --- arch/arm

[PATCH 13/15] ARM: pxa: remove the DMA IO resources

As the last driver using the former mechanism to acquire the DMA requestor line has be converted to the dma_slave_map, remove all these resources from the PXA devices. Signed-off-by: Robert Jarzmik --- arch/arm/mach-pxa/devices.c | 136 1 file

[PATCH 05/15] mtd: nand: pxa3xx: remove the dmaengine compat need

From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function

[PATCH 04/15] media: pxa_camera: remove the dmaengine compat need

From: Robert Jarzmik As the pxa architecture switched towards the dmaengine slave map, the old compatibility mechanism to acquire the dma requestor line number and priority are not needed anymore. This patch simplifies the dma resource acquisition, using the more generic function

Re: [PATCH] [media] pxa_camera: Delete an error message for a failed memory allocation in pxa_camera_probe()

SF Markus Elfring writes: > From: Markus Elfring > Date: Fri, 8 Sep 2017 22:05:14 +0200 > > Omit an extra message for a memory allocation failure in this function. > > This issue was detected by using the Coccinelle software. > > Signed-off-by: Markus Elfring Acked-by:

Re: [RFC] [PATCH 0/4] [media] pxa_camera: Fixing bugs and missing colorformats

Petr Cvek writes: > Dne 1.5.2017 v 06:20 Petr Cvek napsal(a): >> This patchset is just a grouping of a few bugfixes I've found during >> the ov9640 sensor support re-adding. > > P.S. I've manually calculated every format variant for the image size > calculation functions, but still these functio

Re: [PATCH 4/4] [media] pxa_camera: Fix a call with an uninitialized device pointer

orm_device > (as before the old patch). > > Signed-off-by: Petr Cvek Right, would be good to add to the commit message : Fixes: 295ab497d635 ("[media] media: platform: pxa_camera: make printk consistent") And : Acked-by: Robert Jarzmik Cheers. -- Robert > --- > drivers

Re: [PATCH 3/4] [media] pxa_camera: Add (un)subscribe_event ioctl

Petr Cvek writes: > The v4l2-compliance complains about nonexistent vidioc_subscribe_event > and vidioc_unsubscribe_event calls. Add them to fix the complaints. > > Signed-off-by: Petr Cvek Don't know on that one, let others on the mailing list comment, I'm not familiar with the event interface

Re: [PATCH 2/4] [media] pxa_camera: Fix incorrect test in the image size generation

Petr Cvek writes: > During the transfer from the soc_camera a test in pxa_mbus_image_size() > got removed. Without it any PXA_MBUS_LAYOUT_PACKED format causes either > the return of a wrong value (PXA_MBUS_PACKING_2X8_PADHI doubles > the correct value) or EINVAL (PXA_MBUS_PACKING_NONE and > PXA_M

Re: [PATCH 1/4] [media] pxa_camera: Add remaining Bayer 8 formats

ver. > > Signed-off-by: Petr Cvek Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH] [media] pxa_camera: fix module remove codepath for v4l2 clock

Petr Cvek writes: > I will post some other bugfixes (and feature adding) for pxa_camera soon. Do > you wish to be CC'd? > > P.S. Who is the the maintainer of pxa_camera BTW? Still Guennadi Liakhovetski? Euh no, that's me. I had submitted a patch for that here : https://patchwork.kernel.org/p

Re: [PATCH] [media] pxa_camera: fix module remove codepath for v4l2 clock

the ov9640 from the soc_camera. > > Signed-off-by: Petr Cvek Yeah, it's way better with this patch, especially the insmod/rmmod/insmod/rmmod test. Tested-by: Robert Jarzmik Acked-by: Robert Jarzmik Cheers. -- Robert

Re: [PATCH 1/2] media: platform: pxa_camera: add missing sensor power on

Robert Jarzmik writes: > During sensors binding, there is a window where the sensor is switched > off, while there is a call it to set a new format, which can end up in > an access to the sensor, especially an I2C based sensor. > > Remove this window by activating the sensor. Hi

Re: [PATCH 54/57] [media] platform: don't break long lines

Signed-off-by: Mauro Carvalho Chehab > --- > drivers/media/platform/mx2_emmaprp.c | 3 +-- > drivers/media/platform/pxa_camera.c | 6 ++ > drivers/media/platform/via-camera.c | 7 ++- > 3 files changed, 5 insertions(+), 11 deletions(-) For pxa_camera, FWIW: Acked-by: Rober

[PATCH 2/2] media: mt9m111: add regulator support

plug in a gpio based or ldo regulator, mimicking their former soc_camera power hook. Fixes: 5c10113cc668 ("media: mt9m111: make a standalone v4l2 subdevice") Signed-off-by: Robert Jarzmik --- drivers/media/i2c/mt9m111.c | 14 ++ 1 file changed, 14 insertions(+) diff --git

[PATCH 1/2] media: platform: pxa_camera: add missing sensor power on

During sensors binding, there is a window where the sensor is switched off, while there is a call it to set a new format, which can end up in an access to the sensor, especially an I2C based sensor. Remove this window by activating the sensor. Signed-off-by: Robert Jarzmik --- drivers/media

Re: [PATCH] pxa_camera: merge soc_mediabus.c into pxa_camera.c

i driver out of soc_camera. Ok, fair enough. I have tested that for at least YUV422, YUYV, YVYU and RGB565 formats : Tested-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] pxa_camera: merge soc_mediabus.c into pxa_camera.c

tures from soc_mediabus and renames it > to pxa_mbus_*. > > The large table of formats has been culled a bit, removing formats that are > not supported > by this driver. > > Signed-off-by: Hans Verkuil > Cc: Robert Jarzmik Hi Hans, I wonder why you chose to copy-paste this co

Re: [PATCH -next] [media] pxa_camera: remove duplicated include from pxa_camera.c

Wei Yongjun writes: > From: Wei Yongjun > > Remove duplicated include. > > Signed-off-by: Wei Yongjun Acked-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.

Re: [PATCH -next] [media] pxa_camera: fix error return code in pxa_camera_probe()

gned-off-by: Wei Yongjun Acked-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] platform: pxa_camera: add VIDEO_V4L2 dependency

b2_core_streamon+0x1b4): undefined reference to > `v4l_vb2q_enable_media_source' > drivers/media/v4l2-core/videobuf2-v4l2.o: In function `vb2_ioctl_reqbufs': > videobuf2-v4l2.c:(.text.vb2_ioctl_reqbufs+0xc): undefined reference to > `video_devdata' > > Th

Re: [PATCH 2/2] [media] pxa_camera: remove an unused structure pointer

able] > struct pxa_buffer *active; > ^~ > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org

Re: [PATCH 1/2] [media] pxa_camera: make soc_mbus_xlate_by_fourcc() static

*soc_mbus_xlate_by_fourcc( >^~~~ > > Signed-off-by: Mauro Carvalho Chehab Acked-by: Robert Jarzmik Cheers. -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH] pxa_camera: allow building it if COMPILE_TEST is set

Hans Verkuil writes: > Allow building this driver if COMPILE_TEST is set. > > Signed-off-by: Hans Verkuil Acked-by: Robert Jarzmik -- Robert -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org Mor

[PATCH v6 13/14] media: platform: pxa_camera: move pxa_camera out of soc_camera

As the conversion to a v4l2 standalone device is finished, move pxa_camera one directory up and finish severing any dependency to soc_camera. Signed-off-by: Robert Jarzmik --- drivers/media/platform/Kconfig | 8 drivers/media/platform/Makefile

[PATCH v6 06/14] media: platform: pxa_camera: introduce sensor_call

Introduce sensor_call(), which will be used for all sensor invocations. This is a preparation move to v4l2 device conversion, ie. soc_camera adherence removal. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 27 ++ 1 file changed, 15

[PATCH v6 12/14] media: platform: pxa_camera: change stop_streaming semantics

a "cancel capture" than a "wait for end of capture" semantic. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/soc_camera/pxa_camer

[PATCH v6 11/14] media: platform: pxa_camera: add debug register access

Add pxa_camera registers access through advanced video debugging. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 32 ++ 1 file changed, 32 insertions(+) diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media

[PATCH v6 07/14] media: platform: pxa_camera: make printk consistent

Make all print consistent by always using : - dev_xxx(pcdev_to_dev(pcdev), ) This prepares the soc_camera adherence removal by making these call rely on only pcdev, and not the soc_camera icd structure. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 70

[PATCH v6 14/14] media: platform: pxa_camera: fix style

This is a tiny fix for a switch case which quiets 2 checkpatch harmless warnings. The generated code is not affected. Signed-off-by: Robert Jarzmik --- drivers/media/platform/pxa_camera.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/platform/pxa_camera.c b/drivers/media

[PATCH v6 02/14] media: mt9m111: use only the SRGB colorspace

mt9m111 being a camera sensor, its colorspace should always be SRGB, for both RGB based formats or YCbCr based ones. Signed-off-by: Robert Jarzmik --- drivers/media/i2c/soc_camera/mt9m111.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/soc_camera

[PATCH v6 05/14] media: platform: pxa_camera: trivial move of functions

doesn't modify a single line of code. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 473 + 1 file changed, 241 insertions(+), 232 deletions(-) diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media/platform/soc_c

[PATCH v6 01/14] media: mt9m111: make a standalone v4l2 subdevice

also drops support for inverters on synchronisation and clock lines. It is assumed, if any board ever needs such inverters, support for them can be added in the future Acked-by: Guennadi Liakhovetski Signed-off-by: Robert Jarzmik --- drivers/media/i2c/soc_camera/mt9m111.c | 51

[PATCH v6 03/14] media: mt9m111: move mt9m111 out of soc_camera

As the mt9m111 is now working as a standalone v4l2 subdevice sensor, move it out of soc_camera directory and severe its dependency on soc_camera. Signed-off-by: Robert Jarzmik --- drivers/media/i2c/Kconfig| 7 +++ drivers/media/i2c/Makefile | 1

[PATCH v6 10/14] media: platform: pxa_camera: make a standalone v4l2 device

sing. In a subsequence patch pxa_camera_mclk_ops should be used, and platform data MCLK ignored. It will be the sensor's duty to request the clock and enable it, which will end in pxa_camera_mclk_ops. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/Kconfig | 2

[PATCH v6 08/14] media: platform: pxa_camera: add buffer sequencing

Add sequence numbers to completed buffers. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media/platform/soc_camera/pxa_camera.c index

[PATCH v6 04/14] media: platform: pxa_camera: convert to vb2

ned-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/Kconfig | 4 +- drivers/media/platform/soc_camera/pxa_camera.c | 579 - 2 files changed, 269 insertions(+), 314 deletions(-) diff --git a/drivers/media/platform/soc_camera/Kconfig b/drivers/medi

[PATCH v6 09/14] media: platform: pxa_camera: remove set_selection

This is to be seen as a regression as the set_selection (former set_crop) function is removed. This is a temporary situation in the v4l2 porting, and will have to be added later. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 83 -- 1

Re: [PATCH v5 00/13] pxa_camera transition to v4l2 standalone device

Hans Verkuil writes: > On 08/29/2016 07:55 PM, Robert Jarzmik wrote: >> There is no change between v4 and v5, ie. the global diff is empty, only one >> line was shifted to prevent breaking bisectablility. > > Against which tree do you develop? Unfortunately this patch se

Re: [PATCH v5 01/13] media: mt9m111: make a standalone v4l2 subdevice

Guennadi Liakhovetski writes: > Hi Robert, > > On Mon, 29 Aug 2016, Robert Jarzmik wrote: > >> Remove the soc_camera adherence. Mostly the change removes the power >> manipulation provided by soc_camera, and instead : >> - powers on the sensor when the s_power con

[PATCH v5 09/13] media: platform: pxa_camera: remove set_crop

This is to be seen as a regression as the set_crop function is removed. This is a temporary situation in the v4l2 porting, and will have to be added later. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 76 -- 1 file changed, 76

[PATCH v5 10/13] media: platform: pxa_camera: make a standalone v4l2 device

sing. In a subsequence patch pxa_camera_mclk_ops should be used, and platform data MCLK ignored. It will be the sensor's duty to request the clock and enable it, which will end in pxa_camera_mclk_ops. Signed-off-by: Robert Jarzmik --- Since v1: - function namings were cleaned into pxac_XXX_Y

[PATCH v5 08/13] media: platform: pxa_camera: add buffer sequencing

Add sequence numbers to completed buffers. Signed-off-by: Robert Jarzmik --- Since v3: reset buffer sequence number in start_streaming() --- drivers/media/platform/soc_camera/pxa_camera.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b

[PATCH v5 12/13] media: platform: pxa_camera: change stop_streaming semantics

a "cancel capture" than a "wait for end of capture" semantic. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/soc_camera/pxa_camer

[PATCH v5 05/13] media: platform: pxa_camera: trivial move of functions

doesn't modify a single line of code. Signed-off-by: Robert Jarzmik --- Since v3: replace void *alloc_ctxt by struct device *alloc_devs impact Since v4: videobuf2 device init change impact --- drivers/media/platform/soc_camera/pxa_camera.c | 473 + 1 file changed

[PATCH v5 03/13] media: mt9m111: move mt9m111 out of soc_camera

As the mt9m111 is now working as a standalone v4l2 subdevice sensor, move it out of soc_camera directory and severe its dependency on soc_camera. Signed-off-by: Robert Jarzmik --- drivers/media/i2c/Kconfig |7 + drivers/media/i2c/Makefile |1 + drivers/media/i2c

[PATCH v5 02/13] media: mt9m111: use only the SRGB colorspace

mt9m111 being a camera sensor, its colorspace should always be SRGB, for both RGB based formats or YCbCr based ones. Signed-off-by: Robert Jarzmik --- drivers/media/i2c/soc_camera/mt9m111.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/soc_camera

[PATCH v5 13/13] media: platform: pxa_camera: move pxa_camera out of soc_camera

As the conversion to a v4l2 standalone device is finished, move pxa_camera one directory up and finish severing any dependency to soc_camera. Signed-off-by: Robert Jarzmik --- drivers/media/platform/Kconfig |8 + drivers/media/platform/Makefile|1

[PATCH v5 06/13] media: platform: pxa_camera: introduce sensor_call

Introduce sensor_call(), which will be used for all sensor invocations. This is a preparation move to v4l2 device conversion, ie. soc_camera adherence removal. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 27 ++ 1 file changed, 15

[PATCH v5 07/13] media: platform: pxa_camera: make printk consistent

Make all print consistent by always using : - dev_xxx(pcdev_to_dev(pcdev), ) This prepares the soc_camera adherence removal by making these call rely on only pcdev, and not the soc_camera icd structure. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 70

[PATCH v5 04/13] media: platform: pxa_camera: convert to vb2

ned-off-by: Robert Jarzmik --- Since v1: took into account Hans's comments renamed all vb2 functions to pxac_vb2_*() Since v2: spit queue_buffer() and start_streaming() Since v3: replace void *alloc_ctxs by struct device *alloc_devs Since v4: move the queue device initialization to

[PATCH v5 11/13] media: platform: pxa_camera: add debug register access

Add pxa_camera registers access through advanced video debugging. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 32 ++ 1 file changed, 32 insertions(+) diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b/drivers/media

[PATCH v5 00/13] pxa_camera transition to v4l2 standalone device

There is no change between v4 and v5, ie. the global diff is empty, only one line was shifted to prevent breaking bisectablility. All the text in https://lkml.org/lkml/2016/8/15/609 is still applicable. Cheers. -- Robert Robert Jarzmik (13): media: mt9m111: make a standalone v4l2 subdevice

[PATCH v5 01/13] media: mt9m111: make a standalone v4l2 subdevice

-by: Robert Jarzmik --- drivers/media/i2c/soc_camera/mt9m111.c | 51 ++ 1 file changed, 15 insertions(+), 36 deletions(-) diff --git a/drivers/media/i2c/soc_camera/mt9m111.c b/drivers/media/i2c/soc_camera/mt9m111.c index 6dfaead6aaa8..a7efaa5964d1 100644 --- a

Re: [PATCH v4 04/13] media: platform: pxa_camera: convert to vb2

Robert Jarzmik writes: > Convert pxa_camera from videobuf to videobuf2. > > As the soc_camera was already compatible with videobuf2, the port is > quite straightforward. > > The special case of this code in which the vb2 to prepare is "too > big" in terms of size

[PATCH v4 10/13] media: platform: pxa_camera: make a standalone v4l2 device

sing. In a subsequence patch pxa_camera_mclk_ops should be used, and platform data MCLK ignored. It will be the sensor's duty to request the clock and enable it, which will end in pxa_camera_mclk_ops. Signed-off-by: Robert Jarzmik --- Since v1: - function namings were cleaned into pxac_XXX_Y

[PATCH v4 08/13] media: platform: pxa_camera: add buffer sequencing

Add sequence numbers to completed buffers. Signed-off-by: Robert Jarzmik --- Since v3: reset buffer sequence number in start_streaming() --- drivers/media/platform/soc_camera/pxa_camera.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/media/platform/soc_camera/pxa_camera.c b

[PATCH v4 03/13] media: mt9m111: move mt9m111 out of soc_camera

As the mt9m111 is now working as a standalone v4l2 subdevice sensor, move it out of soc_camera directory and severe its dependency on soc_camera. Signed-off-by: Robert Jarzmik --- drivers/media/i2c/Kconfig |7 + drivers/media/i2c/Makefile |1 + drivers/media/i2c

[PATCH v4 01/13] media: mt9m111: make a standalone v4l2 subdevice

-by: Robert Jarzmik --- drivers/media/i2c/soc_camera/mt9m111.c | 51 ++ 1 file changed, 15 insertions(+), 36 deletions(-) diff --git a/drivers/media/i2c/soc_camera/mt9m111.c b/drivers/media/i2c/soc_camera/mt9m111.c index 6dfaead6aaa8..a7efaa5964d1 100644 --- a

[PATCH v4 00/13] pxa_camera transition to v4l2 standalone device

rzmik/linux.git work/v4l2 The result of v4l-compliance -s is in [1]. The result of v4l-compliance -f is in [2]. Happy review. -- Robert Robert Jarzmik (13): media: mt9m111: make a standalone v4l2 subdevice media: mt9m111: use only the SRGB colorspace media: mt9m111: move mt9m111 out of soc_c

[PATCH v4 04/13] media: platform: pxa_camera: convert to vb2

ned-off-by: Robert Jarzmik --- Since v1: took into account Hans's comments renamed all vb2 functions to pxac_vb2_*() Since v2: spit queue_buffer() and start_streaming() Since v3: replace void *alloc_ctxs by struct device *alloc_devs --- drivers/media/platform/soc_camera/Kco

[PATCH v4 02/13] media: mt9m111: use only the SRGB colorspace

mt9m111 being a camera sensor, its colorspace should always be SRGB, for both RGB based formats or YCbCr based ones. Signed-off-by: Robert Jarzmik --- drivers/media/i2c/soc_camera/mt9m111.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/i2c/soc_camera

[PATCH v4 06/13] media: platform: pxa_camera: introduce sensor_call

Introduce sensor_call(), which will be used for all sensor invocations. This is a preparation move to v4l2 device conversion, ie. soc_camera adherence removal. Signed-off-by: Robert Jarzmik --- drivers/media/platform/soc_camera/pxa_camera.c | 27 ++ 1 file changed, 15

[PATCH v4 05/13] media: platform: pxa_camera: trivial move of functions

doesn't modify a single line of code. Signed-off-by: Robert Jarzmik --- Since v3: replace void *alloc_ctxt by struct device *alloc_devs impact --- drivers/media/platform/soc_camera/pxa_camera.c | 475 + 1 file changed, 242 insertions(+), 233 deletions(-) diff --git a/dr

[PATCH v4 13/13] media: platform: pxa_camera: move pxa_camera out of soc_camera

As the conversion to a v4l2 standalone device is finished, move pxa_camera one directory up and finish severing any dependency to soc_camera. Signed-off-by: Robert Jarzmik --- drivers/media/platform/Kconfig |8 + drivers/media/platform/Makefile|1

  1   2   3   4   >