Re: [PATCH] media/pci: set device_caps in struct video_device

2019-06-11 Thread Federico Vaga
| 5 +- > drivers/media/pci/solo6x10/solo6x10-v4l2.c| 5 +- > drivers/media/pci/sta2x11/sta2x11_vip.c | 6 +-- Limited to sta2x11_vip.c Acked-by: Federico Vaga > drivers/media/pci/tw68/tw68-video.c | 8 +-- > drivers/media/pci/tw686x/tw686x-video.c | 5 +- > 25 files changed, 154 insertions(+), 190 deletions(-)

Re: [PATCHv5 05/13] media/pci: convert drivers to use the new vb2_queue dev field

2016-07-04 Thread Federico Vaga
Acked-by: Federico Vaga On Monday 27 June 2016 15:31:56 Hans Verkuil wrote: > From: Hans Verkuil > > Stop using alloc_ctx and just fill in the device pointer. > > Signed-off-by: Hans Verkuil > Cc: Federico Vaga > Cc: Mauro Carvalho Chehab > --- > drivers/media

Re: [PATCH 1/6] adv7180: fix broken standards handling

2016-04-22 Thread Federico Vaga
Acked-by: Federico Vaga On Friday, April 22, 2016 03:03:37 PM Hans Verkuil wrote: > From: Hans Verkuil > > The adv7180 attempts to autodetect the standard. Unfortunately this > is seriously broken. > > This patch removes the autodetect completely. Only the querystd op

Re: [PATCH 2/6] sta2x11_vip: fix s_std

2016-04-22 Thread Federico Vaga
Acked-by: Federico Vaga It sounds fine to me (even the ADV7180 patch). Unfortunately I do not have the hardware to test it. On Friday, April 22, 2016 03:03:38 PM Hans Verkuil wrote: > From: Hans Verkuil > > The s_std ioctl was broken in this driver, partially due to the > ch

Re: [PATCH] sta2x11: use monotonic timestamp

2015-05-07 Thread Federico Vaga
On Thursday 07 May 2015 08:27:20 Hans Verkuil wrote: > Added Federico to the CC-list. Fine for me Acked-by: Federico Vaga > On 05/07/2015 08:22 AM, Hans Verkuil wrote: > > V4L2 drivers should use MONOTONIC timestamps instead of gettimeofday, > > which is affected by day

Re: [PATCH v2 00/15] [media] adv7180: Add support for more chip variants

2015-01-25 Thread Federico Vaga
patches but everything seems fine to me. My 2 cents acked-by to the whole set of patches: Acked-by: Federico Vaga -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] [media] sta2x11_vip: fix error return code in sta2x11_vip_init_one()

2013-05-13 Thread Federico Vaga
So the patch save the return value of v4l2_device_register() to 'ret' > and return it when error. > > Signed-off-by: Wei Yongjun Acked-by: Federico Vaga > --- > v1 -> v2: change the commit message > --- > drivers/media/pci/sta2x11/sta2x11_vip.c | 3 ++- > 1

Re: [PATCH] [media] sta2x11_vip: fix error return code in sta2x11_vip_init_one()

2013-05-13 Thread Federico Vaga
On Monday 13 May 2013 20:40:33 Wei Yongjun wrote: > On 05/13/2013 08:19 PM, Federico Vaga wrote: > > Hello, > > > > I agree with the content of the patch, but I disagree with the commit > > message.> > > >From the commit message it seems that yo

Re: [PATCH] [media] sta2x11_vip: fix error return code in sta2x11_vip_init_one()

2013-05-13 Thread Federico Vaga
v4l2_device_register(&pdev->dev, &vip->v4l2_dev); > + if (ret) > goto free_mem; > > dev_dbg(&pdev->dev, "BAR #0 at 0x%lx 0x%lx irq %d\n", -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [REVIEW PATCH 1/2] videobuf2: add gfp_flags.

2013-03-08 Thread Federico Vaga
ism, but that is still work in progress and we need this feature > now so we won't be able to convert drivers with such requirements to vb2. > > Signed-off-by: Hans Verkuil Acked-by: Federico Vaga > --- > drivers/media/v4l2-core/videobuf2-core.c |2 +- > dri

Re: [RFC PATCH] Adding additional flags when allocating buffer memory

2013-03-05 Thread Federico Vaga
ntig allocator, I did like Marek suggestion. But now I think that Hans solution is better because it is more flexible and future-proof. As Hans said, it is not a rare case and this patch apply to every allocator. /My 2 cent -- Federico Vaga -- To unsubscribe from this list: send the line "uns

Re: [PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-06 Thread Federico Vaga
ges (you did that, right? Just checking...), that > these are really useful improvements, and that I reviewed the code > (as well as I could) and didn't see any problems, I'm giving my ack > anyway: Tested every time I sent a patch > Acked-by: Hans Verkuil Thank you a

[PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-02-05 Thread Federico Vaga
ones from videobuf2 and v4l2_fh Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci/sta2x11/Kconfig |2 +- drivers/media/pci/sta2x11/sta2x11_vip.c | 1073 +-- 2 file modificati, 434 inserzioni(+), 641 rimozioni(-) diff --git a

[PATCH v6 2/2] adv7180: remove {query/g_/s_}ctrl

2013-01-23 Thread Federico Vaga
All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit controls from this subdevice. Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3

[PATCH v6 1/2] sta2x11_vip: convert to videobuf2, control framework, file handler

2013-01-23 Thread Federico Vaga
ones from videobuf2 and v4l2_fh Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci/sta2x11/Kconfig |2 +- drivers/media/pci/sta2x11/sta2x11_vip.c | 1071 +-- 2 file modificati, 432 inserzioni(+), 641 rimozioni(-) diff --git a

Re: [PATCH v4 1/3] videobuf2-dma-contig: user can specify GFP flags

2013-01-08 Thread Federico Vaga
me vb2_dc_conf to vb2_alloc_ctx because it is an implementation vb2_alloc_ctx and (at the moment) it is used only by dma-contig -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v4 1/3] videobuf2-dma-contig: user can specify GFP flags

2013-01-08 Thread Federico Vaga
ake something in the future. On x86 platform GFP_DMA allocates under 16MB and this limit can be too strict. When many other drivers use GFP_DMA we can saturate this tiny zone. As you said, this fix the issue with _older_ and _non-standard_ (like sta2x11) systems. But this fix has effect on every

[PATCH V4 3/3] adv7180: remove {query/g_/s_}ctrl

2013-01-06 Thread Federico Vaga
All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit controls from this subdevice. Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3

[PATCH V4 2/3] sta2x11_vip: convert to videobuf2 and control framework

2013-01-06 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci

[PATCH v4 1/3] videobuf2-dma-contig: user can specify GFP flags

2013-01-06 Thread Federico Vaga
This is useful when you need to specify specific GFP flags during memory allocation (e.g. GFP_DMA). Signed-off-by: Federico Vaga --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 7 ++- include/media/videobuf2-dma-contig.h | 5 + 2 file modificati, 7 inserzioni(+), 5

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-06 Thread Federico Vaga
V4 patches soon. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-04 Thread Federico Vaga
On Thursday 03 January 2013 17:13:14 Federico Vaga wrote: > > After all those discussions, I'm ok on adding this new driver, but please > > add a summary of those discussions at the patch description. As I said, > > the reason why this driver is needed is not obvious. So,

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2013-01-03 Thread Federico Vaga
/for_v3.9 > branch of the media-tree? I will do it -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-12-20 Thread Federico Vaga
board, but they cannot help me. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-12-11 Thread Federico Vaga
rface, it is not a performance problem. > On a separate but related issue, while doing DMABUF tests with an Exynos4 > hardware, using a s5p sensor, sending data to s5p-tv, I noticed a CPU > consumption of about 42%, which seems too high. Could it be related to > not using the DMA streaming

[PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-06 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Federico Vaga
we need to handle it with due care. Getting other authors's > acks on such patch seems to be the only safe way of doing that. Yes I got the point. Thank you -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a messa

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Federico Vaga
> > Ok, I understand. I will write something like this. > > > > * Copyright (C) 2012 ST Microelectronics > > * author: Federico Vaga > > * Copyright (C) 2010 WindRiver Systems, Inc. > > * authors: Andreas Kies > > *

Re: [PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-12-05 Thread Federico Vaga
On Tuesday 04 December 2012 14:04:22 Mauro Carvalho Chehab wrote: > Em 24-09-2012 09:44, Marek Szyprowski escreveu: > > Hello, > > > > On Monday, September 24, 2012 12:59 PM Federico Vaga wrote: > >> The DMA streaming allocator is similar to the DMA contig but

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-05 Thread Federico Vaga
... Ok, I understand. I will write something like this. * Copyright (C) 2012 ST Microelectronics * author: Federico Vaga * Copyright (C) 2010 WindRiver Systems, Inc. * authors: Andreas Kies * Vlad Lungu > The only way of not preserving the origi

Re: [PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-12-04 Thread Federico Vaga
On Tuesday 04 December 2012 14:15:15 Mauro Carvalho Chehab wrote: > Em 24-09-2012 07:58, Federico Vaga escreveu: > > This patch re-write the driver and use the videobuf2 > > interface instead of the old videobuf. Moreover, it uses also > > the control framework which allows

[PATCH v3 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-25 Thread Federico Vaga
From: Marek Szyprowski This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski Acked-by: Laurent Pinchart Acked-by: Federico Vaga --- drivers/media/v4l2-core/videobuf2-core.c | 11

[PATCH v3 4/4] adv7180: remove {query/g_/s_}ctrl

2012-09-24 Thread Federico Vaga
All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit controls from this subdevice. Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3

[PATCH v3 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-24 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci

[PATCH v3 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-24 Thread Federico Vaga
: Federico Vaga --- drivers/media/v4l2-core/Kconfig | 5 + drivers/media/v4l2-core/Makefile | 1 + drivers/media/v4l2-core/videobuf2-dma-streaming.c | 205 ++ include/media/videobuf2-dma-streaming.h | 32 4 file modificati, 243

[PATCH v3 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-24 Thread Federico Vaga
This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski Acked-by: Laurent Pinchart Acked-by: Federico Vaga --- drivers/media/v4l2-core/videobuf2-core.c | 11 +++ include/media/videobuf2-core.h

Re: [PATCH v2 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-23 Thread Federico Vaga
/* Buffer handlers */ > > + .vidioc_reqbufs = vb2_ioctl_reqbufs, > > + .vidioc_querybuf = vb2_ioctl_querybuf, > > + .vidioc_qbuf = vb2_ioctl_qbuf, > > + .vidioc_dqbuf = vb2_ioctl_dqbuf, > > + .vidioc_create_bufs = vb2_ioctl_create_bufs, > > If you want to use create_bufs, then in queue_setup() you need to > handle the fmt argument. See e.g. vivi.c for an example. Fixed I will send a patch v3 tomorrow -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-21 Thread Federico Vaga
rated in the kernel before this one; so this patch will be useless. Anyway, I will apply this comment fix. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2 4/4] adv7180: remove {query/g_/s_}ctrl

2012-09-21 Thread Federico Vaga
All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit the controls from this subdevice. Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3

[PATCH v2 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-21 Thread Federico Vaga
This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci

[PATCH v2 2/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-21 Thread Federico Vaga
: Federico Vaga --- drivers/media/v4l2-core/Kconfig | 5 + drivers/media/v4l2-core/Makefile | 1 + drivers/media/v4l2-core/videobuf2-dma-streaming.c | 205 ++ include/media/videobuf2-dma-streaming.h | 32 4 file modificati, 243

[PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-21 Thread Federico Vaga
This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski Acked-by: Laurent Pinchart Acked-by: Federico Vaga --- drivers/media/v4l2-core/videobuf2-core.c | 11 +++ include/media/videobuf2-core.h

[PATCH v2 3/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-21 Thread federico . vaga
From: Federico Vaga This patch re-write the driver and use the videobuf2 interface instead of the old videobuf. Moreover, it uses also the control framework which allows the driver to inherit controls from its subdevice (ADV7180) Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
In data giovedì 13 settembre 2012 11:45:31, Jonathan Corbet ha scritto: > On Thu, 13 Sep 2012 17:46:32 +0200 > > Federico Vaga wrote: > > > A few words explaining why this memory handling module is required > > > or > > > beneficial will definitely improve the

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
, you know what I'm doing in each vb2_mem_ops. I suppose that this is the reason why there are no comments inside the other memory allocator. Maybe I am wrong. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
> On Thursday, September 13, 2012 3:53 PM Federico Vaga wrote: > > Signed-off-by: Federico Vaga > > A few words explaining why this memory handling module is required or > beneficial will definitely improve the commit :) ok, I will write some lines > > +static void *

Re: [PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
te one or two lines of comment to summarize each function. what do you think? -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 4/4] sta2x11_vip: convert to videobuf2 and control framework

2012-09-13 Thread Federico Vaga
Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/pci/sta2x11/Kconfig |2 +- drivers/media/pci/sta2x11/sta2x11_vip.c | 1235 ++- 2 file modificati, 411 inserzioni(+), 826 rimozioni(-) diff --git a/drivers/media/pci/sta2x11/Kconfig

[PATCH 3/4] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-09-13 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/v4l2-core/Kconfig | 5 + drivers/media/v4l2-core/Makefile | 1 + drivers/media/v4l2-core/videobuf2-dma-streaming.c | 205 ++ include/media/videobuf2-dma-streaming.h | 24 +++ 4

[PATCH 2/4] adv7180: remove {query/g_/s_}ctrl

2012-09-13 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3 rimozioni(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index 45ecf8d..43bc2b9 100644 --- a/drivers/media/i2c/adv7180.c +++ b/drivers/media/i2c/adv7180.c @@ -402,9 +402,6

[PATCH 1/4] v4l: vb2: add prepare/finish callbacks to allocators

2012-09-13 Thread Federico Vaga
This patch adds support for prepare/finish callbacks in VB2 allocators. These callback are used for buffer flushing. Signed-off-by: Marek Szyprowski Acked-by: Laurent Pinchart Acked-by: Federico Vaga --- drivers/media/v4l2-core/videobuf2-core.c | 11 +++ include/media/videobuf2-core.h

Re: [PATCH 2/3] [media] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-08-24 Thread Federico Vaga
k you. I'll do the job -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 2/3] [media] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-08-24 Thread Federico Vaga
esting because avoid me to use cache sync in my driver. Can I work on these patches? >From this page I understand that these patches are not approved yet https://patchwork.kernel.org/project/linux-media/list/?page=2 -- Federico Vaga -- To unsubscribe from this list: send the line "uns

Re: Update VIP to videobuf2 and control framework

2012-08-16 Thread Federico Vaga
; jon I think that the memory allocator is the most questionable patch, but if there are not any other comments I will send my three patches for the inclusion. It is summer, time for vacation, so I'll wait for another week or two for critical comments and then I will send patches. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3 v2] [media] sta2x11_vip: convert to videobuf2 and control framework

2012-08-06 Thread Federico Vaga
ags); > > No need to set V4L2_FL_USES_V4L2_FH, BTW. That will be set > automatically as soon as v4l2_fh_open is called. I saw "unsigned long flags;" in the header but without reading the comment :) Thank you. I will test it in these days but I think it's all done. -- Fede

Re: Update VIP to videobuf2 and control framework

2012-08-06 Thread Federico Vaga
> In that case I need to see your latest version of the source code to > see why it doesn't work. I send it as patch v2 of the previous one -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...

[PATCH 3/3 v2] [media] sta2x11_vip: convert to videobuf2 and control framework

2012-08-06 Thread Federico Vaga
Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/video/sta2x11_vip.c | 1239 + 1 file modificato, 414 inserzioni(+), 825 rimozioni(-) diff --git a/drivers/media/video/sta2x11_vip.c b/drivers/media/video/sta2x11_vip.c index 4c10205

Re: Update VIP to videobuf2 and control framework

2012-08-06 Thread Federico Vaga
hat > > you use struct v4l2_fh. > > ^^ > > Are you using struct v4l2_fh? The version you posted didn't. You need > this anyway to implement control events. Yes I'm using it now, it is part of the extra simplification that I did. -- Federico Vaga -- To unsubscribe from this

Re: Update VIP to videobuf2 and control framework

2012-08-05 Thread Federico Vaga
ers use the core priority handling. But for now it has to be set explicitly. -- -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: Update VIP to videobuf2 and control framework

2012-07-31 Thread Federico Vaga
I use git send-email command to send patches but I think I made a mistake. If something is wrong or confused please tell me and I try to resend all the patches hopefully without mistake. Sorry again. 2012/7/31 Federico Vaga : > As suggested I moved the Video Buffer Input (VIP) of the STA2

Re: [PATCH 1/3] [media] adv7180: remove {query/g_/s_}ctrl

2012-07-31 Thread Federico Vaga
I'm sorry for the email duplication, I press the wrong key on git-send email. Ignore these emails. Sorry -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

[PATCH 3/3] [media] sta2x11_vip: convert to videobuf2 and control framework

2012-07-31 Thread Federico Vaga
Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi --- drivers/media/video/sta2x11_vip.c | 1134 ++--- 1 file modificato, 410 inserzioni(+), 724 rimozioni(-) diff --git a/drivers/media/video/sta2x11_vip.c b/drivers/media/video/sta2x11_vip.c index 4c10205

[PATCH 2/3] [media] videobuf2-dma-streaming: new videobuf2 memory allocator

2012-07-31 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/video/Kconfig | 6 +- drivers/media/video/Makefile | 1 + drivers/media/video/videobuf2-dma-streaming.c | 187 ++ include/media/videobuf2-dma-streaming.h | 24 4 file

[PATCH 1/3] [media] adv7180: remove {query/g_/s_}ctrl

2012-07-31 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/video/adv7180.c | 3 --- 1 file modificato, 3 rimozioni(-) diff --git a/drivers/media/video/adv7180.c b/drivers/media/video/adv7180.c index 07bb550..bcc7d60 100644 --- a/drivers/media/video/adv7180.c +++ b/drivers/media/video/adv7180.c @@ -402,9

Update VIP to videobuf2 and control framework

2012-07-31 Thread Federico Vaga
As suggested I moved the Video Buffer Input (VIP) of the STA2X11 board to the videobuf2. This patch series is an RFC. The first patch is just an update to the adv7180 because the VIP (the only user) now use the control framework so query{g_|s_|ctrl} are not necessery. The second patch adds a new

Update STA2X11 to videobuf2 and control framework

2012-07-31 Thread Federico Vaga
out any control. I add it to inherit controls from adv7180. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 1/3 RFC] [media] adv7180: remove {query/g_/s_}ctrl

2012-07-31 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/video/adv7180.c | 3 --- 1 file modificato, 3 rimozioni(-) diff --git a/drivers/media/video/adv7180.c b/drivers/media/video/adv7180.c index 07bb550..bcc7d60 100644 --- a/drivers/media/video/adv7180.c +++ b/drivers/media/video/adv7180.c @@ -402,9

[PATCH] [media] adv7180.c: convert to v4l2 control framework

2012-07-11 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/video/adv7180.c | 235 +++-- 1 file changed, 84 insertions(+), 151 deletions(-) diff --git a/drivers/media/video/adv7180.c b/drivers/media/video/adv7180.c index 174bffa..07bb550 100644 --- a/drivers/media/video

Re: [PATCH RFC] [media] adv7180.c: convert to v4l2 control framework

2012-07-11 Thread Federico Vaga
trols), so I think these lines must be there. Am I wrong? > > Correct. But once sta2x11 is converted to using the control framework, > then these lines can be dropped since no one else is using this > subdevice driver. What do you suggest? I re-submit this patch and when sta2x11 is f

Re: [PATCH RFC] [media] adv7180.c: convert to v4l2 control framework

2012-07-11 Thread Federico Vaga
-controls.txt document. Right? > > - ret = i2c_smbus_write_byte_data(client, ADV7180_HUE_REG, > > state->hue); + ret = i2c_smbus_write_byte_data(client, > > ADV7180_HUE_REG, > > + ADV7180_HUE_DEF); > > It shouldn't be necessary to initialize the controls

[PATCH RFC] [media] adv7180.c: convert to v4l2 control framework

2012-07-10 Thread Federico Vaga
Signed-off-by: Federico Vaga --- drivers/media/video/adv7180.c | 221 + 1 file changed, 90 insertions(+), 131 deletions(-) diff --git a/drivers/media/video/adv7180.c b/drivers/media/video/adv7180.c index 174bffa..7705456 100644 --- a/drivers/media/video

Re: [PATCH 1/3] adv7180: add support to user controls

2012-07-08 Thread Federico Vaga
> If you could do that work, then that would be much appreciated. You have the > hardware, after all, so that makes it easier for you. Hi Hans, I'll submit a patch for the control framework on the ADV7180 -- Federico Vaga -- To unsubscribe from this list: send the line "u

Re: [GIT PULL FOR v3.5] Move sta2x11_vip to staging

2012-07-08 Thread Federico Vaga
> Any news on this? Hi Hans, I'm on it :) -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [GIT PULL FOR v3.5] Move sta2x11_vip to staging

2012-06-27 Thread Federico Vaga
> Hi Federico, > > Any news on this? Not at the moment. I'll ask for detail :) -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] videobuf-dma-contig: restore buffer mapping for uncached bufers

2012-06-22 Thread Federico Vaga
In data venerdì 22 giugno 2012 18:45:31, Hans Verkuil ha scritto: > On Fri June 22 2012 17:28:04 Federico Vaga wrote: > > > from commit a8f3c203e19b702fa5e8e83a9b6fb3c5a6d1cce4 > > > restore the mapping scheme for uncached buffers, > > > which was changed in a common

Re: [PATCH] [media] videobuf-dma-contig: restore buffer mapping for uncached bufers

2012-06-22 Thread Federico Vaga
d while mapping uncached > buffers. > > Signed-off-by: Lad, Prabhakar > Signed-off-by: Hadli, Manjunath Acked-by: Federico Vaga I tested the patch on the STA2X11 board. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media&quo

Re: Recent patch for videobuf causing a crash to my driver

2012-06-22 Thread Federico Vaga
bug that I found but I have only the STA2X11 board for testing. I'll test your patch for uncached buffer on my cached buffer to test if it still work. -- Federico Vaga -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@

[PATCH 3/3] STA2X11 VIP: new V4L2 driver

2012-04-12 Thread Federico Vaga
V4L2 driver for the Video Input Port within STA2X11 board Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi Cc: Alan Cox --- drivers/media/video/Kconfig | 13 + drivers/media/video/Makefile |1 + drivers/media/video/sta2x11_vip.c | 1550

[PATCH 2/3] videobuf-dma-contig: add cache support

2012-04-12 Thread Federico Vaga
Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi Cc: Alan Cox --- drivers/media/video/videobuf-dma-contig.c | 199 +--- include/media/videobuf-dma-contig.h | 10 ++ 2 files changed, 159 insertions(+), 50 deletions(-) diff --git a/drivers/media/video

[PATCH 1/3] adv7180: add support to user controls

2012-04-12 Thread Federico Vaga
Video user controls such as brightness, contrast, saturation, and hue are now handled. Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi Cc: Alan Cox --- drivers/media/video/adv7180.c | 417 ++--- 1 files changed, 350 insertions(+), 67 deletions

[PATCH 3/3] [PATCH RFC] STA2X11 VIP: new V4L2 driver

2012-03-12 Thread Federico Vaga
V4L2 driver for the Video Input Port within STA2X11 board Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi Cc: Alan Cox --- drivers/media/video/Kconfig | 13 + drivers/media/video/Makefile |1 + drivers/media/video/sta2x11_vip.c | 1550

[PATCH 2/3] [PATCH RFC] videobuf-dma-contig: add cache support

2012-03-12 Thread Federico Vaga
Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi Cc: Alan Cox --- drivers/media/video/videobuf-dma-contig.c | 199 +--- include/media/videobuf-dma-contig.h | 10 ++ 2 files changed, 159 insertions(+), 50 deletions(-) diff --git a/drivers/media/video

[PATCH 1/3] [PATCH RFC] adv7180: add support to user controls

2012-03-12 Thread Federico Vaga
Video user controls such as brightness, contrast, saturation, and hue are now handled. Signed-off-by: Federico Vaga Acked-by: Giancarlo Asnaghi Cc: Alan Cox --- drivers/media/video/adv7180.c | 418 ++--- 1 files changed, 350 insertions(+), 68 deletions