Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: f13d5f361959 ("media: vimc: Collapse component structure into a single
monolithic driver")
Signed-off-by: Wei Yongjun
---
drivers/media/platform/vimc/vimc-
The driver allocates the spinlock but not initialize it.
Use spin_lock_init() on it to initialize it correctly.
This is detected by Coccinelle semantic patch.
Fixes: d2b4387f3bdf ("media: platform: Add Aspeed Video Engine driver")
Signed-off-by: Wei Yongjun
---
drivers/media/platf
Fixes the following sparse warning:
drivers/media/i2c/tvp5150.c:1457:6: warning:
symbol 'tvp5150_volatile_reg' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/media/i2c/tvp5150.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/dri
Fix to return error code -ENODEV from the dma_request_slave_channel()
error handling case instead of 0, as done elsewhere in this function.
rc can be overwrite to 0 by dmaengine_slave_config() in the for loop.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/rcar_drif.c | 3 ++-
1 file
Fixes the following sparse warning:
drivers/media/platform/atmel/atmel-isc.c:338:19: warning:
symbol 'fmt_configs_list' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/media/platform/atmel/atmel-isc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
In case of error, the function platform_device_register_data() returns
ERR_PTR() and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun
---
drivers/media/platform/vimc/vimc-core.c | 5 +++--
1 file changed, 3 insertions(+), 2
From: Wei Yongjun
Remove including that is not needed.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/s5p-cec/s5p_cec.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/s5p-cec/s5p_cec.h
b/drivers/media/platform/s5p-cec/s5p_cec.h
index 7015845..8bcd8dc 100644
From: Wei Yongjun
The driver allocates the spinlock but not initialize it.
Use spin_lock_init() on it to initialize it correctly.
This is detected by Coccinelle semantic patch.
Fixes: 0f314f6c2e77 ("[media] rainshadow-cec: new RainShadow Tech HDMI
CEC driver")
Signed-off-by: W
From: Wei Yongjun
Remove unneeded error handling on the result of a call
to platform_get_resource() when the value is passed to
devm_ioremap_resource().
Signed-off-by: Wei Yongjun
---
drivers/media/platform/mtk-vcodec/mtk_vcodec_enc_drv.c | 5 -
1 file changed, 5 deletions(-)
diff --git
From: Wei Yongjun
Fixes the following sparse warning:
drivers/media/usb/dvb-usb/gp8psk.c:281:28: warning:
symbol 'gp8psk_fe_ops' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/media/usb/dvb-usb/gp8psk.c | 2 +-
1 file changed, 1 insertion(+),
From: Wei Yongjun
Fix typo in parameter description.
Signed-off-by: Wei Yongjun
---
drivers/media/usb/tm6000/tm6000-input.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/tm6000/tm6000-input.c
b/drivers/media/usb/tm6000/tm6000-input.c
index 7fe00a5
From: Wei Yongjun
Fix to return error code -ENODEV from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/atmel/atmel-isc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/atmel/atmel
From: Wei Yongjun
Fix to return error code -ENODEV from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/sti/c8sectpfe/c8sectpfe-core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform
From: Wei Yongjun
'buf' is malloced in dibusb_rc_query() and should be freed before
leaving from the error handling cases, otherwise it will cause
memory leak.
Fixes: ff1c123545d7 ("[media] dibusb: handle error code on RC query")
Signed-off-by: Wei Yongjun
---
drivers/medi
From: Wei Yongjun
'buf' is malloced in dibusb_rc_query() and should be freed before
leaving from the error handling cases, otherwise it will cause
memory leak.
Fixes: ff1c123545d7 ("[media] dibusb: handle error code on RC query")
Signed-off-by: Wei Yongjun
---
drivers/medi
From: Wei Yongjun
Fixes the following sparse warning:
drivers/dma-buf/sw_sync.c:87:22: warning:
symbol 'sync_timeline_create' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/dma-buf/sw_sync.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
di
From: Wei Yongjun
Remove including that don't need it.
Signed-off-by: Wei Yongjun
---
drivers/staging/media/s5p-cec/s5p_cec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/s5p-cec/s5p_cec.c
b/drivers/staging/media/s5p-cec/s5p_cec.c
index 1780a08..aef962b 1
From: Wei Yongjun
Remove including that don't need it.
Signed-off-by: Wei Yongjun
---
drivers/staging/media/st-cec/stih-cec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/st-cec/stih-cec.c
b/drivers/staging/media/st-cec/stih-cec.c
index 2143448..b0aee1d 1
From: Wei Yongjun
Fix to return error code -ENODEV from the error handling case
instead of 0(err maybe overwrited to 0 in the for loop), as
done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/pci/cx88/cx88-dvb.c | 1 +
1 file changed, 1 insertion(+)
diff --git a
From: Wei Yongjun
Fix to return error code -EINVAL from the platform_get_resource() error
handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/sti/bdisp/bdisp-v4l2.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers
From: Wei Yongjun
Remove .owner field if calls are used which set it automatically.
Generated by: scripts/coccinelle/api/platform_no_drv_owner.cocci
Signed-off-by: Wei Yongjun
---
drivers/media/spi/gs1662.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/spi/gs1662.c b
From: Wei Yongjun
It's not necessary to free memory allocated with devm_kzalloc
and using kfree leads to a double free.
Fixes: 7aae6e2df127 ("[media] Add GS1662 driver, a video serializer")
Signed-off-by: Wei Yongjun
---
drivers/media/spi/gs1662.c | 3 +--
1 file changed, 1
From: Wei Yongjun
Fix to return error code -ENOMEM from the memory or workqueue alloc
error handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/vivid/vivid-core.c | 5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff
From: Wei Yongjun
Remove duplicated include.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/pxa_camera.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/platform/pxa_camera.c
b/drivers/media/platform/pxa_camera.c
index 1bce7eb..2d68b80 100644
--- a/drivers/media
From: Wei Yongjun
Fix to return error code -ENODEV from dma_request_slave_channel_compat()
error handling case instead of 0, as done elsewhere in this function.
Also fix to release resources in v4l2_clk_register() error handling.
Signed-off-by: Wei Yongjun
---
drivers/media/platform
Fix to return error code -ENOMEM from the i2c client register error
handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/i2c/adv7511.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/adv7511.c b/drivers/media/i2c
From: Wei Yongjun
Add the missing platform_device_del() before return from
lirc_parallel_init() in the error handling case.
Signed-off-by: Wei Yongjun
---
drivers/staging/media/lirc/lirc_parallel.c | 10 ++
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/staging
From: Wei Yongjun
usb_free_coherent() is safe with NULL addr and this check is
not required.
Signed-off-by: Wei Yongjun
---
drivers/media/usb/em28xx/em28xx-audio.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/media/usb/em28xx/em28xx-audio.c
b/drivers
From: Wei Yongjun
Fixes the following sparse warning:
drivers/media/usb/au0828/au0828-dvb.c:36:5: warning:
symbol 'preallocate_big_buffers' was not declared. Should it be static?
Signed-off-by: Wei Yongjun
---
drivers/media/usb/au0828/au0828-dvb.c | 2 +-
1 file changed, 1 inser
From: Wei Yongjun
Fixes the following sparse warnings:
drivers/media/radio/si4713/radio-usb-si4713.c:226:31: warning:
symbol 'start_seq' was not declared. Should it be static?
drivers/media/radio/si4713/radio-usb-si4713.c:291:29: warning:
symbol 'command_table' was not de
From: Wei Yongjun
Add the missing unlock before return from function bcm2048_rds_fifo_receive()
in the error handling case.
Signed-off-by: Wei Yongjun
---
drivers/staging/media/bcm2048/radio-bcm2048.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/media/bcm2048/radio
From: Wei Yongjun
We had set the pci drvdata in cx88_audio_initdev() as a type of
struct snd_card, so cx88_audio_finidev() should used it as the
same type too.
Signed-off-by: Wei Yongjun
---
drivers/media/pci/cx88/cx88-alsa.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff
From: Wei Yongjun
We had set the i2c clientdata to &flash->subdev_led[LM3560_LED1]
after call lm3560_subdev_init(flash, LM3560_LED1, "lm3560-led1"),
but the container_of() in lm3560_remove() return the wrong pointer
to flash.(should be container_of(subdev, struct lm3560_
From: Wei Yongjun
Add the missing unlock before return from function lm3560_set_ctrl()
in the error handling case.
Signed-off-by: Wei Yongjun
---
drivers/media/i2c/lm3560.c | 14 +-
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/drivers/media/i2c/lm3560.c b/drivers
From: Wei Yongjun
In case of error, the function devm_kzalloc() and devm_ioremap()
returns NULL pointer not ERR_PTR(). The IS_ERR() test in the return
value check should be replaced with NULL test.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/ti-vpe/vpe.c | 8
1 file changed
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/ti-vpe/vpe.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/platform
From: Wei Yongjun
module_platform_driver() makes the code simpler by eliminating
boilerplate code.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/ti-vpe/vpe.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/media/platform/ti-vpe/vpe.c
b
From: Wei Yongjun
In case of error, the function kthread_run() returns ERR_PTR()
and never returns NULL. The NULL test in the return value check
should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun
---
drivers/media/pci/saa7164/saa7164-core.c | 4 +++-
1 file changed, 3 insertions
From: Wei Yongjun
irq allocated with devm_request_irq should not be freed using
free_irq, because doing so causes a dangling pointer, and a
subsequent double free.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/marvell-ccic/mmp-driver.c | 1 -
1 file changed, 1 deletion(-)
diff --git
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/vsp1/vsp1_video.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media
From: Wei Yongjun
Fix to return -ENOMEM in the new i2c client and create workqueue error
handling case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/i2c/adv7511.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/i2c/adv7511.c
From: Wei Yongjun
Fix to return -ENODEV in the subdevice register error handling
case instead of 0, as done elsewhere in this function.
Introduced by commit 873229e4fdf34196aa5d707957c59ba54c25eaba
([media] media: davinci: vpif: capture: add V4L2-async support)
Signed-off-by: Wei Yongjun
From: Wei Yongjun
Fix to return -ENODEV in the subdevice register error handling
case instead of 0, as done elsewhere in this function.
Introduced by commit 873229e4fdf34196aa5d707957c59ba54c25eaba
([media] media: davinci: vpif: capture: add V4L2-async support)
Signed-off-by: Wei Yongjun
From: Wei Yongjun
Fix to return -ENODEV in the subdevice register error handling
case instead of 0, as done elsewhere in this function.
Introduce by commit 4b8a531e6bb0686203e9cf82a54dfe189de7d5c2.
([media] media: davinci: vpif: display: add V4L2-async support)
Signed-off-by: Wei Yongjun
From: Wei Yongjun
Remove including that don't need it.
Signed-off-by: Wei Yongjun
---
drivers/media/usb/usbtv/usbtv.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/usb/usbtv/usbtv.c b/drivers/media/usb/usbtv/usbtv.c
index bf43f87..68fe97f 100644
--- a/drivers/medi
On 06/18/2013 06:03 PM, Philipp Zabel wrote:
> Am Dienstag, den 18.06.2013, 13:00 +0800 schrieb Wei Yongjun:
>> From: Wei Yongjun
>>
>> Add the missing unlock before return from function coda_stop_streaming()
>> in the error handling case.
>>
>> Signed-
From: Wei Yongjun
Add the missing unlock before return from function coda_stop_streaming()
in the error handling case.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/coda.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/coda.c b/drivers/media/platform/coda.c
From: Wei Yongjun
The orig code will release all the resources if v4l2_device_register()
failed and return 0. But what we need in this case is to return an
negative error code to let the caller known we are failed.
So the patch save the return value of v4l2_device_register() to 'ret'
the patch save the return
value of v4l2_device_register() to 'ret' and return it when error.
>
> On Monday 13 May 2013 13:59:45 Wei Yongjun wrote:
>> From: Wei Yongjun
>>
>> Fix to return a negative error code from the error handling
>> case instead
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
v1 -> v2: move config->num_inputs check to the beginning of this function
---
drivers/media/platform/blackfin/bfin_capture
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/i2c/ad9389b.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/i2c/ad9389b.c b/drivers/media/i2c
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/pci/sta2x11/sta2x11_vip.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/pci
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/blackfin/bfin_capture.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform
From: Wei Yongjun
Fix to return -ENODEV in the subdevice register error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/davinci/vpif_capture.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform
From: Wei Yongjun
Fix to return -ENODEV in the subdevice register error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/davinci/vpif_display.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform
From: Wei Yongjun
Fix to return a negative error code in the vb2_dma_contig_init_ctx()
error handling case instead of 0, as done elsewhere in this function.
Also vb2_dma_contig_init_ctx() return ERR_PTR() in case of error and
never return NULL, so use IS_ERR() replace IS_ERR_OR_NULL().
Signed
From: Wei Yongjun
Fix to return -EINVAL in the get kernel address error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/v4l2-core/videobuf2-core.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/staging/media/davinci_vpfe/vpfe_mc_capture.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a
From: Wei Yongjun
Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media
From: Wei Yongjun
Since rc_unregister_device() frees its argument, the subsequently
call to rc_free_device() on the same variable will cause a double
free bug. Fix by set argument to NULL, thus when fall through to
rc_free_device(), nothing will be done there.
Signed-off-by: Wei Yongjun
From: Wei Yongjun
Since rc_unregister_device() frees its argument, the subsequently
call to rc_free_device() on the same variable will cause a double
free bug. Fix by set argument to NULL, thus when fall through to
rc_free_device(), nothing will be done there.
Signed-off-by: Wei Yongjun
From: Wei Yongjun
Since rc_unregister_device() frees its argument, the subsequently
call to rc_free_device() on the same variable will cause a double
free bug. Fix by set argument to NULL, thus when fall through to
rc_free_device(), nothing will be done there.
Signed-off-by: Wei Yongjun
From: Wei Yongjun
Since rc_unregister_device() frees its argument, the subsequently
call to rc_free_device() on the same variable will cause a double
free bug. Fix by set argument to NULL, thus when fall through to
rc_free_device(), nothing will be done there.
Signed-off-by: Wei Yongjun
From: Wei Yongjun
Since rc_unregister_device() frees its argument, the subsequently
call to rc_free_device() on the same variable will cause a double
free bug. Fix by set argument to NULL, thus when fall through to
rc_free_device(), nothing will be done there.
Signed-off-by: Wei Yongjun
From: Wei Yongjun
sizeof() when applied to a pointer typed expression gives the
size of the pointer, not that of the pointed data.
Signed-off-by: Wei Yongjun
---
drivers/staging/media/go7007/go7007-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media
Hi Hans and Dan Carpenter,
On 03/26/2013 04:18 PM, Hans Verkuil wrote:
> On Tue March 26 2013 08:35:57 Dan Carpenter wrote:
>> On Tue, Mar 26, 2013 at 10:04:15AM +0300, Dan Carpenter wrote:
>>> On Tue, Mar 26, 2013 at 02:42:47PM +0800, Wei Yongjun wrote:
>>>> From:
From: Wei Yongjun
sizeof() when applied to a pointer typed expression gives the
size of the pointer, not that of the pointed data.
Signed-off-by: Wei Yongjun
---
drivers/staging/media/go7007/go7007-usb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media
From: Wei Yongjun
Remove including that don't need it.
Signed-off-by: Wei Yongjun
---
drivers/media/i2c/tw9906.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/i2c/tw9906.c b/drivers/media/i2c/tw9906.c
index 2263a91..d94325b 100644
--- a/drivers/media/i2c/tw9906.c
From: Wei Yongjun
Remove including that don't need it.
Signed-off-by: Wei Yongjun
---
drivers/staging/media/go7007/go7007-v4l2.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/staging/media/go7007/go7007-v4l2.c
b/drivers/staging/media/go7007/go7007-v4l2.c
index 24ba50e..50
From: Wei Yongjun
Add the missing unlock before return from function af9035_ctrl_msg()
in the error handling case.
Signed-off-by: Wei Yongjun
---
drivers/media/usb/dvb-usb-v2/af9035.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/drivers/media/usb/dvb
From: Wei Yongjun
dvb_usb_v2_generic_io() was not declared. It should be static.
Signed-off-by: Wei Yongjun
---
drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/dvb-usb-v2/dvb_usb_urb.c
b/drivers/media/usb/dvb
From: Wei Yongjun
usb_free_coherent() is safe with NULL addr and this check is
not required.
Signed-off-by: Wei Yongjun
---
drivers/media/usb/gspca/gspca.c | 9 -
1 file changed, 4 insertions(+), 5 deletions(-)
diff --git a/drivers/media/usb/gspca/gspca.c b/drivers/media/usb/gspca
From: Wei Yongjun
The variable 'output_index' is initialized but never used
otherwise, so remove the unused variable.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/davinci/vpbe.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/platform/davinci/vpbe.c
From: Wei Yongjun
We have assigned error code to 'ret' if crop->type is not
V4L2_BUF_TYPE_VIDEO_OUTPUT, but never use it.
We'd better return the error code on this error.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/davinci/vpbe_display.c | 3 +--
1 file changed,
From: Wei Yongjun
The variable index is initialized but never used
otherwise, so remove the unused variable.
Signed-off-by: Wei Yongjun
---
drivers/media/platform/s5p-mfc/s5p_mfc.c| 5 -
drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 6 --
2 files changed, 11 deletions
From: Wei Yongjun
In case of error, the function vb2_dma_contig_init_ctx() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().
Signed-off-by: Wei Yongjun
---
drivers/media/platform/davinci/vpbe_display.c | 4 ++--
1 file changed
From: Wei Yongjun
The dereference to 'icl' should be moved below the NULL test.
Signed-off-by: Wei Yongjun
---
drivers/media/i2c/soc_camera/mt9v022.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/soc_camera/mt9v022.c
b/drivers/media/i2c/
From: Wei Yongjun
In case of error, the function vb2_dma_contig_init_ctx() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei
Hi Prabhakar,
On 11/09/2012 08:33 PM, Prabhakar Lad wrote:
> Hi Wei,
>
> Thanks for the patch.
>
> On Wed, Oct 24, 2012 at 4:59 PM, Wei Yongjun wrote:
>> From: Wei Yongjun
>>
>> In case of error, the function vb2_dma_contig_init_ctx() returns
>> ERR_PTR(
From: Wei Yongjun
The pattern E == C1 && E == C2 is always false. This patch
fix this according to the assumption that && should be ||.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
---
drivers/media/
From: Wei Yongjun
The pattern E == C1 && E == C2 is always false. This patch
fix this according to the assumption that && should be ||.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
---
drivers/media/
From: Wei Yongjun
The pattern E == C1 && E == C2 is always false. This patch
fix this according to the assumption that && should be ||.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
---
drivers/media/
From: Wei Yongjun
In case of error, the function vb2_dma_contig_init_ctx() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei
From: Wei Yongjun
In case of error, the function vb2_dma_contig_init_ctx() returns
ERR_PTR() and never returns NULL. The NULL test in the return value
check should be replaced with IS_ERR().
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei
From: Wei Yongjun
Add the missing unlock on the error handling path in function
vpbe_initialize().
Signed-off-by: Wei Yongjun
---
no test
---
drivers/media/platform/davinci/vpbe.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/davinci/vpbe.c
From: Wei Yongjun
Add the missing unlock on the error handle path in function
mx2_start_streaming().
Signed-off-by: Wei Yongjun
---
drivers/media/platform/soc_camera/mx2_camera.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/soc_camera
From: Wei Yongjun
Use the module_i2c_driver() macro to make the code smaller
and a bit simpler.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
---
drivers/media/i2c/adv7183.c | 13 +
1 file changed, 1 insertion
From: Wei Yongjun
Use the module_i2c_driver() macro to make the code smaller
and a bit simpler.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
---
drivers/media/i2c/vs6624.c | 13 +
1 file changed, 1 insertion
From: Wei Yongjun
Use the module_i2c_driver() macro to make the code smaller
and a bit simpler.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
---
drivers/staging/media/go7007/wis-uda1342.c| 13 +
drivers
From: Wei Yongjun
The dereference should be moved below the NULL test.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
---
drivers/media/dvb-frontends/stv0900_core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions
From: Wei Yongjun
Using list_move_tail() instead of list_del() + list_add_tail().
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
---
drivers/media/platform/fsl-viu.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions
From: Wei Yongjun
Using list_move_tail() instead of list_del() + list_add_tail().
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
---
drivers/media/pci/cx88/cx88-mpeg.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions
From: Wei Yongjun
Using list_move_tail() instead of list_del() + list_add_tail().
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
---
drivers/media/pci/cx23885/cx23885-core.c | 6 ++
1 file changed, 2 insertions(+), 4
From: Wei Yongjun
Remove including that don't need it.
dpatch engine is used to auto generate this patch.
(https://github.com/weiyj/dpatch)
Signed-off-by: Wei Yongjun
---
drivers/media/platform/s5p-tv/mixer_video.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/pla
94 matches
Mail list logo
