Hi Luca,
On 11/03/2018 11:00 PM, Luca Ceresoli wrote:
> Hi Vladimir,
>
> On 31/10/18 21:12, Vladimir Zapolskiy wrote:
>> Hi Luca,
>>
>> thank you for review.
>>
>> On 10/30/2018 06:43 PM, Luca Ceresoli wrote:
>>> Hi Vladimir,
>>>
&
0UB913, DS90Ux929, DS90Ux947, DS90UB964.
Steve, in case if you're unaware, that's FYI also.
--
Best wishes,
Vladimir
Hi Luca,
On 10/30/2018 06:44 PM, Luca Ceresoli wrote:
> Hi Vladimir,
>
> On 16/10/18 14:48, Laurent Pinchart wrote:
>> Hi Vladimir,
>>
>> On Saturday, 13 October 2018 16:47:48 EEST Vladimir Zapolskiy wrote:
>>> On 10/12/2018 03:01 PM, Laurent Pinchart wrote:
&
Hi Luca,
thank you for review.
On 10/30/2018 06:43 PM, Luca Ceresoli wrote:
> Hi Vladimir,
>
> On 08/10/18 23:12, Vladimir Zapolskiy wrote:
>> From: Vladimir Zapolskiy
>>
>> TI DS90Ux9xx de-/serializers are capable to route I2C messages to
>> I2C slave
Hi Luca,
thank you for review, please find my comments below.
On 10/30/2018 06:43 PM, Luca Ceresoli wrote:
> Hi Vladimir,
>
> On 08/10/18 23:11, Vladimir Zapolskiy wrote:
>> From: Sandeep Jain
>>
>> The change adds device tree binding description of TI DS90Ux9xx
Hi Laurent,
On 10/12/2018 02:59 PM, Vladimir Zapolskiy wrote:
> Hello Laurent.
>
> On 10/12/2018 04:01 PM, Laurent Pinchart wrote:
>> Hello Vladimir,
>>
...
>> then move to the driver side. In that area I would like to have a full
>> example
>> of a sy
Hi Laurent,
On 10/16/2018 04:12 PM, Laurent Pinchart wrote:
> Hi Vladimir,
>
> On Saturday, 13 October 2018 18:10:25 EEST Vladimir Zapolskiy wrote:
>> On 10/12/2018 04:01 PM, Laurent Pinchart wrote:
>>> On Friday, 12 October 2018 14:47:52 EEST Kieran Bingham wrote
Hi Laurent,
On 10/12/2018 04:01 PM, Laurent Pinchart wrote:
> Hello Vladimir,
>
> On Friday, 12 October 2018 14:47:52 EEST Kieran Bingham wrote:
>> On 12/10/18 11:58, Vladimir Zapolskiy wrote:
[snip]
>> Essentially they are multi purpose buses - which do not yet have a
Hi Laurent,
thank you for review, please find my comments below.
On 10/12/2018 02:44 PM, Laurent Pinchart wrote:
> Hi Vladimir,
>
> Thank you for the patch.
>
> On Tuesday, 9 October 2018 00:11:59 EEST Vladimir Zapolskiy wrote:
>> From: Sandeep Jain
>>
>> Th
Hi Laurent,
thank you for review, please find my comments below.
On 10/12/2018 03:01 PM, Laurent Pinchart wrote:
> Hi Vladimir,
>
> Thank you for the patch.
>
> On Tuesday, 9 October 2018 00:12:01 EEST Vladimir Zapolskiy wrote:
>> From: Vladimir Zapolskiy
>>
>
Hi Kieran,
On 10/12/2018 02:47 PM, Kieran Bingham wrote:
> Hi Vladimir,
>
[snip]
>
> Essentially they are multi purpose buses - which do not yet have a home.
> We have used media as a home because of our use case.
>
> The use case whether they transfer frames from a c
Hi Laurent
On 10/12/2018 04:12 PM, Laurent Pinchart wrote:
> Hi Vladimir,
>
> (CC'ing Wolfram)
>
> On Friday, 12 October 2018 10:32:32 EEST Vladimir Zapolskiy wrote:
>> On 10/12/2018 09:04 AM, Lee Jones wrote:
>>> On Tue, 09 Oct 2018, Vladimir Zapolskiy w
On 10/12/2018 02:43 PM, Lee Jones wrote:
> On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote:
>
>> On 10/12/2018 11:39 AM, Lee Jones wrote:
>>> On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote:
>>>> On 10/12/2018 09:03 AM, Lee Jones wrote:
>>>>&g
Hi Lee,
On 10/12/2018 02:34 PM, Lee Jones wrote:
> On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote:
>> On 10/12/2018 12:20 PM, Kieran Bingham wrote:
>>> Hi Vladimir,
>>> On 12/10/18 09:39, Lee Jones wrote:
>>>> On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote:
Hello Laurent.
On 10/12/2018 04:01 PM, Laurent Pinchart wrote:
> Hello Vladimir,
>
> On Friday, 12 October 2018 14:47:52 EEST Kieran Bingham wrote:
>> On 12/10/18 11:58, Vladimir Zapolskiy wrote:
>>> On 10/12/2018 12:20 PM, Kieran Bingham wrote:
>>>> On 12/10
On 10/12/2018 11:39 AM, Lee Jones wrote:
> On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote:
>> On 10/12/2018 09:03 AM, Lee Jones wrote:
>>> On Tue, 09 Oct 2018, Vladimir Zapolskiy wrote:
>>>
>>>> From: Vladimir Zapolskiy
>>>>
>>>> The
Hi Kieran,
On 10/12/2018 12:20 PM, Kieran Bingham wrote:
> Hi Vladimir,
>
> On 12/10/18 09:39, Lee Jones wrote:
>> On Fri, 12 Oct 2018, Vladimir Zapolskiy wrote:
>>> On 10/12/2018 09:03 AM, Lee Jones wrote:
>>>> On Tue, 09 Oct 2018, Vladimir Zapolskiy wrote:
Hi Lee,
On 10/12/2018 09:03 AM, Lee Jones wrote:
> On Tue, 09 Oct 2018, Vladimir Zapolskiy wrote:
>
>> From: Vladimir Zapolskiy
>>
>> The change adds I2C device driver for TI DS90Ux9xx de-/serializers,
>> support of subdevice controllers is done in separate
Hi Lee,
On 10/12/2018 09:04 AM, Lee Jones wrote:
> On Tue, 09 Oct 2018, Vladimir Zapolskiy wrote:
>
>> From: Vladimir Zapolskiy
>>
>> The change adds TI DS90Ux9xx I2C bridge/alias subdevice driver and
>> FPD Link connection handling mechanism.
>>
>> A
On 10/09/2018 02:11 PM, Vladimir Zapolskiy wrote:
> Hi Marek,
>
> On 10/09/2018 03:13 AM, Marek Vasut wrote:
>> On 10/08/2018 11:11 PM, Vladimir Zapolskiy wrote:
>>> From: Sandeep Jain
>>>
>>> The change adds device tree binding description of
On 10/09/2018 07:08 AM, kbuild test robot wrote:
> Hi Vladimir,
>
> I love your patch! Perhaps something to improve:
>
> [auto build test WARNING on ljones-mfd/for-mfd-next]
> [also build test WARNING on v4.19-rc7 next-20181008]
> [if your patch is applied to the wrong git t
Hi Marek,
On 10/09/2018 03:13 AM, Marek Vasut wrote:
> On 10/08/2018 11:11 PM, Vladimir Zapolskiy wrote:
>> From: Sandeep Jain
>>
>> The change adds device tree binding description of TI DS90Ux9xx
>> series of serializer and deserializer controllers which support video
s/ossalsjp18/8a/vzapolskiy_als2018.pdf
Sandeep Jain (1):
dt-bindings: mfd: ds90ux9xx: add description of TI DS90Ux9xx ICs
Vladimir Zapolskiy (6):
dt-bindings: mfd: ds90ux9xx: add description of TI DS90Ux9xx I2C bridge
dt-bindings: pinctrl: ds90ux9xx: add description of TI DS90Ux9xx pinmux
From: Vladimir Zapolskiy
TI DS90Ux9xx de-/serializers have a capability to multiplex pin functions,
in particular a pin may have selectable functions of GPIO, GPIO line
transmitter, one of I2S lines, one of RGB24 video signal lines and so on.
The change adds a description of DS90Ux9xx pin
Record TI DS90Ux9xx series of serializer and deserializer ICs
and IC subcontrollers as maintained.
Signed-off-by: Vladimir Zapolskiy
---
MAINTAINERS | 10 ++
1 file changed, 10 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 29c08106bd22..3952035b6b71 100644
--- a
From: Vladimir Zapolskiy
TI DS90Ux9xx de-/serializers are capable to route I2C messages to
I2C slave devices connected to a remote de-/serializer in a pair,
the change adds description of device tree bindings of the subcontroller
to configure and enable this functionality.
Signed-off-by
From: Vladimir Zapolskiy
The change adds I2C device driver for TI DS90Ux9xx de-/serializers,
support of subdevice controllers is done in separate drivers, because
not all IC functionality may be needed in particular situations, and
this can be fine grained controlled in device tree.
The
From: Vladimir Zapolskiy
The change adds an MFD cell driver for managing pin functions on
TI DS90Ux9xx de-/serializers.
Signed-off-by: Vladimir Zapolskiy
---
drivers/pinctrl/Kconfig | 11 +
drivers/pinctrl/Makefile| 1 +
drivers/pinctrl/pinctrl-ds90ux9xx.c | 970
of secondary importance]
Signed-off-by: Vladimir Zapolskiy
---
.../devicetree/bindings/mfd/ti,ds90ux9xx.txt | 66 +++
1 file changed, 66 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/ti,ds90ux9xx.txt
diff --git a/Documentation/devicetree/bindings/mfd/ti
From: Vladimir Zapolskiy
The change adds TI DS90Ux9xx I2C bridge/alias subdevice driver and
FPD Link connection handling mechanism.
Access to I2C devices connected to a remote de-/serializer is done in
a transparent way, on established link detection event such devices
are registered on an I2C
eo frame controls */>;
> + reg-names = "sxe", "bsev", "mbe", "ppe", "mce",
> + "tfe", "ppb", "vdma", "frameid";
> + iram = <&vde_pool>; /* IRAM region */
> + interrupts = , /* Sync token interrupt
> */
> + , /* BSE-V interrupt */
> + ; /* SXE interrupt */
> + interrupt-names = "sync-token", "bsev", "sxe";
> + clocks = <&tegra_car TEGRA20_CLK_VDE>;
> + resets = <&tegra_car 61>;
> +};
>
--
With best wishes,
Vladimir
Hi Dmitry,
On 10/20/2017 12:34 AM, Dmitry Osipenko wrote:
> From: Vladimir Zapolskiy
>
> All Tegra SoCs contain 256KiB IRAM, which is used to store CPU resume code
> and by hardware engines like a video decoder.
>
> Signed-off-by: Vladimir Zapolskiy
Please add also your o
on);
> +
> + vde->miscdev.minor = MISC_DYNAMIC_MINOR;
> + vde->miscdev.name = "tegra_vde";
> + vde->miscdev.fops = &tegra_vde_fops;
> + vde->miscdev.parent = dev;
> +
> + err = misc_register(&vde->miscdev);
> + if (err) {
> + dev_err(dev, "Failed to register misc device: %d\n", err);
> + goto err_gen_free;
> + }
> +
> + pm_runtime_enable(dev);
> + pm_runtime_use_autosuspend(dev);
> + pm_runtime_set_autosuspend_delay(dev, 300);
> +
> + if (!pm_runtime_enabled(dev)) {
> + err = tegra_vde_runtime_resume(dev);
> + if (err)
> + goto err_misc_unreg;
> + }
> +
> + return 0;
> +
> +err_misc_unreg:
> + misc_deregister(&vde->miscdev);
> +
> +err_gen_free:
> + gen_pool_free(vde->iram_pool,
> + (unsigned long)vde->iram, 0x3FC00);
See a comment above.
> +
> + return err;
> +}
> +
> +static int tegra_vde_remove(struct platform_device *pdev)
> +{
> + struct tegra_vde *vde = platform_get_drvdata(pdev);
> + struct device *dev = &pdev->dev;
> + int err;
> +
> + if (!pm_runtime_enabled(dev)) {
> + err = tegra_vde_runtime_suspend(dev);
> + if (err)
> + return err;
> + }
> +
> + pm_runtime_dont_use_autosuspend(dev);
> + pm_runtime_disable(dev);
> +
> + misc_deregister(&vde->miscdev);
> +
> + gen_pool_free(vde->iram_pool,
> + (unsigned long)vde->iram, 0x3FC00);
See a comment above.
> +
> + return 0;
> +}
> +
[snip]
> +
> +MODULE_DESCRIPTION("NVIDIA Tegra20 Video Decoder driver");
> +MODULE_AUTHOR("Dmitry Osipenko");
Please add your email here, then if you are not a maintainer (and by
the way please consider to add your name to the MAINTAINERS file),
you'll get a higher chance to receive updates in the future.
> +MODULE_LICENSE("GPL");
>
--
With best wishes,
Vladimir
r IRAM resource between users.
My proposal is to add a valid device tree node to describe an IRAM region
firstly, then reserve a subregion in it by using a new "iram" property.
8<
From: Vladimir Zapolskiy
Date: Thu, 12 Oct 2017 10:25:45 +0300
Subject: [PATCH] ARM: tegra:
ing descriptions.
Shawn, please bless the series.
>
> You don't need Greg's Ack for staging/media either, patches there
> go in via us (generally at least) and we handle those, not Greg.
>
--
With best wishes,
Vladimir
t; + vidsw->gpio = NULL;
> + }
> +
> + vidsw->active = gpiod_get_value(vidsw->gpio) ? 1 : 0;
vidsw->active is always set to 0 ?
> + }
> +
> + vidsw->num_pads = num_pads;
> + vidsw->pads = devm_kzalloc(&pdev->dev, sizeof(*vidsw->pads) * num_pads,
> + GFP_KERNEL);
> + vidsw->format_mbus = devm_kzalloc(&pdev->dev,
> + sizeof(*vidsw->format_mbus) * num_pads, GFP_KERNEL);
> + vidsw->endpoint = devm_kzalloc(&pdev->dev,
> + sizeof(*vidsw->endpoint) * (num_pads - 1), GFP_KERNEL);
> +
> + ret = vidsw_async_init(vidsw, np);
> + if (ret)
> + return ret;
> +
> + return 0;
> +}
> +
--
With best wishes,
Vladimir
Hi Ramiro,
On 03/06/2017 01:16 PM, Ramiro Oliveira wrote:
> Create device tree bindings documentation.
>
> Signed-off-by: Ramiro Oliveira
The device tree binding description looks perfect from my perspective.
Reviewed-by: Vladimir Zapolskiy
--
With best wishes,
Vladimir
l updates are fine, thank you. Feel free to add my
Reviewed-by: Vladimir Zapolskiy
> ---
> MAINTAINERS| 7 +
> drivers/media/i2c/Kconfig | 11 +
> drivers/media/i2c/Makefile | 1 +
> drivers/media/i2c/ov5647.c | 636
> +
code of the plugin, I was interested to compare its performance
and features with mine in-house NEON powered RGGB/BGGR to RGB24 GStreamer
conversion element, which is written years ago. My question was offtopic.
--
With best wishes,
Vladimir
iated on the pads (which is actually good enough
> to show the issue.)
I'm sorry for potential offtopic, but is bayer2rgbneon element found in
any officially supported by GStreamer plugin? Can it be a point of
failure?
--
With best wishes,
Vladimir
On 02/22/2017 12:51 PM, Ramiro Oliveira wrote:
> Hi Zakari,
>
> On 2/21/2017 8:36 PM, Vladimir Zapolskiy wrote:
>> Hi Ramiro,
>>
>> On 02/21/2017 06:42 PM, Ramiro Oliveira wrote:
>>> Hi Vladimir,
>>>
>>> Thank you for your feedback
>>&
Hi Ramiro,
On 02/22/2017 12:57 PM, Ramiro Oliveira wrote:
> Hi Vladimir
>
> On 2/21/2017 10:37 PM, Vladimir Zapolskiy wrote:
>> Hi Sakari,
>>
>> On 02/21/2017 11:48 PM, Sakari Ailus wrote:
>>> Hi, Vladimir!
>>>
>>> How do you do? :-)
>>
Hi Sakari,
On 02/21/2017 11:48 PM, Sakari Ailus wrote:
> Hi, Vladimir!
>
> How do you do? :-)
deferring execution of boring tasks by doing code review :)
> On Tue, Feb 21, 2017 at 10:48:09PM +0200, Vladimir Zapolskiy wrote:
>> Hi Ramiro,
>>
>> On 02/21/2017 1
Hi Ramiro,
On 02/21/2017 10:13 PM, Ramiro Oliveira wrote:
> Hi Vladimir,
>
> Thank you for your feedback
>
> On 2/21/2017 3:58 PM, Vladimir Zapolskiy wrote:
>> Hi Ramiro,
>>
>> On 02/17/2017 03:14 PM, Ramiro Oliveira wrote:
>>> Create device tree bin
Hi Ramiro,
On 02/21/2017 06:42 PM, Ramiro Oliveira wrote:
> Hi Vladimir,
>
> Thank you for your feedback
>
> On 2/21/2017 3:54 PM, Vladimir Zapolskiy wrote:
>> Hi Ramiro,
>>
>> please find some review comments below.
>>
>> On 02/17/2017 03:14 PM,
gt; + clock-frequency = <2500>;
When you remove two unused properties, please don't forget to update the
example.
> + port {
> + camera_1: endpoint {
> + remote-endpoint = <&csi1_ep1>;
> + };
> + };
> + };
> + };
>
--
With best wishes,
Vladimir
ate(sensor->xclk);
> + if (sensor->xclk_freq != 2500) {
A comment in "struct ov5647" declaration says about 30MHz, which one is correct?
> + dev_err(dev, "Unsupported clock frequency: %u\n",
> + sensor->xclk_freq);
> + return -EINVAL;
> + }
> +
> + mutex_init(&sensor->lock);
> +
> + sd = &sensor->sd;
> + v4l2_i2c_subdev_init(sd, client, &subdev_ops);
> + sensor->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
> +
> + sensor->pad.flags = MEDIA_PAD_FL_SOURCE;
> + sd->entity.function = MEDIA_ENT_F_CAM_SENSOR;
> + ret = media_entity_pads_init(&sd->entity, 1, &sensor->pad);
> + if (ret < 0)
> + goto mutex_remove;
> +
> + ret = ov5647_detect(sd);
> + if (ret < 0)
> + goto error;
> +
> + ret = v4l2_async_register_subdev(sd);
> + if (ret < 0)
> + goto error;
> +
> + dev_dbg(&client->dev, "OmniVision OV5647 camera driver probed\n");
> + return 0;
> +error:
> + media_entity_cleanup(&sd->entity);
> +mutex_remove:
> + mutex_destroy(&sensor->lock);
> + return ret;
> +}
> +
[snip]
The driver looks good in general IMO.
--
With best wishes,
Vladimir
Hi Ramiro,
On 02/13/2017 09:14 PM, Ramiro Oliveira wrote:
> Hi Vladimir,
>
> Thank you for your feedback.
>
> On 2/13/2017 12:21 PM, Vladimir Zapolskiy wrote:
>> Hello Ramiro,
>>
>> On 02/13/2017 01:25 PM, Ramiro Oliveira wrote:
>>> Modes supported:
>
it from the 'struct ov5647' declaration.
> +
> + sd = &sensor->sd;
> + v4l2_i2c_subdev_init(sd, client, &subdev_ops);
> + sensor->sd.flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
> +
> + sensor->pad.flags = MEDIA_PAD_FL_SOURCE;
> + sd->entity.function = MEDIA_ENT_F_CAM_SENSOR;
> + ret = media_entity_pads_init(&sd->entity, 1, &sensor->pad);
> + if (ret < 0)
> + goto mutex_remove;
> +
> + ret = ov5647_detect(sd);
> + if (ret < 0)
> + goto error;
> +
> + ret = v4l2_async_register_subdev(sd);
> + if (ret < 0)
> + goto error;
> +
> + return 0;
> +error:
> + media_entity_cleanup(&sd->entity);
> +mutex_remove:
> + mutex_destroy(&sensor->lock);
> + return ret;
> +}
> +
> +/**
> + * @short Exit routine - Exit point of the driver
> + * @param[in] client pointer to the i2c client structure
> + * @return 0 on success and a negative number on failure
> + */
> +static int ov5647_remove(struct i2c_client *client)
> +{
> + struct v4l2_subdev *sd = i2c_get_clientdata(client);
> + struct ov5647 *ov5647 = to_state(sd);
> +
> + v4l2_async_unregister_subdev(&ov5647->sd);
> + media_entity_cleanup(&ov5647->sd.entity);
> + v4l2_device_unregister_subdev(sd);
> + mutex_destroy(&ov5647->lock);
> +
> + return 0;
> +}
> +
> +static const struct i2c_device_id ov5647_id[] = {
> + { "ov5647", 0 },
> + { }
> +};
> +MODULE_DEVICE_TABLE(i2c, ov5647_id);
> +
> +#if IS_ENABLED(CONFIG_OF)
>From Kconfig the driver depends on OF.
> +static const struct of_device_id ov5647_of_match[] = {
> + { .compatible = "ovti,ov5647" },
> + { /* sentinel */ },
> +};
> +MODULE_DEVICE_TABLE(of, ov5647_of_match);
> +#endif
> +
> +/**
> + * @short i2c driver structure
> + */
> +static struct i2c_driver ov5647_driver = {
> + .driver = {
> + .of_match_table = of_match_ptr(ov5647_of_match),
Same comment as above, from Kconfig the driver depends on OF.
> + .owner = THIS_MODULE,
.owner is set by the core, please remove it.
> + .name = "ov5647",
May be .name = SENSOR_NAME, ?
Otherwise SENSOR_NAME macro is unused and it should be removed.
> + },
> + .probe = ov5647_probe,
> + .remove = ov5647_remove,
> + .id_table = ov5647_id,
> +};
> +
> +module_i2c_driver(ov5647_driver);
> +
> +MODULE_AUTHOR("Ramiro Oliveira ");
> +MODULE_DESCRIPTION("A low-level driver for OmniVision ov5647 sensors");
> +MODULE_LICENSE("GPL v2");
>
--
With best wishes,
Vladimir
mxcsi2_dt_ids[] = {
> + { .compatible = "fsl,imx-mipi-csi2", },
> + { /* sentinel */ }
> +};
> +MODULE_DEVICE_TABLE(of, imxcsi2_dt_ids);
> +
> +static struct platform_driver imxcsi2_driver = {
> + .driver = {
> + .name = DEVICE_NAME
;sd.entity);
> + v4l2_device_unregister_subdev(&priv->sd);
> +
> + return 0;
> +}
> +
> +static const struct platform_device_id camif_ids[] = {
> + { .name = DEVICE_NAME },
> + { },
> +};
> +MODULE_DEVICE_TABLE(platform, camif_ids);
> +
> +static struct platform_driver imx_camif_driver = {
> + .probe = camif_probe,
> + .remove = camif_remove,
> + .driver = {
> + .name = DEVICE_NAME,
> + .owner = THIS_MODULE,
Please drop the owner assignment.
> + },
> +};
> +
> +module_platform_driver(imx_camif_driver);
> +
> +MODULE_DESCRIPTION("i.MX camera interface subdev driver");
> +MODULE_AUTHOR("Steve Longerbeam ");
> +MODULE_LICENSE("GPL");
>
--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
priv->curr_in_buf->index);
> +
> + /* current input buffer is now last */
> + priv->last_in_buf = priv->curr_in_buf;
> + } else {
> + /*
> + * priv->next buffer is now the active one
name = "imx-ipuv3-smfc" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(platform, imx_smfc_ids);
> +
> +static struct platform_driver imx_smfc_driver = {
> + .probe = imx_smfc_probe,
> + .remove = imx_smfc_remove,
> + .id_table = imx_smfc_ids,
> + .driver =
t; + return ret;
This is a functionally equal and simplified version:
if (ret)
v4l2_ctrl_handler_free(&priv->ctrl_hdlr);
return ret;
> +}
> +
> +static int imx_csi_remove(struct platform_device *pdev)
> +{
> + struct v4l2_subdev *sd = platform_get_drvdata(pdev);
&
ck and remove the goto label.
> +
> + (*csi)[ipu_id * 2 + csi_id] = lcsi;
> + }
> +
> + return 0;
> +err_put:
> + of_node_put(csi_np);
> + return ret;
> +}
> diff --git a/drivers/staging/media/imx/imx-media-of.h
> b/drivers/stagin
MX6QDL_PAD_CSI0_PIXCLK__IPU1_CSI0_PIXCLK
> 0x8000
> + MX6QDL_PAD_CSI0_MCLK__IPU1_CSI0_HSYNC
> 0x8000
> + MX6QDL_PAD_CSI0_VSYNC__IPU1_CSI0_VSYNC
> 0x8000
> + >;
> + };
> +
> pinctrl_pwm3: pwm1grp {
> fsl,pins = <
> MX6QDL_PAD_SD4_DAT1__PWM3_OUT 0x1b0b1
>
--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
MX6QDL_PAD_CSI0_DAT17__IPU1_CSI0_DATA17
> 0x8000
> + MX6QDL_PAD_CSI0_DAT18__IPU1_CSI0_DATA18
> 0x8000
> + MX6QDL_PAD_CSI0_DAT19__IPU1_CSI0_DATA19
> 0x8000
> +
8000
> + MX6QDL_PAD_CSI0_MCLK__IPU1_CSI0_HSYNC
> 0x8000
> + MX6QDL_PAD_CSI0_VSYNC__IPU1_CSI0_VSYNC
> 0x8000
> + MX6QDL_PAD_CSI0_DATA_EN__IPU1_CSI0_DATA_EN
> 0x8000
> + >;
> + };
> +
> +pinctrl_ov5640: ov5640grp {
> +fsl,pins = <
> + MX6QDL_PAD_NANDF_D5__GPIO2_IO05 0x000b0
> + MX6QDL_PAD_NANDF_WP_B__GPIO6_IO09 0x0b0b0
> +>;
> +};
> +
Indentation issues above, please use tabs instead of spaces.
Also please add new pin control groups preserving the alphanimerical order.
--
With best wishes,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Peter,
On 24.03.2016 13:05, Peter Rosin wrote:
> Hi Vladimir,
>
> On 2016-03-24 10:50, Vladimir Zapolskiy wrote:
>> Hi Peter,
>>
>> On 05.01.2016 17:57, Peter Rosin wrote:
>>> From: Peter Rosin
>>>
>>> The initial core mux structure sta
if (!arb->child) {
> dev_err(dev, "Failed to add adapter\n");
> ret = -ENODEV;
> - i2c_put_adapter(arb->parent);
> + i2c_put_adapter(muxc->parent);
> }
>
> return ret;
--
With best wishe
/
> - mutex_lock(&dev->lock);
> atomic_set(&dev->initialized, 1);
> - mutex_unlock(&dev->lock);
>
> IR_dprintk(1, "Registered rc%u (driver: %s, remote: %s, mode %s)\n",
> dev->minor,
>
--
With best wishes,
Vladimir
--
T
;/dev/video0" !
>> video/x-raw,width=640,height=180,framerate=30 ! autovideosink
According to the received caps use
* video/x-raw-yuv
* framerate=30/1
* and start from fakesink
>>
>> But it keeps giving me auto negotiation error -4.
>> Trying to give other values did n
The devm_gpiod_get() function returns either a valid pointer to
struct gpio_desc or ERR_PTR() error value, check for NULL is bogus.
Signed-off-by: Vladimir Zapolskiy
---
drivers/media/i2c/adp1653.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/adp1653
ned-off-by: Vladimir Zapolskiy
---
Documentation/video4linux/v4l2-controls.txt | 1 -
drivers/media/v4l2-core/v4l2-ctrls.c| 16
include/media/v4l2-ctrls.h | 12
3 files changed, 29 deletions(-)
diff --git a/Documentation/video4linux/v4l2-contr
e only one gen_pool
per device, this implies two possible error codes returned by the
function, account it on client side (only misc/sram). This completes
client side changes related to genalloc updates.
Signed-off-by: Vladimir Zapolskiy
Cc: Philipp Zabel
Cc: Greg Kroah-Hartman
Cc: Russell King
C
e only
one gen_pool per device, this implies two possible error codes
returned by the function, account it on client side (only misc/sram).
This completes client side changes related to genalloc updates.
Signed-off-by: Vladimir Zapolskiy
---
arch/arm/mach-at91/pm.c | 2 +-
arch/ar
- minor updates in of_gen_pool_get() change to respect OF_DYNAMIC
- instead of adding two new functions the existing functions
gen_pool_get() (at91, imx5m, imx6 and CODA driver clients) and
devm_gen_pool_create() (sram client) are updated.
Vladimir Zapolskiy (2):
genalloc: add name arg to gen
a gen_pool object.
Due to a weak relation and to avoid any confusion (e.g. in future
possible scenario if gen_pool objects are named) the suffix is
removed.
Signed-off-by: Vladimir Zapolskiy
---
drivers/dma/mmp_tdma.c| 2 +-
drivers/media/platform/coda/coda-common.c | 2 +
based and tested on linux-next.
Vladimir Zapolskiy (2):
genalloc: rename dev_get_gen_pool() to gen_pool_get()
genalloc: rename of_get_named_gen_pool() to of_gen_pool_get()
arch/arm/mach-at91/pm.c | 2 +-
arch/arm/mach-imx/pm-imx5.c | 2 +-
arch/arm/mach-imx
To be consistent with other genalloc interface namings, rename
dev_get_gen_pool() to gen_pool_get(). The original omitted "dev_"
prefix is removed, since it points to argument type of the function,
and so it does not bring any useful information.
Signed-off-by: Vladimir Zapolskiy
---
Hi Andy,
thank you for joining the discussion.
On 02.12.2014 08:36, Andy Yan wrote:
> Hi Vladimir:
>
> I am working on convert imx-hdmi to dw_hdmi now:
> https://lkml.org/lkml/2014/12/1/190
> I also have a plan to use the internal HDMI I2C master under the I2c
> frame
On 01.12.2014 17:11, Philipp Zabel wrote:
> Am Montag, den 01.12.2014, 16:54 +0200 schrieb Vladimir Zapolskiy:
>> Hi Philipp and Shawn,
>>
>> On 15.11.2014 19:49, Vladimir Zapolskiy wrote:
>>> Provide information about how to bind internal iMX6Q/DL HDMI DDC I2C
>&
Hi Philipp and Shawn,
On 15.11.2014 19:49, Vladimir Zapolskiy wrote:
> Provide information about how to bind internal iMX6Q/DL HDMI DDC I2C
> master controller. The property is set as optional one, because iMX6
> HDMI DDC bus may be represented by one of general purpose I2C busses
>
Provide information about how to bind internal iMX6Q/DL HDMI DDC I2C
master controller. The property is set as optional one, because iMX6
HDMI DDC bus may be represented by one of general purpose I2C busses
found on SoC.
Signed-off-by: Vladimir Zapolskiy
Cc: Wolfram Sang
Cc: Philipp Zabel
Cc
On 02/25/2014 01:10 PM, Phil Edworthy wrote:
Signed-off-by: Phil Edworthy
Acked-by: Vladimir Barinov
(Valentine can't do the review atm)
---
v2:
- Fix silly mistake with missing break.
drivers/media/platform/soc_camera/rcar_vin.c |9 +
1 file changed, 9 insertions(+)
Hi Matsubara-san,
On 07/25/2013 07:01 AM, Katsuya MATSUBARA wrote:
Hi Vladimir,
Thank you for the revised patch.
From: Sergei Shtylyov
Date: Sat, 20 Jul 2013 03:14:34 +0400
From: Vladimir Barinov
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy
ead of removal?
Regards,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Guennadi,
Guennadi Liakhovetski wrote:
Hi Sergei
On Fri, 28 Jun 2013, Sergei Shtylyov wrote:
Hello.
On 06/28/2013 03:58 AM, Vladimir Barinov wrote:
From: Vladimir Barinov
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy
Hi Guennadi,
Vladimir Barinov wrote:
Hi Guennadi,
Guennadi Liakhovetski wrote:
Hi Sergei
On Sat, 22 Jun 2013, Sergei Shtylyov wrote:
From: Vladimir Barinov
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy .
Signed-off-by: Vladimir Barinov
[Sergei
Hi Guennadi,
Guennadi Liakhovetski wrote:
Hi Sergei
On Sat, 22 Jun 2013, Sergei Shtylyov wrote:
From: Vladimir Barinov
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy .
Signed-off-by: Vladimir Barinov
[Sergei: removed deprecated IRQF_DISABLED flag
Hi Matsubara-san,
Katsuya MATSUBARA wrote:
Hi Vladimir,
From: Vladimir Barinov
Date: Fri, 21 Jun 2013 14:32:05 +0400
Katsuya MATSUBARA wrote:
Hi Vladimir,
From: Vladimir Barinov
Date: Fri, 21 Jun 2013 13:39:50 +0400
(snip)
I have not seen such i2c errors during
Katsuya MATSUBARA wrote:
Hi Vladimir,
From: Vladimir Barinov
Date: Fri, 21 Jun 2013 13:39:50 +0400
(snip)
I have not seen such i2c errors during capturing and booting.
But I have seen that querystd() in the ml86v7667 driver often
returns V4L2_STD_UNKNOWN, although the corresponding
Hi Matsubara-san,
Katsuya MATSUBARA wrote:
Hi Vladimir,
From: Vladimir Barinov
Date: Fri, 21 Jun 2013 12:06:12 +0400
Hi Matsubara-san,
Katsuya MATSUBARA wrote:
Hi Sergei and Valadmir,
From: Sergei Shtylyov
Date: Fri, 24 May 2013 02:11:28 +0400
(snip)
+/* Similar to
u for the valuable report.
I will try to get the NTSC camera to continue with your finding.
Regards,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
dev_dbg(dev, "Sensor doesn't support cropping\n");
Are you sure this print is correct?
Probably it should be the same like above for the case if subdevice
driver does not support cropping (see soc_scale_crop.c -> client_s_fmt() ).
Regards,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Guennadi,
On 05/15/2013 08:44 AM, Guennadi Liakhovetski wrote:
Hi Sergei, Vladimir
On Wed, 15 May 2013, Sergei Shtylyov wrote:
From: Vladimir Barinov
Add Renesas R-Car VIN (Video In) V4L2 driver.
Based on the patch by Phil Edworthy.
Signed-off-by: Vladimir Barinov
[Sergei: removed
disable */
+iowrite32(*vnmc & ~VNMC_ME, priv->base + VNMC_REG);
+}
+
+static void capture_restore(struct rcar_vin_priv *priv, u32 vnmc)
+{
+unsigned long timeout = jiffies + 10 * HZ;
+
+if (!(vnmc & ~VNMC_ME))
+/* Nothing to restore */
+ return;
And you don&
Vladimir Barinov wrote:
Hi Hans,
Hans Verkuil wrote:
+ */
+val = i2c_smbus_read_byte_data(client, STATUS_REG);
+if (val < 0)
+return val;
+
+priv->std = val & STATUS_NTSCPAL ? V4L2_STD_PAL : V4L2_STD_NTSC;
Shouldn't this be 50 Hz vs 60 Hz for
hem mention PAL output with number of lines in the technical manual.
All of them are 625 lines.
Can you ask the manufacturer for more information?
It can take a while for waiting their feedback since OKI was
significantly reorganized.
Than you very much for your valuable feedback/review.
667 datasheet the description for STATUS register detection
bit is just PAL/NTSC:
" $2C/STATUS [2] NTSC/PAL identification 0: NTSC /1: PAL "
If you assure me that I must judge their description as 50 vs 60Hz
formats and not PAL/NTSC then I will make the change.
Regards,
Vladimir
--
T
e
it will not be available for all non soc-camera v4l2 hosts.
Regards,
Vladimir
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Manjunath Hadli wrote:
This is the display driver for Texas Instruments's DM644X family
SoC. This patch contains the main implementation of the driver with the
V4L2 interface. The driver implements the streaming model with
support for both kernel allocated buffers and user pointers. It also
imple
g DVB card "ST STV0299 DVB-S"
> tuning DVB-S to L-Band:774218352, Pol:V Srate=3000, 22kHz=off
> polling
> Getting frontend event
> FE_STATUS:
> polling
> Getting frontend event
> FE_STATUS: FE_HAS_SIGNAL FE_HAS_CARRIER
> polling
> polling
>
&g
2010/5/7 Magnus Alm :
>
> Hi, the main problem (I think) is that your box doesn't support audio
> over usb. So when you use the "card=28" option, it doesn't turn on the
> audio output connector. Your box has a Em2800 chip, where the "Deluxe"
> version uses a Em2820.
>
> I'll take a look at the code
hvaib...@ti.com wrote:
From: Vaibhav Hiremath
Features Supported -
1. Provides V4L2 user interface for the video pipelines of DSS
2. Basic streaming working on LCD, DVI and TV.
3. Works on latest DSS2 library from Tomi
4. Support for various pixel formats like YUV
Hi Hermann.
Sorry, i forgot it.
Resend patch with SOB.
Signed-off-by: Vladimir Ermakov
# HG changeset patch
# User Vladimir Ermakov
# Date 1269096094 -10800
# Node ID a91db2cf4f5774866c8c5bf906d9ac4faff9173d
# Parent 929298149eba4b6d0696124b9880113c25cd0788
saa7134: fix GPIO HW-404M7
diff
Hi Hermann.
1. It's my mistake. Fixed.
2. Dead code. Removed.
# HG changeset patch
# User Vladimir Ermakov
# Date 1269096094 -10800
# Node ID a91db2cf4f5774866c8c5bf906d9ac4faff9173d
# Parent 929298149eba4b6d0696124b9880113c25cd0788
saa7134: fix GPIO HW-404M7
diff -r 929298149e
pins:
Mode : 0x00389200
Value: 0x0001
Video input: 3
Audio input: Analog Line1
Signed-off-by: Vladimir Ermakov
# HG changeset patch
# User Vladimir Ermakov
# Date 1268232221 -10800
# Node ID 072cd67c6aabe0e700a9e4727b50ad6424cb59f5
# Parent 7a58d924fb049ff1d318514939b3a7e416670c13
saa7134
Karicheri, Muralidharan wrote:
Open issues
---
1.How to handle an HDMI transmitter? It can be put in two different modes: DVI
compatible
or HDMI compatible. Some of the choices are
a) enumerate them as two different outputs when enumerating.
b) adding a status bit on
Using driver v4l-dvb changeset befor 11017
http://linuxtv.org/hg/v4l-dvb/rev/c2e9ae022ea7 my configuration work fine, but
when I try to update for new version changeset 11018 or newly, I can't scan or
add channels in all TV views or players.
My configuration:
Ubuntu 9.04 x86_64
Linux 2.6.28-1
1 - 100 of 103 matches
Mail list logo
