Re: [PATCH v2 1/2] gspca: sn9c2028: Add support for Genius Videocam Live v2

2015-05-20 Thread Vasily Khoruzhick
Hi Mauro, On Wed, May 20, 2015 at 3:12 PM, Mauro Carvalho Chehab wrote: > Em Fri, 24 Apr 2015 10:04:03 +0300 > Vasily Khoruzhick escreveu: >> diff --git a/drivers/media/usb/gspca/sn9c2028.c >> b/drivers/media/usb/gspca/sn9c2028.c >> index 39b6b2e..317b02c 100644 &g

Re: [PATCH v2 1/2] gspca: sn9c2028: Add support for Genius Videocam Live v2

2015-05-15 Thread Vasily Khoruzhick
Hi Hans, On Fri, May 15, 2015 at 8:51 PM, Hans de Goede wrote: > Sorry for being a bit slow on this one, v2 looks good. I'll queue it up for > merging into 4.2 as soon as I find some time to work on this, Thanks! Regards, Vasily -- To unsubscribe from this list: send the line &

Re: [PATCH v2 1/2] gspca: sn9c2028: Add support for Genius Videocam Live v2

2015-05-15 Thread Vasily Khoruzhick
Ping? On Fri, Apr 24, 2015 at 10:04 AM, Vasily Khoruzhick wrote: > This cam seems to return different values on long commands, so make status > check > in sn9c2028_long_command() more tolerant. Anyway, read value isn't used > anywhere > later. > > Signed-off-by: Vas

[PATCH v2 1/2] gspca: sn9c2028: Add support for Genius Videocam Live v2

2015-04-24 Thread Vasily Khoruzhick
This cam seems to return different values on long commands, so make status check in sn9c2028_long_command() more tolerant. Anyway, read value isn't used anywhere later. Signed-off-by: Vasily Khoruzhick --- v2: update commit message to explain change in sn9c2028_long_command() drivers/medi

[PATCH v2 2/2] gspca: sn9c2028: Add gain and autogain controls Genius Videocam Live v2

2015-04-24 Thread Vasily Khoruzhick
Autogain algorithm is very simple, if average luminance is low - increase gain, if it's high - decrease gain. Gain granularity is low enough for this algo to stabilize quickly. Signed-off-by: Vasily Khoruzhick --- v2: According to Hans, header lenght is 12 bytes, so drop 2 redundant

Re: [PATCH 2/2] gspca: sn9c2028: Add gain and autogain controls Genius Videocam Live v2

2015-04-21 Thread Vasily Khoruzhick
This seems wrong, the header is only 12 bytes the extra 2 0x00 bytes you add > are > actually part of the compressed data and are parsed by the userspace code, > please drop them. OK, I've found average lumimance value in header heuristically, based on info that it's present in he

Re: [PATCH 1/2] gspca: sn9c2028: Add support for Genius Videocam Live v2

2015-04-21 Thread Vasily Khoruzhick
sen well, both should probably > be != 2. But checking for status < 0 is not good as this does not catch > a successful read from the chip not returning 2. For this cam it returns 1 on some commands. Anyway, this value is not used anywhere later, so I just extended condition. Regards

[PATCH 2/2] gspca: sn9c2028: Add gain and autogain controls Genius Videocam Live v2

2015-04-19 Thread Vasily Khoruzhick
Autogain algorithm is very simple, if average luminance is low - increase gain, if it's high - decrease gain. Gain granularity is low enough for this algo to stabilize quickly. Signed-off-by: Vasily Khoruzhick --- drivers/media/usb/gspca/sn9c2028.c

[PATCH 1/2] gspca: sn9c2028: Add support for Genius Videocam Live v2

2015-04-19 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- drivers/media/usb/gspca/sn9c2028.c | 120 - 1 file changed, 119 insertions(+), 1 deletion(-) diff --git a/drivers/media/usb/gspca/sn9c2028.c b/drivers/media/usb/gspca/sn9c2028.c index 39b6b2e..317b02c 100644 --- a/drivers

Re: [PATCH] libv4l: add hflip quirk for dealextreme cam sku #44507

2012-01-03 Thread Vasily
2012/1/3 Hans de Goede : > Hi, > > > Thanks for the patch. > > I'm sorry, but a quick google shows that your cam has a usb id used by > various generic > cameras, including some microscopes, see: > http://blog.littleimpact.de/index.php/2011/10/16/using-biolux-nv-on-ubuntu-linux/ > > Enabling flippi

[PATCH] libv4l: add hflip quirk for dealextreme cam sku #44507

2012-01-02 Thread Vasily Khoruzhick
Signed-off-by: Vasily Khoruzhick --- lib/libv4lconvert/control/libv4lcontrol.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/lib/libv4lconvert/control/libv4lcontrol.c b/lib/libv4lconvert/control/libv4lcontrol.c index 12fa874..a9908ac 100644 --- a/lib/libv4lconvert

[REVIEW v4.1] v4l2 loopback

2009-05-17 Thread Vasily Levin
In this patch revision fixed complains from checkpatch.pl spell check of comments done v4 was wrong one --- This patch introduces v4l2 loopback module From: Vasily Levin This is v4l2 loopback driver which can be used to make available any userspace video as v4l2 device. Initially it was

[REVIEW v4] v4l2 loopback

2009-05-17 Thread Vasily Levin
In this patch revision fixed complains from checkpatch.pl spell check of comments done --- This patch introduces v4l2 loopback module From: Vasily Levin This is v4l2 loopback driver which can be used to make available any userspace video as v4l2 device. Initially it was written to make

Re: [REVIEW] v4l2 loopback

2009-05-06 Thread Vasily
This patch introduces v4l2 loopback module From: Vasily Levin This is v4l2 loopback driver which can be used to make available any userspace video as v4l2 device. Initialy it was written to make videoeffects available to Skype, but in fact it have many more uses. Priority: normal Signed-off

Re: [REVIEW] v4l2 loopback

2009-04-26 Thread Vasily
and for messages, may be I missed something? So can you tell please what I should use it for in loopback driver? Just add it to v4l2_loopback_device structure and registe it? --- This patch introduces v4l2 loopback module From: Vasily Levin This is v4l2 loopback driver which can be used to make

[REVIEW] v4l2 loopback

2009-03-26 Thread Vasily
Hello, please review the new version of v4l2 loopback driver. I fixed up comments to the previous submission, waiting for the new ones :-), reposting for patchwork tool --- This patch introduces v4l2 loopback module From: Vasily Levin This is v4l2 loopback driver which can be used to make