Re: [Security] [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-15 Thread Vasiliy Kulikov
enient for him. If sysfs is implemented via filesystem then it must support POSIX permissions semantic. MAC is very good in _some_ cases, but not instead of DAC. Thanks, -- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments -- To unsubscribe from thi

Re: [PATCH 00/20] world-writable files in sysfs and debugfs

2011-03-12 Thread Vasiliy Kulikov
> Vasiliy Kulikov (20): >  mach-ux500: mbox-db5500: world-writable sysfs fifo file >  leds: lp5521: world-writable sysfs engine* files >  leds: lp5523: world-writable engine* sysfs files >  misc: ep93xx_pwm: world-writable sysfs files >  rtc: rtc-ds1511: world-writable sysfs

[bug] radio: wl128x: sleep inside of spinlock

2011-03-12 Thread Vasiliy Kulikov
Hi, There is a copy_to_user() call inside of spin_lock_irqsave()/spin_unlock_irqrestore(): drivers/media/radio/wl128x/fmdrv_common.c: /* Copies RDS data from internal buffer to user buffer */ u32 fmc_transfer_rds_from_internal_buff(struct fmdev *fmdev, struct file *file, u8

[PATCH 00/20] world-writable files in sysfs and debugfs

2011-02-04 Thread Vasiliy Kulikov
le is ./staging/speakup/speakup.h, but it explitly calls macros as world-writable. I didn't check what speakup's world-writable files provide because it requires some knowledge about the hardware. Vasiliy Kulikov (20): mach-omap2: mux: world-writable debugfs files mach-omap2: pm:

[PATCH 07/20] video: sn9c102: world-wirtable sysfs files

2011-02-04 Thread Vasiliy Kulikov
Don't allow everybody to change video settings. Signed-off-by: Vasiliy Kulikov --- Compile tested only. drivers/media/video/sn9c102/sn9c102_core.c |6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/sn9c102/sn9c102_core.c b/drivers/media/

[BUG] media: dvb: dib9000: buggy locking

2011-01-19 Thread Vasiliy Kulikov
, then the code tries to release not holded mutex. This locking "style" is used all over the driver. Thanks, -- Vasiliy Kulikov http://www.openwall.com - bringing security into open computing environments -- To unsubscribe from this list: send the line "unsubscribe

Re: [patch] [media] av7110: make array offset unsigned

2011-01-07 Thread Vasiliy Kulikov
On Fri, Jan 07, 2011 at 16:51 +0300, Dan Carpenter wrote: > But just for my own understanding, why is it wrong to change an int to > an unsigned int in the userspace API? Who would notice? E.g. the same check in userspace (var < 0). If var has changed the sign then the result would differ. --

[PATCH v2] media: rc: ir-lirc-codec: fix integer overflow

2010-12-04 Thread Vasiliy Kulikov
er() call. However, it's better to prevent WARN() in kmalloc(). Signed-off-by: Vasiliy Kulikov --- Compile tested only. drivers/media/rc/ir-lirc-codec.c |3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers/media/rc/ir-lirc-cod

[PATCH] media: rc: ir-lirc-codec: fix potential integer overflow

2010-11-26 Thread Vasiliy Kulikov
int)) too. Signed-off-by: Vasiliy Kulikov --- Compile tested only. drivers/media/rc/ir-lirc-codec.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/media/rc/ir-lirc-codec.c b/drivers/media/rc/ir-lirc-codec.c index 1e87ee8..f011c5d 100644 --- a/drivers/media

[PATCH] media: rc: lirc_dev: check kobject_set_name() result

2010-11-26 Thread Vasiliy Kulikov
kobject_set_name() may fail with -ENOMEM, check for it. Signed-off-by: Vasiliy Kulikov --- Compile tested only. drivers/media/rc/lirc_dev.c |4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/drivers/media/rc/lirc_dev.c b/drivers/media/rc/lirc_dev.c index 8418b14

[PATCH] media: video: pvrusb2: fix memory leak

2010-11-19 Thread Vasiliy Kulikov
Use put_device() instead of kfree() because of device name leak. Signed-off-by: Vasiliy Kulikov --- Compile tested only. drivers/media/video/pvrusb2/pvrusb2-sysfs.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/pvrusb2/pvrusb2-sysfs.c b/drivers