[PATCH 2/2] vivid: Add touch support

2019-10-22 Thread Vandana BN
Support to emulate touch devices in vivid driver. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 3 +- drivers/media/platform/vivid/vivid-core.c | 134 ++- drivers/media/platform/vivid/vivid-core.h | 18 ++ drivers/media/platform/vivid/vivid

[PATCH 1/2] v4l2-core: fix touch support in v4l_g_fmt

2019-10-22 Thread Vandana BN
v4l_s_fmt, for VFL_TYPE_TOUCH, sets unneeded members of the v4l2_pix_format structure to default values.This was missing in v4l_g_fmt, which would lead to failures in v4l2-compliance tests. Signed-off-by: Vandana BN --- drivers/media/v4l2-core/v4l2-ioctl.c | 33 +++- 1

[PATCH 0/2] vivid: Support for touch device

2019-10-22 Thread Vandana BN
This patch adds support for touch devices in the vivid driver. Current code provides a framework for touch support and passes compliance tests. TODO: Add touch emulation. Thank you. Regards, Vandana. Vandana BN (2): v4l2-core: fix touch support in v4l_g_fmt vivid: Add touch support drivers

[PATCH v3] Documentation:media:v4l2:Add vivid metadata doc

2019-10-16 Thread Vandana BN
Adds new file for describing new metadata format V4L2_META_FMT_VIVID added in vivid driver. Signed-off-by: Vandana BN --- Change in V3 - modified pixfmt-meta-vivid.rst to have dual GFDL and GPL license. --- Documentation/media/uapi/v4l/meta-formats.rst | 1 + .../media/uapi/v4l/pixfmt-meta

[PATCH v3] v4l2-ctl: support for metadata output

2019-10-15 Thread Vandana BN
Adds support to test metadata output format V4L2_META_FMT_VIVID. Signed-off-by: Vandana BN --- Changes in V3: simplified meta_fillbuffer(), also ensure the brightness and contrast values are in range 64-255. --- contrib/freebsd/include/linux/videodev2.h | 1 + include/linux/videodev2.h

[PATCH v11 2/3] v4l2-core: Add new metadata format

2019-10-15 Thread Vandana BN
Add new metadata format to support metadata output in vivid. Signed-off-by: Vandana BN --- drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2

[PATCH v11 1/3] vivid: Add metadata capture support

2019-10-15 Thread Vandana BN
This patch adds meatadata capture support in vivid driver. Adds new files for metadata capture. Adds vivid controls to generate PTS and SCR for metadata stream. also fixes v4l2-compliance issues seen on metadata device. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile

[PATCH v11 3/3] vivid: Add metadata output support

2019-10-15 Thread Vandana BN
Support metadata output in vivid driver. Metadata output is used to set brightness, contrast, saturation and hue. Adds new files for metadata output. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c | 98

[PATCH v11 0/3] vivid: Metadata support

2019-10-15 Thread Vandana BN
brightness, contrast, sturation and hue. Changes in V11: fix in metadata output patch to correctly update sequence. fix in metadata capture patch updating description of node_types in module patameter. Regards, Vandana. Vandana BN (3): vivid: Add metadata capture support v4l2-core

[PATCH v10 1/3] vivid: Add metadata capture support

2019-10-08 Thread Vandana BN
This patch adds meatadata capture support in vivid driver. Adds new files for metadata capture. Adds vivid controls to generate PTS and SCR for metadata stream. also fixes v4l2-compliance issues seen on metadata device. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile

[PATCH v10 0/3] vivid: Metadata support

2019-10-08 Thread Vandana BN
brightness, contrast, sturation and hue. Regards, Vandana. Vandana BN (3): vivid: Add metadata capture support v4l2-core: Add new metadata format vivid: Add metadata output support drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c | 197

[PATCH v10 3/3] vivid: Add metadata output support

2019-10-08 Thread Vandana BN
Support metadata output in vivid driver. Metadata output is used to set brightness, contrast, saturation and hue. Adds new files for metadata output. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c | 98

[PATCH v10 2/3] v4l2-core: Add new metadata format

2019-10-08 Thread Vandana BN
Add new metadata format to support metadata output in vivid. Signed-off-by: Vandana BN --- drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2

[PATCH v2] Documentation:media:v4l2:Add vivid metadata doc

2019-10-04 Thread Vandana BN
Adds new file for describing new metadata format V4L2_META_FMT_VIVID added in vivid driver. Signed-off-by: Vandana BN --- Documentation/media/uapi/v4l/meta-formats.rst | 1 + .../media/uapi/v4l/pixfmt-meta-vivid.rst | 43 +++ 2 files changed, 44 insertions(+) create mode

[PATCH v3 2/2] vivid: Add metadata output support

2019-10-04 Thread Vandana BN
Support metadata output in vivid driver. Metadata output is used to set brightness, contrast, saturation and hue. Adds new files for metadata output. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c | 98

[PATCH v3 1/2] v4l2-core: Add new metadata format

2019-10-04 Thread Vandana BN
Add new metadata format to support metadata output in vivid. Signed-off-by: Vandana BN --- drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2

[PATCH v3 0/2] vivid: Metadata output support

2019-10-04 Thread Vandana BN
This patch adds metadata output support in vivid driver. New metadata format V4L2_META_FMT_VIVID is added, which is used to set brightness, contrast, sturation and hue. V2 has changes in metadata output structure and metadata format define. V3 addresses review comments. Regards, Vandana. Vandana

[PATCH] Documentation:media:v4l2:Add vivid metadata doc

2019-10-04 Thread Vandana BN
Adds new file for describing new metadata format V4L2_META_FMT_VIVID added in vivid driver. Signed-off-by: Vandana BN --- Documentation/media/uapi/v4l/meta-formats.rst | 1 + .../media/uapi/v4l/pixfmt-meta-vivid.rst | 43 +++ 2 files changed, 44 insertions(+) create mode

[PATCH v9] vivid: Add metadata capture support

2019-10-04 Thread Vandana BN
This patch adds meatadata capture support in vivid driver. Adds new files for metadata capture. Adds vivid controls to generate PTS and SCR for metadata stream. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c

[PATCH v8] vivid: Add metadata capture support

2019-10-04 Thread Vandana BN
This patch adds meatadata capture support in vivid driver. Adds new files for metadata capture. Adds vivid controls to generate PTS and SCR for metadata stream. Signed-off-by: Vandana BN --- V8 - squash commit:fixes for v4l2-compliance issues. --- drivers/media/platform/vivid/Makefile

[PATCH v2 2/2] vivid: Add metadata output support

2019-10-03 Thread Vandana BN
Support metadata output in vivid driver. Metadata output is used to set brightness, contrast, saturation and hue. Adds new files for metadata output. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c | 98

[PATCH v2 1/2] v4l2-core: Add new metadata format

2019-10-03 Thread Vandana BN
Add new metadata format to support metadata output in vivid. Signed-off-by: Vandana BN --- drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2

[PATCH v2 0/2] vivid: Metadata output support

2019-10-03 Thread Vandana BN
This patch adds metadata output support in vivid driver. New metadata format V4L2_META_FMT_VIVID is added, which is used to set brightness, contrast, sturation and hue. V2 has changes in metadata output structure and metadata format define. Regards, Vandana. Vandana BN (2): v4l2-core: Add new

[PATCH v2] v4l2-ctl: support for metadata output

2019-10-03 Thread Vandana BN
Adds support to test metadata output format V4L2_META_FMT_VIVID. Signed-off-by: Vandana BN --- contrib/freebsd/include/linux/videodev2.h | 1 + include/linux/videodev2.h | 1 + utils/v4l2-ctl/v4l2-ctl-meta.cpp | 35 +++ utils/v4l2-ctl/v4l2-ctl

[PATCH 0/2] vivid: Metadata output support

2019-10-03 Thread Vandana BN
This patch adds metadata output support in vivid driver. New metadata format V4L2_META_FMT_VIVID is added, which is used to set brightness, contrast, sturation and hue. Regards, Vandana. Vandana BN (2): v4l2-core: Add new metadata format vivid: Add metadata output support drivers/media

[PATCH 1/2] v4l2-core: Add new metadata format

2019-10-03 Thread Vandana BN
Add new metadata format to support metadata output in vivid. Signed-off-by: Vandana BN --- drivers/media/v4l2-core/v4l2-ioctl.c | 1 + include/uapi/linux/videodev2.h | 1 + 2 files changed, 2 insertions(+) diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c b/drivers/media/v4l2-core/v4l2

[PATCH 2/2] vivid: Add metadata output support

2019-10-03 Thread Vandana BN
Support metadata output in vivid driver. Metadata output is used to set brightness, contrast, saturation and hue. Adds new files for metadata output. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c | 98

[PATCH] v4l2-ctl: support for metadata output

2019-10-03 Thread Vandana BN
Adds support to test metadata output format V4L2_META_FMT_VIVID. Signed-off-by: Vandana BN --- contrib/freebsd/include/linux/videodev2.h | 1 + include/linux/videodev2.h | 1 + utils/v4l2-ctl/v4l2-ctl-meta.cpp | 31 +++ utils/v4l2-ctl/v4l2-ctl

[PATCH] v4l2-compliance: fix metadata output support

2019-10-03 Thread Vandana BN
This patch fixes test failure in the v4l2-compliance for metadata output support. Signed-off-by: Vandana BN --- utils/v4l2-compliance/v4l2-compliance.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/utils/v4l2-compliance/v4l2-compliance.cpp b/utils/v4l2-compliance/v4l2

[PATCH v2] v4l2-compliance: Verify metadata formats

2019-09-25 Thread Vandana BN
Metadata formats may not be defined for a given input or output type. This patch checks, if given input/output type enumerates metadata formats and validates G_FMT accordingly. Signed-off-by: Vandana BN --- utils/v4l2-compliance/v4l2-test-formats.cpp | 17 + 1 file changed, 13

[PATCH v7 2/2] vivid: fixes for v4l2-compliance issues.

2019-09-25 Thread Vandana BN
From: Hans Verkuil This patch fixes v4l2-compliance issues seen on metadata device. Signed-off-by: Hans Verkuil --- drivers/media/platform/vivid/vivid-core.c | 16 +++- drivers/media/platform/vivid/vivid-meta-cap.c | 2 +- drivers/media/platform/vivid/vivid-vid-cap.c | 5 +++

[PATCH v7 0/2] vivid: Add metadata capture support

2019-09-25 Thread Vandana BN
. Vandana BN (1): vivid: Add metadata capture support drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c | 107 +- drivers/media/platform/vivid/vivid-core.h | 14 ++ drivers/media/platform/vivid/vivid-ctrls.c| 64

[PATCH v7 1/2] vivid: Add metadata capture support

2019-09-25 Thread Vandana BN
This patch adds meatadata capture support in vivid driver. Adds new files for metadata capture. Adds vivid controls to generate PTS and SCR for metadata stream. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c

[PATCH v8] v4l2-ctl: Print UVC meta info

2019-09-24 Thread Vandana BN
Print UVC Metadata information in verbose mode. Signed-off-by: Vandana BN --- Changes since v7: Not to call print_meta_buffer, if V4L2_BUF_FLAG_ERROR is set or bytesused is 0. Changes since v6: Not to print PTS/SCR if not present. Remove loop in print_meta_buffer

[PATCH] v4l2-compliance: Verify metadata formats

2019-09-24 Thread Vandana BN
changes to testEnumFormats() and testGetFormats() to verify METADATA type. G_FMT sets node->valid_buftypes, so TRY/S_FMT does not get called for other input types, hence did not modify them. Signed-off-by: Vandana BN --- utils/v4l2-compliance/v4l2-test-formats.cpp | 17 + 1 f

[PATCH v7] v4l2-ctl: Print UVC meta info

2019-09-24 Thread Vandana BN
Print UVC Metadata information in verbose mode. Signed-off-by: Vandana BN --- Changes since v6: Not to print PTS/SCR if not present. Remove loop in print_meta_buffer() Changes since v5: Use proper print format. split fprintf. Changes since v4: Print PTS

[PATCH v6] v4l2-ctl: Print UVC meta info

2019-09-24 Thread Vandana BN
Print UVC Metadata information in verbose mode. Signed-off-by: Vandana BN --- Changes since v5: Use proper print format. split fprintf. Changes since v4: Print PTS and SCR info. --- utils/v4l2-ctl/v4l2-ctl-meta.cpp | 45 +++ utils/v4l2-ctl

[PATCH v5] v4l2-ctl: Print UVC meta info

2019-09-24 Thread Vandana BN
Print UVC Metadata information in verbose mode. Signed-off-by: Vandana BN --- Changes since v4: Print PTS and SCR info. --- utils/v4l2-ctl/v4l2-ctl-meta.cpp | 42 +++ utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 14 + utils/v4l2-ctl/v4l2-ctl.h

[PATCH v4] v4l2-ctl: Print UVC meta info

2019-09-17 Thread Vandana BN
Print UVC Metadata information in verbose mode. Signed-off-by: Vandana BN --- Changes since v3: - Coding style corrections in print_meta_buffer. --- utils/v4l2-ctl/v4l2-ctl-meta.cpp | 27 +++ utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 14 -- utils/v4l2-ctl

[PATCH v3] v4l2-ctl: Print UVC meta info

2019-09-16 Thread Vandana BN
Print UVC Metadata information in verbose mode. Signed-off-by: Vandana BN --- Changes since v2 - Converted if to switch statement. - Corrected format specifier in print. --- utils/v4l2-ctl/v4l2-ctl-meta.cpp | 25 + utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 14

[PATCH v2] v4l2-ctl: Print UVC meta info

2019-09-16 Thread Vandana BN
Print UVC Metadata information in verbose mode. Signed-off-by: Vandana BN --- Changes since v1 - Removed static form type declaration of structure vivid_uvc_meta_buf. - to print time in seconds. - extract vivid_uvc_meta_buf properly from buf. --- utils/v4l2-ctl/v4l2-ctl-meta.cpp | 22

[PATCH v6] vivid: Add metadata capture support

2019-09-16 Thread Vandana BN
This patch adds meatadata capture support in vivid driver. Added new files for metadata capture. Signed-off-by: Vandana BN --- Changes since v5: -Use multiline comment in vivid-core.c. -changed vivid_meta_cap_gen() to take proper length. --- drivers/media/platform/vivid/Makefile | 2

[PATCH v5] vivid: Add metadata capture support

2019-09-16 Thread Vandana BN
This patch adds meatadata capture support in vivid driver. Added new files for metadata capture. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c | 92 - drivers/media/platform/vivid/vivid-core.h

[PATCH v3] v4l2-core: Add metadata type to vfl_devnode_type

2019-09-12 Thread Vandana BN
Add VFL_TYPE_METADATA, to detect devices of type metadata and to disable unneeded ioctls. Without this change, format ioctls for both video and metadata devices could be called on both device nodes.This is true for other ioctls as well. Signed-off-by: Vandana BN --- V3 Updated commit message

[PATCH v2] v4l2-core: Add metadata type to vfl_devnode_type.

2019-09-12 Thread Vandana BN
Add VFL_TYPE_METADATA, to detect devices of type metadata and to disable unneeded ioctls. Signed-off-by: Vandana BN --- drivers/media/v4l2-core/v4l2-dev.c | 57 ++-- drivers/media/v4l2-core/v4l2-ioctl.c | 5 ++- include/media/v4l2-dev.h | 2 + 3 files

[PATCH v4] vivid: Add metadata capture support

2019-09-11 Thread Vandana BN
This patch adds meatadata capture support in vivid driver. Added new files for metadata capture. Signed-off-by: Vandana BN --- v2 Add UVC metadata structure. v3 Use correct metadata size. v4 use VFL_TYPE_METADATA. drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform

[PATCH] uvc/vsp1/ipu3: use VFL_TYPE_METADATA for metadata device.

2019-09-11 Thread Vandana BN
Use vfl_type VFL_TYPE_METADATA instead of VFL_TYPE_GRABBER for metadata device. Signed-off-by: Vandana BN --- drivers/media/platform/vsp1/vsp1_histo.c | 4 ++-- drivers/media/usb/uvc/uvc_driver.c | 4 +++- drivers/staging/media/ipu3/ipu3-v4l2.c | 8 +++- 3 files changed, 12

[PATCH] v4l2-core: Add metadata type to vfl_devnode_type.

2019-09-10 Thread Vandana BN
Add VFL_TYPE_METADATA, to detect devices of type metadata and to disable unneeded ioctls. Signed-off-by: Vandana BN --- drivers/media/v4l2-core/v4l2-dev.c | 57 ++-- drivers/media/v4l2-core/v4l2-ioctl.c | 5 ++- include/media/v4l2-dev.h | 2 + 3 files

[PATCH v3] vivid: Add metadata capture support

2019-09-09 Thread Vandana BN
This patch adds meatadata capture support in vivid driver. Added new files for metadata capture. Signed-off-by: Vandana BN --- v2 Add UVC metadata structure. v3 Use correct metadata size. drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c

[PATCH v2] vivid: Set vid_cap_streaming and vid_out_streaming to true

2019-09-09 Thread Vandana BN
Verkuil it appears that these 'if (dev->kthread_vid_cap)' checks are a left-over from the original vivid development and should never have been there. Signed-off-by: Vandana BN Cc: # for v3.18 and up --- drivers/media/platform/vivid/vivid-vid-cap.c | 3 --- drivers/media/platform/vi

[PATCH] vivid: Set vid_cap_streaming and vid_out_streaming to true

2019-09-09 Thread Vandana BN
: Vandana BN --- drivers/media/platform/vivid/vivid-vid-cap.c | 3 --- drivers/media/platform/vivid/vivid-vid-out.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/drivers/media/platform/vivid/vivid-vid-cap.c b/drivers/media/platform/vivid/vivid-vid-cap.c index 8cbaa0c998ed..2d030732feac

[PATCH] v4l2-ctl: Print UVC meta info

2019-09-03 Thread Vandana BN
Print UVC Metadata information in verbose mode. Signed-off-by: Vandana BN --- utils/v4l2-ctl/v4l2-ctl-meta.cpp | 20 utils/v4l2-ctl/v4l2-ctl-streaming.cpp | 14 -- utils/v4l2-ctl/v4l2-ctl.h | 1 + 3 files changed, 29 insertions(+), 6 deletions

[PATCH v2] vivid: Add metadata capture support

2019-09-03 Thread Vandana BN
This patch adds meatadata capture support in vivid driver. Added new files for metadata capture. Signed-off-by: Vandana BN --- drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c | 90 - drivers/media/platform/vivid/vivid-core.h

Re: [PATCH] media:dvb-frontends:Return if Max devices are added in dvb_pll_attach().

2019-07-19 Thread Vandana BN
On 19/07/19 7:11 AM, Akihiro TSUKADA wrote: >> Will it be better, if dvb_pll_devcount is decremented in dvb_pll_release(),  >> instead of removing module params? > But you cannot know deterministically which device corrensponds to > what "id" (when you have multiple dvb_pll devices), > since "id

Re: [PATCH] media:dvb-frontends:Return if Max devices are added in dvb_pll_attach().

2019-07-18 Thread Vandana BN
On 18/07/19 6:05 AM, Akihiro TSUKADA wrote: > Hi, > >> diff --git a/drivers/media/dvb-frontends/dvb-pll.c >> b/drivers/media/dvb-frontends/dvb-pll.c >> index ba0c49107bd2..c850f1d69bce 100644 >> --- a/drivers/media/dvb-frontends/dvb-pll.c >> +++ b/drivers/media/dvb-frontends/dvb-pll.c >> @@ -788