Re: [PATCH v2 08/12] intel-ipu3: params: compute and program ccs

On Wed, 2017-10-11 at 16:31 +0300, Andy Shevchenko wrote: > On Wed, Oct 11, 2017 at 10:29 AM, sakari.ai...@linux.intel.com > wrote: > > On Wed, Oct 11, 2017 at 04:14:37AM +, Zhi, Yong wrote: > > > > > +static unsigned int ipu3_css_scaler_get_exp(unsigned int > > > > > counter, > > > > > + 

Re: [PATCH v2 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Tomasz, On Monday, June 12, 2017 18:59:18 Tomasz Figa wrote: > By any chance, doesn't the hardware provide some simple mode for > contiguous buffers? Since we have an MMU anyway, we could use > vb2_dma_contig and simplify the code significantly. In IPU3 the CIO2 (CSI-2 receiver) and the IMGU (

Re: [PATCH 02/12] intel-ipu3: mmu: implement driver

Hi Tomasz, Couple of small comments below. On Wednesday, June 07, 2017 17:35:13 Tomasz Figa wrote: > >> +static void ipu3_mmu_domain_free(struct iommu_domain *dom) > >> +{ > >> + struct ipu3_mmu_domain *mmu_dom = > >> + container_of(dom, struct ipu3_mmu_domain, domain); > >> +

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

Hi Sakari, On Wednesday, May 03, 2017 11:58:01 Sakari Ailus wrote: > Hi Yong, > > A few more minor comments below... > > On Sat, Apr 29, 2017 at 06:34:36PM -0500, Yong Zhi wrote: > ... > > +/*** V4L2 sub-device asynchronous registration callbacks***/ > > + > > +static struct cio2_que

Re: [PATCH 3/3] [media] intel-ipu3: cio2: Add new MIPI-CSI2 driver

URPOSE. See the > > + * GNU General Public License for more details. > > + * > > + * Based partially on Intel IPU4 driver written by > > + * Sakari Ailus > > + * Samu Onkalo > > + * Jouni Högander > > + * Jouni Ukkonen > > + * Antti Laakso > > + *

[PATCH] [media] v4l2-async: failing functions shouldn't have side effects

eral other cases where a failing function could leave nodes into a linked list while the caller might free the node due to a failure. Signed-off-by: Tuukka Toivonen --- drivers/media/v4l2-core/v4l2-async.c | 21 +++-- 1 file changed, 11 insertions(+), 10 deletions(-) diff --git

[yavta PATCH v2] Return proper error code if STREAMON fails

Return the error code if video_enable() and VIDIOC_STREAMON fails. Signed-off-by: Tuukka Toivonen --- yavta.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/yavta.c b/yavta.c index b627725..3d80d3c 100644 --- a/yavta.c +++ b/yavta.c @@ -1708,7 +1708,9 @@ static int

Re: [yavta PATCH] Return proper error code if STREAMON fails

Hi, Thanks for your feedback. On Saturday, December 12, 2015 17:40:07 Laurent Pinchart wrote: > I wonder if there's really a point calling video_free_buffers() in the > error case. The function will return an error causing the caller to > close the device, which will free the buffers. There are o

[yavta PATCH] Return proper error code if STREAMON fails

Fix the bug causing success to be returned even if VIDIOC_STREAMON failed. Also check returned error from VIDIOC_STREAMOFF. Signed-off-by: Tuukka Toivonen --- yavta.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/yavta.c b/yavta.c index b627725..3ad1c97 100644

Re: [ANN] Notes on IRC meeting on new sensor control interface, 2012-01-09 14:00 GMT+2

On Tuesday 10 January 2012 12:05:48 Laurent Pinchart wrote: > > > That was my question, how does the user decide whether hblank or vblank > > > is preferred ? > > > > I think that should be defined in the configuration itself. It's very > > unlikely there's any need to change this dynamically. >

Re: [ANN] Meeting minutes of the Cambourne meeting

On Tuesday, August 09, 2011 06:36:19 pm nitesh moundekar wrote: > I am worried about direction v4l2 is taking. It looks against the basic > principle of driver i.e. hardware abstraction. There definitely should be an API which is hardware independent. However, the problem is that the hardware is