Hello,
On 03/01/2017 11:35 AM, Nicolas Dufresne wrote:
Le mercredi 01 mars 2017 à 14:12 +0100, Andrzej Hajda a écrit :
On 01.03.2017 12:51, Thibault Saunier wrote:
It is required by the standard that the field order is set by the
driver, default to NONE in case any is provided, but we can
Hello,
On 03/01/2017 10:12 AM, Andrzej Hajda wrote:
On 01.03.2017 12:51, Thibault Saunier wrote:
It is required by the standard that the field order is set by the
driver, default to NONE in case any is provided, but we can basically
accept any value provided by the userspace as we will anyway
colorspace do no make it up, we might
later while processing need to figure out the colorspace, which
is possible depending on the frame size but do not ever guess and
leak that guess to the userspace.
Signed-off-by: Javier Martinez Canillas
Signed-off-by: Thibault Saunier
Reviewed-by: And
provided
by userspace from the output to the capture side of the device so
that the information is given back to userspace. This way it can
handle it and potentially deinterlace afterward.
Signed-off-by: Thibault Saunier
---
Changes in v6:
- Pass user output field value to the capture as the
cate users value on the capture side.
This is the sixth version of the patch serie.
Best regards,
Thibault Saunier
Changes in v6:
- Do not ever guess colorspace
- Pass user output field value to the capture as the device is not
doing any deinterlacing and thus decoded content will still be
int
On 02/22/2017 05:03 PM, Nicolas Dufresne wrote:
Le mercredi 22 février 2017 à 15:57 -0300, Thibault Saunier a écrit :
On 02/22/2017 03:06 PM, Hans Verkuil wrote:
On 02/22/2017 05:05 AM, Thibault Saunier wrote:
Hello,
On 02/21/2017 11:19 PM, Hans Verkuil wrote:
On 02/21/2017 11:20 AM
On 02/22/2017 03:06 PM, Hans Verkuil wrote:
On 02/22/2017 05:05 AM, Thibault Saunier wrote:
Hello,
On 02/21/2017 11:19 PM, Hans Verkuil wrote:
On 02/21/2017 11:20 AM, Thibault Saunier wrote:
Use colorspace provided by the user as we are only doing scaling and
color encoding conversion, we
Hello,
On 02/22/2017 06:29 AM, Andrzej Hajda wrote:
On 21.02.2017 20:20, Thibault Saunier wrote:
It is required by the standard that the field order is set by the
driver.
Signed-off-by: Thibault Saunier
---
Changes in v5:
- Just adapt the field and never error out.
Changes in v4: None
Hello,
On 02/21/2017 11:19 PM, Hans Verkuil wrote:
On 02/21/2017 11:20 AM, Thibault Saunier wrote:
Use colorspace provided by the user as we are only doing scaling and
color encoding conversion, we won't be able to transform the colorspace
itself and the colorspace won't mat
It is required by the standard that the field order is set by the
driver.
Signed-off-by: Thibault Saunier
---
Changes in v5:
- Just adapt the field and never error out.
Changes in v4: None
Changes in v3:
- Do not check values in the g_fmt functions as Andrzej explained in previous
review
ed by
EIA CEA 861B.
Signed-off-by: Thibault Saunier
---
Changes in v5: None
Changes in v4:
- Set the colorspace only if the user passed V4L2_COLORSPACE_DEFAULT, in
all other cases just use what userspace provided.
Changes in v3:
- Do not check values in the g_fmt functions as Andrzej explain
REC709 colorspace.
Signed-off-by: Javier Martinez Canillas
Signed-off-by: Thibault Saunier
Reviewed-by: Andrzej Hajda
---
Changes in v5:
- Squash commit to always use output colorspace on the capture side
inside this one
- Fix typo in commit message
Changes in v4:
- Reword commit message
GStreamer
spamming error at us about the driver not following the standard.
This is the fifth version of the patch serie.
Best regards,
Thibault Saunier
Changes in v5:
- Squash commit to always use output colorspace on the capture side
inside this one
- Fix typo in commit message
- Just adapt the
Hello Andrzej,
On 02/21/2017 06:56 AM, Andrzej Hajda wrote:
On 13.02.2017 20:08, Thibault Saunier wrote:
From: Javier Martinez Canillas
The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace
should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV. But drivers
don&#
GStreamer
spamming error at us about the driver not following the standard.
This is the third version of the patch serie.
Best regards,
Thibault Saunier
Changes in v4:
- Reword commit message to better back our assumptions on specifications
- Use any colorspace provided by the user as it won't
ed by
EIA CEA 861B.
Signed-off-by: Thibault Saunier
---
Changes in v4:
- Set the colorspace only if the user passed V4L2_COLORSPACE_DEFAULT, in
all other cases just use what userspace provided.
Changes in v3:
- Do not check values in the g_fmt functions as Andrzej explained in previous
r
SPACE_REC709 colorspace.
Signed-off-by: Javier Martinez Canillas
Signed-off-by: Thibault Saunier
Reviewed-by: Andrzej Hajda
---
Changes in v4:
- Reword commit message to better back our assumptions on specifications
Changes in v3:
- Do not check values in the g_fmt functions as Andrzej explai
It is required by the standard that the field order is set by the
driver.
Signed-off-by: Thibault Saunier
---
Changes in v4: None
Changes in v3:
- Do not check values in the g_fmt functions as Andrzej explained in previous
review
Changes in v2:
- Fix a silly build error that slipped in while
User userspace provided by the user as we are only doing scaling and
color encoding conversion, we won't be able to transform the colorspace
itself and the colorspace won't mater in that operation.
Also always use output colorspace on the capture side.
Signed-off-by: Thibau
On 02/10/2017 12:07 PM, Hans Verkuil wrote:
On 02/10/2017 03:10 PM, Thibault Saunier wrote:
From: Javier Martinez Canillas
The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace
should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV. But drivers
don't agree o
If the colorspace is specified by userspace we should respect
it and not reset it ourself if we can support it.
Signed-off-by: Thibault Saunier
---
Changes in v3:
- Do not check values in the g_fmt functions as Andrzej explained in previous
review
- Set colorspace if user passed
stead unconditionally setting
the V4L2_COLORSPACE_REC709 colorspace.
Signed-off-by: Javier Martinez Canillas
Reviewed-by: Andrzej Hajda
Signed-off-by: Thibault Saunier
---
Changes in v3:
- Do not check values in the g_fmt functions as Andrzej explained in previous
review
- Added 'R
GStreamer
spamming error at us about the driver not following the standard.
This is the third version of the patch serie.
Best regards,
Thibault Saunier
Changes in v3:
- Added 'Reviewed-by: Andrzej Hajda '
- Do not check values in the g_fmt functions as Andrzej explained in previous
rev
The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace
should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV but the driver
didn't set the colorimetry, also respect usespace setting.
Use 576p display resolution as a threshold to set this.
Signed-off-by: Thibault Sa
It is required by the standard that the field order is set by the
driver.
Signed-off-by: Thibault Saunier
---
Changes in v3:
- Do not check values in the g_fmt functions as Andrzej explained in previous
review
Changes in v2:
- Fix a silly build error that slipped in while rebasing the
If the colorspace is specified by userspace we should respect
it and not reset it ourself if we can support it.
Signed-off-by: Thibault Saunier
---
drivers/media/platform/exynos-gsc/gsc-core.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers
From: Javier Martinez Canillas
The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace
should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV. But drivers
don't agree on the display resolution that should be used as a threshold.
Some drivers set V4L2_COLORSPACE_REC709 for
It is required by the standard that the field order is set by the
driver.
Signed-off-by: Thibault Saunier
---
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
b
The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace
should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV but the driver
didn't set the colorimetry, also respect usespace setting.
Use 576p display resolution as a threshold to set this.
Signed-off-by: Thibault Sa
GStreamer
spamming error at us about the driver not following the standard.
Best regards,
Thibault Saunier
Javier Martinez Canillas (1):
[media] exynos-gsc: Use 576p instead 720p as a threshold for
colorspaces
Thibault Saunier (3):
[media] exynos-gsc: Respect userspace colorspace settin
If the colorspace is specified by userspace we should respect
it and not reset it ourself if we can support it.
Signed-off-by: Thibault Saunier
---
drivers/media/platform/exynos-gsc/gsc-core.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/drivers
Changes since v1:
- Fix a silly build error that slipped in while rebasing the patches
Javier Martinez Canillas (1):
[media] exynos-gsc: Use 576p instead 720p as a threshold for
colorspaces
Thibault Saunier (3):
[media] exynos-gsc: Respect userspace colorspace setting
[media] s5p-mfc
The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace
should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV but the driver
didn't set the colorimetry, also respect usespace setting.
Use 576p display resolution as a threshold to set this.
Signed-off-by: Thibault Sa
It is required by the standard that the field order is set by the
driver.
Signed-off-by: Thibault Saunier
---
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 23 +--
1 file changed, 21 insertions(+), 2 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_dec.c
b
From: Javier Martinez Canillas
The media documentation says that the V4L2_COLORSPACE_SMPTE170M colorspace
should be used for SDTV and V4L2_COLORSPACE_REC709 for HDTV. But drivers
don't agree on the display resolution that should be used as a threshold.
Some drivers set V4L2_COLORSPACE_REC709 for
35 matches
Mail list logo
