Re: Status of the patches under review at LMML (35 patches)

2013-01-24 Thread Steinar H. Gunderson
On Thu, Jan 24, 2013 at 06:39:57PM -0200, Mauro Carvalho Chehab wrote: > Steinar, > > Please see the comments below. Hi, I've given up getting DVB in Linux to work long time ago; if you do not want the patches as-is, feel free to reject them. /* Steinar */ -- Homepage: http://www.sesse.net/ --

Re: [PATCH] Various fixes, hacks and patches for Mantis CA support.

2012-04-18 Thread Steinar H. Gunderson
On Wed, Apr 18, 2012 at 08:38:10PM +0200, Ninja wrote: > sorry for the late response. Unfortunately my Skystar HD2 died on me > and it looks like i get an other card in exchange. > Anyway, as far I could test, the patches were ok to me. I can still > put my marks, but I'm not sure which ones I shou

Re: [PATCH 04/11] Show timeouts on I2C transfers.

2012-04-04 Thread Steinar H. Gunderson
On Wed, Apr 04, 2012 at 06:43:11PM +0300, Marko Ristola wrote: > I wrote a patch that uses I2C IRQ. > I had a feeling that it worked well (with old single CPU desktop computer): > framerate with HDTV was low, but it was glitchless. > > Do you want to have the patch to be sent for you? Sure, send

[PATCH 10/11] Ignore timeouts waiting for the IRQ0 flag.

2012-04-01 Thread Steinar H. Gunderson
From: "Steinar H. Gunderson" As others have noticed, sometimes, especially during DMA transfers, the IRQ0 flag is never properly set and thus reads never return. (The typical case for this is when we've just done a write and the en50221 thread is waiting for the CAM status

[PATCH 09/11] Correct wait_event_timeout error return check.

2012-04-01 Thread Steinar H. Gunderson
From: "Steinar H. Gunderson" wait_event_timeout() returns 0 on timeout, not -ERESTARTSYS. Note that since this actually causes timeouts to be handled, it makes the CA situation a lot worse without the next patch in the series. --- drivers/media/dvb/mantis/mantis_hif.c |4 ++

[PATCH 11/11] Enable Mantis CA support.

2012-04-01 Thread Steinar H. Gunderson
From: "Steinar H. Gunderson" Not my patch originally; picked up from verbal descriptions on the linux-media list, and fixed up slightly. Signed-off-by: Steinar H. Gunderson --- drivers/media/dvb/mantis/mantis_ca.c |4 +++- drivers/media/dvb/mantis/mantis_cor

[PATCH 07/11] Fix a ton of SMP-unsafe accesses.

2012-04-01 Thread Steinar H. Gunderson
From: "Steinar H. Gunderson" Basically a lot of the members of mantis_ca were accessed from several threads without a mutex, which is a big no-no; I've mostly changed to using atomic operations here, although I also added some locks were it made sense (e.g. when resetting the CAM

[PATCH 08/11] Remove some unused structure members.

2012-04-01 Thread Steinar H. Gunderson
From: "Steinar H. Gunderson" Signed-off-by: Steinar H. Gunderson --- drivers/media/dvb/mantis/mantis_evm.c | 12 drivers/media/dvb/mantis/mantis_link.h |8 2 files changed, 4 insertions(+), 16 deletions(-) diff --git a/drivers/media/dvb/mantis/manti

[PATCH 01/11] Don't reset IRQ0 if it's not already set.

2012-04-01 Thread Steinar H. Gunderson
From: "Steinar H. Gunderson" By Marko Ristola; see http://patchwork.linuxtv.org/patch/8776/ . Signed-off-by: Steinar H. Gunderson --- drivers/media/dvb/mantis/mantis_cards.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/drivers/media/

[PATCH 06/11] Replace ca_lock by a slightly more general int_stat_lock.

2012-04-01 Thread Steinar H. Gunderson
From: "Steinar H. Gunderson" This lock is ideally held when banging on MANTIS_INT_STAT. (I have no hardware documentation, so I'm afraid I don't really know the specifics here.) Signed-off-by: Steinar H. Gunderson --- drivers/media/dvb/mantis/mantis_ca.c |2 -

[PATCH 04/11] Show timeouts on I2C transfers.

2012-04-01 Thread Steinar H. Gunderson
From: "Steinar H. Gunderson" On I2C reads and writes, show if we had any timeouts in the debug output. Signed-off-by: Steinar H. Gunderson --- drivers/media/dvb/mantis/mantis_i2c.c | 26 -- 1 file changed, 24 insertions(+), 2 deletions(-) diff --git a/dri

[PATCH 05/11] Slightly more friendly debugging output.

2012-04-01 Thread Steinar H. Gunderson
From: "Steinar H. Gunderson" Say what address we read/write from/to. This is useful when trying to trace where the debug output comes from, and which accesses fail, if any. Signed-off-by: Steinar H. Gunderson --- drivers/media/dvb/mantis/mantis_hif.c |9 + 1 file

[PATCH 02/11] Clear out MANTIS_INT_RISCSTAT when printing status bits.

2012-04-01 Thread Steinar H. Gunderson
From: "Steinar H. Gunderson" Clear out MANTIS_INT_RISCSTAT for debugging, so that status words from the RISC do not show up as "Unknown" bits in the debug display. Signed-off-by: Steinar H. Gunderson --- drivers/media/dvb/mantis/mantis_cards.c |3 ++- 1 file changed

[PATCH 03/11] Hack to fix a mutex issue in the DVB layer.

2012-04-01 Thread Steinar H. Gunderson
From: "Steinar H. Gunderson" dvb_usercopy(), which is called on all ioctls, not only copies data to and from userspace, but also takes a lock on the file descriptor, which means that only one ioctl can run at a time. This means that if one thread of mumudvb is busy trying to get, sa

[PATCH] Various fixes, hacks and patches for Mantis CA support.

2012-04-01 Thread Steinar H. Gunderson
Hi, I was asked to break up my large patch into several smaller, Signed-off-by-marked changes. I've rebased against linux-2.6 master and done some today; note that since not all of these changes are originally by me, you will probably have to consider each one separately for inclusion (although th

Re: [PATCH] Various nits, fixes and hacks for mantis CA support on SMP

2012-04-01 Thread Steinar H. Gunderson
On Thu, Mar 22, 2012 at 10:11:40PM +0100, Ninja wrote: > I started some testing and so far the changes seem to be fine, but I > still get freezes from time to time. I have to admit that I still > need to test if I get the same error with other applications than > mythtv. It seems to be CAM depende

Re: [PATCH] Various nits, fixes and hacks for mantis CA support on SMP

2012-03-22 Thread Steinar H. Gunderson
On Mon, Mar 19, 2012 at 03:19:09PM +0100, Bjørn Mork wrote: > The user base is too small to get any feedback without getting the > patches into mainline. I suggest you submit the parts you'd like to use > yourself. That's the only way to get them tested. Well, it's still pretty much blind coding

Re: [PATCH] Various nits, fixes and hacks for mantis CA support on SMP

2012-03-19 Thread Steinar H. Gunderson
On Mon, Mar 19, 2012 at 11:05:10AM -0300, Mauro Carvalho Chehab wrote: > A "conglomerate of patches" can't be applied upstream. Instead, you should > be sending us a patch series, preserving the original author/signed-off-by > for each one, if the patches were nod written by you, and add your > Sig

Re: [PATCH] Various nits, fixes and hacks for mantis CA support on SMP

2012-03-02 Thread Steinar H. Gunderson
On Sat, Mar 03, 2012 at 12:42:19AM +0200, Marko Ristola wrote: > I'm not happy with I2CDONE busy looping either. > I've tried twice lately to swith into I2C IRQ, but those patches have caused > I2CDONE timeouts. Note that there are already timeouts with the current polling code, but they are igno

Re: [PATCH] Various nits, fixes and hacks for mantis CA support on SMP

2012-02-27 Thread Steinar H. Gunderson
On Tue, Feb 28, 2012 at 02:03:30AM +0100, Steinar H. Gunderson wrote: > I'm still not happy with the bit-banging on the I2C interface (as opposed to > dealing with it in the interrupt handler); I long suspected it for causing > the IRQ0 problems, especially as they seem to have a s

[PATCH] Various nits, fixes and hacks for mantis CA support on SMP

2012-02-27 Thread Steinar H. Gunderson
Hi, This patch, against 3.3-rc4, is basically a conglomerate of patches that together seem to make CA support on mantis working and stable, even on SMP systems. (I'm using a Terratec Cinergy DVB-S2 card with a Conax CAM, with mumudvb as userspace.) There are a few fixes from this mailing list and