Re: [PATCH v4 01/12] media: ov5640: Adjust the clock based on the expected rate

2018-10-17 Thread Sam Bobrowicz
Hello Maxime and Jacopo (and other ov5640-ers), I just submitted my version of this patch to the mailing list as RFC. It is working on my MIPI platform. Please try it if you have time. Hopefully we can merge these two into a single patch that doesn't break any platforms. Thanks, Sam Addit

[RFC PATCH] media: ov5640: calculate PLL settings for modes

2018-10-17 Thread Sam Bobrowicz
blob that helps ensure the following DPHY spec requirement is met: MIN HS_ZERO + MIN HS_PREPARE > 145 + t_UI * 10 Signed-off-by: Sam Bobrowicz --- This is a modified version of Maxime's patch that works on my platform. My platform is a dual-lane MIPI CSI2 module with xclk=24MHz connecte

[PATCH 1/4] media: ov5640: fix resolution update

2018-10-08 Thread Sam Bobrowicz
set_fmt was not properly triggering a mode change when a new mode was set that happened to have the same format as the previous mode (for example, when only changing the frame dimensions). Fix this. Signed-off-by: Sam Bobrowicz --- drivers/media/i2c/ov5640.c | 8 1 file changed, 4

[PATCH 3/4] media: ov5640: Don't access ctrl regs when off

2018-10-08 Thread Sam Bobrowicz
Add a check to g_volatile_ctrl to prevent trying to read registers when the sensor is not powered. Signed-off-by: Sam Bobrowicz --- drivers/media/i2c/ov5640.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index f183222

[PATCH 0/4] ov5640: small fixes for compatibility

2018-10-08 Thread Sam Bobrowicz
These patches include fixes for some minor annoyances and also help increase compatibility with some CSI2 drivers. Based on latest media_tree commit: "media: ov5640: fix framerate update" Sam Bobrowicz (4): media: ov5640: fix resolution update media: ov5640: fix get_light_fr

[PATCH 4/4] media: ov5640: Add additional media bus formats

2018-10-08 Thread Sam Bobrowicz
support for the 1X16 formats. Signed-off-by: Sam Bobrowicz --- drivers/media/i2c/ov5640.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index a50d884..ca9de56 100644 --- a/drivers/media/i2c/ov5640.c +++ b/drivers/media/i2c/ov5640.c

[PATCH 2/4] media: ov5640: fix get_light_freq on auto

2018-10-08 Thread Sam Bobrowicz
Light frequency was not properly returned when in auto mode and the detected frequency was 60Hz. Fix this. Signed-off-by: Sam Bobrowicz --- drivers/media/i2c/ov5640.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/i2c/ov5640.c b/drivers/media/i2c/ov5640.c index 5031aab

and for the photos

2018-08-05 Thread Sam Dennis
testing for you. Thanks, Sam Dennis

give editing

2018-08-05 Thread Sam Dennis
testing for you. Thanks, Sam Dennis

Enhancing your images

2018-08-03 Thread Sam
. Thanks, Sam Parker

about the photos and

2018-08-03 Thread Sam
. Thanks, Sam Parker

we look after your photos

2018-08-03 Thread Sam
. Thanks, Sam Parker

edit your photos

2018-08-02 Thread Sam
, body retouching) Glamour retouching Product retouching Color correction and others We provide testing for our services. Thanks, Sam

your photos need edit

2018-08-02 Thread Sam
, body retouching) Glamour retouching Product retouching Color correction and others We provide testing for our services. Thanks, Sam

for the retouching

2018-08-02 Thread Sam
, body retouching) Glamour retouching Product retouching Color correction and others We provide testing for our services. Thanks, Sam

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

2018-06-01 Thread Sam Bobrowicz
>> On May 21, 2018, at 12:39 AM, Maxime Ripard >> wrote: >> >>> On Fri, May 18, 2018 at 07:42:34PM -0700, Sam Bobrowicz wrote: >>>> On Fri, May 18, 2018 at 3:35 AM, Daniel Mack wrote: >>>> On Thursday, May 17, 2018 10:53 AM, Maxime Ripard wr

Re: [PATCH v3 03/12] media: ov5640: Remove the clocks registers initialization

2018-05-18 Thread Sam Bobrowicz
worked previously with MIPI platforms that have loose DPHY timing requirements and a specific xclk (24MHz maybe?). Out of the interest of collecting more data, can you provide the following info on your platform? a) External clock frequency b) List of resolutions (including framerates) that are working with these patches (and your fix) applied c) List of resolutions that were working prior to the regression you experienced with the set_timings function Sam

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-05-07 Thread Sam Bobrowicz
et me know if it works. I'd also recommend that someone add a patch to the series that enables 720p@60hz. I didn't have time to do it yet, but it should be really easy. Sam

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-05-04 Thread Sam Bobrowicz
patches are taking longer than expected, my tree is pretty chaotic since I've been running rapid-fire experiments for weeks now. I'm still working on getting the changes organized into an appropriate set of patches. I think they will go out over the weekend. Sam

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-05-04 Thread Sam Bobrowicz
> Hi, > > On 3 May 2018 at 17:16, Maxime Ripard wrote: > > Hi, > > > > On Wed, May 02, 2018 at 11:11:55AM -0700, Sam Bobrowicz wrote: > >> > On Wednesday, 25 April 2018 01:11:19 EEST Sam Bobrowicz wrote: > >> >> FYI, still hard at work on

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-05-02 Thread Sam Bobrowicz
On Fri, Apr 27, 2018 at 2:27 AM, Laurent Pinchart wrote: > Hi Sam, > > On Wednesday, 25 April 2018 01:11:19 EEST Sam Bobrowicz wrote: >> FYI, still hard at work on this. Did some more experiments last week >> that seemed to corroborate the clock tree in the spreadsheet. It a

Re: [PATCH v2 00/12] media: ov5640: Misc cleanup and improvements

2018-04-24 Thread Sam Bobrowicz
to that point. I'm new to this process :) --Sam --- Sam Bobrowicz Elite Embedded Consulting LLC elite-embedded.com On Thu, Apr 19, 2018 at 5:32 AM, Maxime Ripard wrote: > Hi Samuel, > > On Wed, Apr 18, 2018 at 04:39:06PM -0700, Samuel Bobrowicz wrote: &

Re: Updated fi-HTV scan file

2013-09-09 Thread Sam Stenvall
On 9.9.2013 11:51, Oliver Schinagl wrote: On 07-09-13 15:36, Sam Stenvall wrote: Hi, Hello, Here's an updated fi-HTV scan file according to the official specification available at http://dvb.welho.fi/cable.php. Patch merged manually and pushed, your diff failed to apply, did you us

Updated fi-HTV scan file

2013-09-07 Thread Sam Stenvall
56 +C 53000 690 NONE QAM256 +C 55400 690 NONE QAM256 Regards, Sam Stenvall -- Sam Stenvall +358 (0)40 509 0191 sam.stenv...@arcada.fi -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH v7 4/9] mfd: Add header files and Kbuild plumbing for SI476x MFD core

2013-02-26 Thread Sam Ravnborg
patch > adds a core portion of it that provides all the necessary > functionality to the two other drivers that represent radio and audio > codec subsystems of the chip. > > Acked-by: Hans Verkuil > Signed-off-by: Andrey Smirnov Acked-by: Sam Ravnborg -- To unsubscribe from this

Re: [PATCH v6 1/9] mfd: Add header files and Kbuild plumbing for SI476x MFD core

2013-02-26 Thread Sam Ravnborg
On Tue, Feb 26, 2013 at 08:31:27AM -0800, Andrey Smirnov wrote: > From: Andrey Smirnov > > This patch adds all necessary header files and Kbuild plumbing for the > core driver for Silicon Laboratories Si476x series of AM/FM tuner > chips. > > The driver as a whole is implemented as an MFD device

Re: [Bug] gspca_zc3xx v.2.14.0 Auto Gain is OFF

2012-08-27 Thread Sam Bulka
Just wanted to add, in previous driver version 2.13.0 Auto Gain was switchable ON / OFF, but when switched ON, was activated all the time regardless of lighting conditions, resulting in overexposed images during a day light with only silhouettes visible. But in current version its impossible to

Re: [Bug] gspca_zc3xx v.2.14.0 Auto Gain is OFF

2012-08-26 Thread Sam Bulka
Registry Data for reference: Image Sensor Config Key Name: HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\Control\Class \{6BDD1FC6-810F-11D0-BEC7-08002BE2092F}\0001 Class Name: Last Write Time: 6/25/2012 - 7:08 PM Value 0 Name: CoInstallers32 Type: REG_MULTI_SZ Data: lvco1201278.dll,LvCoInstaller Va

Re: [Bug] gspca_zc3xx v.2.14.0 Auto Gain is OFF (Chipset Config)

2012-08-26 Thread Sam Bulka
Webcam Chipset Config for reference: Key Name: HKEY_LOCAL_MACHINE\SYSTEM\ControlSet001\Control\Class \{6BDD1FC6-810F-11D0-BEC7-08002BE2092F}\0001 Class Name: Last Write Time: 6/25/2012 - 7:08 PM Value 0 Name:CoInstallers32 Type:REG_MULTI_SZ Data:

[Bug] gspca_zc3xx v.2.14.0 Auto Gain is OFF

2012-08-26 Thread Sam Bulka
This is a bug report for gspca_zc3xx v.2.14.0 webcam driver installed as a module on ArchLinux plug computer, kernel 3.5.2-1-ARCH [root@alarm ~]# dmesg [ 15.271381] gspca_main: v2.14.0 registered [ 15.303224] gspca_main: gspca_zc3xx-2.14.0 probing 046d:08d7 [ 16.211715] fuse init (API vers

[PATCH] drivers:media:dvb: add USB PIDs for Elgato EyeTV Sat

2010-12-18 Thread sam
Adds USB PIDs for the Elgato EyeTV Sat device. This device is a clone of the Terratec S7. Signed-off-by: Sam Doshi diff -r abd3aac6644e linux/drivers/media/dvb/dvb-usb/az6027.c --- a/linux/drivers/media/dvb/dvb-usb/az6027.c Fri Jul 02 00:38:54 2010 -0300 +++ b/linux/drivers/media/dvb/dvb-usb

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

2010-11-25 Thread Sam Ravnborg
expect these other things to take a couple of weeks. [Not Linux related - just busy at my day-job/night-job] Sam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/5] kconfig: add an option to determine a menu's visibility

2010-11-16 Thread Sam Ravnborg
> > touch > > on two other menus that are used, as I answered upstream). > > > > I prefer if Michal could forward those patches upstream, so, there's my ack: > > > > Acked-by: Mauro Carvalho Chehab > > Tested-by: Mauro Carvalho Chehab > >

Re: [RFC PATCH] media: consolidation of -I flags

2010-10-05 Thread Sam Ravnborg
Because this version has the flexibility to use the kbuild way of dealing with conditional modules. I see no reason to do such change alaone - but as part of other minor cleanups it would be natural to change to the -y idiom. All the comments above is valid for staging too. There we should try to

Re: [RFC PATCH] media: consolidation of -I flags

2010-10-05 Thread Sam Ravnborg
im) dvb-core/Makefile is one such example 6) remove useless stuff siano/Makefile has some strange assignments to EXTRA_CFLAGS 7) Likely a few more items to look after... This is more work - but then you finish a Makefile rather than doing a simple conversion. Sam -- To unsubsc

Re: dubious section mismatch test (was Re: [PULL] soc-camera: one commit as v4l2-dev preparation)

2009-06-05 Thread Sam Ravnborg
On Sun, May 10, 2009 at 08:33:03PM +0200, Guennadi Liakhovetski wrote: > On Sat, 9 May 2009, Sam Ravnborg wrote: > > > On Sat, May 09, 2009 at 06:13:13PM +0200, Guennadi Liakhovetski wrote: > > > On Sat, 9 May 2009, Mauro Carvalho Chehab wrote: > > > > &g

Re: dubious section mismatch test (was Re: [PULL] soc-camera: one commit as v4l2-dev preparation)

2009-05-09 Thread Sam Ravnborg
ve = __exit_p(my_remove), > }; > > to put them in a new special section? Or is there a better solution? We already have that: __refdata would be your choice in this case. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: ASUS 'My Cinema Europa Hybrid' (P7131 DVB-T) [SAA7134] Firmware oddities

2009-04-29 Thread Sam Spilsbury
.2009, 00:02 +0800 schrieb Sam Spilsbury: >> Hi everyone, >> >> So It's my first time to LinuxTV hacking, debugging etc, so I >> apologize if I've failed to provide anything essential. >> >> Anyways, I've just bought a ASUS 'My Cinema Europa Hybrid

ASUS 'My Cinema Europa Hybrid' (P7131 DVB-T) [SAA7134] Firmware oddities

2009-04-28 Thread Sam Spilsbury
Hi everyone, So It's my first time to LinuxTV hacking, debugging etc, so I apologize if I've failed to provide anything essential. Anyways, I've just bought a ASUS 'My Cinema Europa Hybrid' (P7131 DVB-T) which has the Phillips saa7131 chipset in it (supported by the saa7131 module et al). There i

Re: [PATCH 12/13] [drivers/media] changed ioctls to unlocked

2009-03-24 Thread Sam Ravnborg
red better style to first decalre the variable and then later assign it. So this would allow you to move the assignment after the lock_kernel(), Sam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-23 Thread Sam Ravnborg
On Fri, Jan 23, 2009 at 10:01:44PM +0530, Jaswinder Singh Rajput wrote: > On Fri, 2009-01-23 at 17:21 +0100, Sam Ravnborg wrote: > > On Fri, Jan 23, 2009 at 05:11:13PM +0100, Jan Engelhardt wrote: > > > > > > On Friday 2009-01-23 17:04, Jaswinder Singh Rajput wro

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-23 Thread Sam Ravnborg
s one/seems no one ;-) > > I had an objection as previously stated -- namely that > should be included to remain friendly to C++0x > programs which should use instead. Forcing > stdint.h is therefore not nice. This is fully agreed. Jaswinder - can I ask you to do this change (

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-18 Thread Sam Ravnborg
On Sun, Jan 18, 2009 at 10:13:00AM +0100, Ingo Molnar wrote: > > * Sam Ravnborg wrote: > > > On Sun, Jan 18, 2009 at 08:37:41AM +1100, David Woodhouse wrote: > > > On Sun, 2009-01-18 at 01:47 +0530, Jaswinder Singh Rajput wrote: > > > > --- a/include/lin

Re: [GIT PULL -tip] fix 33 make headers_check warnings

2009-01-17 Thread Sam Ravnborg
x/types.h despite the fact that is uses __u32 etc. But why the _kernel_ should include a userspace header is much more questionable. Sam -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html