Hi Zhaowei,
On Wed, Jul 30, 2014 at 9:39 AM, Zhaowei Yuan wrote:
> Current algorithm relies on the fact that caller will align the
> size to PAGE_SIZE, otherwise order will be decreased to negative
> when remain size is less than PAGE_SIZE, it makes the function
> hard to be migrated.
> This patc
Hi Shaik,
On Mon, Jul 21, 2014 at 10:24 AM, Shaik Ameer Basha
wrote:
> 1] Currently Gscaler clock is enabled only inside pm_runtime callbacks.
>If PM_RUNTIME is disabled, driver hangs. This patch removes the
>PM_RUNTIME dependency by keeping the clock enable/disable functions
>in m2m
Hi Jacek,
On Tue, Jul 8, 2014 at 6:33 PM, Jacek Anaszewski
wrote:
> fc906b6d "Remove special clock usage in driver" removed
> initialization of MFC special clock, arguing that there's
> no need to do it explicitly, since it's one of MFC gate clock's
> dependencies and gets enabled along with it.
n [1].
> [1] http://permalink.gmane.org/gmane.linux.kernel.samsung-soc/31735
>
> Changes from v1
> - Addressed nits pointed by Sachin on PATCH 2/3
Thanks Arun.
Series looks good.
Reviewed-by: Sachin Kamat
--
With warm regards,
Sachin
--
To unsubscribe from this list: send the line &qu
Hi Arun,
On 20 May 2014 15:47, Arun Kumar K wrote:
> For MFC firmwares, improved versions with bug fixes and
> feature additions are released keeping the firmware version
> including major and minor number same. The issue came with
> the release of a new MFCv6 firmware with an interface change.
>
Hi Arun,
Just 2 small nits.
On 7 May 2014 17:00, Arun Kumar K wrote:
> MFCv6 encoder needs specific minimum number of buffers to
> be queued in the CAPTURE plane. This minimum number will
> be known only when the sequence header is generated.
> So we used to allow STREAMON on the CAPTURE plane o
Hi Arun,
On 30 April 2014 11:15, Arun Kumar K wrote:
> Hi Sachin,
>
> Thank you for the review.
>
>
> On 04/29/14 22:45, Sachin Kamat wrote:
>>
>> Hi Arun,
>>
>> On 23 April 2014 18:27, Arun Kumar K wrote:
>>>
>>> From: Kiran AVN
Hi Arun,
On 23 April 2014 18:27, Arun Kumar K wrote:
> From: Kiran AVND
>
> This patch adds variant data and core support for
> V8 decoder. This patch also adds the register definition
> file for new firmware version v8 for MFC.
>
> Signed-off-by: Kiran AVND
> Signed-off-by: Pawel Osciak
> Sig
Hi Jacek,
On 9 April 2014 13:01, Jacek Anaszewski wrote:
> On 04/08/2014 09:49 AM, Sachin Kamat wrote:
>>
> Hello Sachin,
>
> Thanks for the review. I put it into info message because this is
> rather hard for the user to figure out why the adjustment occurred,
> bearin
Hi Jacek,
On 7 April 2014 18:46, Jacek Anaszewski wrote:
> Prevent decompression of a JPEG 4:2:0 with odd width to
> the YUV 4:2:0 compliant formats for Exynos4x12 SoCs and
> adjust capture format to RGB565 in such a case. This is
> required because the configuration would produce a raw
> image w
Hi Jacek,
On 7 April 2014 18:46, Jacek Anaszewski wrote:
> This patch fixes build break occurring when
> there is no support for Device Tree turned on
> in the kernel configuration. In such a case only
> the driver variant for S5PC210 SoC will be available.
>
> Signed-off-by: Jacek Anaszewski
>
Hi Seung-Woo,
On 6 March 2014 10:25, Seung-Woo Kim wrote:
> This patch removes meaningless assignment of memory bank to itself.
>
> Signed-off-by: Seung-Woo Kim
> ---
Thanks for re-doing this.
Acked-by: Sachin Kamat
--
With warm regards,
Sachin
--
To unsubscribe from this li
Hi Seung-Woo,
On 6 March 2014 07:43, Seung-Woo Kim wrote:
> Hello Sachin,
>
> On 2014년 03월 05일 20:42, Sachin Kamat wrote:
>> On 5 March 2014 16:38, Seung-Woo Kim wrote:
>
> (...)
>
>>> - dev->bank1 = dev->bank1;
>>
>> Are you sure th
On 5 March 2014 16:38, Seung-Woo Kim wrote:
> There was assignment of memory bank with dma address converted
> from physical address. But allocation has been changed with dma
> function, so the assignment is not necessary.
>
> Signed-off-by: Seung-Woo Kim
> ---
> change from v1
> - fixes subject
On 10 February 2014 14:28, Inki Dae wrote:
> 2014-02-10 17:44 GMT+09:00 Sachin Kamat :
>> +cc Joonyoung Shim
>>
>> Hi,
>>
>> On 10 February 2014 13:58, Tobias Jakobi
>> wrote:
>>> Hello!
>>>
>>>
>>> Sachin Kamat
+cc Joonyoung Shim
Hi,
On 10 February 2014 13:58, Tobias Jakobi wrote:
> Hello!
>
>
> Sachin Kamat wrote:
>> +cc linux-media list and some related maintainers
>>
>> Hi,
>>
>> On 10 February 2014 00:22, Tobias Jakobi
>> wrote:
>>> Hello!
+cc linux-media list and some related maintainers
Hi,
On 10 February 2014 00:22, Tobias Jakobi wrote:
> Hello!
>
> I noticed while here
> (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/arch/arm/boot/dts/exynos4x12.dtsi?id=3a0d48f6f81459c874165ffb14b310c0b5bb0c58)
> the n
Hi Amit,
On 30 January 2014 11:12, Amit Grover wrote:
> Based on 'master' branch of Linux-next.
Kamil's tree [1] would be more current most of the times for this driver.
[1] git://linuxtv.org/kdebski/media.git
> This is v2 version for the patch:
> s5p-mfc: Add Horizontal and Vertical search r
module_usb_driver eliminates the boilerplate and makes the code simpler.
Signed-off-by: Sachin Kamat
---
drivers/media/radio/radio-keene.c | 19 +--
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/media/radio/radio-keene.c
b/drivers/media/radio/radio
Hi Andrzej,
On 8 January 2014 16:30, Andrzej Hajda wrote:
> On 01/06/2014 12:48 PM, Sachin Kamat wrote:
> Hi Sachin,
>
> Thanks for the fixes.
>
>> Gentle ping on this series :)
>
> Sorry for late reply, but it seems Mauro has merged them already.
No worries. Yes, Mau
Hi Dan,
On 8 January 2014 14:39, Dan Carpenter wrote:
> Hello Andrzej Hajda,
>
> This is a semi-automatic email about new static checker warnings.
>
> The patch 7d459937dc09: "[media] Add driver for Samsung S5K5BAF
> camera sensor" from Dec 5, 2013, leads to the following Smatch
> complaint:
>
>
On 24 December 2013 17:12, Sachin Kamat wrote:
> Fixes the following warnings:
> drivers/media/i2c/s5k5baf.c: In function 's5k5baf_fw_parse':
> drivers/media/i2c/s5k5baf.c:362:3: warning:
> format '%d' expects argument of type 'int', but argument 3 has ty
Fixes the following error:
ERROR: return is not a function, parentheses are not required
FILE: drivers/media/i2c/s5k5baf.c:1353:
Signed-off-by: Sachin Kamat
---
drivers/media/i2c/s5k5baf.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/s5k5baf.c b
Dereference 'fw' after the NULL check.
Signed-off-by: Sachin Kamat
---
drivers/media/i2c/s5k5baf.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/s5k5baf.c b/drivers/media/i2c/s5k5baf.c
index 974b865c2ee1..4b838cbd 100644
--- a/drivers
4: warning:
format '%d' expects argument of type 'int', but argument 4 has type 'size_t'
[-Wformat=]
Signed-off-by: Sachin Kamat
Reported-by: kbuild test robot
---
drivers/media/i2c/s5k5baf.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff -
Hi Arun,
On 10 December 2013 10:15, Arun Kumar K wrote:
> Hi Pawel,
>
> On Tue, Dec 10, 2013 at 6:21 AM, Pawel Osciak wrote:
>> Hi Arun,
>>
>
> Ok will make the change in next version.
>
While at it also update the patch subject appropriately.
--
With warm regards,
Sachin
--
To unsubscribe f
On 6 November 2013 06:58, Laurent Pinchart
wrote:
> Hi Sachin,
>
> Thank you for the patch, and sorry for the late reply.
>
> On Friday 18 October 2013 08:37:11 Sachin Kamat wrote:
>> 'of_match_ptr' is defined in linux/of.h. Include it explicitly to avoid
Hi Olof,
On 24 October 2013 20:00, Olof Johansson wrote:
> Hi Kishon,
>
> On Wed, Oct 16, 2013 at 9:28 AM, Kishon Vijay Abraham I wrote:
>> diff --git a/drivers/video/exynos/exynos_mipi_dsi.c
>> b/drivers/video/exynos/exynos_mipi_dsi.c
>> index 32e5406..00b3a52 100644
>> --- a/drivers/video/exy
'of_match_ptr' is defined in linux/of.h. Include it explicitly to
avoid build breakage in the future.
Signed-off-by: Sachin Kamat
---
drivers/media/rc/gpio-ir-recv.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers/media/rc/gpio-ir-re
'of_match_ptr' is defined in linux/of.h. Include it explicitly to
avoid build breakage in the future.
Signed-off-by: Sachin Kamat
---
drivers/media/i2c/tvp7002.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/tvp7002.c b/drivers/media/i2c/tvp7002.c
ind
'of_match_ptr' is defined in linux/of.h. Include it explicitly to
avoid build breakage in the future.
Signed-off-by: Sachin Kamat
---
drivers/media/i2c/ths8200.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/ths8200.c b/drivers/media/i2c/ths8200.c
ind
'of_match_ptr' is defined in linux/of.h. Include it explicitly to
avoid build breakage in the future.
Signed-off-by: Sachin Kamat
---
drivers/media/i2c/tvp514x.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/tvp514x.c b/drivers/media/i2c/tvp514x.c
ind
'of_match_ptr' is defined in linux/of.h. Include it explicitly to
avoid build breakage in the future.
Signed-off-by: Sachin Kamat
---
drivers/media/i2c/adv7343.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/adv7343.c b/drivers/media/i2c/adv7343.c
ind
'of_match_ptr' is defined in linux/of.h. Include it explicitly to
avoid build breakage in the future.
Signed-off-by: Sachin Kamat
Cc: Laurent Pinchart
---
drivers/media/i2c/mt9p031.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/i2c/mt9p031.c b/drivers/media/i
Hi Hans,
On 30 September 2013 17:52, Hans Verkuil wrote:
> On 09/23/2013 03:43 AM, Jingoo Han wrote:
>> Since commit 0998d0631001288a5974afc0b2a5f568bcdecb4d
>> (device-core: Ensure drvdata = NULL when no driver is bound),
>> the driver core clears the driver data to NULL after device_release
>>
Hi Mateusz,
On 21 September 2013 20:30, Mateusz Krawczuk
wrote:
> This patch series add restoring previous vpll rate after driver offs stream
> or recives error.
> It also replace mxr_info, mxr_dbg, mxr_warn and mxr_err macro
> by generic solution.
It is a good practice to include revision histo
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat
---
drivers/media/radio/radio-sf16fmr2.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/radio/radio-sf16fmr2.c
b/drivers/media/radio/radio-sf16fmr2.c
index f1e3714..448cac9 100644
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat
---
drivers/media/pci/ngene/ngene-core.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/pci/ngene/ngene-core.c
b/drivers/media/pci/ngene/ngene-core.c
index 37ebc42..8402ed6 100644
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat
Cc: Steven Toth
---
drivers/media/pci/saa7164/saa7164-core.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/pci/saa7164/saa7164-core.c
b/drivers/media/pci/saa7164/saa7164-core.c
index
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat
---
drivers/media/pci/bt8xx/bt878.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/media/pci/bt8xx/bt878.c b/drivers/media/pci/bt8xx/bt878.c
index 66eb0ba..2bd2483 100644
--- a/drivers/media
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat
Cc: Manu Abraham
---
drivers/media/pci/mantis/mantis_pci.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/pci/mantis/mantis_pci.c
b/drivers/media/pci/mantis/mantis_pci.c
index
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat
---
drivers/media/pci/cx88/cx88-alsa.c |2 --
drivers/media/pci/cx88/cx88-mpeg.c |1 -
drivers/media/pci/cx88/cx88-video.c |1 -
3 files changed, 4 deletions(-)
diff --git a/drivers/media/pci
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat
Cc: Igor M. Liplianin
---
drivers/media/pci/dm1105/dm1105.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/pci/dm1105/dm1105.c
b/drivers/media/pci/dm1105/dm1105.c
index ab797fe
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat
Cc: Andreas Oberritter
---
drivers/media/pci/pluto2/pluto2.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/pci/pluto2/pluto2.c
b/drivers/media/pci/pluto2/pluto2.c
index 4938285
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat
Cc: Takahito HIRANO
---
drivers/media/pci/pt1/pt1.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/pci/pt1/pt1.c b/drivers/media/pci/pt1/pt1.c
index 75ce142..db887b0 100644
--- a
Driver core sets driver data to NULL upon failure or remove.
Signed-off-by: Sachin Kamat
Cc: Patrick Boettcher
---
drivers/media/pci/b2c2/flexcop-pci.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/pci/b2c2/flexcop-pci.c
b/drivers/media/pci/b2c2/flexcop-pci.c
index
module_pci_driver removes some boilerplate and makes code simpler.
Signed-off-by: Sachin Kamat
---
drivers/media/pci/cx88/cx88-alsa.c | 25 +
1 file changed, 1 insertion(+), 24 deletions(-)
diff --git a/drivers/media/pci/cx88/cx88-alsa.c
b/drivers/media/pci/cx88/cx88
module_pci_driver removes some boilerplate and makes code simpler.
Signed-off-by: Sachin Kamat
Cc: Jelle Foks
---
drivers/media/pci/cx88/cx88-mpeg.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/media/pci/cx88/cx88-mpeg.c
b/drivers/media/pci/cx88
module_pci_driver removes some boilerplate and makes code simpler.
Signed-off-by: Sachin Kamat
Cc: Gerd Knorr
---
drivers/media/pci/cx88/cx88-video.c | 15 +--
1 file changed, 1 insertion(+), 14 deletions(-)
diff --git a/drivers/media/pci/cx88/cx88-video.c
b/drivers/media/pci
On 30 August 2013 17:02, Sylwester Nawrocki wrote:
> Hi Sachin,
>
> On 08/30/2013 01:11 PM, Sachin Kamat wrote:
>> The function returns a pointer to a const array. Duplicate use of const
>> led to the following warning.
>> drivers/media/v4l2-core/v4l2-ctrls.c:574:3
The function returns a pointer to a const array. Duplicate use of const
led to the following warning.
drivers/media/v4l2-core/v4l2-ctrls.c:574:32: warning: duplicate const
Signed-off-by: Sachin Kamat
Cc: Sylwester Nawrocki
---
drivers/media/v4l2-core/v4l2-ctrls.c |6 +++---
include/media
Hi Arun,
On 14 August 2013 10:16, Arun Kumar K wrote:
> From: Shaik Ameer Basha
>
> This patch adds support for media device for EXYNOS5 SoCs.
> The current media device supports the following ips to connect
> through the media controller framework.
>
> * MIPI-CSIS
> Support interconnection(su
Hi Guennadi ,
On 8 August 2013 20:22, Guennadi Liakhovetski wrote:
> Use devm_* resource allocators to simplify the driver's probe and clean up
> paths.
>
> Signed-off-by: Guennadi Liakhovetski
> ---
> drivers/media/platform/soc_camera/mx3_camera.c | 47
> +---
> 1 files
Hi Arun,
On 4 August 2013 20:30, Sylwester Nawrocki wrote:
> Hi Arun,
>
> On 08/02/2013 05:02 PM, Arun Kumar K wrote:
>>
>> This patch adds the crucial hardware pipeline control for the
>> fimc-is driver. All the subdev nodes will call this pipeline
>> interfaces to reach the hardware. Responsibi
Hi Vikas,
On 6 August 2013 10:53, Vikas Sajjan wrote:
> While trying to get boot-logo up on exynos5420 SMDK which has eDP panel
> connected with resolution 2560x1600, following error occured even with
> IOMMU enabled:
> [0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to allocate buffer.
Hi Sylwester,
On 5 August 2013 16:35, Sylwester Nawrocki wrote:
> Hi Sachin,
>
> On 08/05/2013 07:12 AM, Sachin Kamat wrote:
>> On 2 August 2013 12:02, Sachin Kamat wrote:
>>> > __is_set_init_isp_aa and fimc_is_hw_set_tune currently do not have
>>> > any
On 2 August 2013 20:32, Arun Kumar K wrote:
> From: Shaik Ameer Basha
>
> This patch adds support for media device for EXYNOS5 SoCs.
> The current media device supports the following ips to connect
> through the media controller framework.
>
> * MIPI-CSIS
> Support interconnection(subdev interf
Hi Sylwester,
On 2 August 2013 12:02, Sachin Kamat wrote:
> __is_set_init_isp_aa and fimc_is_hw_set_tune currently do not have
> any callers. However these functions may be used in the future. Hence
> instead of deleting them, staticize and annotate them with __maybe_unused
> f
dev->of_node could be NULL. Hence check for the same and return before
dereferencing it in the subsequent error message.
Signed-off-by: Sachin Kamat
---
Changes since v1:
Moved the NULL check to beginning of probe.
---
drivers/media/platform/exynos4-is/fimc-lite.c | 13 +++--
1 f
Hi Sylwester,
On 2 August 2013 14:15, Sylwester Nawrocki wrote:
> Hi Sachin,
>
> On 08/02/2013 08:32 AM, Sachin Kamat wrote:
>> dev->of_node could be NULL. Hence check for the same and return before
>> dereferencing it in the subsequent error message.
>>
__is_set_init_isp_aa and fimc_is_hw_set_tune currently do not have
any callers. However these functions may be used in the future. Hence
instead of deleting them, staticize and annotate them with __maybe_unused
flag to avoid compiler warnings.
Signed-off-by: Sachin Kamat
---
drivers/media
dev->of_node could be NULL. Hence check for the same and return before
dereferencing it in the subsequent error message.
Signed-off-by: Sachin Kamat
---
drivers/media/platform/exynos4-is/fimc-lite.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/media/platform/exynos4-is/f
__fimc_is_hw_update_param is used only in this file. Make it static.
Signed-off-by: Sachin Kamat
---
drivers/media/platform/exynos4-is/fimc-is-param.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/exynos4-is/fimc-is-param.c
b/drivers/media
Hi Vikas,
On 1 August 2013 16:49, Vikas Sajjan wrote:
> While trying to get boot-logo up on exynos5420 SMDK which has eDP panel
> connected with resolution 2560x1600, following error occured even with
> IOMMU enabled:
> [0.88] [drm:lowlevel_buffer_allocate] *ERROR* failed to allocate buffer.
Hi Vikas,
On 2 August 2013 09:23, Vikas Sajjan wrote:
> Hi Tomasz,
>
>
> On 2 August 2013 04:50, Tomasz Figa wrote:
>>
>> Hi Vikas,
>>
>> On Thursday 01 of August 2013 16:49:32 Vikas Sajjan wrote:
>> > While trying to get boot-logo up on exynos5420 SMDK which has eDP panel
>> > connected with re
PTR_RET is now deprecated. Use PTR_ERR_OR_ZERO instead.
Signed-off-by: Sachin Kamat
---
Compile tested and based on the following tree:
git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git (PTR_RET)
Dependent on [1]
[1] http://lkml.indiana.edu/hypermail/linux/kernel/1306.2/00010.html
PTR_RET is now deprecated. Use PTR_ERR_OR_ZERO instead.
Signed-off-by: Sachin Kamat
---
Compile tested and based on the following tree:
git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux.git (PTR_RET)
Dependent on [1]
[1] http://lkml.indiana.edu/hypermail/linux/kernel/1306.2/00010.html
ster video device
s5p-g2d: probe of 1280.g2d failed with error -22
Signed-off-by: Sachin Kamat
Cc: Hans Verkuil
---
drivers/media/platform/s5p-g2d/g2d.c |1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/media/platform/s5p-g2d/g2d.c
b/drivers/media/platform/s5p-g2d/g2d.c
ind
Hi Arun,
On 26 June 2013 12:18, Arun Kumar K wrote:
> Hi Sachin,
>
> On Tue, Jun 25, 2013 at 4:54 PM, Sachin Kamat wrote:
>> Hi Arun,
>>
>>> @@ -684,5 +685,6 @@ void set_work_bit_irqsave(struct s5p_mfc_ctx *ctx);
>>> (d
Hi Arun,
> @@ -684,5 +685,6 @@ void set_work_bit_irqsave(struct s5p_mfc_ctx *ctx);
> (dev->variant->port_num ? 1 : 0) : 0) : 0)
> #define IS_TWOPORT(dev)(dev->variant->port_num == 2 ? 1 : 0)
> #define IS_MFCV6_PLUS(dev) (dev->variant->version >
Hi Sylwester,
On 19 June 2013 03:27, Sylwester Nawrocki wrote:
> Hi Sachin,
>
>
> On 06/18/2013 05:45 AM, Sachin Kamat wrote:
>>
>> Hi Sylwester,
>>
>>> -The machine code (plat-s5p and arch/arm/mach-*) must select following
>>> options
>>&
Hi Arun,
On 18 June 2013 11:25, Arun Kumar K wrote:
> Hi Sachin,
>
>
> On Tue, Jun 18, 2013 at 10:56 AM, Sachin Kamat
> wrote:
>> On 18 June 2013 10:21, Arun Kumar K wrote:
>>> Hi Kamil,
>>>
>>> Thank you for the review.
>>>
>
On 18 June 2013 10:21, Arun Kumar K wrote:
> Hi Kamil,
>
> Thank you for the review.
>
>
>>> #define IS_MFCV6(dev)(dev->variant->version >= 0x60 ? 1 :
>> 0)
>>> +#define IS_MFCV7(dev)(dev->variant->version >= 0x70 ? 1 :
>> 0)
>>
>> According to this, MFC v7 is also
Hi Sylwester,
>
> -The machine code (plat-s5p and arch/arm/mach-*) must select following options
> +The machine code (arch/arm/plat-samsung and arch/arm/mach-*) must select
> +following options:
After the recent platform code cleanup the below entries are not found
in arch/arm/mach-* (checked in
Hi Sylwester,
Just a couple of nits inline.
On 17 June 2013 22:12, Sylwester Nawrocki wrote:
> This change is mainly to update the driver's path changed from
> drivers/media/platform/s5p-fimc to drivers/media/platform/exynos4-is/.
> While at it, remove non-existent files rule, move the whole ent
On 31 May 2013 18:33, Arun Kumar K wrote:
> FIMC-IS has two hardware scalers named as scaler-codec and
> scaler-preview. This patch adds the common code handling the
> video nodes and subdevs of both the scalers.
>
> Signed-off-by: Arun Kumar K
> Signed-off-by: Kilyeon Im
> ---
[snip]
> +stati
On 31 May 2013 18:33, Arun Kumar K wrote:
> FIMC-IS uses certain sensors which are exclusively controlled
> from the IS firmware. This patch adds the sensor subdev for the
> fimc-is sensors.
>
> Signed-off-by: Arun Kumar K
> Signed-off-by: Kilyeon Im
> ---
> drivers/media/platform/exynos5-is/fi
On 31 May 2013 18:33, Arun Kumar K wrote:
> This patch adds the register definition file for the fimc-is driver
> and also the header file containing the main context for the driver.
>
> Signed-off-by: Arun Kumar K
> Signed-off-by: Kilyeon Im
> ---
> drivers/media/platform/exynos5-is/fimc-is-re
On 31 May 2013 18:33, Arun Kumar K wrote:
> fimc-is driver takes video data input from the ISP video node
> which is added in this patch. This node accepts Bayer input
> buffers which is given from the IS sensors.
>
> Signed-off-by: Arun Kumar K
> Signed-off-by: Kilyeon Im
> ---
[snip]
> +stat
Hi Arun,
On 31 May 2013 18:33, Arun Kumar K wrote:
> This driver is for the FIMC-IS IP available in Samsung Exynos5
> SoC onwards. This patch adds the core files for the new driver.
>
> Signed-off-by: Arun Kumar K
> Signed-off-by: Kilyeon Im
> ---
[snip]
> +
> +static void fimc_is_clk_put(stru
On 5 June 2013 15:32, Guennadi Liakhovetski wrote:
> Hi Sachin
>
> On Tue, 4 Jun 2013, Sachin Kamat wrote:
>
>> On 24 May 2013 16:55, Sachin Kamat wrote:
>> > After the switch to devm_* functions, the 'remove' function does
>> > not do anything. De
On 24 May 2013 16:55, Sachin Kamat wrote:
> After the switch to devm_* functions, the 'remove' function does
> not do anything. Delete it.
>
> Signed-off-by: Sachin Kamat
> Cc: Kuninori Morimoto
> ---
> drivers/media/i2c/soc_camera/mt9t112.c |6 --
In certain cases, dma_alloc_coherent returns NULL. Add check for
NULL pointer.
Signed-off-by: Sachin Kamat
---
drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c
b/drivers/media
Hi Andrzej,
On 28 May 2013 12:56, Andrzej Hajda wrote:
> Many debug messages missed end-of-line.
>
> Signed-off-by: Andrzej Hajda
> Signed-off-by: Kyungmin Park
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc.c| 2 +-
> drivers/media/platform/s5p-mfc/s5p_mfc_debug.h | 4 ++--
> drive
Hi Andrzej,
On 28 May 2013 12:56, Andrzej Hajda wrote:
> This patch fixes a bug which caused overwriting h264 codec
> parameters by mpeg4 parameters during V4L2 control setting.
Just curious, what was the use case that triggered this issue?
--
With warm regards,
Sachin
--
To unsubscribe from t
After the switch to devm_* functions, the 'remove' function does
not do anything. Delete it.
Signed-off-by: Sachin Kamat
Cc: Kuninori Morimoto
---
drivers/media/i2c/soc_camera/tw9910.c |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/media/i2c/soc_camera/tw9910.c
After the switch to devm_* functions, the 'remove' function does
not do anything. Delete it.
Signed-off-by: Sachin Kamat
Cc: Kuninori Morimoto
---
drivers/media/i2c/soc_camera/mt9t112.c |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/media/i2c/soc_camera/mt
'exynos_mfc_match' is always compiled in. Hence of_match_ptr
is unnecessary.
Signed-off-by: Sachin Kamat
Cc: Kamil Debski
---
drivers/media/platform/s5p-mfc/s5p_mfc.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c
This is a DT only driver and exynos_gsc_match is always compiled
in. Hence of_match_ptr is unnecessary.
Signed-off-by: Sachin Kamat
---
drivers/media/platform/exynos-gsc/gsc-core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/exynos-gsc/gsc
On 21 May 2013 14:58, Hans Verkuil wrote:
> On Fri 17 May 2013 10:24:50 Sachin Kamat wrote:
>> Hi Hans,
>>
>> I noticed the following sparse warnings with S5P HDMI driver which I
>> think got introduced due to the following commit:
>> 5efb54b2b7b ([media] s5p-tv
On 17 May 2013 13:54, Sachin Kamat wrote:
> Hi Hans,
>
> I noticed the following sparse warnings with S5P HDMI driver which I
> think got introduced due to the following commit:
> 5efb54b2b7b ([media] s5p-tv: add dv_timings support for hdmi)
>
> Warnings:
> drive
On 20 May 2013 17:30, Guennadi Liakhovetski wrote:
> On Mon, 20 May 2013, Sachin Kamat wrote:
>
>> On 13 May 2013 14:49, Sachin Kamat wrote:
>> > Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
>> > driver is bound) removes the need to set
On 13 May 2013 14:49, Sachin Kamat wrote:
> Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
> driver is bound) removes the need to set driver data field to
> NULL.
>
> Signed-off-by: Sachin Kamat
> ---
> drivers/media/platform/soc_camera/sh_mobile_csi2.c |
Hi Hans,
I noticed the following sparse warnings with S5P HDMI driver which I
think got introduced due to the following commit:
5efb54b2b7b ([media] s5p-tv: add dv_timings support for hdmi)
Warnings:
drivers/media/platform/s5p-tv/hdmi_drv.c:483:18: error: unknown field
name in initializer
drivers
NULL check on clocks obtained using common clock APIs should not
be done. Use IS_ERR only.
Signed-off-by: Sachin Kamat
---
drivers/media/platform/s5p-tv/mixer_drv.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/drivers/media/platform/s5p-tv
NULL check on clocks obtained using common clock APIs should not
be done. Use IS_ERR only.
Signed-off-by: Sachin Kamat
---
Based on for-next branch of
git://linuxtv.org/snawrocki/samsung.git
Changes since v3:
Renamed the function and changed the prototype of {hdmi,mxr}_reset_clocks
as suggested
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat
---
drivers/media/rc/gpio-ir-recv.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/rc/gpio-ir-recv.c b/drivers
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat
Cc: Pelagicore AB
---
drivers/media/platform/timblogiw.c |4
1 file changed, 4 deletions(-)
diff --git a/drivers/media
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat
---
drivers/media/platform/soc_camera/sh_mobile_csi2.c |8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a
Commit 0998d06310 (device-core: Ensure drvdata = NULL when no
driver is bound) removes the need to set driver data field to
NULL.
Signed-off-by: Sachin Kamat
---
.../platform/soc_camera/soc_camera_platform.c |7 ---
1 file changed, 7 deletions(-)
diff --git a/drivers/media
1 - 100 of 345 matches
Mail list logo
