Re: [PATCH 10/12] lguest: Only descend into lguest directory when CONFIG_LGUEST is set

2016-06-20 Thread Rusty Russell
"Andrew F. Davis" writes: > When CONFIG_LGUEST is not set make will still descend into the lguest > directory but nothing will be built. This produces unneeded build > artifacts and messages in addition to slowing the build. Fix this here. > > Signed-off-by: Andrew F. Davis > --- > drivers/Makef

Re: WARNING: CPU: 1 PID: 813 at kernel/module.c:291 module_assert_mutex_or_preempt+0x49/0x90()

2015-08-23 Thread Rusty Russell
e its true that the module cannot go away while we hold a reference on it, the data structure we do the lookup in very much _CAN_ change while we do the lookup. Therefore fix the comment and add the required preempt_disable(). Reported-by: poma Signed-off-by: Peter Zijlstra (Intel) Signed-off

Re: [PATCH 05/16] cx18: fix handling of 'radio' module parameter

2012-01-31 Thread Rusty Russell
On Tue, 31 Jan 2012 14:45:18 +0100, Danny Kukawka wrote: > On Dienstag, 31. Januar 2012, Andy Walls wrote: > Overseen this. But wouldn't be the correct fix in this case to: > a) reverse the part of 90ab5ee94171b3e28de6bb42ee30b527014e0be7 to: >get: >static unsigned radio_c = 1; > > b

Re: [PATCH 12/15] module_param: make bool parameters really bool (drivers & misc)

2012-01-03 Thread Rusty Russell
l idonly = 0; > > +static bool bailearly = 0; > > bailearly should be an int here. It's part of some ugly debug code > where a value of 3 means bailout at point 3. Maybe we should just > remove it instead... Yeah, it never worked, since you could only ever set it

[PATCH 1/15] module_param: check type correctness for module_param_array

2011-12-14 Thread Rusty Russell
module_param_array(), unlike its non-array cousins, didn't check the type of the variable. Fixing this found two bugs. Cc: Luca Risolia Cc: Mauro Carvalho Chehab Cc: Eric Piel Cc: linux-media@vger.kernel.org Signed-off-by: Rusty Russell --- drivers/media/video/et61x251/et61x251_c

Re: [PATCH 3/3] use the new request_module_nowait() in drivers/media

2009-02-10 Thread Rusty Russell
On Tuesday 10 February 2009 03:04:56 Mauro Carvalho Chehab wrote: > On Sun, 8 Feb 2009 11:00:52 -0800 > Arjan van de Ven wrote: > > From: Arjan van de Ven > > Subject: [PATCH] use the new request_module_nowait() in drivers/media ... > Acked-by: Mauro Carvalho Chehab > > Cheers, > Mauro Thanks