HI Tomasz
On Mon, Oct 7, 2019 at 11:43 AM Tomasz Figa wrote:
>
> Hi Ricardo,
>
> On Mon, Oct 7, 2019 at 6:22 PM Ricardo Ribalda Delgado
> wrote:
> >
> > HI Nicolas
> >
> > Sorry to hijack the thread. Do you know if anyone at AMD is working on
> >
by VAAPI has a similar design.
>
> I'll try to gather some information next week about that to prepare a
> little. As of now, we have the Rockchip mpp library and the ChromeOS
> version (which is reusing the previous one code). Then the Intel and
> AMD VAAPI drivers (which is implemented in FFMPEG and GStreamer).
>
> Maybe Paul can provide some known information about the CEDRUS (if
> any), even though this is probably harder to gather. We can also study
> software encoders like OpenH264, x264, libvpx etc. to see if there is a
> trend of parameters between the state manager and the low level
> encoders.
>
> Overall goal are, I believe (draft):
> - Find out if there is a common set of per frame encoding parameter
> - Find out if bitrate control can be reused for multiple HW
> - Decide if we do in-kernel bitrate control or not
> - Decide if we keep bitstream header crafting external (unlike Hantro
> JPEG encoder. but like VAAPI)
> - Decide if we provide (and maintain) a libv4l2 plugin like ChromeOS
> folks opted for.
>
> >
> > Best regards,
> > Tomasz
> >
> > > - Anything else? (I have a feeling I missed a codec-related topic, but
> > > I can't find it in my mailbox)
> > >
> > > Regards,
> > >
> > > Hans
>
--
Ricardo Ribalda
Hello Hans
Thanks for your review! I will implement the changes and resend, just
one comment.
On Fri, Sep 20, 2019 at 12:07 PM Hans Verkuil wrote:
>
> On 9/17/19 6:21 PM, Ricardo Ribalda Delgado wrote:
> > Hi Hans
> >
> > Is this something close to what you were havi
:19 PM Ricardo Ribalda Delgado
wrote:
>
> Implement v4l2_ctrl_new_std_compound. This is just a discussion patch,
> do not merge as is, and be gentle with the author ;P.
>
> Signed-off-by: Ricardo Ribalda Delgado
> ---
> drivers/media/i2c/imx214.c | 13 +++--
>
Implement v4l2_ctrl_new_std_compound. This is just a discussion patch,
do not merge as is, and be gentle with the author ;P.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/i2c/imx214.c | 13 +++--
drivers/media/v4l2-core/v4l2-ctrls.c | 79
On Fri, Aug 23, 2019 at 2:56 PM Philipp Zabel wrote:
>
> On Fri, 2019-08-23 at 14:37 +0200, Ricardo Ribalda Delgado wrote:
> > Adding a V4L2_CID_UNIT_CELL_SIZE control requires a lot of boilerplate,
> > try to minimize it by adding a new helper.
> >
> > Suggested-by:
This control returns the unit cell size in nanometres. The struct provides
the width and the height in separated fields to take into consideration
asymmetric pixels and/or hardware binning.
This control is required for automatic calibration of sensors/cameras.
Signed-off-by: Ricardo Ribalda
Helper for creating area controls.
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/kapi/v4l2-controls.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/Documentation/media/kapi/v4l2-controls.rst
b/Documentation/media/kapi/v4l2-controls.rst
index ebe2a55908be
A struct v4l2_area containing the width and the height of a rectangular
area.
Signed-off-by: Ricardo Ribalda Delgado
Suggested-by: Hans Verkuil
---
Documentation/media/uapi/v4l/vidioc-queryctrl.rst | 6 ++
1 file changed, 6 insertions(+)
diff --git a/Documentation/media/uapi/v4l/vidioc
According to the product brief, the unit cell size is 1120 nanometers^2.
https://www.sony-semicon.co.jp/products_en/IS/sensor1/img/products/ProductBrief_IMX214_20150428.pdf
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/i2c/imx214.c | 23 +++
1 file changed, 23
Adding a V4L2_CID_UNIT_CELL_SIZE control requires a lot of boilerplate,
try to minimize it by adding a new helper.
Suggested-by: Philipp Zabel
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/v4l2-core/v4l2-ctrls.c | 25 -
include/media/v4l2-ctrls.h
Instead of creating manually the V4L2_CID_UNIT_CELL_SIZE control, lets
use the helper.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/i2c/imx214.c | 29 -
1 file changed, 8 insertions(+), 21 deletions(-)
diff --git a/drivers/media/i2c/imx214.c b/drivers
New control to pass to userspace the width/height of a pixel. Which is
needed for calibration and lens selection.
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/uapi/v4l/ext-ctrls-image-source.rst | 8
1 file changed, 8 insertions(+)
diff --git a/Documentation/media
We have passed the barrier of 64 supported formats, therefore a int64_t
is not enough for holding the bitfield.
Instead use bit-ops ala kernel.
Signed-off-by: Ricardo Ribalda Delgado
Suggested-by: Hans de Goede
---
lib/libv4lconvert/libv4lconvert-priv.h | 3 +-
lib/libv4lconvert
NV12 is a two-plane version YUV 4:2:0, where the U and V components
are subsampled 2x2.
Signed-off-by: Ricardo Ribalda Delgado
---
Changelog v2:
- None
The code has ben tested with qv4l2 and vivid.
v4lconvert_nv12_to_yuv420 has not been tested!!, any suggestions for
how to do it?
lib
Hi Hans
On Tue, Apr 16, 2019 at 6:00 PM Hans de Goede wrote:
>
> Hi Ricardo,
>
> On 16-04-19 14:02, Ricardo Ribalda Delgado wrote:
> > NV12 is a two-plane version YUV 4:2:0, where the U and V components
> > are subsampled 2x2.
> >
> > Signed-off-by: Ricardo R
NV12 is a two-plane version YUV 4:2:0, where the U and V components
are subsampled 2x2.
Signed-off-by: Ricardo Ribalda Delgado
---
The code has ben tested with qv4l2 and vivid.
v4lconvert_nv12_to_yuv420 has not been tested!!, any suggestions for
how to do it?
Thanks!
lib/libv4lconvert
4l2/notes/osseu18-media.html>
> > > >
> > > >
> > > > Attendees
> > > > -
> > > >
> > > > Brad Love
> > > > Ezequiel Garcia
> > > > Gustavo Padovan
> > > > Hans Verkuil
> >
t_bayer10_to_bayer8
>
> Tested using vivid included in linux v5.0-rc8.
>
> Signed-off-by: Daniel Gomez
Signed-off-by: Ricardo Ribalda
> ---
> lib/libv4lconvert/bayer.c | 10
> lib/libv4lconvert/libv4lconvert-priv.h | 2 +
> lib/libv4lconvert/libv4lcon
nux v5.0-rc8.
>
> Signed-off-by: Daniel Gomez
Signed-off-by: Ricardo Ribalda
> ---
> lib/libv4lconvert/bayer.c | 9 ++
> lib/libv4lconvert/libv4lconvert-priv.h | 3 ++
> lib/libv4lconvert/libv4lconvert.c | 45 ++
> 3 files c
10 bit packet Bayer format broke the support for the other
compressed bayer formats.
Due to the fallthrough of the compressed formats, 10b code will be
executed for every 10b format.
Fixes: c44b30096589 ("libv4l: Add support for BAYER10P format conversion")
Signed-off-by: Ricardo Ribal
h
> > should also set it).
> >
> > Also, the entire logic there depends on having format != NULL, so
> > just remove the bogus broken support for a null format.
I believe it is a relic for when I did not use imx214_entity_init_cfg.
Sorry about that.
> >
> > Signed-o
Documentation and code was linking the old documentation at:
http://v4l2spec.bytesex.org/spec/x1904.htm
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/v4l-drivers/sh_mobile_ceu_camera.rst | 2 +-
drivers/media/platform/sh_vou.c | 2 +-
2 files changed, 2
7
> > bDescriptorType 5
> > bEndpointAddress 0x82 EP 2 IN
> > bmAttributes5
> > Transfer TypeIsochronous
> > Synch Type Asynchronous
> > Usage Type Data
> > wMaxPacketSize 0x0200 1x 512 bytes
> > bInterval 1
> > Interface Descriptor:
> > bLength 9
> > bDescriptorType 4
> > bInterfaceNumber3
> > bAlternateSetting 3
> > bNumEndpoints 1
> > bInterfaceClass14 Video
> > bInterfaceSubClass 2 Video Streaming
> > bInterfaceProtocol 0
> > iInterface 0
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x82 EP 2 IN
> > bmAttributes5
> > Transfer TypeIsochronous
> > Synch Type Asynchronous
> > Usage Type Data
> > wMaxPacketSize 0x0400 1x 1024 bytes
> > bInterval 1
> > Interface Descriptor:
> > bLength 9
> > bDescriptorType 4
> > bInterfaceNumber3
> > bAlternateSetting 4
> > bNumEndpoints 1
> > bInterfaceClass14 Video
> > bInterfaceSubClass 2 Video Streaming
> > bInterfaceProtocol 0
> > iInterface 0
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x82 EP 2 IN
> > bmAttributes5
> > Transfer TypeIsochronous
> > Synch Type Asynchronous
> > Usage Type Data
> > wMaxPacketSize 0x0b00 2x 768 bytes
> > bInterval 1
> > Interface Descriptor:
> > bLength 9
> > bDescriptorType 4
> > bInterfaceNumber3
> > bAlternateSetting 5
> > bNumEndpoints 1
> > bInterfaceClass14 Video
> > bInterfaceSubClass 2 Video Streaming
> > bInterfaceProtocol 0
> > iInterface 0
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x82 EP 2 IN
> > bmAttributes5
> > Transfer TypeIsochronous
> > Synch Type Asynchronous
> > Usage Type Data
> > wMaxPacketSize 0x0c00 2x 1024 bytes
> > bInterval 1
> > Interface Descriptor:
> > bLength 9
> > bDescriptorType 4
> > bInterfaceNumber3
> > bAlternateSetting 6
> > bNumEndpoints 1
> > bInterfaceClass14 Video
> > bInterfaceSubClass 2 Video Streaming
> > bInterfaceProtocol 0
> > iInterface 0
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x82 EP 2 IN
> > bmAttributes5
> > Transfer TypeIsochronous
> > Synch Type Asynchronous
> > Usage Type Data
> > wMaxPacketSize 0x13aa 3x 938 bytes
> > bInterval 1
> > Interface Descriptor:
> > bLength 9
> > bDescriptorType 4
> > bInterfaceNumber3
> > bAlternateSetting 7
> > bNumEndpoints 1
> > bInterfaceClass14 Video
> > bInterfaceSubClass 2 Video Streaming
> > bInterfaceProtocol 0
> > iInterface 0
> > Endpoint Descriptor:
> > bLength 7
> > bDescriptorType 5
> > bEndpointAddress 0x82 EP 2 IN
> > bmAttributes5
> > Transfer TypeIsochronous
> > Synch Type Asynchronous
> > Usage Type Data
> > wMaxPacketSize 0x1400 3x 1024 bytes
> > bInterval 1
> > Device Qualifier (for other device speed):
> > bLength10
> > bDescriptorType 6
> > bcdUSB 2.00
> > bDeviceClass 239 Miscellaneous Device
> > bDeviceSubClass 2
> > bDeviceProtocol 1 Interface Association
> > bMaxPacketSize064
> > bNumConfigurations 1
> > Device Status: 0x
> > (Bus Powered)
> >
> >
> >
> > thanks,
> >
>
--
Ricardo Ribalda
-off-by: Ricardo Ribalda Delgado
---
drivers/media/i2c/imx214.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
index fe01a13f13c5..284b9b49ebde 100644
--- a/drivers/media/i2c/imx214.c
+++ b/drivers/media/i2c/imx214.c
Add a V4L2 sub-device driver for the Sony IMX214 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Tested on a DB820c alike board with Intrinsyc Open-Q 13MP camera.
Signed-off-by: Ricardo Ribalda Delgado
Reviewed-by: Jacopo Mondi
---
Changelog from
Document bindings for imx214 camera sensor
Cc: devicet...@vger.kernel.org
Reviewed-by: Laurent Pinchart
Signed-off-by: Ricardo Ribalda Delgado
---
Changelog from v10:
Sakari Ailus:
-Re-introduce clock-frequency property
.../bindings/media/i2c/sony,imx214.txt| 53
Document bindings for imx214 camera sensor
Cc: devicet...@vger.kernel.org
Reviewed-by: Laurent Pinchart
Signed-off-by: Ricardo Ribalda Delgado
---
Changelog from v10:
Sakari Ailus:
-remove clock name
.../bindings/media/i2c/sony,imx214.txt| 51 +++
1 file changed, 51
Hi Sakari
On Sat, Oct 6, 2018 at 12:02 AM Sakari Ailus wrote:
>
> Hi Ricardo,
>
> On Fri, Oct 05, 2018 at 11:57:50PM +0200, Ricardo Ribalda Delgado wrote:
> > Document bindings for imx214 camera sensor
> >
> > Cc: devicet...@vger.kernel.org
> > Reviewed-by:
Document bindings for imx214 camera sensor
Cc: devicet...@vger.kernel.org
Reviewed-by: Laurent Pinchart
Signed-off-by: Ricardo Ribalda Delgado
---
Changelog from v8:
Rob Herring:
-rename file
-Move address to reg
-rename name on example
-Patch author
Sakari Ailus:
-should->sh
-off-by: Ricardo Ribalda Delgado
---
drivers/media/i2c/imx214.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/i2c/imx214.c b/drivers/media/i2c/imx214.c
index 46a2fdfbd049..0b99123161b8 100644
--- a/drivers/media/i2c/imx214.c
+++ b/drivers/media/i2c/imx214.c
From: Ricardo Ribalda
Document bindings for imx214 camera sensor
Cc: devicet...@vger.kernel.org
Reviewed-by: Laurent Pinchart
Signed-off-by: Ricardo Ribalda Delgado
---
.../devicetree/bindings/media/i2c/imx214.txt | 53 +++
1 file changed, 53 insertions(+)
create mode
Add a V4L2 sub-device driver for the Sony IMX214 image sensor.
This is a camera sensor using the I2C bus for control and the
CSI-2 bus for data.
Tested on a DB820c alike board with Intrinsyc Open-Q 13MP camera.
Signed-off-by: Ricardo Ribalda Delgado
Reviewed-by: Jacopo Mondi
---
Changelog from
Document bindings for imx214 camera sensor
Cc: devicet...@vger.kernel.org
Signed-off-by: Ricardo Ribalda Delgado
---
Changelog from v2:
Laurent Pinchart:
-Spell checks
-Remove frequency
-Identation
-Data lanes order
Thanks!
.../devicetree/bindings/media/i2c/imx214.txt | 52
The loop seemed to be made to calculate max, but max is not used in that
function.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/i2c/smiapp/smiapp-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/i2c/smiapp/smiapp-core.c
b/drivers/media/i2c
the
focus was back to its original position :S.
Apparently, this has not been an issue before because usually there is
a close loop program constantly setting up the focus and not closing
the device.
Shouldn't we poweron the focus when the pipeline is running?
Regards!
--
Ricardo Ribalda
Add support for 10 bit packet Bayer formats:
-V4L2_PIX_FMT_SBGGR10P
-V4L2_PIX_FMT_SGBRG10P
-V4L2_PIX_FMT_SGRBG10P
-V4L2_PIX_FMT_SRGGB10P
These formats pack the 2 LSBs for every 4 pixels in an indeppendent
byte.
Signed-off-by: Ricardo Ribalda Delgado
---
lib/libv4lconvert/bayer.c
Hi Hans
On Fri, Sep 21, 2018 at 9:38 AM Hans de Goede wrote:
>
> Hi,
>
> On 20-09-18 22:04, Ricardo Ribalda Delgado wrote:
> > Add support for 10 bit packet Bayer formats:
> > -V4L2_PIX_FMT_SBGGR10P
> > -V4L2_PIX_FMT_SGBRG10P
> > -V4L2_PIX_FMT_SGRBG10P
>
. And
> > the digital gain control is no exception to this.
> >
> > So if we want to improve the user space's ability to be informed how the
> > control values reflect to device configuration, we do need to provide more
> > information to the user space. One way to do that would be through
> > VIDIOC_QUERY_EXT_CTRL. The IOCTL struct has plenty of reserved fields ---
> > just for purposes such as this one.
>
> I don't think we can come up with a good way to expose arbitrary mathematical
> formulas through an ioctl. In my opinion the question is how far we want to
> go, how precise we need to be.
>
> > > Any opinions or better ideas?
My 0.02 DKK. On a similar situation, where userspace was running a
close loop calibration:
We have implemented two extra control: eposure_next exposure_pre that
tell us which one is the next value. Perhaps we could embebed such
functionality in QUERY_EXT_CTRL.
Cheers
>
> --
> Regards,
>
> Laurent Pinchart
>
>
>
--
Ricardo Ribalda
HI
Sorry, I did not check the produced files before sending them with git
send-email. It has been a long day. Please ignore v3 and use v4.
I will write 100 times: I will check my patches before sending them
to the mailing list
Cheers
--
Ricardo Ribalda
Add support for 10 bit packet Bayer formats:
-V4L2_PIX_FMT_SBGGR10P
-V4L2_PIX_FMT_SGBRG10P
-V4L2_PIX_FMT_SGRBG10P
-V4L2_PIX_FMT_SRGGB10P
These formats pack the 2 LSBs for every 4 pixels in an indeppendent
byte.
Signed-off-by: Ricardo Ribalda Delgado
---
lib/libv4lconvert/bayer.c
how we are integrating
that calibration flash with v4l2-ctrl. And if this feature is useful
for someone else and upstream it.
Thanks!
--
Ricardo Ribalda
that exports the
internal flags to userspace.
Reported-by: Dimitrios Katsaros
Signed-off-by: Ricardo Ribalda Delgado
---
Attention: Maybe we want to cc stable.
v2: Suggested-by Hans Verkuil
-Define struct v4l2_ctrl as const
drivers/media/v4l2-core/v4l2-ctrls.c | 16
1 file
that exports the
internal flags to userspace.
Reported-by: Dimitrios Katsaros
Signed-off-by: Ricardo Ribalda Delgado
---
Maybe we should cc stable on this one.
drivers/media/v4l2-core/v4l2-ctrls.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/drivers
max_width and max_height are swap with step_width and step_height.
Signed-off-by: Ricardo Ribalda Delgado
---
Since that this bug has been here for ever. I do not know if we should
notify stable or not
I have also cut the lines to respect the 80 char limit
v2: Suggested by Laurent Pinchart
max_width and max_height are swap with step_width and step_height.
Signed-off-by: Ricardo Ribalda Delgado
---
Since that this bug has been here for ever. I do not know if we should
notify stable or not
I have also cut the lines to respect the 80 char limit
drivers/media/v4l2-core/v4l2
Hi Hans
On Fri, Sep 1, 2017 at 11:46 AM, Hans Verkuil wrote:
>
>
> Also, if you plan to attend, please let me know. It is open for all, but it is
> nice if we know beforehand who we can expect.
>
I plan to attend. I do not have any specific topic right now, but as
the date gets closer I might ad
r Function : Default
YCbCr/HSV Encoding: Hue 0 - 179
Quantization : Default
Flags :
Signed-off-by: Ricardo Ribalda Delgado
---
utils/v4l2-ctl/v4l2-ctl.cpp | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/utils/v4l2-ctl/v4l2-ctl.cpp b/
Support set/get and override of HSV encodings.
Signed-off-by: Ricardo Ribalda Delgado
---
utils/qv4l2/general-tab.cpp | 4 +++-
utils/qv4l2/qv4l2.cpp | 5 -
utils/qv4l2/tpg-tab.cpp | 4 +++-
3 files changed, 10 insertions(+), 3 deletions(-)
diff --git a/utils/qv4l2/general
Zero is not a valid value for hsv_enc. Set the field to a valid
initial value.
This is not a problem for vivid, because it sets the field to 180 via
tpg_s_hsv_enc() on the control initialization, but it might be a source
of errors for other drivers that use this code.
Signed-off-by: Ricardo
HSV formats were missing the color encoding, which leads to an invalid
ycbcr_enc value during get_fmt and try_fmt.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/platform/vivid/vivid-vid-common.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/platform/vivid/vivid
Support for HSV32 and HSV24.
Signed-off-by: Ricardo Ribalda Delgado
---
utils/qv4l2/capture-win-gl.cpp | 32 +++-
1 file changed, 31 insertions(+), 1 deletion(-)
diff --git a/utils/qv4l2/capture-win-gl.cpp b/utils/qv4l2/capture-win-gl.cpp
index af1909c936c5
HSV32 and HSV24 are single plane interleaved Hue Saturation Value
formats.
Signed-off-by: Ricardo Ribalda Delgado
---
lib/libv4lconvert/libv4lconvert-priv.h | 3 ++
lib/libv4lconvert/libv4lconvert.c | 62 +++
lib/libv4lconvert/rgbyuv.c | 77
: vsp1: Add support for capture and output in HSV formats
Ricardo Ribalda Delgado (12):
videodev2.h Add HSV formats
Documentation: Add HSV format
Documentation: Add Ricardo Ribalda
vivid: Code refactor for color encoding
vivid: Add support for HSV formats
vivid
1242d7e43b9053cd649ac5ec81aad8597e88ab46:
[media] vsp1: Add support for capture and output in HSV formats
(2016-09-07 10:41:52 +0200)
Laurent Pinchart (1):
[media] vsp1: Add support for capture and output in HSV formats
Ricardo Ribalda Delgado (12
Hi Laurent,
On Wed, Sep 7, 2016 at 9:09 AM, Laurent Pinchart
wrote:
>>
>> Signed-off-by: Ricardo Ribalda Delgado
>
> Do you mean Acked-by ?
Acked-by: Ricardo Ribalda Delgado
Ups, my bad
>
> Feel free to take the patch in your tree to get it merged along with the
ed-off-by: Ricardo Ribalda Delgado
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Some hardware maps the Hue between 0 and 255 instead of 0-179. Support
this format with a new field hsv_enc.
Signed-off-by: Ricardo Ribalda Delgado
---
v5_2: s/s_rgb_or_yuv/s_rgb_or_hsv/
Thanks Hans!!
include/uapi/linux/videodev2.h | 32 +++-
1 file changed, 27
Hello Hans:
>
> That should be is_rgb_or_hsv.
Sorry about that! I am resending v5_2 with only that patch fixed
>
> All other patches look OK.
Thanks
>
> It would be useful though if you could rebase on top of
> https://git.linuxtv.org/hverkuil/media_tree.git/log/?h=sycc.
> I have a pull reque
precalculate_color() had a optimization that avoided duplicated
conversion for YUV formats. This optimization did not take into
consideration YUV444, YUV555, YUV565 or limited range quantization.
This patch keeps the optimization, but fixes the wrong handling.
Signed-off-by: Ricardo Ribalda
Replace is_yuv with color_enc Which can be used by other
color encodings such us HSV.
This change should ease the review of the following patches.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 49 +++
drivers/media/platform
r_y and g_u now also contain the H and V components on the HSV formats.
Rename the variables to reflect this.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 209 +-
1 file changed, 105 insertions(+), 104 deletions(-)
diff
Simplifies handling of Gray formats.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 26 +++--
drivers/media/platform/vivid/vivid-vid-common.c | 6 +++---
include/media/v4l2-tpg.h| 1 +
3 files changed
Some hardware maps the Hue between 0 and 255 instead of 0-179. Support
this format with a new field hsv_enc.
Signed-off-by: Ricardo Ribalda Delgado
---
include/uapi/linux/videodev2.h | 32 +++-
1 file changed, 27 insertions(+), 5 deletions(-)
diff --git a/include
Describe the HSV formats
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/uapi/v4l/hsv-formats.rst | 19 +++
Documentation/media/uapi/v4l/pixfmt-packed-hsv.rst | 158 +
Documentation/media/uapi/v4l/pixfmt.rst| 1 +
Documentation/media/uapi
This patch adds support for V4L2_PIX_FMT_HSV24 and V4L2_PIX_FMT_HSV32.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 93 +++--
drivers/media/platform/vivid/vivid-vid-common.c | 14
include/media/v4l2-tpg.h
Support HSV encoding. Most of the logic is replicated from ycbcr_enc.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 25 +
drivers/media/platform/vivid/vivid-core.h | 1 +
drivers/media/platform/vivid/vivid-ctrls.c
op of docs-next (port documentation to .rst)
Ricardo Ribalda Delgado (12):
[media] videodev2.h Add HSV formats
[media] Documentation: Add HSV format
[media] Documentation: Add Ricardo Ribalda
[media] vivid: Code refactor for color encoding
[media] vivid: Add support for HSV formats
[me
Avoid duplicated clamps when possible.
Suggested-by: Philipp Zabel
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c
b
My initials were on the Changelog, but there was no link to my name.
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/uapi/v4l/v4l2.rst | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/media/uapi/v4l/v4l2.rst
b/Documentation/media/uapi/v4l/v4l2.rst
index
.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++
include/uapi/linux/videodev2.h | 4
2 files changed, 6 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c
b/drivers/media/v4l2-core/v4l2-ioctl.c
index 51a0fa144392..16b211f7212b 100644
Describe the hsv_enc field and its use.
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/uapi/v4l/pixfmt-002.rst| 12 ++-
Documentation/media/uapi/v4l/pixfmt-003.rst| 14 ++--
Documentation/media/uapi/v4l/pixfmt-006.rst| 41
Hi
On Tue, Aug 2, 2016 at 1:34 PM, Baole Ni wrote:
> thus, I suggest replacing the numeric parameter with the macro.
For what my opinion is worth it... I found more comprehensive the
octal values than the macros, but maybe it is because I am old and
dream in hexadecimal
I do not know if the
V4L2_CTRL_FLAG_VOLATILE behaviour when V4L2_CTRL_FLAG_EXECUTE_ON_WRITE
is set was not properly explained.
Also set some hyperlink to ease the Documentation browsing.
Reported-by: Dimitrios Katsaros
Credit-to: Hans Verkuil
Signed-off-by: Ricardo Ribalda Delgado
---
v2: By Hans Verkuil
-Fix
V4L2_CTRL_FLAG_VOLATILE behaviour when V4L2_CTRL_FLAG_EXECUTE_ON_WRITE
is set was not properly explained.
Reported-by: Dimitrios Katsaros
Credit-to: Hans Verkuil
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/uapi/v4l/vidioc-queryctrl.rst | 8
1 file changed, 4
}
I like this variant much better than mine. I have applied to my local
tree. So it will be what I post on v5
Thanks for you comments :)
btw: it is scary what the compiler optimizations are capable of doing these days
--
Ricardo Ribalda
--
To unsubscribe from this list: send the li
.
Now it is only one.
Best regards!
--
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/v4l2-core/v4l2-ioctl.c | 2 ++
include/uapi/linux/videodev2.h | 4
2 files changed, 6 insertions(+)
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c
b/drivers/media/v4l2-core/v4l2-ioctl.c
index f899bf1c5fc0..54670cd59212 100644
Replace is_yuv with color_enc Which can be used by other
color encodings such us HSV.
This change should ease the review of the following patches.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 49 +++
drivers/media/platform
(port documentation to .rst)
Ricardo Ribalda Delgado (12):
[media] videodev2.h Add HSV formats
[media] Documentation: Add HSV format
[media] Documentation: Add Ricardo Ribalda
[media] vivid: Code refactor for color encoding
[media] vivid: Add support for HSV formats
[media] vivid: Rename
My initials were on the Changelog, but there was no link to my name.
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/uapi/v4l/v4l2.rst | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/media/uapi/v4l/v4l2.rst
b/Documentation/media/uapi/v4l/v4l2.rst
index
Simplifies handling of Gray formats.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 26 +++--
drivers/media/platform/vivid/vivid-vid-common.c | 6 +++---
include/media/v4l2-tpg.h| 1 +
3 files changed
Some hardware maps the Hue between 0 and 255 instead of 0-179. Support
this format with a new field hsv_enc.
Signed-off-by: Ricardo Ribalda Delgado
---
include/uapi/linux/videodev2.h | 21 +++--
1 file changed, 19 insertions(+), 2 deletions(-)
diff --git a/include/uapi/linux
This patch adds support for V4L2_PIX_FMT_HSV24 and V4L2_PIX_FMT_HSV32.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 93 +++--
drivers/media/platform/vivid/vivid-vid-common.c | 14
include/media/v4l2-tpg.h
precalculate_color() had a optimization that avoided duplicated
conversion for YUV formats. This optimization did not take into
consideration YUV444, YUV555, YUV565 or limited range quantization.
This patch keeps the optimization, but fixes the wrong handling.
Signed-off-by: Ricardo Ribalda
r_y and g_u now also contain the H and V components on the HSV formats.
Rename the variables to reflect this.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 209 +-
1 file changed, 105 insertions(+), 104 deletions(-)
diff
Describe the HSV formats
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/uapi/v4l/hsv-formats.rst | 19 +++
Documentation/media/uapi/v4l/pixfmt-packed-hsv.rst | 158 +
Documentation/media/uapi/v4l/pixfmt.rst| 1 +
Documentation/media/uapi
Support HSV encoding. Most of the logic is replicated from ycbcr_enc.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 25 +
drivers/media/platform/vivid/vivid-core.h | 1 +
drivers/media/platform/vivid/vivid-ctrls.c
Describe the hsv_enc field and its use.
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/uapi/v4l/pixfmt-002.rst| 12 ++-
Documentation/media/uapi/v4l/pixfmt-003.rst| 14 ++--
Documentation/media/uapi/v4l/pixfmt-006.rst| 38
Avoid duplicated data shifts when possible.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c
b/drivers/media/common/v4l2-tpg
Hi Hans
On Mon, Jul 18, 2016 at 10:51 AM, Hans Verkuil wrote:
>> + int y, cb, cr;
>> + bool ycbbr_valid = false;
>
> I guess you mean ycbcr_valid?
Yes, I think the medical term is Saturday dyslexia :)
It is fixed on the next version.
Thanks!
--
To unsubscribe from this list: send the
Hi Hans
On Sat, Jul 16, 2016 at 5:28 PM, Hans Verkuil wrote:
>
>> +
>> +enum v4l2_rgb_encoding {
>> + V4L2_RGB_ENC_FULL = 32,
>> + V4L2_HSV_ENC_16_235 = 33,
>> +};
>
> No.
I was trying to fit also Laurent special 16-235 RGB format. I will
remove it on future versions.
Ca
xfer_func;
__u8reserved[7];
> --
Best regards!
--
Ricardo Ribalda
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi
On Sat, Jul 16, 2016 at 12:41 PM, Ricardo Ribalda Delgado
wrote:
> - cr = clamp(cr, 16 << 4, 240 << 4);
> + y = clamp(y >> 4, 16, 235);
> + cb = clamp(cb >> 4, 16, 240);
> +
precalculate_color() had a optimization that avoided duplicated
conversion for YUV formats. This optimization did not take into
consideration YUV444, YUV555, YUV565 or limited range quantization.
This patch keeps the optimization, but fixes the wrong handling.
Signed-off-by: Ricardo Ribalda
r_y and g_u now also contain the H and V components on the HSV formats.
Rename the variables to reflect this.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 209 +-
1 file changed, 105 insertions(+), 104 deletions(-)
diff
Describe the HSV formats
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/uapi/v4l/hsv-formats.rst | 19 +++
Documentation/media/uapi/v4l/pixfmt-packed-hsv.rst | 158 +
Documentation/media/uapi/v4l/pixfmt.rst| 1 +
Documentation/media/uapi
Avoid duplicated data shifts when possible.
Signed-off-by: Ricardo Ribalda Delgado
---
drivers/media/common/v4l2-tpg/v4l2-tpg-core.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/media/common/v4l2-tpg/v4l2-tpg-core.c
b/drivers/media/common/v4l2-tpg
My initials were on the Changelog, but there was no link to my name.
Signed-off-by: Ricardo Ribalda Delgado
---
Documentation/media/uapi/v4l/v4l2.rst | 4
1 file changed, 4 insertions(+)
diff --git a/Documentation/media/uapi/v4l/v4l2.rst
b/Documentation/media/uapi/v4l/v4l2.rst
index
gray formats
-CodeStyle
Thanks!
v2: Suggested by Mauro Carvalho Chehab ,
-Rebase on top of docs-next (port documentation to .rst)
Ricardo Ribalda Delgado (9):
[media] videodev2.h Add HSV formats
[media] Documentation: Add HSV format
[media] Documentation: Add Ricardo Ribalda
[media] vivid
1 - 100 of 452 matches
Mail list logo
