_hz <= 200)
> + bandwidth = 0x02;
Please fix checkpatch errors for this patch aswel.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
dev_err(&client->dev, "automatic bandwidth not supported");
> + goto err;
> + }
> + else if (c->bandwidth_hz <= 500)
> bandwidth = 0x05;
Checkpatch should catch it. did you run checkpatch ?
Thanks,
--Prabhakar Lad
v4l_info(client, "failed to initialize media entity!\n");
> + kfree(state);
Not required.
> + return -ENODEV;
return ret; instead ?
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
as not able to utilize my holidays
in proper way :D
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
up
> and running with this kernel to test it but more help with this would
> be much appreciated.
>
FYI, I am on a holiday and out of reach of the hardware, will test it once I get
from holiday after Christmas.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: sen
On Thu, Dec 4, 2014 at 3:24 PM, Hans Verkuil wrote:
> From: Hans Verkuil
>
> Weird, this op isn't used at all. Seems to be orphaned code.
> Remove it.
>
> Signed-off-by: Hans Verkuil
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> ---
> include/media/v
t Pinchart
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> ---
> drivers/media/v4l2-core/v4l2-subdev.c | 8
> include/media/v4l2-subdev.h | 4
> 2 files changed, 12 deletions(-)
>
> diff --git a/drivers/media/v4l2-core/v4l2-subdev.c
> b/dri
Hans Verkuil
> Acked-by: Sylwester Nawrocki
> Acked-by: Laurent Pinchart
> Cc: Prabhakar Lad
> Cc: Philipp Zabel
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> ---
> drivers/media/i2c/mt9m032.c | 42 ---
> drivers
ll accepted for
> 3.19.
>
OK will post a v4 tonight fixing all the below issues.
FYI: Looking at the response of Mauro on 'soc-camera: 1st set for 3.19'
he wont accept it!
Thanks,
--Prabhakar Lad
> On 12/04/2014 12:12 AM, Lad, Prabhakar wrote:
>> From: Benoit Parrot
>
er.
>
> Signed-off-by: Hans Verkuil
> Cc: Sylwester Nawrocki
> Cc: Laurent Pinchart
> Cc: Prabhakar Lad
> Cc: Philipp Zabel
> ---
> drivers/media/i2c/mt9m032.c | 40 +++---
> drivers/media/i2c/mt9p031.c | 40
3 Sequence: 119 Field: None Timestamp: 76.711771s
test MMAP: OK
test USERPTR: OK (Not Supported)
test DMABUF: Cannot test, specify --expbuf-device
Total: 42, Succeeded: 42, Failed: 0, Warnings: 0
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsu
Hi Hans,
On Mon, Dec 1, 2014 at 11:26 PM, Laurent Pinchart
wrote:
> Hi Prabhakar,
>
> On Sunday 30 November 2014 21:30:35 Prabhakar Lad wrote:
>> On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart wrote:
>> > On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote:
>>
Hi Hans,
On Tue, Dec 2, 2014 at 7:32 AM, Hans Verkuil wrote:
> On 12/01/2014 11:27 PM, Prabhakar Lad wrote:
>> Hi Hans,
>>
>> On Mon, Dec 1, 2014 at 11:00 AM, Hans Verkuil wrote:
>>> On 12/01/2014 11:11 AM, Hans Verkuil wrote:
>>>> Hi all,
>>&
Hi Hans,
On Tue, Dec 2, 2014 at 7:26 AM, Hans Verkuil wrote:
> On 12/01/2014 11:17 PM, Prabhakar Lad wrote:
>> Hi Hans,
>>
>> Thanks for the review.
>>
>> On Mon, Dec 1, 2014 at 10:11 AM, Hans Verkuil wrote:
>>> Hi all,
>>>
>>> Than
take a decision
on this quickly I can post a v2 soon.
> One question, unrelated to this patch series:
>
> Prabhakar, would it make sense to look at the various existing TI sources
> as well and rename them to make it more explicit for which SoCs they are
> meant? Most are pretty vagu
Hi Hans,
Thanks for the review.
On Mon, Dec 1, 2014 at 10:11 AM, Hans Verkuil wrote:
> Hi all,
>
> Thanks for the patch, review comments are below.
>
> For the next version I would appreciate if someone can test this driver with
> the latest v4l2-compliance from the v4l-utils git repo. If possib
Hi Laurent,
On Sun, Nov 30, 2014 at 9:16 PM, Laurent Pinchart
wrote:
> On Sunday 30 November 2014 21:05:50 Prabhakar Lad wrote:
>> On Sat, Nov 29, 2014 at 7:12 PM, Laurent Pinchart wrote:
>> > Hi Prabhakar,
>>
>> [Snip]
>>
>> >> > Sure. Tha
he
> configuration store. The userspace subdev API would use the configuration
> store from the file handle.
>
are planning to work/post any time soon ? Or are you OK with suggestion from
Hans ?
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe l
> I originally wrote them like that in order to avoid writing essentially the
> same code three times over. If there will be more targets, the same repeats
> further, should one write those functions open for all different macro
> arguments. That's why it was a macro to begin with.
Hi Laurent,
On Sat, Nov 29, 2014 at 6:11 PM, Laurent Pinchart
wrote:
> Hi Prabhakar,
>
> On Friday 28 November 2014 17:06:52 Prabhakar Lad wrote:
>> On Thu, Nov 27, 2014 at 9:32 PM, Laurent Pinchart wrote:
>> > Hi Prabhakar,
>>
>> [Snip]
>>
>
lease cannot be dropped
as it does some usb_autopm_get/put_interface() calls which I am not aware of.
Thanks,
--Prabhakar Lad
>> ret = vb2_queue_init(&queue->queue);
>> if (ret)
>> return ret;
>
> --
> Regards,
>
> Laurent Pinchart
>
t; The queue lock field isn't initialized by the uvcvideo driver, so you can't
> use vb2_ops_wait_prepare|finish().
>
Oops not sure what happened here I just took the patch from [1]
and added commit message. anyway will post a single patch v3.
[1] https://patchwork.kernel.org/patch/5
Hi,
On Tue, Nov 25, 2014 at 3:18 PM, Prabhakar Lad
wrote:
> Hi Mauro,
>
> On Tue, Nov 25, 2014 at 3:04 PM, Mauro Carvalho Chehab
> wrote:
>> Em Tue, 18 Nov 2014 10:57:48 +
> [Snip]
>>
>> -static u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32 *ind
ne address is wrong");
> return -EINVAL;
> }
> + return 0;
the control wont reach here! may be you can remove the complete else
part outside ?
with that change,
Reported-by: Lad, Prabhakar
Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
> }
>
Prabhakar
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> ---
> drivers/staging/media/bcm2048/radio-bcm2048.c | 5 +++--
> drivers/staging/media/davinci_vpfe/vpfe_video.c | 8
> drivers/staging/media/dt3155v4l/dt3155v4l.c | 5 ++---
> 3 files changed, 9 inser
UT caps for M2M devices. These
> were already slated for removal, so it's time to do so.
>
> Signed-off-by: Hans Verkuil
> Cc: Lad, Prabhakar
> Cc: Kamil Debski
> Cc: Jacek Anaszewski
> ---
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> drivers/media/pla
one where the
> __V4L2_SUBDEV_MK_GET_TRY
> is removed and these three try functions are just written as proper
> static inlines. I find it very obfuscated code.
>
the functions were initially inline itself which were changes into
macro's later.
> In addition, because it is a ma
7;t try to stand in its way. It would be nice
> to see a real changelog on the patch, though.
>
Sorry there is no movement of code to other file. And I dont see any
reason why anybody reading will go haywire its a standard v4l2 thing.
The subject explains it all, If you still want me to e
nput fields, generate N progressive frames
>
While you are at it can you test the following 2 patches ?
(had CCed to Archit but the mail bounced back)
https://patchwork.kernel.org/patch/5328481/
https://patchwork.kernel.org/patch/5327801/
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send
gt;> @@ -642,7 +642,6 @@ struct v4l2_subdev_fh {
>> #define to_v4l2_subdev_fh(fh) \
>> container_of(fh, struct v4l2_subdev_fh, vfh)
>>
>> -#if defined(CONFIG_VIDEO_V4L2_SUBDEV_API)
>
>
> Wouldn't you need to drop these from struct v4l2_subdev_fh as well?
---
For all the above,
Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
> drivers/media/i2c/vs6624.c| 18
> 46 files changed, 382 insertions(+), 382 deletions(-)
>
> diff --git a/drivers/media/i2c/adv7170.c b/drivers/media/i2c/adv7170.c
> index 04bb297..40a1a
| 4 +-
[snip]
> include/media/davinci/vpbe.h | 2 +-
> include/media/davinci/vpbe_venc.h | 5 +-
For all the above.
Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a me
dia/davinci_vpfe/dm365_ipipeif.c | 100
> ++---
> drivers/staging/media/davinci_vpfe/dm365_isif.c| 90 +--
> drivers/staging/media/davinci_vpfe/dm365_resizer.c | 98 ++--
> .../staging/media/davinci_vpfe/vpfe_mc_capture.c | 18 ++--
For all the above
Hi,
Thanks for the patch!
On Thu, Nov 6, 2014 at 1:04 PM, Sudip Mukherjee
wrote:
> we are getting struct clk using clk_get before calling
> clk_prepare_enable. but if clk_prepare_enable fails, then we are
> jumping to fail_mutex_unlock where we are just unlocking the mutex,
> but we are not free
the others for 3.19. Just post
> an
> updated version for this one and I'll pick it up later.
>
I fixed it and posted the patch. To avoid conflicts I have rebased the patch on
for-v3.19a branch of your tree.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "u
Hi Dan,
Thanks for the patch!
On Mon, Sep 22, 2014 at 9:00 AM, Dan Carpenter wrote:
> We don't need to check "ret", we know it's zero.
>
> Signed-off-by: Dan Carpenter
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
>
> diff --git a/drivers/media/p
apture.ko] undefined!
>
> That's because vpif_lock symbol is not exported.
>
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> Reported-by: Stephen Rothwell
> Signed-off-by: Mauro Carvalho Chehab
>
> diff --git a/drivers/media/platform/davinci/vpif.c
> b/drivers/med
On Wed, Sep 3, 2014 at 9:33 PM, Mauro Carvalho Chehab
wrote:
> Instead of allocating a var to store 0 and just return it,
> change the code to return 0 directly.
>
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> Signed-off-by: Mauro Carvalho Chehab
>
> diff --git a/driv
r fix [1], so NACK.
[1] https://patchwork.kernel.org/patch/4730111/
Regards,
--Prabhakar Lad
> Signed-off-by: Andreas Ruprecht
> ---
> drivers/media/platform/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/Makefile b/drivers/media/p
Hi Axel,
Thanks for the patch!
On Sat, Aug 16, 2014 at 7:57 AM, Axel Lin wrote:
> This ensures device->streaming has correct status.
>
> Signed-off-by: Axel Lin
Acked-By: Lad, Prabhakar
Regards,
--Prabhakar Lad
> ---
> drivers/media/i2c/tvp7002.c | 21 -
On Sun, Aug 10, 2014 at 10:41 AM, Axel Lin wrote:
> Using the managed function the kfree() calls can be removed from the
> probe error path and the remove handler.
>
> Signed-off-by: Axel Lin
Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
> ---
> drivers/media/i
re these errors from the media/master branch or
from your tree ?
Thanks,
--Prabhakar Lad
> Regards,
>
> Hans
>
> /home/hans/work/build/media-git/drivers/media/platform/davinci/vpif_display.c:
> In function 'vpif_remove':
> /home/hans/work/build/media-git/driv
ure.c | 2478
> +
> drivers/media/platform/ti-vpfe/vpfe_capture.h | 263 +++
> 14 files changed, 4501 insertions(+), 1 deletion(-)
Missing documentation for DT ?
Thanks,
--Prabhakar Lad
> create mode 100644 drivers/media/platform/ti-vpfe/Kconfig
> create mode 1
to make a config that would build that code. But i believe
> that warning is still better than misbehaviour.
>
It wont cause any compile warning.
Applied for v3.17
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a me
gards,
--Prabhakar Lad
> Regards,
>
> Hans
>
> On 06/13/2014 08:13 PM, Prabhakar Lad wrote:
>> On Thu, Jun 12, 2014 at 8:01 AM, Dan Carpenter
>> wrote:
>>> We recently changed some locking around so we need some new unlocks on
>>> the e
On Thu, Jun 12, 2014 at 8:01 AM, Dan Carpenter wrote:
> We recently changed some locking around so we need some new unlocks on
> the error paths.
>
> Signed-off-by: Dan Carpenter
Applied!
Thanks,
--Prabhakar Lad
> ---
> v2: move the unlock so the list_for_each_entry_safe()
if the unlock should go
> before or after the list_for_each_entry_safe() loop.
>
Yes the unlock should go after the list_for_each_entry_safe() loop
please respin another version fixing it.
Thanks,
--Prabhakar Lad
> diff --git a/drivers/media/platform/davinci/vpif_capture.c
> b/drivers/me
On Wed, Jun 11, 2014 at 7:36 AM, Sakari Ailus
wrote:
> Add numeric definitions for menu items used in the smiapp driver's test
> pattern menu.
>
> Signed-off-by: Sakari Ailus
> Acked-by: Laurent Pinchart
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> ---
>
led cppcheck.
>
> Signed-off-by: Rickard Strandqvist
The commit message and header needs to be improved, apart from that rest of the
patch looks good.
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar Lad
> ---
> drivers/media/v4l2-core/v4l2-dv-timings.c |4 ++--
> 1 file changed, 2
you need to add an entry in Kbuild file for this ?
Regards,
--Prabhakar Lad
> 1 file changed, 29 insertions(+)
> create mode 100644 include/uapi/linux/smiapp.h
>
> diff --git a/include/uapi/linux/smiapp.h b/include/uapi/linux/smiapp.h
> new file mode 100644
> index 000..5393
Hi Dan,
Thanks for the patch.
On Mon, Jun 9, 2014 at 4:10 PM, Dan Carpenter wrote:
> The RSZ_LPF_INT_MASK define is cut and pasted twice so we can remove the
> second instance.
>
Applied.
Regards,
--Prabhakar Lad
> Signed-off-by: Dan Carpenter
>
> diff --git a/dri
Hi Paul,
Thanks for the patch.
On Thu, May 22, 2014 at 8:42 PM, Paul Bolle wrote:
> A check for CONFIG_DM644X_VIDEO_PORT_ENABLE was added in v2.6.32. The
> related Kconfig symbol was never added so this check has always
> evaluated to false. Remove that check.
>
Applied.
Thanks,
> let
> me know and I will try to make a good description on Monday.
>
> The second patch depends on the first, so rather than trying to fix the second
> patch it is easier to just create a proper description for the first so that
> the can be applied in order.
>
Pl
t; Why to remove those parameters? Please _ALWAYS_ describe your patches.
>
My bad! will take care next time.
Thanks,
--Prabhakar Lad
> My crystal ball is malfunctioning today, so I was unable to scry the
> reasons for this patch.
>
> Thanks,
> Mauro
>
>> ---
>> dr
cating next week so will take me at-least
2-3 weeks for me to get back the boards and get in action.
Regards,
--Prabhakar Lad
> Regards,
>
> Hans
>
> On 05/16/2014 03:33 PM, Lad, Prabhakar wrote:
>> From: "Lad, Prabhakar"
>>
>> Hi,
>>
>
>>
>> common->started = ret;
>> vpif_config_addr(ch, ret);
>> + /* Get the next frame from the buffer queue */
>> + common->next_frm = common->cur_frm =
>> + list_entry(common->dma_queue.next,
>>
Supported)
>> test VIDIOC_S_FMT: OK (Not Supported)
>> test VIDIOC_G_SLICED_VBI_CAP: OK (Not Supported)
>>
>> Codec ioctls:
>> test VIDIOC_(TRY_)ENCODER_CMD: OK (Not Supported)
>> test VIDIOC_G_EN
For the above: Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
if_display.c | 6 ++
[snip]
> drivers/staging/media/davinci_vpfe/vpfe_video.c| 3 +--
For the above all,
Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
> drivers/staging/media/dt3155v4l/dt3155v4l.c| 3 +--
> drivers/staging/media/go7007/go7007-v4l2.c
Hi Hans,
On Thu, Apr 17, 2014 at 2:51 PM, Hans Verkuil wrote:
> Split off the removal of the vb2_is_streaming check as requested.
> Note that the davinci drivers still have this unnecessary check, but
> Prabhakar will remove that himself.
>
Yes will post the patch, doping the check for davinci dr
kel_buffer, vb2);
>
> Why is this a type? The vb2_buffer member in struct skel_buffer is called
> 'vb', so this should be correct.
>
Oops may be I overlooked, sorry for the noise.
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Hans,
On Tue, Apr 1, 2014 at 8:12 PM, Hans Verkuil wrote:
> On 04/01/14 16:26, Hans Verkuil wrote:
>>
>>
>> On 04/01/14 16:06, Prabhakar Lad wrote:
>>> Hi Hans,
>>>
>>> On Tue, Apr 1, 2014 at 7:20 PM, Hans Verkuil wrote:
>>>> Hi
t where as the prototype in v4l_fd mmap the last parameter type is int64_t
but that should have been off_t and same applies with test_mmap().
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
6c15b3 100644
>> --- a/drivers/media/platform/davinci/vpif_capture.c
>> +++ b/drivers/media/platform/davinci/vpif_capture.c
>
> ...
>
>> static int vpif_buffer_init(struct vb2_buffer *vb)
>> {
>> - struct vpif_cap_buffer *buf = container_of(vb,
>> -
Hi Mauro,
Please pull the following patches which are fixes for various davinci
media drivers.
Thanks,
--Prabhakar Lad
The following changes since commit 8432164ddf7bfe40748ac49995356ab4dfda43b7:
[media] Sensoray 2255 uses videobuf2 (2014-03-24 17:23:43 -0300)
are available in the git
On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart
wrote:
> Signed-off-by: Laurent Pinchart
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar lad
> ---
> include/media/v4l2-subdev.h| 4
> include/uapi/linux/videodev2.h | 10 --
> 2 files changed, 12 insertions(
On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart
wrote:
> The video enum_dv_timings and dv_timings_cap operations are deprecated
> and unused. Remove them.
>
> Signed-off-by: Laurent Pinchart
> Reviewed-by: Hans Verkuil
> Acked-by: Sakari Ailus
Acked-by: Lad, Prabhakar
Re
m.
>
> Cc: Prabhakar Lad
> Signed-off-by: Laurent Pinchart
> Reviewed-by: Hans Verkuil
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar lad
> ---
> drivers/staging/media/davinci_vpfe/vpfe_video.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git
m.
>
> Cc: Prabhakar Lad
> Signed-off-by: Laurent Pinchart
> Reviewed-by: Hans Verkuil
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar lad
> ---
> drivers/media/platform/davinci/vpif_capture.c | 4 +++-
> drivers/media/platform/davinci/vpif_display.c | 4 +++-
> 2 files chan
On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart
wrote:
> The video enum_dv_timings and dv_timings_cap operations are deprecated
> and unused. Remove them.
>
> Signed-off-by: Laurent Pinchart
> Reviewed-by: Hans Verkuil
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar lad
&
il
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar lad
> ---
> drivers/media/i2c/tvp7002.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/media/i2c/tvp7002.c b/drivers/media/i2c/tvp7002.c
> index 912e1cc..9f56fd5 100644
> --- a/drivers/media/i2c/tvp700
Reviewed-by: Hans Verkuil
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar lad
> ---
> drivers/media/i2c/ths8200.c | 12
> 1 file changed, 12 insertions(+)
>
> diff --git a/drivers/media/i2c/ths8200.c b/drivers/media/i2c/ths8200.c
> index f72561e..c4ec8b2 100644
> --
On Tue, Mar 11, 2014 at 4:45 AM, Laurent Pinchart
wrote:
> The video enum_dv_timings and dv_timings_cap operations are deprecated
> and unused. Remove them.
>
> Signed-off-by: Laurent Pinchart
> Reviewed-by: Hans Verkuil
Acked-by: Lad, Prabhakar
Regards,
--Prabhakar lad
&
Hi Philipp,
Thanks for the patch.
On Thu, Feb 27, 2014 at 10:14 PM, Philipp Zabel wrote:
> Set permissions on the debug module parameter to make it appear in sysfs.
>
> Signed-off-by: Philipp Zabel
Acked-by: Lad, Prabhakar
Thanks,
--Prabhakar Lad
--
To unsubscribe from this list:
rect->height = clamp(rect->height,
> ^
> include/linux/kernel.h:763:17: warning: comparison of distinct pointer types
> lacks a cast [enabled by default]
> (void) (&__val == &__max); \
> ^
> drivers/media/i2c/tvp5150.c:904:17:
Hi Michael,
On Mon, Feb 24, 2014 at 11:01 AM, Prabhakar Lad
wrote:
> Hi Michael,
>
> On Thu, Feb 20, 2014 at 6:47 PM, Michael Opdenacker
> wrote:
>> Hi Laurent,
>>
>> On 02/20/2014 12:36 PM, Laurent Pinchart wrote:
>>> Hi Michael,
>>>
>>>
Hi Mauro
On Thu, Feb 20, 2014 at 12:21 PM, Prabhakar Lad
wrote:
> Hi Mauro,
>
> Please pull the following patch for davinci vpfe driver.
>
I have included one more patch from Michael, with a fresh pull request.
Thanks,
--Prabhakar Lad
The following changes
ively, pushing all the remaining changes
> in one go (or removing the definition of IRQF_DISABLED) may be the final
> solution.
>
> I hope to be able to answer your question by the end of the week.
>
gentle ping. should I pick it up ?
Regards,
--Prabhakar Lad
--
To unsubscribe from t
From: "Lad, Prabhakar"
This patch series include fixing some typos and
removal of unwanted comments.
Lad, Prabhakar (3):
media: omap3isp: fix typos
media: omap3isp: ispccdc: remove unwanted comments
media: omap3isp: rename the variable names in description
drivers/media/platform/omap3is
From: "Lad, Prabhakar"
Signed-off-by: Lad, Prabhakar
---
drivers/media/platform/omap3isp/isp.c|2 +-
drivers/media/platform/omap3isp/ispccdc.c|2 +-
drivers/media/platform/omap3isp/ispccp2.c|4 ++--
drivers/media/platform/omap3isp/isphist.c|2 +-
drivers/medi
From: "Lad, Prabhakar"
this patch renames the variable in the description to
match it appropriately to function definition.
Signed-off-by: Lad, Prabhakar
---
drivers/media/platform/omap3isp/isp.h| 12 ++--
drivers/media/platform/omap3isp/ispccdc.c|8
drivers/
From: "Lad, Prabhakar"
this patch removes the description of members which
does not exists for ispccdc_lsc structure.
Signed-off-by: Lad, Prabhakar
---
drivers/media/platform/omap3isp/ispccdc.h |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/media/platform/omap3isp/ispccdc.
Hi Mauro,
Please pull the following patch for davinci vpfe driver.
Regards,
--Prabhakar Lad
The following changes since commit 37e59f876bc710d67a30b660826a5e83e07101ce:
[media, edac] Change my email address (2014-02-07 08:03:07 -0200)
are available in the git repository at:
git
On Tue, Feb 4, 2014 at 3:29 PM, Amit Grover wrote:
> Adding V4L2 controls for horizontal and vertical search range in pixels
> for motion estimation module in video encoder.
>
> Signed-off-by: Swami Nathan
> Signed-off-by: Amit Grover
Acked-by: Lad, Prabhakar
Regards,
nd if you see VIDEO_V4L2_SUBDEV_API depends on MEDIA_CONTROLLER
config so there is no point in adding this dependency.
Thanks,
--Prabhakar Lad
> Signed-off-by: Marcus Folkesson
> ---
> drivers/media/i2c/Kconfig |6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>
changed, 58 insertions(+), 6 deletions(-)
>>
This patch from the outset looks OK, but you need to split up
into two, first adding a v4l control and second one using it up in the driver.
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
From: "Lad, Prabhakar"
clk_set_rate(), clk_prepare_enable() functions can fail, so check the return
values to avoid surprises.
Signed-off-by: Lad, Prabhakar
---
Changes for v2:
1: Called regulator_bulk_disable() in the error path
drivers/media/i2c/mt9p031.c | 15 ---
1 file c
From: "Lad, Prabhakar"
clk_set_rate(), clk_prepare_enable() functions can fail, so check the return
values to avoid surprises.
Signed-off-by: Lad, Prabhakar
---
drivers/media/i2c/mt9v032.c | 10 --
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/mt9v03
From: "Lad, Prabhakar"
clk_set_rate(), clk_prepare_enable() functions can fail, so check the return
values to avoid surprises.
Signed-off-by: Lad, Prabhakar
---
drivers/media/i2c/mt9p031.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/media/i2c/mt9p
From: "Lad, Prabhakar"
Signed-off-by: Lad, Prabhakar
---
README.libv4l |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/README.libv4l b/README.libv4l
index 0be503f..ffe6366 100644
--- a/README.libv4l
+++ b/README.libv4l
@@ -169,4 +169,4 @@ A: Just replace the open call for
From: "Lad, Prabhakar"
The README for libv4l was renamed from README.lib to
README.libv4l but the reference to it was not fixed.
This patch fixes the above.
Signed-off-by: Lad, Prabhakar
---
README|2 +-
v4l-utils.spec.in |2 +-
2 files changed, 2 insertions(+), 2 deletions
Hi Hans,
On Fri, Dec 20, 2013 at 7:00 PM, Hans Verkuil wrote:
> Hi Prabhakar,
>
> On 12/20/2013 02:02 PM, Prabhakar Lad wrote:
>> Hi Hans,
>>
>> On Fri, Dec 20, 2013 at 6:23 PM, Hans Verkuil wrote:
>>> I just made a patch myself that I added to the pull reque
ke up in linux-media but its
present DLOS [1].
I posted it the same day when you pinged me about this issue. Anyway your patch
too didnt reach me and I also cannot find it in the ML. May be you
directly issued the pull ?
[1] https://patchwork.kernel.org/patch/3362211/
Regards,
--Prabhakar Lad
--
To u
mplicit declaration of function ‘msleep’
>
Will you pick this patch or shall I go ahead and issue a pull to Mauro ?
Regards,
--Prabhakar Lad
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordo
Hi Mauro,
Please pull the following patches for davinci vpfe driver.
Regards,
--Prabhakar Lad
The following changes since commit 989af88339db26345e23271dae1089d949c4a0f1:
[media] v4l: vsp1: Add LUT support (2013-12-11 09:25:20 -0200)
are available in the git repository at:
http
by: Lisa Nguyen
Acked-by: Lad, Prabhakar
Will be queueing it for 3.14.
Regrads,
--Prabhakar Lad
> ---
> Changes since v3:
> - Removed () from return statement per Laurent Pinchart's suggestion
>
> drivers/staging/media/davinci_vpfe/vpfe_video.c |2 +-
> 1 fi
return ret;
>>> +
>>> + return -ETIMEDOUT;
>>
>> I don't want to point the obvious, but what about just
>>
>> return ret ? -ETIMEDOUT : 0;
>>
>> or, if this is just about fixing the checkpatch.pl warning,
>>
>&g
Hi Lisa,
On Tue, Dec 10, 2013 at 8:38 PM, Lisa Nguyen wrote:
> Hi Prabhakar,
>
> On Tue, Dec 10, 2013 at 7:04 AM, Prabhakar Lad
> wrote:
>> Hi Lisa,
>>
>> On Tue, Dec 10, 2013 at 8:27 PM, Lisa Nguyen wrote:
>>> Hi everyone,
>>>
>>>
Hi Lisa,
On Tue, Dec 10, 2013 at 8:27 PM, Lisa Nguyen wrote:
> Hi everyone,
>
> On Tue, Dec 10, 2013 at 6:34 AM, Prabhakar Lad
> wrote:
>> Hi Laurent,
>>
>> On Tue, Dec 10, 2013 at 7:34 PM, Laurent Pinchart
>> wrote:
>>> Hi Prabhakar,
>>>
&
Hi Laurent,
On Tue, Dec 10, 2013 at 7:34 PM, Laurent Pinchart
wrote:
> Hi Prabhakar,
>
> On Wednesday 30 October 2013 13:20:25 Prabhakar Lad wrote:
>> On Tue, Oct 29, 2013 at 2:53 AM, Lisa Nguyen wrote:
>> > Remove unnecessary spaces before semicolons to meet
1 - 100 of 687 matches
Mail list logo
