Re: [PATCH v4 01/11] dt-bindings: video-interfaces: Document 'location' property

2019-10-23 Thread Pavel Machek
eve it would be better to specify "this camera is selfie -- takes pictures of the user" vs. "this is main camera -- takes pictures of what user is looking at". Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: PGP signature

Re: [PATCH v4 01/11] dt-bindings: video-interfaces: Document 'location' property

2019-10-08 Thread Pavel Machek
On Tue 2019-10-08 09:58:28, Jacopo Mondi wrote: > Pavel, > > On Tue, Oct 08, 2019 at 09:40:52AM +0200, Pavel Machek wrote: > > On Mon 2019-10-07 18:29:03, Jacopo Mondi wrote: > > > Add the 'location' device property, used to specify a device mounting > >

Re: [PATCH v4 01/11] dt-bindings: video-interfaces: Document 'location' property

2019-10-08 Thread Pavel Machek
of the front facing one. > + 2 - External. The device is not attached directly to the system but is > + attached in a way that allows it to move freely. I explained why this is not enough, and it did not change. NAK.

Re: [PATCH v3 01/11] dt-bindings: video-interfaces: Document 'location' property

2019-09-27 Thread Pavel Machek
nstead say that it is "main" vs "selfie" camera? Notebooks usually have just "selfie" camera, tablets often have both... DSLRs have just "main" camera. Best regards, Pavel -- (english) http:

Re: [RFC] Removal of drivers/staging/media/bcm2048

2019-07-23 Thread Pavel Machek
since that. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: Remote "Mouse mode" buttons, Keycode choices, etc.

2019-06-22 Thread Pavel Machek
On Fri 2019-06-21 13:39:39, Bastien Nocera wrote: > On Sun, 2019-06-16 at 18:58 +0200, Pavel Machek wrote: > > Hi! > > > > > I dug out a fair bunch of remote controls I got around 10 years > > > ago[1], > > > and started trying them all out. >

Re: Remote "Mouse mode" buttons, Keycode choices, etc.

2019-06-16 Thread Pavel Machek
Hi! > I dug out a fair bunch of remote controls I got around 10 years ago[1], > and started trying them all out. > > I bumped into a couple of problems: > > - the Snapstream Firefly remote ([2] using the rc-snapstream-firefly > keymap and the ati_remote protocol) creates 2 input device nodes, on

Re: [PATCH 00/14] Add support for FM radio in hcill and kill TI_ST

2018-12-22 Thread Pavel Machek
i-connectivity/wl128x-fw-5-sr.bin > /lib/firmware/ti-connectivity/wl128x-nvs.bin > root@devuan:/home/user# > > Ideas welcome... ... ... am I supposed to compile wl128-nvs.bin into > the kernel using EXTRA_FIRMWARE? EXTRA_FIRMWARE gets me further... some of it was not in debian. "Speak

Re: [PATCH 00/14] Add support for FM radio in hcill and kill TI_ST

2018-12-22 Thread Pavel Machek
ser# Ideas welcome... ... ... am I supposed to compile wl128-nvs.bin into the kernel using EXTRA_FIRMWARE? Pavel > Merry Christmas! > > -- Sebastian > > Sebastian Reichel (14): > ARM: dts: LogicPD Torpedo: Add WiLink UART node > ARM: dts: IGEP: Add WiLink UART node >

Re: [PATCH 11/14] media: wl128x-radio: fix skb debug printing

2018-12-22 Thread Pavel Machek
On Fri 2018-12-21 02:17:49, Sebastian Reichel wrote: > From: Sebastian Reichel > > This fixes incorrect code in the TX/RX skb debug print > function and add stubs in receive/transmit packet path. > > Signed-off-by: Sebastian Reichel Acked-by: Pavel Machek > @@ -228,7

Re: [PATCH 10/14] media: wl128x-radio: simplify fmc_prepare/fmc_release

2018-12-22 Thread Pavel Machek
ne to return int. Even if it currently does not do anything that could return error, I'd kind of expect allocations being done there... Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCH 08/14] media: wl128x-radio: use device managed memory allocation

2018-12-22 Thread Pavel Machek
On Fri 2018-12-21 02:17:46, Sebastian Reichel wrote: > From: Sebastian Reichel > > This simplifies memory allocation and removes a few useless > errors in case of -ENOMEM errors. > > Signed-off-by: Sebastian Reichel Acked-by: Pavel Machek -- (english) http://w

Re: [PATCH 07/14] media: wl128x-radio: convert to platform device

2018-12-22 Thread Pavel Machek
On Fri 2018-12-21 02:17:45, Sebastian Reichel wrote: > From: Sebastian Reichel > > This converts the wl128x FM radio module into a platform device. > It's a preparation for using it from hci_ll Bluetooth driver instead > of TI_ST. > > Signed-off-by: Sebastian Reiche

Re: [PATCH 06/14] media: wl128x-radio: remove global radio_dev

2018-12-22 Thread Pavel Machek
On Fri 2018-12-21 02:17:44, Sebastian Reichel wrote: > From: Sebastian Reichel > > Move global radio_dev into device structure to prepare converting > this driver into a normal platform device driver supporting multiple > instances. > > Signed-off-by: Sebastian Reichel A

Re: [PATCH 05/14] media: wl128x-radio: remove global radio_disconnected

2018-12-22 Thread Pavel Machek
an Reichel Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [RFC PATCH v8 1/4] media: Media Device Allocator API

2018-12-09 Thread Pavel Machek
Hi! > > On Thu 2018-12-06 08:33:14, shuah wrote: > > > On 11/19/18 1:59 AM, Pavel Machek wrote: > > > >On Thu 2018-11-01 18:31:30, sh...@kernel.org wrote: > > > >>From: Shuah Khan > > > >> > > > >>Media Devic

Re: [RFC PATCH v8 1/4] media: Media Device Allocator API

2018-12-09 Thread Pavel Machek
On Thu 2018-12-06 08:33:14, shuah wrote: > On 11/19/18 1:59 AM, Pavel Machek wrote: > >On Thu 2018-11-01 18:31:30, sh...@kernel.org wrote: > >>From: Shuah Khan > >> > >>Media Device Allocator API to allows multiple drivers share a media device. > >>

Re: [PATCH v5 0/9] Asynchronous UVC

2018-11-27 Thread Pavel Machek
nt but... not really. Would it be possible to improve kernel<->user interface, so it says "data is in this buffer, and it starts here" and so that memcpy in kernel is not neccessary? Pavel -

Re: [RFC PATCH v8 1/4] media: Media Device Allocator API

2018-11-19 Thread Pavel Machek
ted by a driver, other > drivers can get a reference to it. The media device is released when all > the references are released. Sounds like a ... bad idea? That's what new "media control" framework is for, no? Why do you need this?

Re: [GIT PULL for v4.20-rc1] new experimental media request API

2018-11-11 Thread Pavel Machek
ny complaints from their > side if the API would require further changes. You may want to simply disable it in Kconfig... ChromeOS people can enable it easily, and if it never worked in the mainline, you get some wiggle room :-).

Re: [PATCH 09/11] [media] marvell-ccic/mmp: add devicetree support

2018-11-05 Thread Pavel Machek
On Mon 2018-11-05 08:30:52, Lubomir Rintel wrote: > The platform data is actually not used anywhere (along with the CSI > support) and should be safe to remove. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > + } else { > + /* > +

Re: [PATCH 07/11] [media] marvell-ccic: drop unused stuff

2018-11-05 Thread Pavel Machek
On Mon 2018-11-05 08:30:50, Lubomir Rintel wrote: > Remove structure members and headers that are not actually used. Saves > us from some noise in subsequent cleanup commits. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelm

Re: [PATCH 08/11] [media] marvell-ccic/mmp: enable clock before accessing registers

2018-11-05 Thread Pavel Machek
On Mon 2018-11-05 08:30:51, Lubomir Rintel wrote: > The access to REG_CLKCTRL or REG_CTRL1 without the clock enabled hangs > the machine. Enable the clock first. > > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek > --- > drivers/media/platform/marvell-ccic/mmp-dri

Re: [PATCH 06/11] [media] marvell-ccic: drop ctlr_reset()

2018-11-05 Thread Pavel Machek
people needing this. (Perhaps noone uses this, but...) > Signed-off-by: Lubomir Rintel Git blame says: 7c269f454 . Perhaps its authors should be Cced here, too? Pavel > --- > .../media/platform/marvell-ccic/mcam-core

Re: [PATCH 05/11] [media] marvell-ccic: don't generate EOF on parallel bus

2018-11-05 Thread Pavel Machek
or and people that signed off on that patch. Pavel > drivers/media/platform/marvell-ccic/mcam-core.c | 6 -- > 1 file changed, 6 deletions(-) > > diff --git a/drivers/media/platform/marvell-ccic/mcam-core.c > b/drivers/media/platform/m

Re: [PATCH] [media] ov7670: make "xclk" clock optional

2018-11-04 Thread Pavel Machek
el.org # 4.11+ > Fixes: 0a024d634cee ("[media] ov7670: get xclk") > Signed-off-by: Lubomir Rintel Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCH 2/5] v4l: controls: Add support for exponential bases, prefixes and units

2018-10-13 Thread Pavel Machek
4 > +#define V4L2_CTRL_UNIT_PIXEL 5 > +#define V4L2_CTRL_UNIT_PIXELS_PER_SEC6 > +#define V4L2_CTRL_UNIT_HZ7 And Hz is 1/second. Should we also have some support for ISO-sensitivity and f/ aperture numbers? Thanks, Pavel

Re: V4L2 analogue gain contol

2018-08-25 Thread Pavel Machek
le) is in terms of * 0.1EV, i.e. 10 indexes in the table give 2 time more gain [0] in * the *analog gain, [1] in the digital gain * * Analog gain [dB] = 20*log10(regvalue/32); 0x20..0x100 */ Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCHv17 01/34] Documentation: v4l: document request API

2018-08-15 Thread Pavel Machek
ta. > +EIO > +The hardware is in a bad state. To recover, the application needs to > +stop streaming to reset the hardware state and then try to restart > +streaming. Pavel

Re: [PATCHv16 01/34] Documentation: v4l: document request API

2018-08-10 Thread Pavel Machek
nvalid request FD is given, then > + ``ENOENT`` will be returned. Should this still specify that this should be 0 if V4L2_BUF_FLAG_REQUEST_FD is not set? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky,

Re: [PATCH v2 1/2] media: dt-bindings: bind nokia,n900-ir to generic pwm-ir-tx driver

2018-07-13 Thread Pavel Machek
rs/media/rc/pwm-ir-tx.c b/drivers/media/rc/pwm-ir-tx.c > index 27d0f5837a76..272947b430c8 100644 > --- a/drivers/media/rc/pwm-ir-tx.c > +++ b/drivers/media/rc/pwm-ir-tx.c > @@ -30,6 +30,7 @@ struct pwm_ir { > }; > > static const struct of_device_id pwm_ir_of_match[]

Re: [PATCH 16/16] media: imx: add mem2mem device

2018-07-10 Thread Pavel Machek
as you state (and I like that), you should also say so in SPDX. Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: Software-only image processing for Intel "complex" cameras

2018-06-29 Thread Pavel Machek
might be able to create a test > > > environment for X11 tools if really necessary). > > > > Could you just compile libv4l2 with sdlcam demo on the target, and > > then ssh -X there from some sort of reasonable system? > > Yes, that should work I guess. That would be a C

Re: Software-only image processing for Intel "complex" cameras

2018-06-29 Thread Pavel Machek
erably limited > to command line tools (but I might be able to create a test > environment for X11 tools if really necessary). Could you just compile libv4l2 with sdlcam demo on the target, and then ssh -X there from some sort of reasonable system? Best regards,

Re: [git:media_tree/master] media: i2c: lm3560: add support for lm3559 chip

2018-06-28 Thread Pavel Machek
Hi! > This is an automatic generated email to let you know that the following patch > were queued: > > Subject: media: i2c: lm3560: add support for lm3559 chip > Author: Pavel Machek > Date:Sun May 6 04:06:07 2018 -0400 > > Add support for LM3559, as found in Mot

Re: Software-only image processing for Intel "complex" cameras

2018-06-23 Thread Pavel Machek
ary could use them. This could be done, but it would be better if libraries could query neccessary information from v4l2 drivers. If DMI was used, _library_ would need to know about new hardware, which is not desirable. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: Software-only image processing for Intel "complex" cameras

2018-06-20 Thread Pavel Machek
questions has no > one have ever implemented this, hence measure performance. I believe Intel has some estimates. What is the maximum resolution of camera in the current Dell systems? Thanks, Pavel -- (english) htt

Software-only image processing for Intel "complex" cameras

2018-06-20 Thread Pavel Machek
access to machine with IPU3, or would there be someone willing to test libv4l2 patches? Thanks and best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pav

[PATCH, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-06-07 Thread Pavel Machek
API design). Ok. Here's updated patch. open_complex() now takes fd. Any other issues? Best regards, Pavel diff --git a/lib/include/libv4l2.h b/lib/include/libv4l2.h index ea1870d..a0ec0a9 100644 --- a/lib/include/libv4l2.

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-06-07 Thread Pavel Machek
support. And we should be able to provide them with just that. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-06-06 Thread Pavel Machek
> > Test apps such as qv4l2 would be nice to have, and maybe I'll > > experiment with capturing video somehow one day. I'm pretty sure it > > will not be easy. > > Capture video is a must have for PCs. The final solution should > take it into account. N900 is quite slow for JPEG compression (and I don't really want solution depending on hardware extras like DSP)... so that will be fun. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-06-06 Thread Pavel Machek
t going to be widely used > OR > b) it is designed well enough to cover the complex cases I mentioned > and which are likely to represent most of the hardware in the wild. .mc descriptors should be indeed extensible enough for that. Best regards,

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-06-06 Thread Pavel Machek
ngouts. Anyway, there's big difference between open("/dev/video0") and v4l2_open("/dev/video0"). I don't care about the first one, but yes we should be able to support the second one eventually. And I don't think Mauro says apps like Camorama are of open() kind. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-06-06 Thread Pavel Machek
if (i>=1 && map->map[i].control <= map->map[i-1].control) { > > + V4L2_LOG_ERR("v4l2_open_pipeline: Controls not > > sorted.\n"); > > + return -1; > > I guess we could just sort them at startup with qsort()? We could... but I'd prefer them sorted on-disk, as it is written very seldom, but needs to be readed on every device open. Thanks for review, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-06-06 Thread Pavel Machek
s testing? Main use case is kernel testing. Secondary use case is taking .jpg photos using sdlcam. Test apps such as qv4l2 would be nice to have, and maybe I'll experiment with capturing video somehow one day. I'm pretty sure it will not be easy. Oh and I guess a link to how well it works? See https://www.youtube.com/watch?v=fH6zuK2OOVU . Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-06-06 Thread Pavel Machek
d work in steps before getting there... controls propagation can not be done from external application, so I'm starting with it. > Some minor comments for the code follow. Ok, let me send this, then go through the comments. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-06-02 Thread Pavel Machek
Hi! Ok, can I get any comments on this one? v4l2_open_complex("/file/with/descriptor", 0) can be used to open whole pipeline at once, and work if it as if it was one device. Thanks, Pavel diff --git a/lib/include/libv4

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-05-16 Thread Pavel Machek
hat, it seems ok. Good, thanks! Here's current version of the patch. Code will need moving to libv4l2. Would "v4l2_open_pipeline()" be suitable name to use? Best regards, Pavel diff --git a/contrib/test/sdlcam.c b/contr

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-05-15 Thread Pavel Machek
like this? Note that I'd only implement the controls mapping for now... but it should be extensible later to setup mappings for the application. Best regards, Pavel #modes: 2 Driver name: OMAP 3 resizer Mode: 3000x1800 #devic

[PATCH] media: i2c: lm3560: add support for lm3559 chip

2018-05-06 Thread Pavel Machek
Add support for LM3559, as found in Motorola Droid 4 phone, for example. SW interface seems to be identical. Signed-off-by: Pavel Machek diff --git a/drivers/media/i2c/lm3560.c b/drivers/media/i2c/lm3560.c index b600e03a..c4e5ed5 100644 --- a/drivers/media/i2c/lm3560.c +++ b/drivers/media/i2c

[PATCH] media: i2c: lm3560: use conservative defaults

2018-05-06 Thread Pavel Machek
If no pdata is found, we should use lowest current settings, not highest. Signed-off-by: Pavel Machek diff --git a/drivers/media/i2c/lm3560.c b/drivers/media/i2c/lm3560.c index b600e03a..c4e5ed5 100644 --- a/drivers/media/i2c/lm3560.c +++ b/drivers/media/i2c/lm3560.c @@ -420,14 +434,14

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-03-20 Thread Pavel Machek
320x200: entity5:0[1] > sink1 = UYVY 640x480: entity3:0[1] Well, first, this looks like very unsuitable for key=value file. Plus, it will not be easy to parse. and control map needs to be per-pipeline-configuration. Again, proposed Windows-style format can not easily do that. Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-03-19 Thread Pavel Machek
#x27;s setup you should be able to do: 'v4l2-ctl --stream-mmap' and > get video. > > Next, libv4l will also read the same configuration file and use it to provide > a compatibility layer so applications that use libv4l will work better with > MC devices. Part of that is indeed control handling. Yep, that would be nice. And yes, control handling is important for me. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-03-19 Thread Pavel Machek
e than 5 years old now. libv4l2 is still completely uses on media control-based devices, and people are asking for controls propagation in the kernel to fix that. My proposol implements simple controls propagation in the userland. I believe we should do that. > A good test platform for this (ou

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-03-19 Thread Pavel Machek
Hi! > > Pavel, > > > > I appreciate your efforts of adding support for mc-based devices to > > libv4l. Thanks. > > I guess the main poin that Hans is pointing is that we should take > > extra care in order to avoid adding new symbols to libv4l ABI/API &g

Re: [RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-03-19 Thread Pavel Machek
able way? If so, yes, I can proceed with parser. Best regards, Pavel > > ...so you can use it on complex devices. Tested on my N900. > > > > I guess later helper would be added that would parse some kind of > > des

[RFC, libv4l]: Make libv4l2 usable on devices with complex pipeline

2018-03-16 Thread Pavel Machek
nd of descritption file and do open_pipeline(). But.. lets solve that next. In the first place, it would be nice to have libv4l2 usable on complex devices. Best regards, Pavel Signed-off-by: Pavel Machek diff --git a/lib/include/libv4l2.h

Re: [PATCH v2] media: omap3isp: fix unbalanced dma_iommu_mapping

2018-03-15 Thread Pavel Machek
paths or the driver remove path resulting > in an unbalanced mapping refcount and a memory leak. Fix this properly. > > Reported-by: Pavel Machek > Signed-off-by: Suman Anna > Acked-by: Sakari Ailus > --- > v2 Changes: > - Dropped the error_attach label, and returned dir

next-20180219: camera problems on n900

2018-02-19 Thread Pavel Machek
ot start. > > > > > > > > Any ideas what might be wrong there? > > > > > > What kind of oopses do you get? > > > > Hmm. bisect pointed to commit that can't be responsible Ideas > > welcome. > > Hi Pavel, > > I t

Re: [PATCH v2 8/8] platform: vivid-cec: use 64-bit arithmetic instead of 32-bit

2018-02-13 Thread Pavel Machek
e Coverity > * "Unintentional integer overflow" warning. Coverity isn't smart enough > * to understand that len is always <= 16, so there is no chance of an > * integer overflow. > */ Or maybe it would be better to add comment about Coverity having false-positiv

Re: v4.15: camera problems on n900

2017-12-29 Thread Pavel Machek
On Fri 2017-12-29 11:38:55, Sakari Ailus wrote: > On Thu, Dec 28, 2017 at 09:24:53PM +0100, Pavel Machek wrote: > > On Wed 2017-12-27 23:17:19, Sakari Ailus wrote: > > > On Wed, Dec 27, 2017 at 10:05:43PM +0100, Pavel Machek wrote: > > > > Hi! > > > > &

Re: v4.15: camera problems on n900

2017-12-28 Thread Pavel Machek
On Wed 2017-12-27 23:17:19, Sakari Ailus wrote: > On Wed, Dec 27, 2017 at 10:05:43PM +0100, Pavel Machek wrote: > > Hi! > > > > In v4.14, back camera on N900 works. On v4.15-rc1.. it works for few > > seconds, but then I get repeated oopses. >

Re: v4.15: camera problems on n900

2017-12-28 Thread Pavel Machek
On Wed 2017-12-27 23:17:19, Sakari Ailus wrote: > On Wed, Dec 27, 2017 at 10:05:43PM +0100, Pavel Machek wrote: > > Hi! > > > > In v4.14, back camera on N900 works. On v4.15-rc1.. it works for few > > seconds, but then I get repeated oopses. >

Re: v4.15: camera problems on n900

2017-12-27 Thread Pavel Machek
1;2802;0cOn Wed 2017-12-27 23:17:19, Sakari Ailus wrote: > On Wed, Dec 27, 2017 at 10:05:43PM +0100, Pavel Machek wrote: > > Hi! > > > > In v4.14, back camera on N900 works. On v4.15-rc1.. it works for few > > seconds, but then I get repeated oopses. >

v4.15: camera problems on n900

2017-12-27 Thread Pavel Machek
? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCH] devicetree: Add video bus switch

2017-12-22 Thread Pavel Machek
log/?h=xilinx-wip > > > > but the patches are from 2005. So I guess I'll need some guidance here... > > You made me feel very old for a moment. The patches are from 2015 :-) Sorry about that :-). Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCH] media: et8ek8: select V4L2_FWNODE

2017-11-14 Thread Pavel Machek
river.c:(.text+0x884): undefined reference to > `v4l2_async_register_subdev_sensor_common' > > This adds a Kconfig 'select' statement like all the other users of > this interface have. > > Fixes: d8932f38c10f ("media: et8ek8: Add support for flash and lens devices

Re: [PATCH 1/2] sdlcam: fix linking

2017-11-13 Thread Pavel Machek
On Mon 2017-11-13 10:19:07, Rafaël Carré wrote: > Signed-off-by: Rafaël Carré Acked-by: Pavel Machek Thanks! Pavel -- (english) http://www.livejournal.

[rfc] libv4l2: better auto-gain

2017-11-12 Thread Pavel Machek
Add support for better autogain. Old code had average brightness as a target. New code has number of bright pixels as a target. Signed-off-by: Pavel Machek I see I need to implement histogram for bayer8 and rgb24. Any other comments? Best regards

et8ek8: Document support for flash and lens devices

2017-11-12 Thread Pavel Machek
Document dts support of LED/focus. Signed-off-by: Pavel Machek diff --git a/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt b/Documentation/devicetree/bindings/media/i2c/toshiba,et8ek8.txt index 0b7b6a4..e80d589 100644 --- a/Documentation/devicetree/bindings/media/i2c/toshiba

Re: Nokia N9: fun with camera

2017-11-01 Thread Pavel Machek
cap_y) ] ) > m.media_ctl( [ '-l', '"OMAP3 ISP CSI2a":1 -> "OMAP3 ISP CSI2a output":0[1]' > ] ) > > # WORKS > # pavel@n900:~/g/tui/camera$ sudo /my/tui/yavta/yavta > # --capture=8 --skip 0 --format SGRBG10 --size 4272x301

Re: Nokia N9: fun with camera

2017-10-31 Thread Pavel Machek
guess I forgot to reset the pipeline between the tries, or something. For the record, this got me some data on n950: m.media_ctl( [ '-f', '"OMAP3 ISP CSI2a":0 [fmt:%s/%dx%d]' % (m.fmt, m.cap_x, m.cap_y) ] ) m.media_ctl( [ '-l', '"OMAP3 ISP CSI2

Nokia N9: fun with camera

2017-10-31 Thread Pavel Machek
t;smiapp binner 1-0010":0 [ENABLED,IMMUTABLE] (And you mentioned width 3600, and SGRBG10). I updated my scripts accordingly. Now I get pavel@n900:~/g/tui/camera$ /my/tui/yavta/yavta -c5 -f SRGGB10 -F/tmp/foo -s 3572x2464 /dev/video1 Device /dev/video1 opened. Device `OMAP3 ISP CSI2a output

Re: [patch] libv4l2: SDL test application

2017-10-30 Thread Pavel Machek
On Mon 2017-10-30 17:30:53, Hans Verkuil wrote: > Hi Pavel, > > On 10/28/2017 09:57 PM, Pavel Machek wrote: > > Add support for simple SDL test application. Allows taking jpeg > > snapshots, and is meant to run on phone with touchscreen. Not > > particulary useful on

[patch] libv4l2: SDL test application

2017-10-28 Thread Pavel Machek
Add support for simple SDL test application. Allows taking jpeg snapshots, and is meant to run on phone with touchscreen. Not particulary useful on PC with webcam, but should work. Signed-off-by: Pavel Machek diff --git a/configure.ac b/configure.ac index f3691be..f6540c2 100644 --- a

Re: Camera support, Prague next week, sdlcam

2017-10-23 Thread Pavel Machek
Hi! > > I'll talk about the issues at ELCE in few days: > > > > https://osseu17.sched.com/event/ByYH/cheap-complex-cameras-pavel-machek-denx-software-engineering-gmbh > > > > Will someone else be there? Is there some place where v4l people meet? > > Why

Re: Camera support, Prague next week, sdlcam

2017-10-22 Thread Pavel Machek
Ok, will do, thanks! > > I'll talk about the issues at ELCE in few days: > > > > https://osseu17.sched.com/event/ByYH/cheap-complex-cameras-pavel-machek-denx-software-engineering-gmbh > > > > Will someone else be there? Is there some place where v4l people meet? > >

Camera support, Prague next week, sdlcam

2017-10-21 Thread Pavel Machek
media graph device, such as N900. I'll talk about the issues at ELCE in few days: https://osseu17.sched.com/event/ByYH/cheap-complex-cameras-pavel-machek-denx-software-engineering-gmbh Will someone else be there? Is there some place where v4l people meet? Be

Re: [PATCH 04/24] media: v4l2-mediabus: convert flags to enums and document them

2017-10-11 Thread Pavel Machek
and "flag" is confusing because there is more than one inside. What about something like __legacy_flags? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCH v15 29/32] et8ek8: Add support for flash and lens devices

2017-10-06 Thread Pavel Machek
On Thu 2017-10-05 00:50:48, Sakari Ailus wrote: > Parse async sub-devices related to the sensor by switching the async > sub-device registration function. > > Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil Acked-by: Pavel Machek -- (english) http://www.livejournal.c

Re: [PATCH v15 28/32] smiapp: Add support for flash and lens devices

2017-10-06 Thread Pavel Machek
> Signed-off-by: Sakari Ailus > Acked-by: Hans Verkuil Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [RESEND PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example

2017-09-18 Thread Pavel Machek
On Mon 2017-09-18 17:49:23, Sakari Ailus wrote: > Hi Pavel, > > On Mon, Sep 18, 2017 at 12:56:55PM +0200, Pavel Machek wrote: > > Hi! > > > > > Specify the exact label used if the label property is omitted in DT, as > > > well as use label in the exa

Re: [RESEND PATCH v2 4/6] dt: bindings: as3645a: Improve label documentation, DT example

2017-09-18 Thread Pavel Machek
termine if this is flash from main camera or flash for front camera; todays smartphones have flashes on both cameras. So.. Can I suggset as3645a:white:main_camera_flash or main_flash or ? Thanks, Pavel -- (english) h

Re: [PATCH v13 06/25] omap3isp: Use generic parser for parsing fwnode endpoints

2017-09-16 Thread Pavel Machek
On Sat 2017-09-16 09:04:31, Pavel Machek wrote: > Hi! > > > Instead of using driver implementation, use > > v4l2_async_notifier_parse_fwnode_endpoints() to parse the fwnode endpoints > > of the device. > > > > Signed-off-by: Sakari Ailus > > Acked-by:

Re: [PATCH v13 11/25] v4l: async: Introduce helpers for calling async ops callbacks

2017-09-16 Thread Pavel Machek
rkuil I'd remove "_call" from these names; they are long enough already and do not add much. But either way is okay. Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html s

Re: [PATCH v13 06/25] omap3isp: Use generic parser for parsing fwnode endpoints

2017-09-16 Thread Pavel Machek
series... Is merge of the series expected anytimme soon? If not, can we at least merge patches up to here, so that less stuff is retransmitted over and over? Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesk

Re: as3645a flash userland interface

2017-09-14 Thread Pavel Machek
On Thu 2017-09-14 13:01:19, Sylwester Nawrocki wrote: > On 09/14/2017 12:07 PM, Pavel Machek wrote: > >>Isn't the V4L2 subdev/Media Controller API supposed to provide means > >>for associating flash LEDs with camera sensors? You seem to be insisting > >>on usin

Re: as3645a flash userland interface

2017-09-14 Thread Pavel Machek
sh LEDs with camera sensors? You seem to be insisting > on using the sysfs leds interface for that, which is not a primary > interface for camera flash AFAICT. a) subdev/media controller API currently does not provide such means. b) if we have /sys/class/leds interface to userland, it should be useful. c) having flashlight application going through media controller API is a bad joke. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: as3645a flash userland interface

2017-09-12 Thread Pavel Machek
On Tue 2017-09-12 20:53:33, Jacek Anaszewski wrote: > Hi Pavel, > > On 09/12/2017 12:36 PM, Pavel Machek wrote: > > Hi! > > > > There were some changes to as3645a flash controller. Before we have > > stable interface we have to keep forever I want to ask: >

Re: as3645a flash userland interface

2017-09-12 Thread Pavel Machek
Hi! > On Tue, Sep 12, 2017 at 12:36:28PM +0200, Pavel Machek wrote: > > Hi! > > > > There were some changes to as3645a flash controller. Before we have > > stable interface we have to keep forever I want to ask: > > > > What directory are the flash co

as3645a flash userland interface

2017-09-12 Thread Pavel Machek
? Thanks, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCH v11 21/24] smiapp: Add support for flash and lens devices

2017-09-12 Thread Pavel Machek
y: Sakari Ailus > Acked-by: Hans Verkuil Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

[PATCH] et8ek8: Add support for flash and lens devices

2017-09-11 Thread Pavel Machek
ensor. Signed-off-by: Pavel Machek --- This enables me to do autofocus on n900. Depends on Sakari's series, so best solution would be to append it there. Thanks, Pavel diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c

Re: [PATCH v10 19/24] v4l: fwnode: Add convenience function for parsing common external refs

2017-09-11 Thread Pavel Machek
@notifier: the async notifier where the async subdevs will be added > + * > + * Return: 0 on success > + * -ENOMEM if memory allocation failed > + * -EINVAL if property parsing failed > + */ Returns: would sound more correct to me, but it seems kernel is split on that. Acked-by: P

Re: [PATCH v10 24/24] arm: dts: omap3: N9/N950: Add flash references to the camera

2017-09-11 Thread Pavel Machek
On Mon 2017-09-11 11:00:08, Sakari Ailus wrote: > Add flash and indicator LED phandles to the sensor node. > > Signed-off-by: Sakari Ailus Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/pictu

Re: [PATCH v10 20/24] dt: bindings: smiapp: Document lens-focus and flash properties

2017-09-11 Thread Pavel Machek
On Mon 2017-09-11 11:00:04, Sakari Ailus wrote: > Document optional lens-focus and flash properties for the smiapp driver. Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.h

[RFC] et8ek8: Add support for flash and lens devices

2017-09-09 Thread Pavel Machek
ensor. Signed-off-by: Pavel Machek # Not yet ready -- broken whitespace --- Whitespace is horribly bad. But otherwise... does it look ok? diff --git a/drivers/media/i2c/et8ek8/et8ek8_driver.c b/drivers/media/i2c/et8ek8/et8ek8_driver.c index c14f0fd..7714d2c 100644 --- a/drivers/media/i2c/e

Re: [PATCH v9 24/24] arm: dts: omap3: N9/N950: Add flash references to the camera

2017-09-09 Thread Pavel Machek
Hi! > Add flash and indicator LED phandles to the sensor node. > > Signed-off-by: Sakari Ailus I'm adding similar support to et8ek8 and wonder.. why don't you also add support for autofocus? Driver not yet available? Thanks,

Re: [PATCH v9 00/23] Unified fwnode endpoint parser, async sub-device notifier support, N9 flash DTS

2017-09-09 Thread Pavel Machek
-rc0, and it does not break anything. So: Tested-by: Pavel Machek Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html signature.asc Description: Digital signature

Re: [PATCH v9 18/24] as3645a: Switch to fwnode property API

2017-09-09 Thread Pavel Machek
On Fri 2017-09-08 16:18:16, Sakari Ailus wrote: > Switch the as3645a from OF to the fwnode property API. Also add ACPI > support. > > Signed-off-by: Sakari Ailus Acked-by: Pavel Machek -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin

  1   2   3   4   5   6   7   >