Kernel source files need not include explicitly
because the top Makefile forces to include it with:
-include $(srctree)/include/linux/kconfig.h
Remove another reduntdant include, that managed to sneak by commit
97139d4a6f26 ("treewide: remove redundant #include ").
Signed-off-by:
the top of this file states, succinctly, that the license
is GPL v2. And, according to include/linux/module.h, the
MODULE_LICENSE() macro here states that the license is GPL v2 or later.
So I think that either that comment or the ident used in that macro
needs to change.
Ditto for 2/2.
Thanks,
Paul B
)
> + c8sectpfe-y += c8sectpfe-debugfs.o
> +endif
Isn't the above equivalent to
c8sectpfe-y += c8sectpfe-core.o c8sectpfe-common.o c8sectpfe-dvb.o
c8sectpfe-debugfs.o
obj-$(CONFIG_DVB_C8SECTPFE) += c8sectpfe.o
Or am I missing something subtle here?
Paul Bolle
--
To unsu
x00));
> + if (desc & 0x80)
> + if1 -= (0xff - desc);
> + else
> + if1 += desc;
> + }
> + }
> +
> + tun_i2c = dib3000mc_get_tuner_i2c_master(adap->fe_adap[0]
I'm not
really sure what you're saying here, probably because "select" and
"depends on" are rather different. How would you know that the actual
intention was to use "depends on"?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubsc
quot;);
So you probably want
MODULE_LICENSE("GPL v2");
here.
(If you think this is a bit silly, and somewhere I think so too, you're
invited to jump into the discussion starting at
https://lkml.org/lkml/2015/3/7/119 .)
Paul Bolle
--
To unsubscribe from this list: send the lin
Hi Fengguang
On Wed, 2014-11-26 at 11:30 -0800, Fengguang Wu wrote:
> On Wed, Nov 26, 2014 at 08:50:41AM +0100, Paul Bolle wrote:
> > Hi Fengguang,
> >
> > On Wed, 2014-11-26 at 09:34 +0800, kbuild test robot wrote:
> > > tree: git://linuxtv.org/me
t.ko] undefined!
> >> ERROR: "omap_dispc_unregister_isr"
> >> [drivers/media/platform/omap/omap-vout.ko] undefined!
> >> ERROR: "omapdss_compat_uninit" [drivers/media/platform/omap/omap-vout.ko]
> >> undefined!
> >> ERROR: "omap_dss_get
Commit 38a073116525 ("[media] omap: be sure that MMU is there for
COMPILE_TEST") added a dependency on HAS_MMU. There's no Kconfig symbol
HAS_MMU. Use MMU instead.
Signed-off-by: Paul Bolle
---
0) Perhaps it would have been better to add a line or two explaining why
MMU is
On Mon, 2014-11-24 at 12:08 +0100, Hans Verkuil wrote:
> I found the same thing and it is already part of my pull request
> to Mauro.
Either way, this trivial issue will be solved.
Thanks,
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-media"
The deprecated omap2 camera drivers were recently removed. Both the
Kconfig symbol VIDEO_TCM825X and the drivers/staging/media/omap24xx
directory are gone. So the Makefile entry that references both is now
pointless. Remove it too.
Signed-off-by: Paul Bolle
---
Tested by grepping the tree
On Mon, 2014-11-10 at 18:54 -0200, Mauro Carvalho Chehab wrote:
> Em Mon, 10 Nov 2014 21:45:56 +0100
> Paul Bolle escreveu:
> > This typo is still present in both next-20141110 and v3.18-rc4. And I've
> > first reported it nearly two months ago. I see two fixes:
&
Hi Mauro,
On Mon, 2014-10-20 at 10:31 +0200, Paul Bolle wrote:
> This became commit 38a073116525 ("[media] omap: be sure that MMU is
> there for COMPILE_TEST").
>
> As I reported in
> http://article.gmane.org/gmane.linux.drivers.video-input-infrastructure/82299
> it a
's no such
symbol. So that test will always fail. Did you perhaps mean simply "MMU"?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Thu, 2014-10-09 at 07:30 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 09 Oct 2014 08:45:28 +0200
> Paul Bolle escreveu:
> > The above discussion meanders a bit, and I just stumbled onto it, but
> > would
> > #if IS_BUILTIN(CONFIG_INPUT) || (IS_MODULE(CONFIG_INPUT
| (IS_MODULE(CONFIG_INPUT) && defined(MODULE))
cover your requirements when using macros?
> Probably the best would be to write another macro that would evaluate
> like the above.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
them with ARCH_S5PV210.
>
> Reported-by: Paul Bolle
> Signed-off-by: Sylwester Nawrocki
Thanks for picking this up!
Should
Fixes: d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
be added so this will end up in stable for v3.17?
> drivers/media/platform/Kconf
d actually do that, that would be great. I lost patience
waiting for a patch that did that. So I submitted these cleanup patches
that basically change nothing.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger
On Mon, 2014-10-06 at 11:26 +0200, Arnd Bergmann wrote:
> On Monday 06 October 2014 11:10:26 Paul Bolle wrote:
> > config VIDEO_SAMSUNG_S5P_TV
> > bool "Samsung TV driver for S5P platform"
> > depends on PM_RUNTIME
> > - depends on PL
Commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
removed the Kconfig symbol PLAT_S5P. Remove an optional dependency on
that symbol from this Kconfig file too.
Signed-off-by: Paul Bolle
---
drivers/media/platform/s5p-tv/Kconfig | 2 +-
1 file changed, 1 insertion(+),
Commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
removed the Kconfig symbol PLAT_S5P. Remove an optional dependency on
that symbol from this Kconfig file too.
Signed-off-by: Paul Bolle
---
drivers/media/platform/exynos4-is/Kconfig | 2 +-
1 file changed, 1 inser
Commit d78c16ccde96 ("ARM: SAMSUNG: Remove remaining legacy code")
removed the Kconfig symbol PLAT_S5P. Remove three optional dependencies
on that symbol from this Kconfig file too.
Signed-off-by: Paul Bolle
---
drivers/media/platform/Kconfig | 6 +++---
1 file changed, 3 insert
ptional dependencies. If it turns out that they should actually be
replaced by another symbol, as was said in a reply to my first message
but never done, this series can be used as a reference for the places
that need fixing.
This series is done on top of next-20141003. It is tested by grepping
; make: *** [vmlinux] Error 1
#
# Automatically generated file; DO NOT EDIT.
# Linux/x86 3.17.0-rc6 Kernel Configuration
#
[...]
CONFIG_SMS_SDIO_DRV=y
[...]
CONFIG_SMS_SIANO_MDTV=m
[...]
Should SMS_SDIO_DRV depend on SMS_SIANO_MDTV?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
pends on ARCH_OMAP2 || ARCH_OMAP3 || (COMPILE_TEST && HAS_MMU)
There's no Kconfig symbol HAS_MMU. So this last test will always fail.
Did you perhaps mean simply "MMU"?
> select VIDEOBUF_GEN
> select VIDEOBUF_DMA_CONTIG
Paul Bolle
--
To unsubscribe from this l
Hi Mauro,
On Thu, 2014-09-04 at 12:36 -0300, Mauro Carvalho Chehab wrote:
> Em Thu, 22 May 2014 14:48:07 +0200
> Paul Bolle escreveu:
>
> > dib0900.c has always shipped with its own, manual, configuration
> > system. There a three problems with it.
> >
> > 1)
patch to remove the arch/arm/mach-imx/
code is pending somewhere?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
On Wed, 2014-04-16 at 17:47 +0200, Paul Bolle wrote:
> Remove the CONFIG_ prefix from two Kconfig symbols in a dependency for
> SMS_SIANO_DEBUGFS. This prefix is invalid inside Kconfig files.
>
> Note that the current (common sense) dependency on SMS_USB_DRV and
> SMS_SDIO_DRV bein
When support for homebrew serial port receivers was added in v2.6.36 its
code contained checks for CONFIG_LIRC_SERIAL_NSLU2. The related Kconfig
symbol didn't exist then. It still doesn't exist now. Remove these checks.
Signed-off-by: Paul Bolle
---
Untested. Done on top of next-20
A check for CONFIG_DM644X_VIDEO_PORT_ENABLE was added in v2.6.32. The
related Kconfig symbol was never added so this check has always
evaluated to false. Remove that check.
Signed-off-by: Paul Bolle
---
Untested.
Related, trivial, cleanup: make ccdc_enable_vport() a oneliner.
drivers/media
hidden behind the macros that are never defined too.
Signed-off-by: Paul Bolle
---
0) Compile tested. I don't have the hardware.
1) This might be a bit hard to review. Should I split it in two or three
patches?
2) dib0070.c has a reference to CONFIG_SYS_ISDBT. I'll remove it in a
future
constraint are that:
- it should only be built if SMS_USB_DRV is set;
- it can't be builtin if USB support is modular.
So drop the dependency on SMS_USB_DRV, as it is unneeded.
Fixes: 6c84b214284e ("[media] sms: fix randconfig building error")
Reported-by: Martin Walch
Signed-off
ntent was to use
MEDIA_SUBDRV_AUTOSELECT here.
So the following (untested!) patch makes the Kconfig entry for "Micronas
DRX-J demodulator" use the current symbol. It is basically a copy of
d65fcbb0007b "([media] ts2020: use customise option correctly").
- >8
et this flag, if I'm
not misunderstanding Joe.) For what it's worth, I've added the list of
these (for v3.14-rc5) below.
Paul Bolle
v3.14-rc5:arch/powerpc/platforms/pseries/Makefile:ccflags-$(CONFIG_PPC_PSERIES_DEBUG)
+= -DDEBUG
v3.14-rc5:drivers/base/Makefile:ccflags-$(CO
The Kconfig symbol S5P_SETUP_MIPIPHY was removed in v3.13. Remove a
reference to its macro from a list of Kconfig options.
Signed-off-by: Paul Bolle
---
See commit e66f233dc7f7 ("ARM: Samsung: Remove the MIPI PHY setup
code"). Should one or more options be added to replace
S5P_SETUP_
Mauro,
On Sat, 2013-11-02 at 17:40 -0200, Mauro Carvalho Chehab wrote:
> Em Sat, 02 Nov 2013 20:20:54 +0100
> Paul Bolle escreveu:
> > On Sun, 2013-10-20 at 00:03 +0200, Martin Walch wrote:
> > > drivers/media/common/siano/Kconfig:21-26
> > > > config SMS_S
entry is used to set the DEBUG
compiler flag, which enables calls of dev_dbg().
So add a Makefile line to do that for omap4iss too.
Signed-off-by: Paul Bolle
---
0) v1 was called "[media] v4l: omap4iss: Remove VIDEO_OMAP4_DEBUG". This
versions implements Laurent's alternativ
Laurent,
On Mon, 2014-02-10 at 15:13 +0100, Laurent Pinchart wrote:
> On Sunday 09 February 2014 16:09:37 Paul Bolle wrote:
> > Commit d632dfefd36f ("[media] v4l: omap4iss: Add support for OMAP4
> > camera interface - Build system") added a Kconfig entry for
> >
ems that if what people actually
use is radio-usb-si4713.ko or radio-platform-si4713.ko than I2C_SI4713
could be made a 'select only' Kconfig symbol (that won't show up in
menuconfig), couldn't it?
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe l
ther two modules
require. Have I overlooked anything?
> If you can post a patch fixing that, then I'll pick
> it up for 3.14.
>
> With the addition of the USB si4713 driver things moved around and were
> renamed, and these selects were missed.
Thanks,
Paul Bolle
--
To
ear why they were added
but it's safe to remove them anyway.
Signed-off-by: Paul Bolle
---
Untested!
drivers/media/radio/si4713/Kconfig | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/radio/si4713/Kconfig
b/drivers/media/radio/si4713/Kconfig
index a7c3ba8..ed51ed0 10
rresponding Makefile line is missing.
Besides, the debug code also depends on a mysterious ISS_ISR_DEBUG
macro. This Kconfig entry can be removed.
Someone familiar with the code might be able to say what to do with the
code depending on the DEBUG and ISS_ISR_DEBUG macros.
Signed-off-by: Paul
On Sat, 2013-11-02 at 17:40 -0200, Mauro Carvalho Chehab wrote:
> Em Sat, 02 Nov 2013 20:20:54 +0100
> Paul Bolle escreveu:
> > Those are obvious typos. Still present in v3.12-rc7. Perhaps you'd like
> > to send the trivial patch to fix this?
>
> Yes, it is a typo
ed and evaluates to n.
> The default values are probably only for convenience, so 88EU_AP_MODE and
> 88EU_P2P are activated together with 8188EU. They still can be turned off.
> Anyway, it should probably say "default y" in both cases.
Ditto.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
I can only state that this
dependency is now useless, because that is simply how the kconfig system
works. But you can probably elaborate why it's OK to not replace it with
another (negative) dependency. That would make a more informative commit
explanation.
Paul Bolle
--
To unsubscribe fro
was included in
v3.10-rc1).
After that commit there's still one reference to VIDEO_VPFE_CAPTURE in
the tree: as a (negative) dependency in
drivers/staging/media/davinci_vpfe/Kconfig. Can that (negative)
dependency now be dropped (as it's currently useless) or should it be
replaced with a (n
The last users of Kconfig symbols MX3_VIDEO and VIDEO_MX2_HOSTSUPPORT
were removed in v3.2. Their Kconfig entries can be removed now.
Signed-off-by: Paul Bolle
---
v1 was called "[...] remove "config MX3_VIDEO"". But it turned out that
v3.2, through commit 389d12cc7f ("
The last user of Kconfig symbol MX3_VIDEO was removed in v3.2. Its
Kconfig entry can be removed now.
Signed-off-by: Paul Bolle
---
Tested with "git grep".
drivers/media/platform/soc_camera/Kconfig | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/media/platform/soc_came
The et61x251 driver was removed in v3.5. Remove the last references to
its Kconfig macro now.
Signed-off-by: Paul Bolle
---
Untested, as usual.
drivers/media/usb/gspca/etoms.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/media/usb/gspca/etoms.c b/drivers/media/usb/gspca/etoms.c
On Mon, 2013-03-25 at 13:40 +0400, Denis Kirjanov wrote:
> Just found that the exactly the same patch has been posted a while ago:
> http://driverdev.linuxdriverproject.org/pipermail/devel/2012-November/033623.html
Thanks for that. Is that previous patch queued somewhere?
Paul Bolle
lirc uses the CONFIG_SA1100_BITSY Kconfig macro. But its Kconfig symbol
was removed in v2.4.13. So we can remove a few lines of dead code.
Signed-off-by: Paul Bolle
---
Untested, but of rather low risk. Note that support for the
machine_is_bitsy() macro was already removed in v2.4.10.
drivers
mt9v022:
allow setting of bus width from board code").
These two commits removed all gpio related code from these two drivers.
But they skipped removing their two selects of GPIO_PCA953X. Remove
these now as they are outdated. Their dependencies can never evaluate to
true anyhow.
Signe
The Kconfig entry for "TS2020 based tuners" defaults to modular if
DVB_FE_CUSTOMISE is set. But that Kconfig symbol was replaced with
MEDIA_SUBDRV_AUTOSELECT as of v3.7. So use the new symbol. And negate
the logic, so we are in line with all the similar entries in this file.
Signed-of
unction is called. That means we can change the
while()-do{} loop into a do{}-while() loop. And that suffices to make
GCC see that 'ret' will not be used uninitialized.
Signed-off-by: Paul Bolle
---
Compile tested only!
drivers/media/usb/dvb-usb/m920x.c | 4 ++--
1 file changed, 2 in
:
‘saa7164_s_register’ defined but not used [-Wunused-function]
Silence these warnings by wrapping these two functions in an "#ifdef
CONFIG_VIDEO_ADV_DEBUG" and "#endif" pair.
Signed-off-by: Paul Bolle
---
0) Compile tested only.
1) These warnings are apparently a s
up_read(¤t->mm->mmap_sem);
> } else {
> /* otherwise, use get_user_pages() for general userland pages */
> int res, nr_pages = 1;
> struct page *pages;
> - down_read(¤t->mm->mmap_sem);
>
>
alized_var() stopgap measure.
Also stop printing the return values of tda18212_rd_reg() or
tda18218_rd_reg(), as these are not interesting.
Signed-off-by: Paul Bolle
---
0) Compile tested only.
drivers/media/tuners/tda18212.c | 6 +++---
drivers/media/tuners/tda18218.c | 6 +++---
2 files change
uninitialized in this function [-Wuninitialized]
Move the printk() that uses t_state.bandwith to the location where it
should be initialized to fix this.
Signed-off-by: Paul Bolle
---
0) Compile tested only.
1) By the way, the first two if()-tests in tda8261_get_bandwidth()
should be superfluous
the 'sense' parameter from bool
to int. But, to be safe, we also need to make sure 'sense' will only be
-1, 0, or 1. There's no need to document the new values that are now
allowed for the 'sense' parameter, since they're basically useless.
Signed-off-
Commit 39c3d488452ae206cfc8afda0db041ee55d01c3c ("[media] cpia, stradis:
remove deprecated V4L1 drivers") removed the last file including these
five headers. Apparently it was just an oversight to keep them in the
tree. They can safely be removed now.
Signed-off-by: Paul Bolle
---
0) T
es
tda18271_attach, which is only available if MEDIA_TUNER_TDA18271 is
set.)
The selects of MEDIA_TUNER_XC5000 and MEDIA_TUNER_TDA18271 should only
be done if MEDIA_TUNER_CUSTOMISE isn't set.
Signed-off-by: Paul Bolle
---
0) git grep tested only. The second statement is pure bluff: I&#x
On Sun, 2011-10-30 at 10:24 -0700, Randy Dunlap wrote:
> On 10/30/11 10:12, Paul Bolle wrote:
> > 2) I'm not sure why things are done that way. Why can't builtin drivers
> > and loadable drivers default to identical values? But perhaps I'm just
> > misund
On Sun, 2011-10-30 at 09:43 -0700, Randy Dunlap wrote:
> On 10/30/11 05:08, Paul Bolle wrote:
> > The Kconfig symbol RADIO_TEA5764_XTAL is unused. The code does use a
> > RADIO_TEA5764_XTAL macro, but does that rather peculiar. But there seems
> > to be a way to keep both.
7;use_xtal' to influence all this.
Signed-off-by: Paul Bolle
---
I didn't dare to submit this a trivial patch. This is still untested. By
the way, is xtal a common abbreviation of crystal?
drivers/media/radio/radio-tea5764.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
7;use_xtal' to influence all this.
Signed-off-by: Paul Bolle
---
I didn't dare to submit this a trivial patch. This is still untested. By
the way, is xtal a common abbreviation of crystal?
drivers/media/radio/radio-tea5764.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
es.
See
http://lists.nongnu.org/archive/html/qemu-devel/2010-09/msg00017.html
for the - not very interesting - answer I got when I wanted to know more
about the problems of USB pass through in qemu.
Paul Bolle
--
To unsubscribe from this list: send the line "unsubscribe lin
alyzer and similar
tools in Documentation/usb/usbmon.txt (it now only mentions "usbdump"
and "USBMon"). I remember looking for a tool like that (ie, a parser)
for quite some time before stumbling onto vusb-analyzer.
Paul Bolle
--
To unsubscribe from this list: send the line &q
67 matches
Mail list logo
