Re: [PATCH] libdvbv5: more fixes in the T2 delivery descriptor handler

2013-12-19 Thread Nikolaus Schulz
oid confusion with the {frequency,subcell_info}_loop_length fields in the binary DVBSI format. Thanks, Nikolaus > > Signed-off-by: Nikolaus Schulz > > --- > > lib/libdvbv5/descriptors/desc_t2_delivery.c | 35 > > ++- > > 1 files changed, 18

Re: [PATCH] libdvbv5: more fixes in the T2 delivery descriptor handler

2013-12-18 Thread Nikolaus Schulz
Hi Mauro, I didn't have the time yet to look at your comments and that patch again, but: Please note that my email address is shut down as of today[1]. Please use my alternate address, , for any further replies or followups. Maybe Patchwork[2] should also be updated accordingly? Thanks, Nikol

[PATCH] libdvbv5: more fixes in the T2 delivery descriptor handler

2013-12-05 Thread Nikolaus Schulz
* Fix a couple of memcpy calls, and remove a bogus one * Properly use lengths of centre_frequency loop and subcell_info loop (they count bytes, not entries) Signed-off-by: Nikolaus Schulz --- lib/libdvbv5/descriptors/desc_t2_delivery.c | 35 ++- 1 files changed, 18

Re: global mutex in dvb_usercopy (dvbdev.c)

2013-01-09 Thread Nikolaus Schulz
On Tue, Jan 08, 2013 at 12:05:47PM +0530, Soby Mathew wrote: > Hi Everyone, > I have a doubt regarding about the global mutex lock in > dvb_usercopy(drivers/media/dvb-core/dvbdev.c, line 382) . > > > /* call driver */ > mutex_lock(&dvbdev_mutex); > if ((err = func(file, cmd, parg)) == -ENOIOC

Re: [patch] [media] dvb: unlock on error in dvb_ca_en50221_io_do_ioctl()

2013-01-07 Thread Nikolaus Schulz
On Fri, Jan 04, 2013 at 09:56:02PM +0300, Dan Carpenter wrote: > We recently pushed the locking down into this function, but there was > an error path where the unlock was missed. Ugh, indeed. Thanks for catching this! Nikolaus. -- To unsubscribe from this list: send the line "unsubscribe linux-m

Re: [PATCH] dvb: push down ioctl lock in dvb_usercopy

2012-07-17 Thread Nikolaus Schulz
Hi! I don't want to press or annoy anybody, but may I ask what's the status of this patch[1]? On Thu, Jun 21, 2012 at 07:44:15PM +0200, sch...@macnetix.de wrote: > Since most dvb ioctls wrap their real work with dvb_usercopy, the static mutex > used in dvb_usercopy effectively is a global lock fo

Re: [PATCH] dvb-core: Release semaphore on error path dvb_register_device().

2012-06-23 Thread Nikolaus Schulz
CC'ing sta...@kernel.org, this bugfix applies to all kernels >> 2.6.28. The patch should also be tagged accordingly. On Sat, Jun 23, 2012 at 05:29:54PM +0530, santosh nayak wrote: > From: Santosh Nayak > > There is a missing "up_write()" here. Semaphore should be released > before returning err