.versions = MFC_V6PLUS_BITS,
>> + .flags = V4L2_FMT_FLAG_DYN_RESOLUTION,
>> },
>> {
>> .fourcc = V4L2_PIX_FMT_HEVC,
>> @@ -132,6 +147,8 @@ static struct s5p_mfc_fmt formats[] = {
ly imported and detached again, like Weston is currently
> doing in the DRM compositor.
>
> Signed-off-by: Lucas Stach
Acked-by: Marek Szyprowski
> ---
> v2: Add comments why it is safe to skip the CPU sync.
> ---
> .../common/videobuf2/videobuf2-dma-contig.c | 23
Hi Hans,
On 2019-07-15 12:30, Hans Verkuil wrote:
> Use cec_notifier_cec_adap_(un)register instead of
> cec_notifier_get, cec_notifier_put and cec_register_cec_notifier.
>
> Also enable the CEC_CAP_CONNECTOR_INFO capability.
>
> Signed-off-by: Hans Verkuil
> Cc: Marek Szypro
havior of the
driver and fixes its operation on Exynos5420 SoCs.
Fixes: 1bce6fb3edf1 ("[media] s5p-mfc: Rework clock handling")
Signed-off-by: Marek Szyprowski
---
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/media/pl
havior of the
driver and fixes its operation on Exynos5420 SoCs.
Fixes: 1bce6fb3edf1 ("[media] s5p-mfc: Rework clock handling")
Signed-off-by: Marek Szyprowski
---
v2: this is the correct version, v1 had parenthesis in wrong place
---
drivers/media/platform/s5p-mfc/s5p_mfc_pm.c | 5 +
x28)
Exception stack(0xe73ddfa8 to 0xe73ddff0)
...
---[ end trace 376cf5ba6e0bee93 ]---
Fixes: c8ffbd433a77 ("media: s5p-mfc: Use min scratch buffer size as provided
by F/W")
Signed-off-by: Marek Szyprowski
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 3 ++-
1 file changed, 2 ins
->num_buffers)
> + return q->bufs[index];
> + return NULL;
> +}
> +
> /*
> * The following functions are not part of the vb2 core API, but are useful
>* functions for videobuf2-*.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Hi Hans,
On 2019-06-11 09:52, Hans Verkuil wrote:
> On 6/7/19 9:43 PM, Nicolas Dufresne wrote:
>> Le vendredi 07 juin 2019 à 16:39 +0200, Marek Szyprowski a écrit :
>>> Hi Hans,
>>>
>>> On 2019-06-07 16:11, Hans Verkuil wrote:
>>>> On 6/7/19 3:55 PM
Hi Hans,
On 2019-06-07 16:11, Hans Verkuil wrote:
> On 6/7/19 3:55 PM, Marek Szyprowski wrote:
>> On 2019-06-07 15:40, Hans Verkuil wrote:
>>> On 6/7/19 2:47 PM, Hans Verkuil wrote:
>>>> On 6/7/19 2:23 PM, Hans Verkuil wrote:
>>>>> On 6/7/19 2:14 PM,
Hi Hans,
On 2019-06-07 15:40, Hans Verkuil wrote:
> On 6/7/19 2:47 PM, Hans Verkuil wrote:
>> On 6/7/19 2:23 PM, Hans Verkuil wrote:
>>> On 6/7/19 2:14 PM, Marek Szyprowski wrote:
>>>> On 2019-06-07 14:01, Hans Verkuil wrote:
>>>>> On 6/7/19 1:16 PM,
pt userspace memory
> causing the application to crash. It's not quite clear to me how the memory
> can
> get corrupted. I don't know enough of those low-level mm internals to
> understand
> the sequence of events.
>
> I have test code for v4l2-compliance available
ma_map_resource
> implementation to not provide a somewhat dangerous default and improve
> the error handling.
>
> Changes since v1:
> - don't apply bus offsets in dma_direct_map_resource
Works fine on older Exynos based boards with IOMMU and CMA disabled.
Tested-by: Marek
a
> whole buffer from its beginning.
>
> Signed-off-by: Souptick Joarder
Suggested-by: Marek Szyprowski
Reviewed-by: Marek Szyprowski
> ---
> drivers/media/common/videobuf2/videobuf2-core.c| 7 +++
> .../media/common/videobuf2/videobuf2-dma-contig.c | 6 --
>
Hi Souptick,
On 2019-01-25 05:55, Souptick Joarder wrote:
> On Tue, Jan 22, 2019 at 8:37 PM Marek Szyprowski
> wrote:
>> On 2019-01-11 16:11, Souptick Joarder wrote:
>>> Convert to use vm_insert_range_buggy to map range of kernel memory
>>> to user vma.
>>&g
usize -= PAGE_SIZE;
> - } while (usize > 0);
> -
> + err = vm_insert_range_buggy(vma, buf->pages, buf->num_pages);
> + if (err) {
> + printk(KERN_ERR "Remapping memory, error: %d\n", err);
> + return err;
> + }
>
> /*
>* Use common vm_area operations to track buffer refcount.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Hi Christoph,
On 2019-01-17 18:21, Christoph Hellwig wrote:
> On Mon, Jan 14, 2019 at 01:42:26PM +0100, Marek Szyprowski wrote:
>> On 2019-01-11 19:17, Christoph Hellwig wrote:
>>> vb2_dc_get_userptr pokes into arm direct mapping details to get the
>>> resemblan
ed only when no IOMMU is available, but I agree that the
hacky code should be replaced by a generic code if possible.
Tested-by: Marek Szyprowski
V4L2 pipeline works fine on older Exynos-based boards with CMA and IOMMU
disabled.
> ---
> .../common/videobuf2/videobuf2-dma-contig.c | 41
ptions about the DMA mapping internals. Feel
free to add my:
Reviewed-by: Marek Szyprowski
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
ign data[] to
ARCH_KMALLOC_MINALIGN").
Reported-by: Paweł Chmiel
Fixes: c79667dd93b0 ("media: s5p-mfc: replace custom reserved memory handling
code with generic one")
Signed-off-by: Marek Szyprowski
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 1 -
1 file changed, 1 deletion(-)
dif
Hi Souptick,
On 2018-11-15 16:50, Souptick Joarder wrote:
> Convert to use vm_insert_range to map range of kernel memory
> to user vma.
>
> Signed-off-by: Souptick Joarder
> Reviewed-by: Matthew Wilcox
Acked-by: Marek Szyprowski
> ---
> drivers/media/common/videobuf2/vi
.
>
> Signed-off-by: Myungho Jung
> Reported-by: syzbot+4180ff9ca6810b06c...@syzkaller.appspotmail.com
Acked-by: Marek Szyprowski
Thanks for analyzing the code and fixing this issue!
> ---
> drivers/media/common/videobuf2/videobuf2-core.c | 4
> 1 file changed, 4 insertio
NERS file.
Reported-by: Joe Perches
Signed-off-by: Marek Szyprowski
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 29c08106bd22..4455fe05d3a3 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -15720,7 +15720,7 @@ M:
-mfc 1100.codec: Direct firmware load for s5p-mfc-v6-v2.fw failed with
error -2
s5p-mfc 1100.codec: Direct firmware load for s5p-mfc-v6.fw failed with
error -2
Signed-off-by: Marek Szyprowski
---
drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c | 2 +-
1 file changed, 1 insertion(+), 1
ulk_data *clks)
+{
+}
+
static inline struct clk *clk_get(struct device *dev, const char *id)
{
return NULL;
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
to ioremap so that ioremap
can map correct area. Also, this uses __pfn_to_phys() to get the physical
address of given PFN.
Signed-off-by: Masami Hiramatsu
Reported-by: Takao Orito
Reported-by: Fumihiro ATSUMI
Reviewed-by: Marek Szyprowski
---
Chanegs in v2:
- Fix to pass size + off
PAGE_KERNEL);
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Hi Hans,
On 2017-12-15 16:57, Hans Verkuil wrote:
On 14/12/17 15:11, Marek Szyprowski wrote:
I would like to get your opinion on this patch. Do you think it makes sense to:
1. add limited support for USERPTR and DMA-buf import? (limited means driver
will accept setting buffer pointer/fd only
userspace to discover if device support
queue buffer reconfiguration on-fly or not?
Here is the discussion: https://patchwork.linuxtv.org/patch/45305/
Best regards
Marek Szyprowski, PhD
Samsung R&D Institute Poland
On 2017-11-06 20:21, Nicolas Dufresne wrote:
Le lundi 06 novembre 2017 à 1
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Marek Szyprowski
---
drivers/media/v4l2-core/videobuf2-core.c | 56
drivers/media/v4l2-core/videobuf2-v4l2.c | 10 +++---
2 files changed, 33 insertions(+), 33 deletions(-)
diff --git a/drivers/media/v4l2-core
Hi Nicolas,
On 2017-11-03 14:45, Nicolas Dufresne wrote:
Le vendredi 03 novembre 2017 à 09:11 +0100, Marek Szyprowski a écrit :
MFC driver supports only MMAP operation mode mainly due to the hardware
restrictions of the addresses of the DMA buffers (MFC v5 hardware can
access buffers only in
adapted to v4.14 code base, rewrote and extended commit message,
added checks for changing buffer addresses, added bidirectional queue
flags and comments]
Signed-off-by: Marek Szyprowski
---
v2:
- fixed copy/paste bug, which broke encoding support (thanks to Marian
Mihailescu for reporting i
the above limitations. The IOMMU fault can be mitigated by
enabling
bidirectional flag on OUTPUT queue. This is a bit strange, but that's
how the
hardware behaves. From my research it looks that it happens only in case
of MFCv5,
higher versions don't modify source stream.
Best r
for now
to match other mem2mem drivers.
Signed-off-by: Marek Szyprowski
---
drivers/media/platform/exynos4-is/fimc-m2m.c | 10 +-
1 file changed, 1 insertion(+), 9 deletions(-)
diff --git a/drivers/media/platform/exynos4-is/fimc-m2m.c
b/drivers/media/platform/exynos4-is/fimc-m
for now
to match other mem2mem drivers.
Signed-off-by: Marek Szyprowski
---
drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c
b/drivers/media/platform/exynos-gsc/gsc-m2m.c
index 72
it message]
Signed-off-by: Marek Szyprowski
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 14 --
drivers/media/platform/s5p-mfc/s5p_mfc_dec.c | 73
drivers/media/platform/s5p-mfc/s5p_mfc_enc.c | 24 ++---
3 files changed, 89 insertions(+), 22 deletions(-)
MFC & GSC updates (almost up to date
with 4.14 I think) there was no "Wrong buffer/video queue type (1)"
message either
I will check it and let you know if this is something we should worry about.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
se to add the information about the reference commit to
each
commit message and also point to commit
e752577ed7bf55c81e10343fced8b378cda2b63b,
as it is exactly the same case here. Anyway:
Acked-by: Marek Szyprowski
I wonder if makes sense to send those patches also to sta...@vget.kernel.org
(
.
Suggested-by: Marek Szyprowski
Signed-off-by: Stanimir Varbanov
Acked-by: Marek Szyprowski
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 6 --
drivers/media/v4l2-core/videobuf2-dma-sg.c | 7 +++
2 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/media
Support for Exynos4212 SoCs has been removed by commit bca9085e0ae9 ("ARM:
dts: exynos: remove Exynos4212 support (dead code)"), so there is no need
to keep remaining dead code related to this SoC version.
Signed-off-by: Marek Szyprowski
---
drivers/media/platform/exynos4-is/Kconf
-by: Marek Szyprowski
---
include/media/videobuf2-core.h | 59 +-
1 file changed, 29 insertions(+), 30 deletions(-)
diff --git a/include/media/videobuf2-core.h b/include/media/videobuf2-core.h
index ef9b64398c8c..5f4df060affb 100644
--- a/include/media
probably other drivers
in the future) which wants to map output type of buffers as
read/write.
Signed-off-by: Stanimir Varbanov
Thanks for the patch.
Acked-by: Marek Szyprowski
While touching this, I would love to unify set_page_dirty_lock()
related code in videobuf2-dc, videobuf2-sg and
allow_zero_bytesused:1;
@@ -516,6 +528,7 @@ struct vb2_queue {
/* private: internal use only */
struct mutexmmap_lock;
unsigned intmemory;
+ enum dma_data_direction dma_dir;
struct vb2_buffer
Hi Christoph,
On 2017-07-05 19:33, Christoph Hellwig wrote:
On Mon, Jul 03, 2017 at 11:27:32AM +0200, Marek Szyprowski wrote:
The main question here if we want to merge incomplete solution or not. As
for now, there is no support in ARM/ARM64 for NON_CONSISTENT attribute.
Also none of the v4l2
ned-off-by: Arvind Yadav
Acked-by: Marek Szyprowski
---
drivers/media/v4l2-core/videobuf2-dma-sg.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c
b/drivers/media/v4l2-core/videobuf2-dma-sg.c
index 8e8798a..f8b4643 100644
--- a/dri
Signed-off-by: Arvind Yadav
Thanks!
Acked-by: Marek Szyprowski
---
drivers/media/v4l2-core/videobuf2-dma-contig.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/videobuf2-dma-contig.c
b/drivers/media/v4l2-core/videobuf2-dma-contig.c
index 4f246d
ned-off-by: Arvind Yadav
Acked-by: Marek Szyprowski
---
drivers/media/v4l2-core/videobuf2-vmalloc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/videobuf2-vmalloc.c
b/drivers/media/v4l2-core/videobuf2-vmalloc.c
index b337d78..6bc130f 100644
---
Escande (1):
[media] videobuf2-dc: Move vb2_dc_get_base_sgt() above mmap callbacks
drivers/media/v4l2-core/videobuf2-dma-contig.c | 60 --
1 file changed, 38 insertions(+), 22 deletions(-)
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
too and add DT bindings file pattern match. Also change the mailing
list from ARM generic to Samsung SoC specific to get more attention and
easier review in the future.
Signed-off-by: Marek Szyprowski
Acked-by: Krzysztof Kozlowski
---
v2:
- added DT bindings file as suggested by Krzysztof Kozlowski
too. Also change the mailing list from ARM generic to Samsung SoC
specific to get more attention and easier review in the future.
Signed-off-by: Marek Szyprowski
---
MAINTAINERS | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 053c3bdd1fe5
Hi All,
I'm sorry for the late reply, I just got back from holidays.
On 2017-06-02 23:43, Jacek Anaszewski wrote:
Cc Marek Szyprowski.
Marek, could you share your opinion about this patch?
On 06/02/2017 06:02 PM, Thierry Escande wrote:
From: Tony K Nadackal
This patch adds suppor
Hi Krzysztof,
On 2017-05-31 21:55, Krzysztof Kozlowski wrote:
On Wed, May 31, 2017 at 01:00:17PM +0200, Marek Szyprowski wrote:
Exynos5250 and Exynos542x SoCs have the same CEC hardware module as
Exynos4 SoC series, so enable support for it using the same compatible
string.
Tested on Odroid
e/v4l2-ioctl.c | 6 +++---
drivers/media/v4l2-core/v4l2-subdev.c | 7 ---
drivers/media/v4l2-core/videobuf2-dma-sg.c | 8
For vb2:
Acked-by: Marek Szyprowski
There are also a few vmalloc calls in old videobuf (v1) framework, which
might be converted to kvmalloc if you
Hi Hans,
On 2017-05-31 13:17, Hans Verkuil wrote:
On 05/31/17 13:00, Marek Szyprowski wrote:
Exynos5250 and Exynos542x SoCs have the same CEC hardware module as
Exynos4 SoC series, so enable support for it using the same compatible
string.
Tested on Odroid XU3 (Exynos5422) and Google Snow
Exynos4.
I've just posted a patch enabling CEC module on Exynos5250 (Google Snow)
and Exynos5422 (Odroid XU3).
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Exynos5250 and Exynos542x SoCs have the same CEC hardware module as
Exynos4 SoC series, so enable support for it using the same compatible
string.
Tested on Odroid XU3 (Exynos5422) and Google Snow (Exynos5250) boards.
Signed-off-by: Marek Szyprowski
---
arch/arm/boot/dts/exynos5250
Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote:
Hi Laurent,
On 2017-04-20 12:25, Laurent Pinchart wrote:
Hi Marek,
(CC'ing Sakari Ailus)
Thank you for the patches.
On Thursday 20 Apr 2017 11:13:36 Marek Szyprowski wrote:
Dear all,
This is an updated proposal for extending E
Hi Tobias and Nicolas,
On 2017-04-26 17:16, Tobias Jakobi wrote:
Nicolas Dufresne wrote:
Le mercredi 26 avril 2017 à 01:21 +0300, Sakari Ailus a écrit :
Hi Marek,
On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote:
Hi Laurent,
On 2017-04-20 12:25, Laurent Pinchart wrote:
Hi
Hi Sakari,
On 2017-04-26 00:21, Sakari Ailus wrote:
Hi Marek,
On Thu, Apr 20, 2017 at 01:23:09PM +0200, Marek Szyprowski wrote:
Hi Laurent,
On 2017-04-20 12:25, Laurent Pinchart wrote:
Hi Marek,
(CC'ing Sakari Ailus)
Thank you for the patches.
On Thursday 20 Apr 2017 11:13:36
uf2:
Acked-by: Marek Szyprowski
Thanks, Daniel
---
Changes since v1:
- Added the missing tegra driver (noticed by kbuild robot)
- Rebased off of drm-intel-next to get the i915 selftest that is new
- Fixed nits Sinclair pointed out.
drivers/dma-buf/dma-buf.c
Hi Shuah,
On 2017-04-11 00:50, Shuah Khan wrote:
On 04/06/2017 06:01 AM, Marek Szyprowski wrote:
On 2017-04-05 18:02, Shuah Khan wrote:
When coherent DMA memory without struct page is shared, importer
fails to find the page and runs into kernel page fault when it
tries to dmabuf_ops_attach
d, 69 insertions(+), 5 deletions(-)
> [...]
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
cated - driver will use generic allocator for them instead of the
pre-allocated buffer for firmware and contexts.
Signed-off-by: Marek Szyprowski
---
This patch should solve failure of h264 encoding due to insufficient memory
for codec temporary buffers. Please consider it as part of "[PATC
f v3 patchset) fixes the
issue.
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
From: Marek Szyprowski
Date: Wed, 22 Mar 2017 10:59:26 +0100
Subject: [PATCH] media: s5p-mfc: Don't allocate codec buffers from
pre-allocated region
Further investigation revealed that co
ide
more details of your setup:
- which kernel and patches,
- which hw,
- which test app.
Regards
Andrzej
Thanks,
Marian
Either I've been missing something or nothing has been going on. (K. E. Gordon)
Best regards
--
Marek Szyprowski, PhD
Samsung R&D Institute Poland
Clock should be turned off after calling s5p_mfc_init_hw() from the
watchdog worker, like it is already done in the s5p_mfc_open() which also
calls this function.
Signed-off-by: Marek Szyprowski
Fixes: af93574678108 ("[media] MFC: Add MFC 5.1 V4L2 driver")
CC: sta...@vger.kernel.
Internal MFC driver device structure contains two pointers to devices used
for DMA memory allocation: mem_dev_l and mem_dev_r. Replace them with the
mem_dev[] array and use defines for accessing particular banks. This will
help to simplify code in the next patches.
Signed-off-by: Marek Szyprowski
Remove unused structures, definitions and functions that are no longer
called from the driver code.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
Acked-by: Andrzej Hajda
Tested-by: Smitha T Murthy
Reviewed-by: Smitha T Murthy
code provides and if the DMA base address equals zero, skip
first 128 KiB to keep required alignment. This patch also make the driver
operational on ARM64 architecture, because it no longer depends on ARM
specific DMA-mapping and IOMMU glue code functions.
Signed-off-by: Marek Szyprowski
Reviewed-by
ve also did a bit of cleanup while touching the driver.
Best regards
Marek Szyprowski
Samsung R&D Institute Poland
Changelog:
v3:
- collected tags
- added a patch, which renames BANK1/2 to BANK_L/R to match documentation
- rebased onto v4.11-rc3
v2:
- fixed issues pointed by Javier Martinez Can
Change parameters for s5p_mfc_alloc_priv_buf() and s5p_mfc_release_priv_buf()
functions. Instead of DMA device pointer and a base, provide common MFC
device structure and memory bank context identifier.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier
Use s5p_mfc_priv_buf structure for keeping the firmware image. This will
help handling of firmware buffer allocation in the next patches.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
Acked-by: Andrzej Hajda
Tested-by: Smitha T
Once firmware buffer has been converted to use s5p_mfc_priv_buf structure,
it is possible to allocate it with existing s5p_mfc_alloc_priv_buf()
function. This change will help to reduce code variants in the next
patches.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
keep DMA memory related operations in a single place. This way
s5p_mfc_alloc_firmware() is simplified and does what it name says. The
other consequence of this change is moving s5p_mfc_alloc_firmware() call
from the s5p_mfc_probe() function to the s5p_mfc_configure_dma_memory().
Signed-off-by: Marek
Firmware for MFC v6+ variants is not larger than 400 KiB, so there is no
need to allocate a full 1 MiB buffer for it. Reduce it to 512 KiB to keep
proper alignment of allocated buffer.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Acked-by: Andrzej Hajda
Tested-by
Internal MFC driver device structure contains two entries for keeping
addresses of the DMA memory banks. Replace them with the dma_base[] array
and use defines for accessing particular banks. This will help to simplify
code in the next patches.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier
Setting DMA max segment size to 32 bit mask is a part of DMA memory
configuration, so move those calls to s5p_mfc_configure_dma_memory()
function.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
Acked-by: Andrzej Hajda
Tested-by
functional even without the reserved memory blocks for all
v6+ variants. This patch removes those reserved memory nodes from all
boards having MFC v6+ hardware block.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
Acked-by: Andrzej Hajda
Replace custom code with generic helper to retrieve driver data.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
Acked-by: Andrzej Hajda
Tested-by: Smitha T Murthy
Reviewed-by: Smitha T Murthy
---
drivers/media/platform/s5p-mfc
decoders or encoders (other codecs have smaller memory requirements).
If one needs more for particular use case, one can use "mem" module
parameter to force larger (or smaller) buffer (for example by adding
"s5p_mfc.mem=16M" to kernel command line).
Signed-off-by: Marek Szyprowski
Move code for DMA memory configuration with IOMMU into separate function
to make it easier to compare what is being done in each case.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
Acked-by: Andrzej Hajda
Tested-by: Smitha T Murthy
Documentation for MFC hardware still uses 'left' and 'right' names for
the memory channel/banks, so replace BANK1/2 defines with more appropriate
BANK_L/R names.
Suggested-by: Shuah Khan
Signed-off-by: Marek Szyprowski
---
drivers/media/platform/s5p-mfc/s
guous Memory Allocator) is enabled is 4MiB.
This patch also removes the requirement to provide two reserved memory
regions for MFC v6+ devices in device tree. Now the driver is fully
functional without them.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Mar
Hi Shuah,
On 2017-02-24 15:23, Shuah Khan wrote:
On Thu, Feb 23, 2017 at 11:26 PM, Marek Szyprowski
wrote:
On 2017-02-23 22:43, Shuah Khan wrote:
On Tue, Feb 14, 2017 at 12:52 AM, Marek Szyprowski
wrote:
It turned out that all versions of MFC v6+ hardware doesn't have a strict
requir
Hi Shuah
On 2017-02-23 22:43, Shuah Khan wrote:
On Tue, Feb 14, 2017 at 12:52 AM, Marek Szyprowski
wrote:
It turned out that all versions of MFC v6+ hardware doesn't have a strict
requirement for ALL buffers to be allocated on higher addresses than the
firmware base like it was docum
from [] (ret_from_fork+0x14/0x3c)
---[ end trace 1ead49a7bb83f0d8 ]---
Signed-off-by: Marek Szyprowski
Fixes: af93574678108 ("[media] MFC: Add MFC 5.1 V4L2 driver")
CC: sta...@vger.kernel.org # v4.5+
---
This issue was there from the beggining of the driver, but this patch applies
only t
Hi Shuah,
On 2017-02-22 19:07, Shuah Khan wrote:
On Mon, Feb 20, 2017 at 6:38 AM, Marek Szyprowski
wrote:
To complete DMA memory configuration for MFC device, allocation of the
firmware buffer is needed, because some parameters are dependant on its base
address. Till now, this has been
Dear All,
On 2017-02-21 15:37, Marek Szyprowski wrote:
Hi Christian,
On 2017-02-21 14:59, Christian König wrote:
Am 21.02.2017 um 14:21 schrieb Marek Szyprowski:
Add compat ioctl support to dma-buf. This lets one to use
DMA_BUF_IOCTL_SYNC
ioctl from 32bit application on 64bit kernel. Data
Hi Christian,
On 2017-02-21 14:59, Christian König wrote:
Am 21.02.2017 um 14:21 schrieb Marek Szyprowski:
Add compat ioctl support to dma-buf. This lets one to use
DMA_BUF_IOCTL_SYNC
ioctl from 32bit application on 64bit kernel. Data structures for
both 32
and 64bit modes are same, so there
Add compat ioctl support to dma-buf. This lets one to use DMA_BUF_IOCTL_SYNC
ioctl from 32bit application on 64bit kernel. Data structures for both 32
and 64bit modes are same, so there is no need for additional translation
layer.
Signed-off-by: Marek Szyprowski
---
drivers/dma-buf/dma-buf.c
Setting DMA max segment size to 32 bit mask is a part of DMA memory
configuration, so move those calls to s5p_mfc_configure_dma_memory()
function.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
---
drivers/media/platform/s5p-mfc
Internal MFC driver device structure contains two pointers to devices used
for DMA memory allocation: mem_dev_l and mem_dev_r. Replace them with the
mem_dev[] array and use defines for accessing particular banks. This will
help to simplify code in the next patches.
Signed-off-by: Marek Szyprowski
Replace custom code with generic helper to retrieve driver data.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
---
drivers/media/platform/s5p-mfc/s5p_mfc.c| 17 ++---
drivers/media/platform/s5p-mfc
Firmware for MFC v6+ variants is not larger than 400 KiB, so there is no
need to allocate a full 1 MiB buffer for it. Reduce it to 512 KiB to keep
proper alignment of allocated buffer.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
---
drivers/media/platform/s5p-mfc/regs
Use s5p_mfc_priv_buf structure for keeping the firmware image. This will
help handling of firmware buffer allocation in the next patches.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
---
drivers/media/platform/s5p-mfc/s5p_mfc_cmd_v5
code provides and if the DMA base address equals zero, skip
first 128 KiB to keep required alignment. This patch also make the driver
operational on ARM64 architecture, because it no longer depends on ARM
specific DMA-mapping and IOMMU glue code functions.
Signed-off-by: Marek Szyprowski
Reviewed-by
Move code for DMA memory configuration with IOMMU into separate function
to make it easier to compare what is being done in each case.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 102
keep DMA memory related operations in a single place. This way
s5p_mfc_alloc_firmware() is simplified and does what it name says. The
other consequence of this change is moving s5p_mfc_alloc_firmware() call
from the s5p_mfc_probe() function to the s5p_mfc_configure_dma_memory().
Signed-off-by: Marek
functional even without the reserved memory blocks for all
v6+ variants. This patch removes those reserved memory nodes from all
boards having MFC v6+ hardware block.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Martinez Canillas
---
arch/arm/boot/dts
guous Memory Allocator) is enabled is 4MiB.
This patch also removes the requirement to provide two reserved memory
regions for MFC v6+ devices in device tree. Now the driver is fully
functional without them.
Signed-off-by: Marek Szyprowski
Reviewed-by: Javier Martinez Canillas
Tested-by: Javier Mar
decoders or encoders (other codecs have smaller memory requirements).
If one needs more for particular use case, one can use "mem" module
parameter to force larger (or smaller) buffer (for example by adding
"s5p_mfc.mem=16M" to kernel command line).
Signed-off-by: Marek Szyprowski
1 - 100 of 975 matches
Mail list logo
