Re: Keymap with duplicate entries

2019-07-03 Thread Malcolm Priestley
> On Tue, Jul 02, 2019 at 11:29:58PM +0100, Malcolm Priestley wrote: >>> Hey Malcolm, >>> >>> There seems to be a problem in the keymap you provided for inclusion >>> in the kernel. >>> >>> In media/rc/keymaps/rc-it913x-v2

Re: Keymap with duplicate entries

2019-07-02 Thread Malcolm Priestley
> Hey Malcolm, > > There seems to be a problem in the keymap you provided for inclusion > in the kernel. > > In media/rc/keymaps/rc-it913x-v2.c, 2 keys are triggered by the same > keycode: > 53 ↦ { 0x866b18, KEY_VOLUMEDOWN },• > 55 ↦ { 0x866b18, KEY_CHANNELDOWN },• Hmm I don't hav

[PATCH v2 2/2] media: lmedm04: Move interrupt buffer to priv buffer.

2018-12-05 Thread Malcolm Priestley
Interrupt is always present throughout life time of driver and there is no dma element move this buffer to private area of driver. Signed-off-by: Malcolm Priestley --- v2 removed the need for DMA transfer flags as per Sean drivers/media/usb/dvb-usb-v2/lmedm04.c | 28

[PATCH v2 1/2] media: lmedm04: Add missing usb_free_urb to free interrupt urb.

2018-12-05 Thread Malcolm Priestley
The interrupt urb is killed but never freed add the function Signed-off-by: Malcolm Priestley --- v2 avoiding stale pointer in usb_free_coherent as per sean drivers/media/usb/dvb-usb-v2/lmedm04.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b

[PATCH 1/4] media: lmedm04: Add missing usb_free_urb to free, interrupt urb

2018-11-29 Thread Malcolm Priestley
The interrupt urb is killed but never freed add the function Cc: sta...@vger.kernel.org Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb-usb-v2/lmedm04

[PATCH 2/4] media: lmedm04: Move usb buffer to lme2510_state.

2018-11-29 Thread Malcolm Priestley
lme2510_state exists for the entire duration of driver. Move usb_buffer to lme2510_state removing the need for lme2510_exit_int for removing the buffer. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 35 +++--- 1 file changed, 3 insertions

[PATCH 3/4] media: lmedm04: Move interrupt buffer to priv buffer.

2018-11-29 Thread Malcolm Priestley
Interrupt is always present throught life time of there is no dma element move this buffer to private area of driver. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a

[PATCH 4/4] media: lmedm04: use dvb_usbv2_generic_rw_locked

2018-11-29 Thread Malcolm Priestley
Use dvb-usb-v2 generic usb function for bulk transfers and simplify logic. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 42 -- 1 file changed, 12 insertions(+), 30 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b

[PATCH v3] [bug/urgent] dvb-usb-v2: Fix incorrect use of transfer_flags URB_FREE_BUFFER

2018-11-26 Thread Malcolm Priestley
buffers. The stream buffer should remain constant while driver is up. Signed-off-by: Malcolm Priestley CC: sta...@vger.kernel.org # v4.18+ --- v3 change commit message to the actual cause drivers/media/usb/dvb-usb-v2/usb_urb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff

Re: DVB-S PCI card regression on 4.19 / 4.20

2018-11-21 Thread Malcolm Priestley
On 20/11/2018 16:08, Mauro Carvalho Chehab wrote: > Em Tue, 20 Nov 2018 14:20:01 +0100 > Ok. Now, min/max frequencies are at the same scale. For DVB-S, > dvb_frontend_get_frequency_limits() returns both in kHz, so the frequency > range is now OK. > > The tuning frequency is wrong through. 10,71

Re: DVB-S PCI card regression on 4.19 / 4.20

2018-11-19 Thread Malcolm Priestley
Hi On 19/11/2018 17:53, Mauro Carvalho Chehab wrote: > Hi Takashi, > > Em Mon, 19 Nov 2018 16:13:29 +0100 > Takashi Iwai escreveu: > >> Hi, >> >> we've got a regression report on openSUSE Bugzilla regarding DVB-S PCI >> card: >> https://bugzilla.opensuse.org/show_bug.cgi?id=1116374 >> >> Acc

[PATCH v2] [bug/urgent] dvb-usb-v2: Fix incorrect use of transfer_flags URB_FREE_BUFFER

2018-10-24 Thread Malcolm Priestley
: Malcolm Priestley CC: sta...@vger.kernel.org # v4.18+ --- drivers/media/usb/dvb-usb-v2/usb_urb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/usb_urb.c b/drivers/media/usb/dvb-usb-v2/usb_urb.c index 024c751eb165..2ad2ddeaff51 100644 --- a

Re: [PATCH] [bug/urgent] dvb-usb-v2: Fix incorrect use of transfer_flags URB_FREE_BUFFER

2018-10-24 Thread Malcolm Priestley
On 23/10/2018 22:26, Malcolm Priestley wrote: > In commit 1a0c10ed7b media: dvb-usb-v2: stop using coherent memory for URBs > incorrectly adds URB_FREE_BUFFER after every urb transfer resulting in > no buffers and eventually deadlock. > > The stream buffer should remain in consta

[PATCH] [bug/urgent] dvb-usb-v2: Fix incorrect use of transfer_flags URB_FREE_BUFFER

2018-10-23 Thread Malcolm Priestley
: Malcolm Priestley CC: sta...@vger.kernel.org # v4.18+ --- drivers/media/usb/dvb-usb-v2/usb_urb.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/usb_urb.c b/drivers/media/usb/dvb-usb-v2/usb_urb.c index 024c751eb165..2ad2ddeaff51 100644

[PATCH 1/2] media: dvb-usb-v2: lmedm04: Improve logic checking of warm start.

2017-09-26 Thread Malcolm Priestley
deref or user memory access as Reported-by: Andrey Konovalov Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 26 ++ 1 file changed, 18 insertions(+), 8 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb

[PATCH 2/2] media: dvb-usb-v2: lmedm04: move ts2020 attach to dm04_lme2510_tuner

2017-09-26 Thread Malcolm Priestley
: probe of 0-0060 failed with error -11 ... LME2510(C): TUN Found RS2000 tuner kasan: CONFIG_KASAN_INLINE enabled kasan: GPF could be caused by NULL-ptr deref or user memory access general protection fault: [#1] PREEMPT SMP KASAN Reported-by: Andrey Konovalov Signed-off-by: Malcolm Priestley

Re: usb/media/lmedm04: GPF in lme2510_int_read/usb_pipe_endpoint

2017-09-25 Thread Malcolm Priestley
On 25/09/17 13:39, Andrey Konovalov wrote: Hi! I've got the following report while fuzzing the kernel with syzkaller. On commit e19b205be43d11bff638cad4487008c48d21c103 (4.14-rc2). usb 1-1: new full-speed USB device number 2 using dummy_hcd gadgetfs: connected gadgetfs: disconnected gadgetfs

Re: [PATCH RFC 1/2] app: kaffeine: Fix missing PCR on live streams.

2017-07-09 Thread Malcolm Priestley
On 09/07/17 12:14, Mauro Carvalho Chehab wrote: Hi Malcolm, Em Sun, 9 Jul 2017 10:43:50 +0100 Malcolm Priestley escreveu: The ISO/IEC standard 13818-1 or ITU-T Rec. H.222.0 standard allow transport vendors to place PCR (Program Clock Reference) on a different PID. If the PCR is unset the

[PATCH RFC 1/2] app: kaffeine: Fix missing PCR on live streams.

2017-07-09 Thread Malcolm Priestley
offset of 8 in pmtSection structure. Signed-off-by: Malcolm Priestley --- src/dvb/dvbliveview.cpp | 8 src/dvb/dvbsi.h | 5 + 2 files changed, 13 insertions(+) diff --git a/src/dvb/dvbliveview.cpp b/src/dvb/dvbliveview.cpp index cfad892..3e92fa6 100644 --- a/src/dvb

[PATCH RFC 2/2] app: kaffeine: Fix missing PCR on stream recordings.

2017-07-09 Thread Malcolm Priestley
The ISO/IEC standard 13818-1 or ITU-T Rec. H.222.0 standard allow transport vendors to place PCR (Program Clock Reference) on a different PID. This patch adds it recording to file. Signed-off-by: Malcolm Priestley --- src/dvb/dvbrecording.cpp | 8 1 file changed, 8 insertions(+) diff

Re: Kaffeine with VLC backend.

2017-07-08 Thread Malcolm Priestley
On 08/07/17 20:09, Mauro Carvalho Chehab wrote: Em Sat, 8 Jul 2017 18:13:14 +0100 Malcolm Priestley escreveu: On 08/07/17 08:17, Malcolm Priestley wrote: Hi Mauro Have you encountered a strange bug with Kaffeine with VLC backend. Certain channels will not play correctly, the recordings

Re: Kaffeine with VLC backend.

2017-07-08 Thread Malcolm Priestley
On 08/07/17 08:17, Malcolm Priestley wrote: Hi Mauro Have you encountered a strange bug with Kaffeine with VLC backend. Certain channels will not play correctly, the recordings will also not play in VLC. However, they will play fine with xine player. Only some channels are affected of

Kaffeine with VLC backend.

2017-07-08 Thread Malcolm Priestley
Hi Mauro Have you encountered a strange bug with Kaffeine with VLC backend. Certain channels will not play correctly, the recordings will also not play in VLC. However, they will play fine with xine player. Only some channels are affected of those provided by SKY such as 12207 V on Astra 28.

Re: [media-dvb-usb-v2] question about value overwrite

2017-05-18 Thread Malcolm Priestley
Hi On 18/05/17 20:09, Gustavo A. R. Silva wrote: Hello everybody, While looking into Coverity ID 1226934 I ran into the following piece of code at drivers/media/usb/dvb-usb-v2/lmedm04.c:205 205static int lme2510_stream_restart(struct dvb_usb_device *d) 206{ 207struct lme2510_state *

Re: [v4.9-rc4] dvb-usb/cinergyT2 NULL pointer dereference

2016-11-09 Thread Malcolm Priestley
On 08/11/16 21:38, Mauro Carvalho Chehab wrote: Em Tue, 8 Nov 2016 22:15:24 +0100 Benjamin Larsson escreveu: On 11/08/2016 09:22 PM, Mauro Carvalho Chehab wrote: Em Tue, 8 Nov 2016 10:42:03 -0800 Linus Torvalds escreveu: On Sun, Nov 6, 2016 at 7:40 AM, Jörg Otte wrote: Since v4.9-rc4 I g

Re: [PATCH 0004/1529] Fix typo

2016-05-22 Thread Malcolm Priestley
On 21/05/16 12:36, Andrea Gelmini wrote: Signed-off-by: Andrea Gelmini --- Documentation/DocBook/media/v4l/lirc_device_interface.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/DocBook/media/v4l/lirc_device_interface.xml b/Documentation/DocBook/media/v4l

Re: [PATCH] media: dvb-core: Don't force CAN_INVERSION_AUTO in oneshot mode.

2015-08-31 Thread Malcolm Priestley
Hi Devin On 31/08/15 19:07, Devin Heitmueller wrote: Hi Malcolm, The capabilities call interacting with the oneshot setting is rather weird and maybe unexpected. No, because in normal mode it can do auto inversion. ... If the goal was for the software-emulated auto inversion to be trans

Re: [PATCH] media: dvb-core: Don't force CAN_INVERSION_AUTO in oneshot mode.

2015-08-31 Thread Malcolm Priestley
On 31/08/15 18:03, Johann Klammer wrote: Why not just remove the line? info->caps |= FE_CAN_INVERSION_AUTO; The capabilities call interacting with the oneshot setting is rather weird and maybe unexpected. No, because in normal mode it can do auto inversion. -- To unsubscribe from

[PATCH] media: dvb-core: Don't force CAN_INVERSION_AUTO in oneshot mode.

2015-08-31 Thread Malcolm Priestley
only set FE_CAN_INVERSION_AUTO in modes other than FE_TUNE_MODE_ONESHOT Signed-off-by: Malcolm Priestley Cc: --- drivers/media/dvb-core/dvb_frontend.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/media/dvb-core/dvb_frontend.c b/drivers/media/dvb

Re: [BUG] STV0299 has bogus CAN_INVERSION_AUTO flag

2015-08-30 Thread Malcolm Priestley
On 30/08/15 16:07, Johann Klammer wrote: On 08/30/2015 11:53 AM, Malcolm Priestley wrote: On 24/08/15 16:19, Johann Klammer wrote: from gdb dump: [...] info = { name = "ST STV0299 DVB-S", '\000' , type = FE_QPSK, frequency_min = 95, fre

Re: [BUG] STV0299 has bogus CAN_INVERSION_AUTO flag

2015-08-30 Thread Malcolm Priestley
On 24/08/15 16:19, Johann Klammer wrote: from gdb dump: [...] info = { name = "ST STV0299 DVB-S", '\000' , type = FE_QPSK, frequency_min = 95, frequency_max = 215, frequency_stepsize = 125, frequency_tolerance = 0, symbol_rate_min = 100, symbol_rate_max = 4

[PATCH v2][media] lmedm04: implement dvb v5 statistics

2015-06-08 Thread Malcolm Priestley
/tuner. Signed-off-by: Malcolm Priestley --- v2 Correct variable size casts drivers/media/usb/dvb-usb-v2/lmedm04.c | 104 - 1 file changed, 77 insertions(+), 27 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb-usb-v2

Re: [PATCH] [media] lmedm04: implement dvb v5 statistics

2015-06-08 Thread Malcolm Priestley
On 08/06/15 21:06, Malcolm Priestley wrote: Indroduce function lme2510_update_stats to update statistics directly from usb interrupt. Provide signal and snr wrap rounds for dvb v3 functions. Block and post bit are not available. When i2c_talk_onoff is on no statistics are available, with

[PATCH] [media] lmedm04: implement dvb v5 statistics

2015-06-08 Thread Malcolm Priestley
/tuner. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 104 - 1 file changed, 77 insertions(+), 27 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb-usb-v2/lmedm04.c index f1983f2..1717102

[PATCH] [media] lmedm04: Enable dont_poll for TS2020 tuner.

2015-06-05 Thread Malcolm Priestley
Following a change made to TS2020 tuner in patches ts2020: Provide DVBv5 API signal strength ts2020: Allow stats polling to be suppressed Polling on the driver must be suppressed because the demuxer is stopped by I2C messages. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2

Re: [PATCH] ts2020: Allow stats polling to be suppressed

2015-06-03 Thread Malcolm Priestley
On 03/06/15 12:35, David Howells wrote: Statistics polling can not be done by lmedm04 driver's implementation of M88RS2000/TS2020 because I2C messages stop the device's demuxer, so allow polling for statistics to be suppressed in the ts2020 driver by setting dont_poll in the ts2020_config struc

Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength

2015-06-03 Thread Malcolm Priestley
On 03/06/15 17:43, Antti Palosaari wrote: On 06/03/2015 07:37 PM, David Howells wrote: Malcolm Priestley wrote: Yes, also, the workqueue appears not to be initialized when using the dvb attached method. I'm not sure what you're referring to. It's initialised in ts2020_pro

Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength

2015-06-03 Thread Malcolm Priestley
On 03/06/15 17:37, David Howells wrote: Malcolm Priestley wrote: Yes, also, the workqueue appears not to be initialized when using the dvb attached method. I'm not sure what you're referring to. It's initialised in ts2020_probe() just after the ts2020_priv struct is alloc

Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength

2015-06-03 Thread Malcolm Priestley
On 03/06/15 12:13, Antti Palosaari wrote: On 05/28/2015 11:07 PM, Malcolm Priestley wrote: On 28/05/15 11:08, David Howells wrote: Malcolm Priestley wrote: Statistics polling can not be done by lmedm04 driver's implementation of M88RS2000/TS2020 because I2C messages stop the de

Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength

2015-06-03 Thread Malcolm Priestley
On 03/06/15 11:17, David Howells wrote: Malcolm Priestley wrote: Yes, also, the workqueue appears not to be initialized when using the dvb attached method. I'm not sure what you're referring to. It's initialised in ts2020_probe() just after the ts2020_priv struct is alloc

Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength

2015-05-28 Thread Malcolm Priestley
On 28/05/15 11:08, David Howells wrote: Malcolm Priestley wrote: Statistics polling can not be done by lmedm04 driver's implementation of M88RS2000/TS2020 because I2C messages stop the devices demuxer. So any polling must be a config option for this driver. Ummm... I presume a ru

Re: [PATCH 2/2] ts2020: Provide DVBv5 API signal strength

2015-05-26 Thread Malcolm Priestley
On 26/05/15 16:04, David Howells wrote: Provide a DVBv5 API signal strength. This is in units of 0.001 dBm rather than a percentage. From Antti Palosaari's testing with a signal generator, it appears that the gain calculated according to Montage's specification if negated is a reasonable repr

Re: [PATCH 5/5] lmedm04: add read snr, signal strength and ber call backs

2015-02-03 Thread Malcolm Priestley
On 03/02/15 19:44, Mauro Carvalho Chehab wrote: Em Tue, 03 Feb 2015 19:31:16 + Malcolm Priestley escreveu: On 03/02/15 19:19, Mauro Carvalho Chehab wrote: Em Fri, 2 Jan 2015 13:56:31 + Malcolm Priestley escreveu: This allows calling the original functions providing the

Re: [PATCH 5/5] lmedm04: add read snr, signal strength and ber call backs

2015-02-03 Thread Malcolm Priestley
On 03/02/15 19:31, Malcolm Priestley wrote: On 03/02/15 19:19, Mauro Carvalho Chehab wrote: Em Fri, 2 Jan 2015 13:56:31 + Malcolm Priestley escreveu: This allows calling the original functions providing the streaming is off. Malcolm, I'm applying this patch series, as the d

Re: [PATCH 5/5] lmedm04: add read snr, signal strength and ber call backs

2015-02-03 Thread Malcolm Priestley
On 03/02/15 19:19, Mauro Carvalho Chehab wrote: Em Fri, 2 Jan 2015 13:56:31 + Malcolm Priestley escreveu: This allows calling the original functions providing the streaming is off. Malcolm, I'm applying this patch series, as the driver has already some support for the legacy

[PATCH 4/5] lmedm04: Create frontend call back for read status.

2015-01-02 Thread Malcolm Priestley
ck for rs2000 tuner is nologer required. All frontend types have been tested. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 205 ++--- 1 file changed, 60 insertions(+), 145 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/lmedm0

[PATCH 2/5] lmedm04: Fix usb_submit_urb BOGUS urb xfer, pipe 1 != type 3 in interrupt urb

2015-01-02 Thread Malcolm Priestley
A quirk of some older firmwares that report endpoint pipe type as PIPE_BULK but the endpoint otheriwse functions as interrupt. Check if usb_endpoint_type is USB_ENDPOINT_XFER_BULK and set as usb_rcvbulkpipe. Signed-off-by: Malcolm Priestley Cc: --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 7

[PATCH 5/5] lmedm04: add read snr, signal strength and ber call backs

2015-01-02 Thread Malcolm Priestley
This allows calling the original functions providing the streaming is off. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b/drivers/media/usb/dvb

[PATCH 3/5] lmedm04: create frontend callbacks for signal/snr/ber/ucblocks

2015-01-02 Thread Malcolm Priestley
Create call backs dm04_read_signal_strength, dm04_read_snr and move dm04_read_ber and dm04_read_ucblocks for all frontends Removing the I2C filtering from lme2510_msg and the old rs2000 callbacks. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 93

[PATCH 1/5] lmedm04: Increase Interupt due time to 200 msec.

2015-01-02 Thread Malcolm Priestley
Ocassionally the device fails to report back an interrupt urb status which results in false no lock trigger on the RS2000 demodulator. Increase time from 60 msecs to 200 msecs. Signed-off-by: Malcolm Priestley Cc: # v3.17+ --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 7 --- 1 file changed

Re: [PATCH] [media] lmed04: add missing breaks

2014-11-25 Thread Malcolm Priestley
On 25/11/14 18:00, Mauro Carvalho Chehab wrote: Em Tue, 25 Nov 2014 17:10:00 + Malcolm Priestley escreveu: On 25/11/14 11:19, Mauro Carvalho Chehab wrote: drivers/media/usb/dvb-usb-v2/lmedm04.c:828 lme_firmware_switch() warn: missing break? reassigning 'st->dvb_usb_lme2510_

Re: [PATCH] [media] lmed04: add missing breaks

2014-11-25 Thread Malcolm Priestley
On 25/11/14 11:19, Mauro Carvalho Chehab wrote: drivers/media/usb/dvb-usb-v2/lmedm04.c:828 lme_firmware_switch() warn: missing break? reassigning 'st->dvb_usb_lme2510_firmware' drivers/media/usb/dvb-usb-v2/lmedm04.c:849 lme_firmware_switch() warn: missing break? reassigning 'st->dvb_usb_lme2510

Re: em28xx: Hauppauge HVR 900 on 3.18.0-rc3

2014-11-06 Thread Malcolm Priestley
On 06/11/14 06:51, Michal B wrote: Hi, analog TV on Hauppauge HVR 900 [2040:6500] - audio works correctly but video stops after few samples, audio continues after video stop, H Michal Yep, pretty much the same for all 3.18 and rc3 One of my systems freezes the other no video. All the drivers

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-07 Thread Malcolm Priestley
On 07/09/14 00:38, Antti Palosaari wrote: On 09/07/2014 01:37 AM, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014 22:37:21 +0100 Malcolm Priestley escreveu: On 06/09/14 17:24, Malcolm Priestley wrote: On 06/09/14 03:51, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014 05:09:55 +0300

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-06 Thread Malcolm Priestley
On 06/09/14 17:24, Malcolm Priestley wrote: On 06/09/14 03:51, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014 05:09:55 +0300 Antti Palosaari escreveu: Moro! On 08/29/2014 01:45 PM, Akihiro TSUKADA wrote: moikka, Start polling thread, which polls once per 2 sec or so, which reads RSSI

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-06 Thread Malcolm Priestley
On 06/09/14 17:24, Malcolm Priestley wrote: On 06/09/14 03:51, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014 05:09:55 +0300 Antti Palosaari escreveu: Moro! On 08/29/2014 01:45 PM, Akihiro TSUKADA wrote: moikka, Start polling thread, which polls once per 2 sec or so, which reads RSSI

Re: [PATCH v2 1/5] dvb-core: add a new tuner ops to dvb_frontend for APIv5

2014-09-06 Thread Malcolm Priestley
On 06/09/14 03:51, Mauro Carvalho Chehab wrote: Em Sat, 06 Sep 2014 05:09:55 +0300 Antti Palosaari escreveu: Moro! On 08/29/2014 01:45 PM, Akihiro TSUKADA wrote: moikka, Start polling thread, which polls once per 2 sec or so, which reads RSSI and writes value to struct dtv_frontend_propert

[PATCH] af9035: new IDs: add support for PCTV 78e and PCTV 79e

2014-08-05 Thread Malcolm Priestley
add the following IDs USB_PID_PCTV_78E (0x025a) for PCTV 78e USB_PID_PCTV_79E (0x0262) for PCTV 79e For these it9135 devices. Signed-off-by: Malcolm Priestley Cc: Antti Palosaari Cc: # v3.14+ --- drivers/media/dvb-core/dvb-usb-ids.h | 2 ++ drivers/media/usb/dvb-usb-v2/af9035.c | 4 2

[PATCH] lmedm04: rs2000 check if interrupt urb is over due

2014-05-24 Thread Malcolm Priestley
clear signal lock. This results in far faster recovery of lock and streaming. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/lmedm04.c | 25 ++--- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/lmedm04.c b

Re: lmedm04 NEC scancode question

2014-03-30 Thread Malcolm Priestley
On 28/03/14 00:38, David Härdeman wrote: Hi Malcolm, Hi David I'm trying to make sure that the extended NEC parsing is consistent across drivers and I have a question regarding drivers/media/usb/dvb-usb-v2/lmedm04.c In commit 616a4b83 you changed the scancode from something like this:

[PATCH] m88rs2000: fix sparse static warnings.

2014-03-24 Thread Malcolm Priestley
hould it be static? m88rs2000.c:366:16: warning: symbol 'fe_trigger' was not declared. Should it be static? Signed-off-by: Malcolm Priestley --- drivers/media/dvb-frontends/m88rs2000.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/dvb-fr

[PATCH 1/4] it913x: dead code Remove driver.

2014-02-13 Thread Malcolm Priestley
Following moving ids to af9035. This driver is no longer in use. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/Kconfig | 7 - drivers/media/usb/dvb-usb-v2/Makefile | 3 - drivers/media/usb/dvb-usb-v2/it913x.c | 809 -- 3 files changed

[PATCH 4/4] get_dvb_firmware: it913x: Remove it9137 firmware files

2014-02-13 Thread Malcolm Priestley
Remove it9137 firmware files it9137.txt and it9137 get_dvb_firmware. dvb-usb-it9137-01.fw firmware is no longer in use. Signed-off-by: Malcolm Priestley --- Documentation/dvb/get_dvb_firmware | 22 ++ Documentation/dvb/it9137.txt | 9 - 2 files changed, 2

[PATCH 3/4] MAINTAINERS: Remove it913x* maintainers entries.

2014-02-13 Thread Malcolm Priestley
Signed-off-by: Malcolm Priestley --- MAINTAINERS | 16 1 file changed, 16 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index b2cf5cf..538b894 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4771,22 +4771,6 @@ F: Documentation/hwmon/it87 F: drivers/hwmon/it87.c

Re: [PATCH 2/2] af9035: Add remaining it913x dual ids to af9035.

2014-02-11 Thread Malcolm Priestley
On Tue, 2014-02-11 at 22:41 +0200, Antti Palosaari wrote: > On 11.02.2014 22:32, Malcolm Priestley wrote: > > On Tue, 2014-02-11 at 19:42 +0200, Antti Palosaari wrote: > >> Moikka Malcolm! > >> Thanks for the patch serie. > >> > >> You removed all ID

Re: [PATCH 2/2] af9035: Add remaining it913x dual ids to af9035.

2014-02-11 Thread Malcolm Priestley
On Tue, 2014-02-11 at 19:42 +0200, Antti Palosaari wrote: > Moikka Malcolm! > Thanks for the patch serie. > > You removed all IDs from it913x driver. There is possibility to just > remove / comment out: > MODULE_DEVICE_TABLE(usb, it913x_id_table); > which prevents loading that driver automa

[PATCH 2/2] af9035: Add remaining it913x dual ids to af9035.

2014-02-09 Thread Malcolm Priestley
As follow on to patch af9035: Move it913x single devices to af9035 and patch 1. SNR is reported as db/10 values. All dual ids are added to af9035 and it913x driver disabled. it913x/it913x-fe removal patches to follow. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/af9035.c

[PATCH 1/2] af9035: add default 0x9135 slave I2C address

2014-02-09 Thread Malcolm Priestley
On some devices the vendor has not set EEPROM_2ND_DEMOD_ADDR. Checks tmp is not zero after call to get EEPROM_2ND_DEMOD_ADDR and sets the default slave address of 0x3a on 0x9135 devices. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/af9035.c | 8 1 file changed, 8

Re: [PATCH] af9035: Move it913x single devices to af9035

2014-02-09 Thread Malcolm Priestley
On Sat, 2014-02-08 at 16:11 +, Malcolm Priestley wrote: > The generic v1 and v2 devices have been all tested. > > IDs tested > USB_PID_ITETECH_IT9135 v1 & v2 > USB_PID_ITETECH_IT9135_9005 v1 > USB_PID_ITETECH_IT9135_9006 v2 > > Current Issues > There is no sign

Re: video from USB DVB-T get damaged after some time

2014-02-08 Thread Malcolm Priestley
> And then run it again. (It was not necessary to switch to another freq. > and back, as I wrote before). > Unfortunately it damages for a while the recording (file.ts). > Is there another way how to "re-tune" (re-zap) without break > recording/viewing ? > I cou

[PATCH] af9035: Move it913x single devices to af9035

2014-02-08 Thread Malcolm Priestley
All remotes tested okay. Dual device failed to register second adapter USB_PID_KWORLD_UB499_2T_T09 It is not clear what the problem is at the moment. So only single IDs are transferred in this patch. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/af9035.c

Re: video from USB DVB-T get damaged after some time

2014-02-08 Thread Malcolm Priestley
On Sat, 2014-02-08 at 15:43 +0100, kap...@mizera.cz wrote: > Hello, > > unfortunately I do not understand development, patching, compiling things. > I have try it but I need more help. > > I have done: > > git clone --depth=1 git://linuxtv.org/media_build.git > cd media_build > ./build > > it d

[PATCH 1/2] m88rs2000: add caps FE_CAN_INVERSION_AUTO

2014-02-04 Thread Malcolm Priestley
This frontend is always auto inversion. Signed-off-by: Malcolm Priestley Cc: sta...@vger.kernel.org # v3.9+ --- drivers/media/dvb-frontends/m88rs2000.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/m88rs2000.c b/drivers/media/dvb-frontends

[PATCH 2/2] m88rs2000: add m88rs2000_get_tune_settings

2014-02-04 Thread Malcolm Priestley
, but slows down the set frontend where lock can never be achieved i.e. DVB-S2. Signed-off-by: Malcolm Priestley Cc: sta...@vger.kernel.org # v3.9+ --- drivers/media/dvb-frontends/m88rs2000.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/media/dvb-frontends/m88rs2000

[PATCH TEST] ts2020.c : correct divider settings

2014-01-24 Thread Malcolm Priestley
try to tune to the problematic channels. Then try to see if I > can figure out how the code that programs the pll oscilliator functions > and if I can come up with better dividers for it. I am using the ts2020 with the m88r2000. It think the problem is in ds3000. Here is alternative ndiv

[PATCH 3/3] m88rs2000: Correct m88rs2000_get_fec

2013-12-28 Thread Malcolm Priestley
Value of fec is achieved by the upper nibble bits 6,7 & 8. Signed-off-by: Malcolm Priestley --- drivers/media/dvb-frontends/m88rs2000.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/drivers/media/dvb-frontends/m88rs2000.c b/drivers/media/dvb-front

[PATCH 2/3] m88rs2000: Correct m88rs2000_set_fec settings.

2013-12-28 Thread Malcolm Priestley
Register 0x70 is used to set fec, register 0x76 is used to get fec Register 0x76 is set to 0x8. Signed-off-by: Malcolm Priestley --- drivers/media/dvb-frontends/m88rs2000.c | 37 + 1 file changed, 19 insertions(+), 18 deletions(-) diff --git a/drivers/media/dvb

[PATCH 1/3] m88rs2000: correct read status lock value.

2013-12-28 Thread Malcolm Priestley
The correct lock values is when bits of the value 0xee are set. Signed-off-by: Malcolm Priestley --- drivers/media/dvb-frontends/m88rs2000.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/dvb-frontends/m88rs2000.c b/drivers/media/dvb-frontends/m88rs2000.c

[PATCH 2/2] m88rs2000: set symbol rate accurately.

2013-12-24 Thread Malcolm Priestley
0-0xa3. In set_frontend add changes to register 0xf1 this must be done prior call to fe_reset. Register 0x00 doesn't need a second write of 0x1 Applied after patch m88rs2000: add m88rs2000_set_carrieroffset Signed-off-by: Malcolm Priestley Cc: sta...@vger.kernel.org # v3.9+ --- driver

[PATCH 1/2] m88rs2000: add m88rs2000_set_carrieroffset

2013-12-24 Thread Malcolm Priestley
becomes a signed value. Register 0x86 is set the appropriate value according to remainder value of frequency % 192857 calculation as shown. Signed-off-by: Malcolm Priestley Cc: sta...@vger.kernel.org # v3.9+ --- drivers/media/dvb-frontends/m88rs2000.c | 77

[PATCH] it913x: Add support for Avermedia H335 id 0x0335

2013-12-12 Thread Malcolm Priestley
Signed-off-by: Malcolm Priestley Cc: sta...@vger.kernel.org # v3.11+ --- drivers/media/dvb-core/dvb-usb-ids.h | 1 + drivers/media/usb/dvb-usb-v2/it913x.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/drivers/media/dvb-core/dvb-usb-ids.h b/drivers/media/dvb-core/dvb-usb-ids.h index

Re: af9035 test needed!

2013-01-31 Thread Malcolm Priestley
hen possible. Once everything is stable enough the dvb-usb-it913x and it913x-fe modules can be removed. Acked-by: Malcolm Priestley Regards Malcolm -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] usb id addition for Terratec Cinergy T Stick Dual rev. 2

2013-01-07 Thread Malcolm Priestley
On Mon, 2013-01-07 at 21:37 +0200, Antti Palosaari wrote: > On 10/06/2012 06:40 PM, Mauro Carvalho Chehab wrote: > > Em Mon, 01 Oct 2012 14:21:34 +0300 > > Antti Palosaari escreveu: > > > >> On 10/01/2012 02:15 PM, Mauro Carvalho Chehab wrote: > >>> Em Sun, 30 Sep 2012 19:36:50 +0200 > >>> Damien

Re: [PATCH] ts2020: call get_rf_strength from frontend

2013-01-06 Thread Malcolm Priestley
On Sun, 2013-01-06 at 20:45 +0200, Antti Palosaari wrote: > On 01/06/2013 08:14 PM, Malcolm Priestley wrote: > > On Sun, 2013-01-06 at 15:37 +0200, Antti Palosaari wrote: > >> On 01/06/2013 02:40 PM, Malcolm Priestley wrote: > >>> Restore ds3000.c read_signal_st

Re: [PATCH] ts2020: call get_rf_strength from frontend

2013-01-06 Thread Malcolm Priestley
On Sun, 2013-01-06 at 15:37 +0200, Antti Palosaari wrote: > On 01/06/2013 02:40 PM, Malcolm Priestley wrote: > > Restore ds3000.c read_signal_strength. > > > > Call tuner get_rf_strength from frontend read_signal_strength. > > > > We are able to do a NULL

[PATCH] ts2020: call get_rf_strength from frontend

2013-01-06 Thread Malcolm Priestley
Restore ds3000.c read_signal_strength. Call tuner get_rf_strength from frontend read_signal_strength. We are able to do a NULL check and doesn't limit the tuner attach to the frontend attach area. At the moment the lmedm04 tuner attach is stuck in frontend attach area. Signed-off-by: Ma

[PATCH] ts2020.c: ts2020_set_params [BUG] point to fe->tuner_priv.

2013-01-03 Thread Malcolm Priestley
Fixes corruption of fe->demodulator_priv Signed-off-by: Malcolm Priestley --- drivers/media/dvb-frontends/ts2020.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/ts2020.c b/drivers/media/dvb-frontends/ts2020.c index 94e3fe2..f50e237 100

[PATCH] lmedm04: correct I2C values to 7 bit addressing.

2012-12-29 Thread Malcolm Priestley
6f487c2ee841f3df9709d1b4e4416a1b15: > > > > ts2020: separate from m88rs2000 (2012-12-24 01:26:12 +0300) > > > > > > Applied, thanks. Hi all, The separation the lmedm04 fails on the ts2020 portion because the correct I2C addressing. So, it's time to correct

Re: [PATCH RFC 08/11] it913x: remove unused define and increase module version

2012-12-10 Thread Malcolm Priestley
On Mon, 2012-12-10 at 02:45 +0200, Antti Palosaari wrote: > Cc: Malcolm Priestley > Signed-off-by: Antti Palosaari > --- Acked-by: Malcolm Priestley > drivers/media/usb/dvb-usb-v2/it913x.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers

[PATCH] it913x: [BUG] fix correct endpoint size when pid filter on.

2012-11-08 Thread Malcolm Priestley
On Thu, 2012-11-08 at 22:18 +0200, Antti Palosaari wrote: > On 11/08/2012 07:48 PM, Malcolm Priestley wrote: > > > > On 07/11/12 23:43, Antti Palosaari wrote: > >> Malcolm, > >> Have you newer tested it with USB1.1 port? Stream is totally broken. > >>

Re: it913x driver with USB1.1

2012-11-08 Thread Malcolm Priestley
On 07/11/12 23:43, Antti Palosaari wrote: > Malcolm, > Have you newer tested it with USB1.1 port? Stream is totally broken. > Hi Antti Hmm, yes it is a bit choppy on dvb-usb-v2. I will have a look at it. Regards Malcolm > regards > Antti > -- To unsubscribe from this list: send the line

[PATCH] add MAINTAINERS entry

2012-11-04 Thread Malcolm Priestley
Signed-off-by: Malcolm Priestley --- MAINTAINERS | 40 1 file changed, 40 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 28eeaec..ac738f5 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -4100,6 +4100,22 @@ S: Maintained F

[PATCH] it913x [BUG] Enable endpoint 3 on devices with HID interface.

2012-10-20 Thread Malcolm Priestley
On some USB controllers when endpoint 3 (used by HID) is not enabled this causes a USB reset. Signed-off-by: Malcolm Priestley --- drivers/media/usb/dvb-usb-v2/it913x.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/media/usb/dvb-usb-v2/it913x.c b

Re: [PATCH] usb id addition for Terratec Cinergy T Stick Dual rev. 2

2012-09-28 Thread Malcolm Priestley
On Fri, 2012-09-28 at 20:55 +0300, Antti Palosaari wrote: > On 09/28/2012 07:34 PM, Damien Bally wrote: > > > I will NACK that initially because that USB ID already used by AF9015 > >> driver. You have to explain / study what happens when AF9015 driver > >> claims that device same time. > >> > >

Re: ITE9135 on AMD SB700 - ehci_hcd bug

2012-09-13 Thread Malcolm Priestley
On Wed, 2012-09-12 at 08:32 +0200, Marx wrote: > Hello > I'm trying to use dual DVB-T tuner based on ITE9135 tuner. I use Debian > kernel 3.5-trunk-686-pae. My motherboard is AsRock E350M1 (no USB3 ports). > Tuner is detected ok, see log at the end of post. > > When I try to scan channels, bug ha

media_build duplicate module structures

2012-08-18 Thread Malcolm Priestley
Hi Updating older kernels with media_build does not remove the old file structure. Running /sbin/depmod will mean the new structure will have two modules of the same name causing module conflicts. The entire old structure needs to be removed first. rm -r /lib/modules/$(uname -r)/kernel/drivers/

[PATCH] it913x ver 1.32 driver moved to dvb-usb-v2

2012-08-13 Thread Malcolm Priestley
Functional changes PID filter is default to off and controlled from dvb-usb-v2 Driver now supports suspend and resume changes in dvb-usb-v2 USB bus repeater functions have been removed. Signed-off-by: Malcolm Priestley --- drivers/media/dvb/dvb-usb-v2/Kconfig |7 + drivers/media/dvb/dvb

[PATCH] re: [media] lmedm04: fix build

2012-08-13 Thread Malcolm Priestley
firmware() >error: usb_control_msg() 'data' too small (128 vs 265) > >737 data = kzalloc(128, GFP_KERNEL); >^^^ > data is 128 bytes. Hi All Control isn't used, so remove it. Signed-off-by: Malcolm Priestley --- drivers/med

Re: [PATCH] [BUG] Re: dvb_usb_lmedm04 crash Kernel (rs2000)

2012-08-06 Thread Malcolm Priestley
On Mon, 2012-08-06 at 21:46 +0300, Antti Palosaari wrote: > On 08/03/2012 02:31 AM, Malcolm Priestley wrote: > > On Thu, 2012-08-02 at 23:54 +0300, Antti Palosaari wrote: > >> Moi Malcolm, > >> Any idea why this seems to crash Kernel just when device is plugged? &g

[PATCH] lmedm04 2.06 conversion to dvb-usb-v2 version 2

2012-08-06 Thread Malcolm Priestley
Conversion of lmedm04 to dvb-usb-v2 Functional changes m88rs2000 tuner now uses all callbacks. TODO migrate other tuners to the callbacks. This patch is applied on top of [BUG] Re: dvb_usb_lmedm04 crash Kernel (rs2000) http://patchwork.linuxtv.org/patch/13584/ Signed-off-by: Malcolm Priestley

  1   2   3   >