Hi,
On 08/05/2014 06:31 PM, Zhaowei Yuan wrote:
> ctx->ctx should be released if the following allocation for ctx->shm
> gets failed.
>
> Signed-off-by: Zhaowei Yuan
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_opr_v5.c |1 +
> 1 file changed, 1 insertion(+)
> mode change 100644 => 10075
Hi,
On 08/01/2014 06:15 PM, panpan liu wrote:
> Because the api s5p_mfc_queue_setup has already realized the same function
>
> Signed-off-by: panpan liu
> ---
> drivers/media/platform/s5p-mfc/s5p_mfc_dec.c |9 +
> 1 file changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/driv
Hi Zhaowei,
On 07/23/2014 09:49 AM, Zhaowei Yuan wrote:
> Since we have get vdev by calling video_devdata() at the beginning of
> s5p_mfc_open(), we should just use vdev instead of calling video_devdata()
> again in the following code.
>
> Change-Id: I869051762d33b50a7c0dbc8149b072e70b89c6b9
Ple
Hi Tomasz,
On 04/15/2014 12:00 AM, Tomasz Stanislawski wrote:
This patch add proper compatibles for Mixer and HDMI chip
available on exynos4210 SoCs.
Signed-off-by: Tomasz Stanislawski
---
drivers/gpu/drm/exynos/exynos_hdmi.c |3 +++
drivers/gpu/drm/exynos/exynos_mixer.c |3 +++
2
There is no any reason to use comma here.
Signed-off-by: Joonyoung Shim
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c
b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index e2aac59
There is any reason to use comma here.
Signed-off-by: Joonyoung Shim
---
drivers/media/platform/s5p-mfc/s5p_mfc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c
b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index e2aac59
HVR-950q device, also DViCO FusionHDTV7 device can solve it as using low
i2c clock speed - 20KHz.
Signed-off-by: Joonyoung Shim
---
drivers/media/usb/au0828/au0828-cards.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/usb/au0828/au0828-cards.c
b/drivers/media
b/drivers/media/usb/au0828/au0828-cards.c
@@ -108,7 +108,7 @@ struct au0828_board au0828_boards[] = {
.name= "DViCO FusionHDTV USB",
.tuner_type = UNSET,
.tuner_addr = ADDR_UNSET,
-.i2c_clk_divider = AU0828_I2C_CLK_250KHZ,
+.i2c_clk_div
Hi,
Sorry for response about the past post.
The logic as written would *never* actually return an error condition, since
the loop would run until the counter hit zero but the check was for a value
less than zero.
Signed-off-by: Devin Heitmueller
---
drivers/media/common/tuners/xc5000.c |
On 02/28/2013 11:45 AM, Vikas Sajjan wrote:
Hi,
On 28 February 2013 08:07, Joonyoung Shim wrote:
On 02/27/2013 08:49 PM, Vikas Sajjan wrote:
Add support for parsing the display-timing node using video helper
function.
The DT node parsing and pinctrl selection is done only if 'dev.of
quot;samsung,exynos4-fimd",
+ { .compatible = "samsung,exynos4210-fimd",
.data = &exynos4_fimd_driver_data },
- { .compatible = "samsung,exynos5-fimd",
+ { .compatible = "samsung,exynos5250-fimd",
.data = &exynos5_fimd_driver
OF_USE_NATIVE_MODE);
+ if (ret) {
+ DRM_ERROR("failed: of_get_fb_videomode()\n"
+ "with return value: %d\n", ret);
Could you make this error log to one line?
except this,
Acked-by: Joonyoung Shim
+
Hi,
On 02/21/2013 04:18 PM, Joonyoung Shim wrote:
On 02/21/2013 04:12 PM, Vikas Sajjan wrote:
Hi,
On 21 February 2013 12:25, Joonyoung Shim
wrote:
Hi,
On 02/15/2013 03:43 PM, Vikas Sajjan wrote:
Add support for parsing the display-timing node using video helper
function.
The DT node
On 02/21/2013 04:12 PM, Vikas Sajjan wrote:
Hi,
On 21 February 2013 12:25, Joonyoung Shim wrote:
Hi,
On 02/15/2013 03:43 PM, Vikas Sajjan wrote:
Add support for parsing the display-timing node using video helper
function.
The DT node parsing and pinctrl selection is done only if
Hi,
On 02/21/2013 02:11 PM, Vikas Sajjan wrote:
Adds support for pinctrl to drm fimd.
Signed-off-by: Leela Krishna Amudala
Signed-off-by: Vikas Sajjan
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c |9 +
1 file changed, 9 insertions(+)
diff --git a/drivers/gpu/drm/exynos/exynos_
Hi,
Please refer my comments about v6 patch.
On 02/21/2013 02:11 PM, Vikas Sajjan wrote:
Add display-timing node parsing to drm fimd and depends on
the display helper patchset at
http://lists.freedesktop.org/archives/dri-devel/2013-January/033998.html
It also adds pinctrl support for drm fimd
Hi,
On 02/15/2013 03:43 PM, Vikas Sajjan wrote:
Add support for parsing the display-timing node using video helper
function.
The DT node parsing and pinctrl selection is done only if 'dev.of_node'
exists and the NON-DT logic is still maintained under the 'else' part.
Signed-off-by: Leela Krish
On 02/05/2013 12:03 PM, Inki Dae wrote:
> 2013/2/4 Sachin Kamat :
>> On 1 February 2013 18:28, Inki Dae wrote:
>>>
>>>
>>>
>>> 2013. 2. 1. 오후 8:52 Inki Dae 작성:
>>>
> -Original Message-
> From: linux-media-ow...@vger.kernel.org [mailto:linux-media-
> ow...@vger.kernel.org]
On 04/18/2012 07:17 AM, manjunatha_ha...@ti.com wrote:
From: Manjunatha Halli
Also this patch adds CID's for below new FM features,
1) FM RX - De-Emphasis filter mode and RDS AF switch
2) FM TX - RDS Alternate frequency set.
The subject of this patch is about FM RX, but it inc
strength value(unit: dbµV)
reading from hardware and some drivers transform the signal value to
above range from 0 to 65535.
I wonder which thing is proper way.
Thank.
--
- Joonyoung Shim
--
To unsubscribe from this list: send the line "unsubscribe linux-media" in
the body of a message
Signed-off-by: Joonyoung Shim
---
drivers/media/radio/si470x/radio-si470x-i2c.c | 32 +++--
drivers/media/radio/si470x/radio-si470x.h |1 -
2 files changed, 9 insertions(+), 24 deletions(-)
diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c
b/drivers/media
Signed-off-by: Joonyoung Shim
---
drivers/media/radio/si470x/radio-si470x-i2c.c | 16 +---
1 files changed, 9 insertions(+), 7 deletions(-)
diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c
b/drivers/media/radio/si470x/radio-si470x-i2c.c
index 81b0a1a..92ce10d 100644
Currently we use busy waiting to seek and tune, it can replace to
interrupt way. SI470X I2C driver supports interrupt way to week and tune
via this patch.
Signed-off-by: Joonyoung Shim
---
drivers/media/radio/si470x/radio-si470x-common.c | 60 +++---
drivers/media/radio/si470x
is is good catch.
Acked-by: Joonyoung Shim
Signed-off-by: Marek Szyprowski
Signed-off-by: Kyungmin Park
CC: Tobias Lorenz
CC: Joonyoung Shim
CC: Douglas Schilling Landgraf
CC: Jean Delvare
---
drivers/media/radio/si470x/radio-si470x-i2c.c |2 +-
1 files changed, 1 insertions(+), 1 dele
We should go to err_video instead of err_all if this error is occured
when probed.
Signed-off-by: Joonyoung Shim
---
drivers/media/radio/si470x/radio-si470x-i2c.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c
b/drivers
This patch set is to fix bug of si470x common part and i2c driver.
Thanks.
Joonyoung Shim (3):
radio-si470x: Fix setting of de-emphasis
radio-si470x: Remove ifdef for RDS
radio-si470x: Fix error handling of si470x i2c driver
drivers/media/radio/si470x/radio-si470x-common.c
The de-emphasis should be setted if requested by module parameter
instead of always setting de-emphasis.
Reported-by: Tobias Lorenz
Signed-off-by: Joonyoung Shim
---
drivers/media/radio/si470x/radio-si470x-common.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a
The si470x i2c and usb driver support the RDS, so this ifdef statement
doesn't need more.
Signed-off-by: Joonyoung Shim
---
drivers/media/radio/si470x/radio-si470x-common.c |6 --
1 files changed, 0 insertions(+), 6 deletions(-)
diff --git a/drivers/media/radio/si470x/radio-s
Hi, all.
I wonder about the usage of the signal variable of struct v4l2_tuner. I
have found only to use it to get the signal strength on drivers.
The si470x radio device can set the seek threshold value of
RSSI(Received Signal Strength Indicator) when the device scans the
channels, so if the curr
Hi, all.
I just wonder there is any radio application using the V4L2 on console.
I found only the Kradio app of KDE, but the KDE is difficult to use the
embedded system.
I am testing using my simple radio test application on console, but it
is also difficult to test correctly RDS - parsing proble
This patch is to support PM of the si470x i2c driver.
Signed-off-by: Joonyoung Shim
---
drivers/media/radio/si470x/radio-si470x-i2c.c | 40 +
1 files changed, 40 insertions(+), 0 deletions(-)
diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c
b/drivers/media
This patch is to support RDS on si470x i2c driver. The routine of RDS
operation is almost same with thing of usb driver, but this uses RDS
interrupt.
Signed-off-by: Joonyoung Shim
---
drivers/media/radio/si470x/radio-si470x-i2c.c | 164 +++--
drivers/media/radio/si470x
The read and poll file operations of the si470x usb driver can be used
also equally on the si470x i2c driver, so they go to the common file.
Signed-off-by: Joonyoung Shim
---
drivers/media/radio/si470x/radio-si470x-common.c | 98 ++
drivers/media/radio/si470x/radio-si470x
Hi,
I post patches v2 for radio-si470x-i2c driver.
[PATCH v2 1/3] radio-si470x: move some file operations to common file
[PATCH v2 2/3] radio-si470x: support RDS on si470x i2c driver
[PATCH v2 3/3] radio-si470x: support PM functions
1/3 patch is same with v1.
2/3 patch is updated the RDS interru
On 12/2/2009 9:12 AM, Tobias Lorenz wrote:
> Hi,
>
> ok, understood this problem.
> So, why not set this in si470x_fops_open directly after the si470x_start?
> It seems more appropriate to enable the RDS interrupt after starting the
> radio.
>
OK, it makes sense. I will move it in si470x_fops_o
gt; Bye,
> Toby
>
> Am Mittwoch 18 November 2009 07:21:25 schrieb Joonyoung Shim:
>> We should use the or operation to set value to the SYSCONFIG1 register
>> on si470x_start().
>>
>> Signed-off-by: Joonyoung Shim
>> ---
>> drivers/media/radio/si470x/radio
This patch is to support RDS on si470x i2c driver. The routine of RDS
operation is almost same with thing of usb driver, but this uses RDS
interrupt.
Signed-off-by: Joonyoung Shim
---
drivers/media/radio/si470x/radio-si470x-i2c.c | 159 +++--
drivers/media/radio/si470x
The read and poll file operations of the si470x usb driver can be used
also equally on the si470x i2c driver, so they go to the common file.
Signed-off-by: Joonyoung Shim
---
drivers/media/radio/si470x/radio-si470x-common.c | 98 ++
drivers/media/radio/si470x/radio-si470x
We should use the or operation to set value to the SYSCONFIG1 register
on si470x_start().
Signed-off-by: Joonyoung Shim
---
drivers/media/radio/si470x/radio-si470x-common.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/media/radio/si470x/radio-si470x-common.c
Hi,
On 7/30/2009 7:26 PM, Tobias Lorenz wrote:
> Hi,
>
>> I send the radio-si470x patches worked on http://linuxtv.org/hg/v4l-dvb.
>> The patches is updated to version 2.
>
> The patchset looks good. I'll give my feedback in the following mails.
>
>> Tobias informed me the base code for seperat
>> +
>> +int si470x_disconnect_check(struct si470x_device *radio)
>> +{
>> + return 0;
>> +}
>
> Looks like this function is empty and it's called few times. Is it
> good to make it inline?
>
Yes, this function is empty. It looks fine to me too.
I will modify it, thanks.
--
To unsubscrib
't support the RDS.
Signed-off-by: Joonyoung Shim
---
linux/drivers/media/radio/si470x/Kconfig | 13 +
linux/drivers/media/radio/si470x/Makefile |2 +
.../media/radio/si470x/radio-si470x-common.c |6 +
.../drivers/media/radio/si470x/radio-si470
The si470x_disconnect_check is function to check disconnect state of
radio in common file. The function is implemented in each interface
file.
Signed-off-by: Joonyoung Shim
---
.../media/radio/si470x/radio-si470x-common.c | 40 +--
.../drivers/media/radio/si470x/radio
This patch is for using dev_* macro instead of printk.
Signed-off-by: Joonyoung Shim
---
.../media/radio/si470x/radio-si470x-common.c | 50 +-
.../drivers/media/radio/si470x/radio-si470x-usb.c | 58 +---
2 files changed, 52 insertions(+), 56 deletions
Hi, all
I send the radio-si470x patches worked on http://linuxtv.org/hg/v4l-dvb.
The patches is updated to version 2.
I have a board with Silicon Labs si4709 chip using the i2c interface,
but the radio-si470x is only support usb interface currently. I posted
about separating usb and i2c interface
);
>> +}
>> +module_init(si470x_i2c_init);
>> +
>> +static void __exit si470x_i2c_exit(void)
>> +{
>> +i2c_del_driver(&si470x_i2c_driver);
>> +}
>> +module_exit(si470x_i2c_exit);
>> +
>> +MODULE_DESCRIPTION("i2c radio driver for si470x fm radio r
't support the RDS.
Signed-off-by: Joonyoung Shim
---
linux/drivers/media/radio/si470x/Kconfig | 13 +
linux/drivers/media/radio/si470x/Makefile |2 +
.../media/radio/si470x/radio-si470x-common.c | 24 ++
.../drivers/media/radio/si470x/radio-si470
Hi, all
I send the radio-si470x patches worked on http://linuxtv.org/hg/v4l-dvb.
I have a board with Silicon Labs si4709 chip using the i2c interface,
but the radio-si470x is only support usb interface currently. I posted
about separating usb and i2c interface in radio-si470x the past.
http://www
verified it at the si4709 device using i2c interface,
but there is not at your implementation.
I wonder above things, and i send you the patch to fix make warning and build
errors, and for easy work.
=====
Fix compile warning
On 4/13/2009 7:31 PM, Joonyoung Shim wrote:
>> I'm not sure about the consequences in case of renaming the radio-si470x
>> module. But it would be consequent to add the appendix -usb and -i2c to
>> the current name.
>>
>> I applied the patch as follows:
>
> I'm not sure about the consequences in case of renaming the radio-si470x
> module. But it would be consequent to add the appendix -usb and -i2c to
> the current name.
>
> I applied the patch as follows:
Okay, your patch is better.
Thanks.
I will post the i2c part soon after testing.
--
To unsu
On 4/13/2009 10:46 AM, Joonyoung Shim wrote:
> On 4/13/2009 5:56 AM, Tobias Lorenz wrote:
>> Hi Joonyoung,
>>
>> Hi Alexey,
>>
>> I've split the driver into a couple of segments:
>>
>> - radio-si470x-common.c is for common functions
>&g
On 4/13/2009 5:56 AM, Tobias Lorenz wrote:
> Hi Joonyoung,
>
> Hi Alexey,
>
> I've split the driver into a couple of segments:
>
> - radio-si470x-common.c is for common functions
>
> - radio-si470x-usb.c are the usb support functions
>
> - radio-si470x-i2c.c is an untested prototyped file for
e any success on this ?
Hi,
I have tried, but could not do it yet.
Like radio-tea5764.c, radio-si470x driver for I2C interface also was
implemented as the I2C driver, but it has many redundant functions with
the existing radio-si470x for USB interface, so I tried to join two
interfaces but it wa
usb
interface and could listen to FM radio station.
I think it can be to join two things together to one file because there isn't
the difference between the two except for the interface.
I am considering how to integrate them.
Please send your opinion.
--
- Joonyoung Shim
--
To unsubscribe
55 matches
Mail list logo
