Logitech C270 webcam floods the log

st plug my webcam before using it and unplug it as soon as I'm done, which isn't exactly convenient. Thanks, -- Jean Delvare SUSE L3 Support

Re: [PATCH] media: v4l: v4l2-controls.h must include types.h

On Mon, 2018-11-12 at 11:03 +0100, Paul Kocialkowski wrote: > On Mon, 2018-11-12 at 11:01 +0100, Jean Delvare wrote: > > Fix the following build-time warning: > > ./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type > > without #include > > We al

[PATCH] media: v4l: v4l2-controls.h must include types.h

Fix the following build-time warning: ./usr/include/linux/v4l2-controls.h:1105: found __[us]{8,16,32,64} type without #include Signed-off-by: Jean Delvare Fixes: c27bb30e7b6d ("media: v4l: Add definitions for MPEG-2 slice format and metadata") Cc: Paul Kocialkowski Cc: Mauro Carva

[PATCH] [media] cec: fix Kconfig help text

MEDIA_CEC is no longer a tristate option, so the user can't actually choose M. Whether the code is built-in or built as a module is decided somewhere else. Signed-off-by: Jean Delvare Fixes: 5bb2399a4fe4 ("[media] cec: fix Kconfig dependency problems") Cc: Hans Verkuil Cc: Ar

Re: [lm-sensors] MAINTAINERS/s5p: Kamil Debski no longer with Samsung?

hould be clarified soon > (I've added Kamil to Cc). Already clarified behind the scenes ;-) The patch should be discarded. Thanks, -- Jean Delvare SUSE L3 Support -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 21/66] rtl2830: implement own I2C locking

olve the deadlock due to the i2c bus topology and i2c-based muxing. If I am correct then it would be clearer to make that two separate patches with better descriptions. And if I'm wrong then the patch needs a better description too ;-) -- Jean Delvare SUSE L3 Support -- To unsubscribe from

[PATCH] [media] V4L2: soc_camera: Add run-time dependencies to sh_mobile drivers

The sh_mobile_ceu_camera and sh_mobile_csi2 drivers are only useful on SuperH and shmobile unless build testing. Signed-off-by: Jean Delvare Cc: Guennadi Liakhovetski Cc: Mauro Carvalho Chehab --- drivers/media/platform/soc_camera/Kconfig |2 ++ 1 file changed, 2 insertions(+) --- linux

[PATCH] [media] V4L2: soc_camera: add run-time dependencies to R-Car VIN driver

The R-Car Video Input driver is only useful on shmobile unless build testing. Signed-off-by: Jean Delvare Cc: Vladimir Barinov Cc: Sergei Shtylyov Cc: Guennadi Liakhovetski Cc: Mauro Carvalho Chehab --- drivers/media/platform/soc_camera/Kconfig |1 + 1 file changed, 1 insertion

[PATCH] [media] Prefer gspca_sonixb over sn9c102 for all devices

gspca_sonixb driver now, so that it gets sufficient testing before the sn9c102 driver is finally phased out. Signed-off-by: Jean Delvare Cc: Hans de Goede Cc: Mauro Carvalho Chehab Cc: Luca Risolia Cc: Greg Kroah-Hartman --- I consider this a bug fix, I believe it should go upstream ASAP

[PATCH] [media] platform: Fix timberdale dependencies

"|| HAS_IOMEM" to the TIMB_DMA dependencies silenced the kconfig warning about unmet direct dependencies but it was wrong: without MFD_TIMBERDALE, TIMB_DMA is useless as the driver has no device to bind to. Signed-off-by: Jean Delvare Cc: Vinod Koul Cc: Dan Williams Cc: Mauro Carvalho Chehab --

Re: [PATCH 2/3] femon: Display SNR in dB

Hi Manu, On Sun, 24 Nov 2013 22:51:33 +0530, Manu Abraham wrote: > Sorry, that I came upon this patch quite late. No problem, better late than never! :) > On Mon, Jun 3, 2013 at 8:51 PM, Jean Delvare wrote: > > SNR is supposed to be reported by the frontend drivers in dB, so print

Re: [PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

ed to read > chip ID in order to detect => i2c_new_probed_device() is quite useless. Please remember you can pass a custom probe function to i2c_new_probed_device(). That probe function can read whatever chip ID register exists to decide if the probe should be successful or not. --

Re: [PATCH REVIEW] e4000: convert DVB tuner to I2C driver model

t; perform an attach without probe? Oh, i2c_new_probed_device() probes the device, what a surprise! :D Try, I don't know, i2c_new_device() maybe if you don't want the probe? ;) -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body o

Re: cannot ret error from probe - switch tuner to I2C driver model

Hi Antti, The driver's .probe() after i2c_new_device() is simply not supposed to fail. You should only use i2c_new_device() if you are 100% sure that there is a device of the given type at the given address. Checking i2c_get_clientdata() is an ugly trick that you should no longer need to use. i2c

cx23885_wakeup: 3 buffers handled (should be 1)

debugging or experimentation. Thanks, -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 3/3] femon: Handle -EOPNOTSUPP

else + printf ("snr | "); + if (got_info & DVBFE_INFO_BER) + printf ("ber %08x | ", fe_info.ber); + else + printf ("ber | "); + if (got_info & DVBFE_INFO_UNCORRECTED_BLOCKS) + printf ("unc %08x | ", fe_info.ucblocks); + else + printf ("unc | "); } if (fe_info.lock) -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/3] femon: Display SNR in dB

fe_info.ucblocks); } else { printf ("signal %04x | snr %04x | ber %08x | unc %08x | ", fe_info.signal_strength, -- Jean Delvare -- To unsubscribe from this list: send the li

[PATCH 1/3] femon: Share common code

;C' : ' ', - fe_info.viterbi ? 'V' : ' ', - fe_info.sync ? 'Y' : ' ', - fe_info.lock ? 'L' : ' ', + printf ("signal %04x | snr %04x | ber %08x | unc %08x | ",

[PATCH 0/3] dvb-apps: Improve femon

Improvements to dvb-apps/femon: * femon: Share common code * femon: Display SNR in dB * femon: Handle -EOPNOTSUPP -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo inf

[PATCH] [media] sony-btf-mpx: Drop needless newline in param description

Module parameter descriptions need not be terminated with a newline. Signed-off-by: Jean Delvare Cc: Hans Verkuil Cc: Mauro Carvalho Chehab --- drivers/media/i2c/sony-btf-mpx.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-3.10-rc1.orig/drivers/media/i2c/sony-btf-mpx.c

[PATCH v2] [media] m920x: Fix uninitialized variable warning

t success or failure randomly. OTOH the initialization of ret in m920x_init is needless, the function returns with an error as soon as an error happens, so the last return can only be a success and we can hard-code 0 there. Signed-off-by: Jean Delvare Cc: Mauro Carvalho Chehab Cc: Antonio Ospite --

[media] m920x: Fix uninitialized variable warning

t success or failure randomly. OTOH the initialization of ret in m920x_init is needless, the function returns with an error as soon as an error happens, so the last return can only be a success and we can hard-code 0 there. Signed-off-by: Jean Delvare Cc: Mauro Carvalho Chehab Cc: Antonio Ospite --- Un

[media] drxk_hard: Drop unused parameter

Last parameter of function GetLockStatus() isn't used so drop it. Signed-off-by: Jean Delvare Cc: Mauro Carvalho Chehab --- drivers/media/dvb-frontends/drxk_hard.c |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) --- linux-3.8.orig/drivers/media/dvb-frontends/drxk_h

Re: TerraTec Cinergy T PCIe Dual not working

Hi Oliver, On Wed, 06 Mar 2013 19:07:01 +0100, Oliver Schinagl wrote: > On 03/06/13 16:03, Jean Delvare wrote: > > It turns out that my problem is the antenna. I was using the antenna I > > have been using with my previous card, which is an internal DVB-T > > antenna with am

drxk driver statistics

. I would like to see these statistics improved. I am willing to help, however the drxk driver is rather complex (at least to my eyes) and I do not have a datasheet so I wouldn't know where to start. Is there anyone who can work on this and/or provide some guidance? Thanks, -- Jean Delvare

Re: TerraTec Cinergy T PCIe Dual not working

, powered antenna causes that kind of issue? Oliver, out of curiosity, what antenna are you using? The Terratec-provided one, or another one? -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

TerraTec Cinergy T PCIe Dual not working

I tried with kernels 3.4.30, 3.5.7, 3.6.0, 3.6.11, 3.7.10 and 3.8.2, with exactly the same results. How would I debug this further? Thanks, -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 13/13] drivers/media/tuners/e4000.c: use macros for i2c_msg initialization

> message or buffer arrays that contain only one element. Please note that I resigned from my position of i2c subsystem maintainer, so I will not handle this. If you think this is important, you'll have to resubmit and Wolfram will decide what he wants to do about it. -- Jean Delvare --

Re: [PATCH 0/11] introduce macros for i2c_msg initialization

er to use isn't at the top of my priority list. And I see the extra work for the pre-processor, so we need a good reason for doing that. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org

Re: [PATCH 2/13] drivers/media/tuners/mxl5007t.c: use macros for i2c_msg initialization

ove. I am not opposed to the idea of i2c_msg initialization helper macros, but please don't mix that with actual code changes which could have bad side effects. Thanks, -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a m

Re: [PATCH 3/13] drivers/media/tuners/qt1010.c: use macros for i2c_msg initialization

y for not having seen that. I can do that. Eek, no, you can't, not in the general case at least. sizeof(*val) will return the size of the _first_ element of the destination buffer, which has nothing to do with the length of that buffer (which in turn might be rightfully longer than the read lengt

Re: [PATCH 9/13] drivers/media/tuners/fc0011.c: use macros for i2c_msg initialization

self won't care, it just passes the request down to the underlying i2c bus driver. Most driver implementations will assume proper buffer addresses as soon as size > 0, so passing NULL instead would crash them. In short, don't do that. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] [media] mceusb: Optimize DIV_ROUND_CLOSEST call

Hi Mauro, On Tue, 18 Sep 2012 12:49:53 -0300, Mauro Carvalho Chehab wrote: > Em 01-09-2012 15:53, Jean Delvare escreveu: > > DIV_ROUND_CLOSEST is faster if the compiler knows it will only be > > dealing with unsigned dividends. > > > > Signed-off-by: Jean Delvare &g

[PATCH] [media] cx23885: Select drivers for Terratec Cinergy T PCIe Dual

The Terratec Cinergy T PCIe Dual is based on the CX23885, and uses MT2063, DRX-3913k and DRX-3916k chips, so select the relevant drivers. Signed-off-by: Jean Delvare Cc: Stefan Ringel Cc: Mauro Carvalho Chehab --- drivers/media/video/cx23885/Kconfig |2 ++ 1 file changed, 2 insertions

[PATCH] [media] mceusb: Optimize DIV_ROUND_CLOSEST call

DIV_ROUND_CLOSEST is faster if the compiler knows it will only be dealing with unsigned dividends. Signed-off-by: Jean Delvare Cc: Andrew Morton Cc: Guenter Roeck Cc: Mauro Carvalho Chehab --- drivers/media/rc/mceusb.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-3.6

[PATCH] i2c: Export an unlocked flavor of i2c_transfer

messages are logged. We don't want to log messages while holding a rt_mutex. * No check is done on the existence of adap->algo->master_xfer. It is thus the caller's responsibility to ensure that the function is OK to call. Signed-off-by: Jean Delvare Cc: Mauro Carvalho Chehab

Re: [PATCH] [media] drxk: change it to use request_firmware_nowait()

and unlocking are taking place inside i2c_transfer(), not at its boundaries. I'm looking into this now. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] [media] dib0700: Drop useless check when remote key is pressed

Hi Mauro, On Tue, 20 Mar 2012 09:17:54 -0300, Mauro Carvalho Chehab wrote: > Em 20-03-2012 04:20, Jean Delvare escreveu: > > On Mon, 19 Mar 2012 19:26:11 -0300, Mauro Carvalho Chehab wrote: > >> Yet, I'd be more happy if Jean's patch could check first if the status

Re: [PATCH 1/2] [media] dib0700: Drop useless check when remote key is pressed

Hi Mauro, On Mon, 19 Mar 2012 19:26:11 -0300, Mauro Carvalho Chehab wrote: > On Tue, Mar 13, 2012 at 1:50 PM, Jean Delvare wrote: > > --- linux-3.3-rc7.orig/drivers/media/dvb/dvb-usb/dib0700_core.c > > 2012-03-13 11:09:13.0 +0100 > > +++ linux-3.3-rc7/driv

[PATCH 2/2 v2] [media] dib0700: Fix memory leak during initialization

Reported by kmemleak. Signed-off-by: Jean Delvare Cc: Mauro Carvalho Chehab Cc: Devin Heitmueller --- Changes since v1: * Don't free the URB when it is still in use. * Fix a second leak (transfer_buffer). drivers/media/dvb/dvb-usb/dib0700_core.c |7 ++- 1 file changed, 6 inser

[PATCH 1/2] [media] dib0700: Drop useless check when remote key is pressed

L or the driver would crash right away. Signed-off-by: Jean Delvare Cc: Mauro Carvalho Chehab Cc: Devin Heitmueller --- Devin, am I missing something? drivers/media/dvb/dvb-usb/dib0700_core.c |3 --- 1 file changed, 3 deletions(-) --- linux-3.3-rc7.orig/drivers/media/dvb/dvb-usb/dib0700_co

Re: [PATCH] [media] dib0700: Fix memory leak during initialization

On Mon, 12 Mar 2012 07:28:02 -0300, Mauro Carvalho Chehab wrote: > Em 12-03-2012 07:04, Jean Delvare escreveu: > > "!d" can't actually happen, so it doesn't matter. d is passed by > > dib0700_rc_setup() when calling usb_fill_bulk_urb(), and > > dib0700_rc_s

Re: [PATCH] [media] dib0700: Fix memory leak during initialization

Hi Mauro, Thanks for your reply. On Thu, 08 Mar 2012 08:21:20 -0300, Mauro Carvalho Chehab wrote: > Em 12-02-2012 08:19, Jean Delvare escreveu: > > Reported by kmemleak. > > > > Signed-off-by: Jean Delvare > > Cc: Mauro Carvalho Chehab > > Cc: Devin Heitmuell

[PATCH] cx22702: Fix signal strength

. In practice I get 67% with my antenna fully amplified and 51% with no amplification. This is close enough to what I get on my other DVB-T adapter with the same antenna. Signed-off-by: Jean Delvare Cc: Steven Toth --- This was written without a datasheet so this is essentially guess work. dr

[PATCH] [media] dib0700: Fix memory leak during initialization

Reported by kmemleak. Signed-off-by: Jean Delvare Cc: Mauro Carvalho Chehab Cc: Devin Heitmueller --- I am not familiar with the usb API, are we also supposed to call usb_kill_urb() in the error case maybe? drivers/media/dvb/dvb-usb/dib0700_core.c |2 ++ 1 file changed, 2 insertions

PCTV teleScope: good or not?

at the device is supported since kernel 2.6.26, which looks promising. However, before I actually buy it, I would love to hear from someone actually using this device under Linux. Anyone? Is there anything to worry about, or can I just buy it? Thanks, -- Jean Delvare -- To unsubscribe from this l

Re: [RFC 1/2] dvb-core: add generic helper function for I2C register

Hi Antti, As an additional note, it just occurred to me that what you are working on is somewhat related to Mark Brown's regmap. Look in drivers/base/regmap and see if maybe you can reuse and/or extend Mark's approach. -- Jean Delvare -- To unsubscribe from this list: send the line &q

Re: [RFC 1/2] dvb-core: add generic helper function for I2C register

On Wed, 09 Nov 2011 10:02:08 -0200, Mauro Carvalho Chehab wrote: > Em 09-11-2011 08:37, Jean Delvare escreveu: > > Speaking of struct i2c_client, I seem to remember that the dvb > > subsystem doesn't use it much at the moment. This might be an issue if > > you intend to

Re: [RFC 2/2] tda18218: use generic dvb_wr_regs()

ystems need something similar then we can consider moving the code to i2c-core or some generic i2c helper module. If you count on me to drive it, I am afraid it will take months, given my current workload and various tasks with a much higher priority than this. I will however be happy to help with

[PATCH] [media] video: Drop undue references to i2c-algo-bit

" from all drivers, to avoid any confusion. This is the best way to ensure that the comments won't go out of sync again. Anyone interested in the implementation details would rather look at the code itself. Signed-off-by: Jean Delvare --- drivers/media/video/au0828/au0828-i2c.c |

Re: [RFC 1/2] dvb-core: add generic helper function for I2C register

plitting block reads in continuous chunks won't always work either. Which makes some sense if you think about it: if both the slave and the controller supported larger blocks then there would be no need to split the transfer into multiple messages in the first place. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [RFC 1/2] dvb-core: add generic helper function for I2C register

i's proposal share the idea of storing information about the device capabilities (max block read and write lengths, but we could also put there alignment requirements or support for repeated start condition.) in a private structure. If we generalize the functions then this information would have t

[PATCH] [media] usbvision: Drop broken 10-bit I2C address support

e, decoder or the like. So let's simply get rid of the broken and useless code. I'm also adding I2C_FUNC_I2C, as the driver and hardware support plain I2C messaging. [1] http://marc.info/?l=linux-i2c&m=117499415208244&w=2 Signed-off-by: Jean Delvare --- drivers/media/video/usbv

Re: [PATCH] v4l: mt9p031/mt9t001: Use i2c_smbus_{read|write}_word_swapped()

art As far as I can tell, this fixes a bug too, the original code would not work on big-endian machines. Acked-by: Jean Delvare > --- > drivers/media/video/mt9p031.c |5 ++--- > drivers/media/video/mt9t001.c |5 ++--- > 2 files changed, 4 insertions(+), 6 deletions(-) >

Re: [PATCH] v4l: use i2c_smbus_read_word_swapped

i2c_smbus_read_word_data(client, reg); > - return data < 0 ? data : swab16(data); > + return i2c_smbus_read_word_swapped(client, reg); > + Stray blank line. > } > (...) Other than this, looks all OK: Acked-by: Jean Delvare Obviously depends on the i2c patch, which will go upstr

Re: [PATCH 1/2] misc: remove CONFIG_MISC_DEVICES

On Mon, 5 Sep 2011 16:19:35 +0200, Arnd Bergmann wrote: > On Monday 05 September 2011, Jean Delvare wrote: > > As said before, I'm not sure. Yes, it makes it easier to select misc > > device drivers from Kconfig files. But it also makes it impossible to > > deselect all m

Re: [PATCH 2/2] mfd: remove CONFIG_MFD_SUPPORT

; config MFD_CORE > tristate I think I prefer Luciano's proposal, for the same reasons given for the misc device drivers patch. But here again I'm not the one making the decision, so it's up to Samuel to decide which patch he wants to apply. -- Jean Delvare -- To un

Re: [PATCH 1/2] misc: remove CONFIG_MISC_DEVICES

es Digital Potentiometers" > @@ -344,6 +328,12 @@ config ISL29020 > This driver can also be built as a module. If so, the module > will be called isl29020. > > +config SENSORS_LIS3LV02D > + tristate > + depends on INPUT > + select INPUT_POLLDEV >

Re: [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE

FD_SUPPORT is not. -- Luca] > > > > Signed-off-by: Randy Dunlap > > Reported-by: Johannes Berg > > Cc: Jean Delvare > > Cc: Tony Lindgren > > Cc: Grant Likely > > Signed-off-by: Luciano Coelho > > --- > > > > I guess this should

Re: [PATCH] mfd: Combine MFD_SUPPORT and MFD_CORE

support for SCI-based features of the OLPC XO-1 laptop: - EC-driven system wakeups > > Signed-off-by: Randy Dunlap > Reported-by: Johannes Berg > Cc: Jean Delvare > Cc: Tony Lindgren > Cc: Grant Likely > Signed-off-by: Luciano Coelho > --- > > I guess t

Re: [PATCH 3/4] drivers/media/video/hexium_gemini.c: delete useless initialization

> + struct hexium *hexium; > int ret; > > DEB_EE((".\n")); > Looks correct. Acked-by: Jean Delvare -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [lm-sensors] [PATCH 01/34] System Firmware Interface

nce. I would guess that you know what backend is present on a system when you try to identify it. At this point, I see the work needed to review your patches, the risk of regressions due to the large size of the patch set, but I don't see any immediate benefit. Thus I am not going to look into it at

Re: [PATCH] [media] tea5764: Fix module parameter permissions

Hi Andy, On Friday 08 July 2011 12:34:38 pm Andy Walls wrote: > Jean Delvare wrote: > >The third parameter of module_param is supposed to represent sysfs > >file permissions. A value of "1" leads to the following: > > > >$ ls -l /sys/module/radio_tea5764/p

[PATCH] [media] tea5764: Fix module parameter permissions

module parameters in this driver. Signed-off-by: Jean Delvare Cc: Mauro Carvalho Chehab Cc: Fabio Belavenuto --- drivers/media/radio/radio-tea5764.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-3.0-rc6.orig/drivers/media/radio/radio-tea5764.c 2011-05-20 10:4

Re: CX24116 i2c patch

Hi Mauro, Sorry for the late reply. On Thu, 05 May 2011 13:18:04 -0300, Mauro Carvalho Chehab wrote: > Em 05-05-2011 12:09, Jean Delvare escreveu: > > Hi Mauro, Steven, > > > > On Thu, 05 May 2011 10:15:04 -0300, Mauro Carvalho Chehab wrote: > >> As you pointed,

Re: CX24116 i2c patch

= i2c_addr; > for (i = 0; i < 2048; i++) { > if (i) > msg.flags = I2C_M_NOSTART; > msg.buf = &fw_buf[i * 16]; > ret = i2c_transfer(props->adap, &msg, 2048); > } > unlock_i2c_transactio

[PATCH] zoran: Drop unused module parameters encoder and decoder

The ability to force the encoder or decoder chip was broken by commit 0ab6e1c38d80ab586e3a1ca9e71844131d9f51dc in February 2009. As nobody complained for over 2 years, I take it that these parameters were no longer used so we can simply drop them. Signed-off-by: Jean Delvare Cc: Hans Verkuil

Re: [GIT FIXES for 2.6.38] Fix cx23885 and cx25840 regressions

x25840: fix probing of cx2583x chips > > drivers/media/video/cx23885/cx23885-i2c.c | 10 -- > drivers/media/video/cx25840/cx25840-core.c |3 ++- > 2 files changed, 2 insertions(+), 11 deletions(-) -- Jean Delvare -- To unsubscribe from this list: send the line &quo

Re: [corrected get-bisect results]: DViCO FusionHDTV7 Dual Express I2C write failed

commit > commit 44835f197bf1e3f57464f23dfb239fef06cf89be > Author: Jean Delvare > Date: Sun Jul 18 16:52:05 2010 -0300 > > V4L/DVB: cx23885: Check for slave nack on all transactions > > Don't just check for nacks on zero-length transactions. Check on > other transactions t

Re: [GIT PATCHES for 2.6.38] Zilog Z8 IR unit fixes

On Wed, 19 Jan 2011 12:12:49 -0500, Jarod Wilson wrote: > On Jan 19, 2011, at 8:50 AM, Jean Delvare wrote: > > > Hi Andy, > > > > On Wed, 19 Jan 2011 08:38:02 -0500, Andy Walls wrote: > >> As I understand it, the rules/guidelines for I2C probing are now >

Re: [GIT PATCHES for 2.6.38] Zilog Z8 IR unit fixes

On Wed, 19 Jan 2011 09:09:47 -0600 (CST), Mike Isely wrote: > On Wed, 19 Jan 2011, Jean Delvare wrote: > > > Hi Andy, > > > > On Sun, 16 Jan 2011 14:20:49 -0500, Andy Walls wrote: > > > 3. I hear from Jean, or whomever really cares about ir-kbd-i2c, if > &

Re: [GIT PATCHES for 2.6.38] Zilog Z8 IR unit fixes

quot; and "transceiver_lock". These seem too TX-oriented for a mutex that is supposed to synchronize TX and RX access. It's particularly surprising for the ir-kbd-i2c driver, which as far as I know only supports RX. The name "xcvr_lock" you used for lirc_zilog seems more app

Re: [GIT PATCHES for 2.6.38] Zilog Z8 IR unit fixes

t; probe or provide a custom hardware probe method to the I2C subsystem. > hdpvr and pvrusb2 currently do the former. Yes, that's exactly how things are supposed to work now. And hopefully it makes sense and helps you all write cleaner code (that was the intent at least.) -- Jean Delvare -- To u

Re: [GIT PATCHES for 2.6.38] Zilog Z8 IR unit fixes

be used for probing purpose. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] hdpvr: reduce latency of i2c read/write w/recycled buffer

of IR receive with hdpvr hardware. > > v2: make sure (len <= (dev->i2c_buf)) [Jean Delvare] > > Reported-by: Jean Delvare > Signed-off-by: Jarod Wilson Acked-by: Jean Delvare -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media&quo

Re: [PATCH] hdpvr: reduce latency of i2c read/write w/recycled buffer

his might also remedy user reports of very sluggish behavior > of IR receive with hdpvr hardware. Maybe. But the fact that the Zilog is unresponsive during processing of sent data certainly contributes to this feeling too. > > Reported-by: Jean Delvare > Signed-off-by: Jarod Wilson

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

On Thu, 13 Jan 2011 12:07:34 -0500, Devin Heitmueller wrote: > On Thu, Jan 13, 2011 at 11:48 AM, Jean Delvare wrote: > > On Thu, 13 Jan 2011 11:34:42 -0500, Andy Walls wrote: > >> How should clock stretches by slaves be handled using i2c-algo-bit? > > > > It is

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

support clock stretching by slaves. Apparently it doesn't support repeated start conditions either, so it wouldn't surprise me. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordom

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

On Wed, 05 Jan 2011 20:02:41 -0200, Mauro Carvalho Chehab wrote: > Em 05-01-2011 19:51, Jean Delvare escreveu: > > If you have specific cases you don't know how to solve, please point me > > to them and I'll take a look. > > You can take a look at saa7134-cards.c, f

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

lirc_zilog.c:send_code() makes a lot of sense, and I wouldn't skip it: if the device is busy, you don't want to return immediately, otherwise a subsequent request will fail. The failure documented for the HD PVR simply suggests that the wait loop isn't long enough. It is 20 * 50 ms currently

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

he function which needs it, or kept for the lifetime of the driver, as you prefer. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: soc_camera Client Driver with Multiple I2C Addresses

function using i2c_new_dummy(). See drivers/misc/eeprom/at24.c for an example of how this is done. I'm not sure I understand the problem at hand exactly though, so my advice might be inappropriate. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

an't, it's fine. I merely wanted to show my support to Andy's work, I don't care if I'm not counted as a reviewer for these small patches. > Em 05-01-2011 12:45, Jean Delvare escreveu: > > From a purely technical perspective, changing client->addr in the > >

Re: [PATCH 3/3] lirc_zilog: Remove use of deprecated struct i2c_adapter.id field

hat nobody uses the adapter in-between. Assuming that the Z8 understands the repeated-start I2C condition, this should hopefully let you get rid of IR.ir_lock and solve the driver design issue. > + /* >* The external IR receiver is at i2c address 0x71. >* The IR transmitt

Re: [PATCH 2/3] ir-kbd-i2c: Add HD PVR IR Rx support to ir-kbd-i2c

> /* IR device specific entries should be added here */ > { "ir_rx_z8f0811_haup", 0 }, > + { "ir_rx_z8f0811_hdpvr", 0 }, > { } > }; > Acked-by: Jean Delvare -- Jean Delvare -- To unsubscribe from this list: send the line "unsubs

Re: [PATCH 1/3] hdpvr: Add I2C and ir-kdb-i2c registration of the Zilog Z8 IR chip

good to me (even though it looks strange to update code which is apparently disabled for quite a while...) Acked-by: Jean Delvare -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More

Re: [PATCH] media: video: do not clear 'driver' from an i2c_client

Hi Wolfram, Sorry for the late answer. On Mon, 15 Nov 2010 23:28:15 +0100, Wolfram Sang wrote: > On Wed, Nov 10, 2010 at 03:14:13PM +0100, Wolfram Sang wrote: > > The i2c-core does this already. > > > > Reported-by: Jean Delvare > > Signed-off-by: Wolfram Sang &

Re: [PATCH 2/3] i2c: Drivers shouldn't include

On Sat, 13 Nov 2010 12:34:23 -0200, Mauro Carvalho Chehab wrote: > Em 05-11-2010 18:07, Jean Delvare escreveu: > > Drivers don't need to include , especially not when > > they don't use anything that header file provides. > > > > Signed-off-by: Jean Delvare

Re: [PATCH] i2c: Remove obsolete cleanup for clientdata

LL; This statement seems equally unneeded, maybe you could remove it too? Unless you want to provide a separate patch for this, as there are 5 other drivers doing the same. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH 2/2] TM6000: Drop unused macro

Signed-off-by: Jean Delvare Cc: Michel Ludwig Cc: Stefan Ringel --- drivers/staging/tm6000/tm6000-i2c.c | 12 1 file changed, 12 deletions(-) --- linux-2.6.36-rc7.orig/drivers/staging/tm6000/tm6000-i2c.c 2010-10-13 10:30:09.0 +0200 +++ linux-2.6.36-rc7/drivers

[PATCH 1/2] TM6000: Clean-up i2c initialization

) and properly return error on adapter registration failure. Signed-off-by: Jean Delvare Cc: Michel Ludwig Cc: Stefan Ringel --- Untested, I don't have the hardware. drivers/staging/tm6000/tm6000-i2c.c | 27 ++- 1 file changed, 10 insertions(+), 17 dele

[PATCH 3/3] i2c: Mark i2c_adapter.id as deprecated

It's about time to make it clear that i2c_adapter.id is deprecated. Hopefully this will remind the last user to move over to a different strategy. Signed-off-by: Jean Delvare Cc: Hans Verkuil Cc: Jarod Wilson --- drivers/i2c/i2c-mux.c |1 - include/linux/i2c.h |2 +- 2 files ch

[PATCH 2/3] i2c: Drivers shouldn't include

Drivers don't need to include , especially not when they don't use anything that header file provides. Signed-off-by: Jean Delvare Cc: Michael Hunold Cc: Mauro Carvalho Chehab --- drivers/media/common/saa7146_i2c.c|1 - drivers/media/video/ir-kbd-i2c.c |1 - drive

[PATCH 1/3] i2c: Delete unused adapter IDs

code in question never runs. As the code additionally expects that I2C_HW_B_HDPVR may not be defined, we can delete it now and let the lirc_zilog driver maintainer rewrite this piece of code. Big thanks for Hans Verkuil for doing all the hard work :) Signed-off-by: Jean Delvare Cc: Hans

Re: REGRESSION: Re: [GIT] kconfig rc fixes

cial complexity that will make Kconfig almost > unreadable. > > I still think that the easiest way to solve this is to add some logic that > will > hide the menu if a condition doesn't happen. Something like: > menu FOO > prompt if BAR > > or >

[PATCH] V4L/DVB: dibx000_common: Restore i2c algo pointer

Commit a90f933507859941c4a58028d7593a80f57895c4 accidentally removed the piece of code setting the i2c algo pointer. Restore it. That's what happens when you put two code statements on the same line... Signed-off-by: Jean Delvare Cc: Mauro Carvalho Chehab --- Sorry about this, I didn

[PATCH 2/2] i2c: Stop using I2C_CLASS_TV_DIGITAL

Detection class I2C_CLASS_TV_DIGITAL is set by many adapters but no I2C device driver is setting it anymore, which means it can be dropped. I2C devices on digital TV adapters are instantiated explicitly these days, which is much better. Signed-off-by: Jean Delvare --- drivers/media/dvb/b2c2

[PATCH 1/2] i2c: Stop using I2C_CLASS_TV_ANALOG

Detection class I2C_CLASS_TV_ANALOG is set by a few adapters but no I2C device driver is setting it anymore, which means it can be dropped. I2C devices on analog TV adapters are instantiated explicitly these days, which is much better. Signed-off-by: Jean Delvare --- drivers/media/dvb/ngene

Re: [PATCH] V4L/DVB: dib0700: Prevent NULL pointer dereference during probe

On Sun, 26 Sep 2010 16:25:53 +0200, Jean Delvare wrote: > Commit 8dc09004978538d211ccc36b5046919489e30a55 assumes that > dev->rc_input_dev is always set. It is, however, NULL if dvb-usb was > loaded with option disable_rc_polling=1. > > Signed-off-by: Jean Delvare > Cc:

Re: [PATCH 00/16] Use modaliases to load I2C modules - please review

by blacklisting. This is one more good reason to use module aliases where possible, BTW... Respecting user-defined blacklisting is desirable. -- Jean Delvare -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kern

  1   2   3   4   >