Convert the driver to use regulator framework instead of set_power callback.
This with gpio_reset platform data provide cleaner way to manage chip VIO,
VDD and reset signal inside the driver.
Signed-off-by: Jarkko Nikula
Cc: Eduardo Valentin
---
v3:
include/media/si4713.h change was
On Fri, 29 Oct 2010 11:54:34 -0200
Mauro Carvalho Chehab wrote:
> I had to remove it from my queue, as the patch broke compilation:
>
>
> http://git.linuxtv.org/media_tree.git?a=commit;h=350df81ebaccc651fa4dfad27738db958e067ded
>
> What's the sense of adding a patch that breaks a driver?
upport
> Author: Jarkko Nikula
> Date:Tue Sep 21 05:49:43 2010 -0300
>
> Convert the driver to use regulator framework instead of set_power callback.
> This with gpio_reset platform data provide cleaner way to manage chip VIO,
> VDD and reset signal inside the driver.
>
Convert the driver to use regulator framework instead of set_power callback.
This with gpio_reset platform data provide cleaner way to manage chip VIO,
VDD and reset signal inside the driver.
Signed-off-by: Jarkko Nikula
Cc: Eduardo Valentin
---
v2:
I moved all the regulator management to i2c
Call to i2c_put_adapter was missing in radio_si4713_pdriver_probe and
radio_si4713_pdriver_remove.
Signed-off-by: Jarkko Nikula
Acked-by: Eduardo Valentin
---
No changes, Eduardo's ack added.
---
drivers/media/radio/radio-si4713.c | 10 --
1 files changed, 8 insertions(
Hi
Repost of these two patches. I added Eduardo's ack to 1st and moved regulator
management in 2nd to single place only as suggested by Eduardo.
My first version was separating them to radio-si4713.c and si4713-i2c.c and
indeed then there is a risk that vio is missed if si4713-i2c.c is reused in
On Wed, 8 Sep 2010 15:11:36 +0300
Eduardo Valentin wrote:
> The background here you are probably missing is that the split between
> i2c and platform drivers. That has been done because we were thinking also
> in the situation where the si4713 i2c driver could be used without the
> platform drive
Hi
On Tue, 7 Sep 2010 22:49:49 +0300
Eduardo Valentin wrote:
> Hello Jarkko,
>
> On Sun, Jun 13, 2010 at 08:09:28PM +0200, Jarkko Nikula wrote:
> > Convert the driver to use regulator framework instead of set_power callback.
> > This with gpio_reset platform data provide
Hi
On Mon, 2 Aug 2010 13:09:52 +0300
Jarkko Nikula wrote:
> On Mon, 05 Jul 2010 16:28:30 -0300
> Mauro Carvalho Chehab wrote:
>
> > Hi Eduardo,
> >
> > Could you please review those two patches?
> >
> Hmm.. are these two patches already late for 2.6.36?
On Mon, 05 Jul 2010 16:28:30 -0300
Mauro Carvalho Chehab wrote:
> Hi Eduardo,
>
> Could you please review those two patches?
>
Hmm.. are these two patches already late for 2.6.36? I have two another
patches to arch/arm/mach-omap2/board-rx51-peripherals.c and
sound/soc/omap/rx51.c that are pendi
On Mon, 05 Jul 2010 13:09:22 -0300
Mauro Carvalho Chehab wrote:
> Hi Eduardo,
>
> This patch is still on my queue. It is not clear to me what "proably fine"
> means...
> Please ack or nack on it for me to move ahead ;)
>
Ah, sorry, I should have nacked this myself after I sent the regulator
fr
On Sun, 13 Jun 2010 21:09:28 +0300
Jarkko Nikula wrote:
> Convert the driver to use regulator framework instead of set_power callback.
> This with gpio_reset platform data provide cleaner way to manage chip VIO,
> VDD and reset signal inside the driver.
>
> Signed-off-by: Jark
Convert the driver to use regulator framework instead of set_power callback.
This with gpio_reset platform data provide cleaner way to manage chip VIO,
VDD and reset signal inside the driver.
Signed-off-by: Jarkko Nikula
Cc: Eduardo Valentin
---
I don't have specifications for this chip
Call to i2c_put_adapter was missing in radio_si4713_pdriver_probe and
radio_si4713_pdriver_remove.
Signed-off-by: Jarkko Nikula
Cc: Eduardo Valentin
---
drivers/media/radio/radio-si4713.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/drivers/media/radio
On Tue, 18 May 2010 15:55:27 +0300
Eduardo Valentin wrote:
> I'm probably fine with this patch, and the driver must check for the pointer
> before using it, indeed.
>
> But, I'm a bit skeptic about marking its platform data as __initdata. Would
> it make sense?
> What happens if driver is built
oint to valid data
anymore after kernel is initialized.
Fix this by taking local copy of si4713_platform_data->set_power. Add also
NULL check for this function pointer.
Signed-off-by: Jarkko Nikula
Cc: Eduardo Valentin
---
drivers/media/radio/si4713-i2c.c | 15 +--
drivers/med
16 matches
Mail list logo
