Re: [PATCH] MAINTAINERS & files: Canonize the e-mails I use at files

urity number or whatever), with would be weird, IMO. > > As we all use e-mails to uniquely identify contributors submissions, > IMHO, the best is to keep using e-mails. The side effect is that > we should keep those emails updated. Understood but e-mails in code get stale eventually as people rarely update those. So I think having a contact email in MAINTAINERS and git logs is enough for practical purposes. Honza -- Jan Kara SUSE Labs, CR

Re: [PATCH v2 3/4] [media] v4l2: disable filesystem-dax mapping support

l can > coordinate revoking DMA access when the filesystem needs to truncate > mappings. > > Reported-by: Jan Kara > Cc: Mauro Carvalho Chehab > Cc: linux-media@vger.kernel.org > Cc: > Fixes: 3565fce3a659 ("mm, x86: get_user_pages() for dax mappings")

Re: [PATCH v2 2/4] mm: fail get_vaddr_frames() for filesystem-dax mappings

Cc: Inki Dae > Cc: Seung-Woo Kim > Cc: Joonyoung Shim > Cc: Kyungmin Park > Cc: Mauro Carvalho Chehab > Cc: linux-media@vger.kernel.org > Cc: Jan Kara > Cc: Mel Gorman > Cc: Vlastimil Babka > Cc: Andrew Morton > Cc: > Fixes: 3565fce3a659 ("mm, x86:

Re: [PATCH 05/10] mm: replace get_vaddr_frames() write/force parameters with gup_flags

r (and hence > bugs) within the mm subsystem. > > Signed-off-by: Lorenzo Stoakes Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > drivers/gpu/drm/exynos/exynos_drm_g2d.c| 3 ++- > drivers/media/pla

Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

r > (and > hence bugs) within the mm subsystem. > > Signed-off-by: Lorenzo Stoakes After our discussion the patch looks good to me. You can add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe fro

Re: [PATCH 08/10] mm: replace __access_remote_vm() write parameter with gup_flags

addr, buf, len, write); > + return __access_remote_vm(NULL, mm, addr, buf, len, > + write ? FOLL_WRITE : 0); > } > > /* > @@ -1871,7 +1873,8 @@ int access_process_vm(struct task_struct *tsk, unsigned > long addr, void *buf, in > if (!mm) >

Re: [PATCH 06/10] mm: replace get_user_pages() write/force parameters with gup_flags

hence > bugs) within the mm subsystem. > > Signed-off-by: Lorenzo Stoakes The patch looks good. You can add: Reviewed-by: Jan Kara Honza > --- > arch/cris/arch-v32/drivers/cryptocop.c |

Re: [PATCH 07/10] mm: replace get_user_pages_remote() write/force parameters with gup_flags

r > (and > hence bugs) within the mm subsystem. > > Signed-off-by: Lorenzo Stoakes Looks good. You can add: Reviewed-by: Jan Kara Honza > --- > drivers/gpu/drm/etnaviv/etnaviv_gem.c | 7 +-- > drivers/g

Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

On Tue 18-10-16 14:56:09, Lorenzo Stoakes wrote: > On Tue, Oct 18, 2016 at 02:54:25PM +0200, Jan Kara wrote: > > > @@ -1282,7 +1282,7 @@ long get_user_pages(unsigned long start, unsigned > > > long nr_pages, > > > int write,

Re: [PATCH 04/10] mm: replace get_user_pages_locked() write/force parameters with gup_flags

s second but I don't care that much. But it definitely should be consistent... Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 03/10] mm: replace get_user_pages_unlocked() write/force parameters with gup_flags

iour > (and > hence bugs) within the mm subsystem. > > Signed-off-by: Lorenzo Stoakes Looks good. You can add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line &quo

Re: [PATCH 02/10] mm: remove write/force parameters from __get_user_pages_unlocked()

> mm subsystem. > > Signed-off-by: Lorenzo Stoakes The patch looks good. You can add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-media"

Re: [PATCH 01/10] mm: remove write/force parameters from __get_user_pages_locked()

he mm subsystem. > > Signed-off-by: Lorenzo Stoakes Looks good. You can add: Reviewed-by: Jan Kara Honza -- Jan Kara SUSE Labs, CR -- To unsubscribe from this list: send the line "unsubscribe linux-media" in

Re: [PATCH 1/2] [media] vb2-memops: Fix over allocation of frame vectors

> Signed-off-by: Ricardo Ribalda Delgado The patch looks good. Thanks for fixing this! You can add: Reviewed-by: Jan Kara Honza > --- > > Maybe we should cc stable. > > This error has not pop-out yet because userp

[PATCH 0/7] get_user_pages() cleanup

From: Jan Kara Hello, Now when the usage of get_user_pages() in media drivers got cleaned up, here comes a series which removes knowledge about mmap_sem from a couple of other drivers. Patches are trivial and standalone but please check, they are only compile tested. If you are OK with them

[PATCH 7/7] [media] ivtv: Convert to get_user_pages_unlocked()

From: Jan Kara Convert ivtv_yuv_prep_user_dma() to use get_user_pages_unlocked() so that we don't unnecessarily leak knowledge about mm locking into drivers code. CC: Andy Walls CC: Mauro Carvalho Chehab CC: linux-media@vger.kernel.org Signed-off-by: Jan Kara --- drivers/media/pci/ivtv

Re: [PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

On Sat 18-07-15 12:14:12, Inki Dae wrote: > On 2015년 07월 17일 19:31, Hans Verkuil wrote: > > On 07/17/2015 12:29 PM, Inki Dae wrote: > >> On 2015년 07월 17일 19:20, Hans Verkuil wrote: > >>> On 07/13/2015 04:55 PM, Jan Kara wrote: > >>>> From: Jan Kara &

[PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns()

From: Jan Kara Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() instead of hand made mapping of virtual address to physical address. Also the function leaked page reference from get_user_pages() so fix that by properly release the reference when omap_vout_buffer_release() is called

[PATCH 4/9] vb2: Provide helpers for mapping virtual addresses

From: Jan Kara Provide simple helper functions to map virtual address range into an array of pfns / pages. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/Kconfig| 1 + drivers/media/v4l2-core/videobuf2-memops.c | 58

[PATCH 6/9] media: vb2: Convert vb2_vmalloc_get_userptr() to use frame vector

From: Jan Kara Convert vb2_vmalloc_get_userptr() to use frame vector infrastructure. When we are doing that there's no need to allocate page array and some code can be simplified. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2

[PATCH 2/9] mm: Provide new get_vaddr_frames() helper

From: Jan Kara Provide new function get_vaddr_frames(). This function maps virtual addresses from given start and fills given array with page frame numbers of the corresponding pages. If given start belongs to a normal vma, the function grabs reference to each of the pages to pin them in memory

[PATCH 1/9] [media] vb2: Push mmap_sem down to memops

From: Jan Kara Currently vb2 core acquires mmap_sem just around call to __qbuf_userptr(). However since commit f035eb4e976ef5 (videobuf2: fix lockdep warning) it isn't necessary to acquire it so early as we no longer have to drop queue mutex before acquiring mmap_sem. So push acquisiti

[PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

From: Jan Kara Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_frames(). This removes the knowledge about vmas and mmap_sem locking from exynos driver. Also it fixes a problem that the function has been mapping user provided address without holding mmap_sem. Signed-off-by: Jan

[PATCH 0/9 v7] Helper to abstract vma handling in media layer

From: Jan Kara Hello, I'm sending the seventh version of my patch series to abstract vma handling from the various media drivers. Since the previous version there are just minor cleanups and fixes (see detailed changelog at the end of the email). After this patch set drivers have to

[PATCH 5/9] media: vb2: Convert vb2_dma_sg_get_userptr() to use frame vector

From: Jan Kara Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-sg.c | 95 +- 1 file changed, 15 insertions(+), 80 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c b

[PATCH 8/9] media: vb2: Remove unused functions

From: Jan Kara Conversion to the use of pinned pfns made some functions unused. Remove them. Also there's no need to lock mmap_sem in __buf_prepare() anymore. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-memops.c

[PATCH 7/9] media: vb2: Convert vb2_dc_get_userptr() to use frame vector

From: Jan Kara Convert vb2_dc_get_userptr() to use frame vector infrastructure. When we are doing that there's no need to allocate page array and some code can be simplified. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/vide

Re: [PATCH 0/10 v6] Helper to abstract vma handling in media layer

On Mon 13-07-15 10:45:25, Hans Verkuil wrote: > On 07/09/2015 02:12 PM, Hans Verkuil wrote: > > On 07/09/2015 01:48 PM, Jan Kara wrote: > >> Hello, > >> > >> Hans, did you have a chance to look at these patches? I have tested them > >> with the v

Re: [PATCH 0/10 v6] Helper to abstract vma handling in media layer

... Honza On Thu 18-06-15 16:08:30, Jan Kara wrote: > Hello, > > I'm sending the sixth version of my patch series to abstract vma handling from > the various media drivers. Since the previous version I have added a patch to > mo

[PATCH 10/10] mm: Move get_vaddr_frames() behind a config option

98 - -98 get_vaddr_frames 485 --485 Suggested-by: Andrew Morton Signed-off-by: Jan Kara --- drivers/gpu/drm/exynos/Kconfig | 1 + drivers/media/platform/omap/Kconfig | 1 + drivers/media/v4l2-core/Kconfig | 1

[PATCH 8/10] media: vb2: Remove unused functions

Conversion to the use of pinned pfns made some functions unused. Remove them. Also there's no need to lock mmap_sem in __buf_prepare() anymore. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-memops.c

[PATCH 5/10] media: vb2: Convert vb2_dma_sg_get_userptr() to use frame vector

Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-sg.c | 95 +- 1 file changed, 15 insertions(+), 80 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c b/drivers/media/v4l2

[PATCH 3/10] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns()

: Jan Kara --- drivers/media/platform/omap/omap_vout.c | 67 +++-- 1 file changed, 31 insertions(+), 36 deletions(-) diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c index 17b189a81ec5..0e4b3cfacc5d 100644 --- a/drivers/media

[PATCH 6/10] media: vb2: Convert vb2_vmalloc_get_userptr() to use frame vector

Convert vb2_vmalloc_get_userptr() to use frame vector infrastructure. When we are doing that there's no need to allocate page array and some code can be simplified. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-vmal

[PATCH 7/10] media: vb2: Convert vb2_dc_get_userptr() to use frame vector

Convert vb2_dc_get_userptr() to use frame vector infrastructure. When we are doing that there's no need to allocate page array and some code can be simplified. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-con

[PATCH 1/10] [media] vb2: Push mmap_sem down to memops

ole locking mess will get resolved once we convert videobuf2 core to the new mm helper which avoids the need for mmap_sem in .put_userptr memop altogether. Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-core.c | 2 -- drivers/media/v4l2-core/videobuf2-dma-contig.c | 5 +

[PATCH 9/10] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_frames(). This removes the knowledge about vmas and mmap_sem locking from exynos driver. Also it fixes a problem that the function has been mapping user provided address without holding mmap_sem. Signed-off-by: Jan Kara --- drivers

[PATCH 2/10] mm: Provide new get_vaddr_frames() helper

belongs to VM_IO | VM_PFNMAP vma, we don't touch page structures. Caller must make sure pfns aren't reused for anything else while he is using them. This function is created for various drivers to simplify handling of their buffers. Acked-by: Mel Gorman Acked-by: Vlastimil Babka Signed-o

[PATCH 4/10] vb2: Provide helpers for mapping virtual addresses

Provide simple helper functions to map virtual address range into an array of pfns / pages. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-memops.c | 58 ++ include/media/videobuf2-memops.h

[PATCH 0/10 v6] Helper to abstract vma handling in media layer

Hello, I'm sending the sixth version of my patch series to abstract vma handling from the various media drivers. Since the previous version I have added a patch to move mm helpers into a separate file and behind a config option. I also changed patch pushing mmap_sem down in videobuf2 core to avo

Re: [PATCH 9/9] [media] mm: Move get_vaddr_frames() behind a config option

On Wed 10-06-15 09:37:20, Josh Triplett wrote: > On Wed, Jun 10, 2015 at 06:20:52AM -0300, Mauro Carvalho Chehab wrote: > > From: Jan Kara > > > > get_vaddr_frames() is used by relatively rare drivers so hide it and the > > related functions behind a config opti

Re: [PATCH] Revert "[media] vb2: Push mmap_sem down to memops"

On Thu 18-06-15 12:45:26, Hans Verkuil wrote: > On 06/18/2015 12:33 PM, Jan Kara wrote: > > On Mon 15-06-15 09:24:55, Hans Verkuil wrote: > >> This reverts commit 48b25a3a713b90988b6882d318f7c0a6bed9aabc. > >> > >> That commit caused two regressions. The firs

Re: [PATCH] Revert "[media] vb2: Push mmap_sem down to memops"

49.376820] [] > vivid_fop_release+0x92/0x230 [vivid] > Jun 14 18:44:07 test-media kernel: [ 49.376822] [] > v4l2_release+0x30/0x80 [videodev] > Jun 14 18:44:07 test-media kernel: [ 49.376824] [] > __fput+0xe5/0x200 > Jun 14 18:44:07 test-media kernel: [ 49.376825]

Re: [git:media_tree/master] [media] vb2: Push mmap_sem down to memops

from __qbuf_userptr, but > not when called from __vb2_queue_free. I will see if I have time to dig into > this during the weekend and solve it, but if not, then this has to be reverted > and the get_vaddr_frames() patch series postponed since it depends on this > one. > > Rega

Re: [PATCH 2/9] mm: Provide new get_vaddr_frames() helper

On Tue 02-06-15 15:29:12, Andrew Morton wrote: > On Tue, 2 Jun 2015 17:23:00 +0200 Jan Kara wrote: > > > > That's a lump of new code which many kernels won't be needing. Can we > > > put all this in a new .c file and select it within drivers/media > >

Re: [PATCH 2/9] mm: Provide new get_vaddr_frames() helper

On Thu 28-05-15 16:24:02, Andrew Morton wrote: > On Wed, 13 May 2015 15:08:08 +0200 Jan Kara wrote: > > > Provide new function get_vaddr_frames(). This function maps virtual > > addresses from given start and fills given array with page frame numbers of > > the corre

Re: [PATCH 2/9] mm: Provide new get_vaddr_frames() helper

On Thu 28-05-15 16:24:02, Andrew Morton wrote: > On Wed, 13 May 2015 15:08:08 +0200 Jan Kara wrote: > > > Provide new function get_vaddr_frames(). This function maps virtual > > addresses from given start and fills given array with page frame numbers of > > the corre

Re: [PATCH 0/9 v5] Helper to abstract vma handling in media layer

On Mon 25-05-15 13:37:56, Hans Verkuil wrote: > Hi Jan, > > On 05/13/2015 03:08 PM, Jan Kara wrote: > > Hello, > > > > I'm sending the fifth version of my patch series to abstract vma handling > > from the various media drivers. The patches got some revi

Re: [PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

On Thu 14-05-15 19:51:23, Inki Dae wrote: > Hi, > > On 2015년 05월 13일 22:08, Jan Kara wrote: > > Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_frames(). > > This removes the knowledge about vmas and mmap_sem locking from exynos > > driver. Also

[PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns()

: Jan Kara --- drivers/media/platform/omap/omap_vout.c | 67 +++-- 1 file changed, 31 insertions(+), 36 deletions(-) diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c index 17b189a81ec5..0e4b3cfacc5d 100644 --- a/drivers/media

[PATCH 1/9] [media] vb2: Push mmap_sem down to memops

into .get_userptr and .put_userptr memops so that the semaphore is acquired for a shorter time and it is clearer what it is needed for. Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-core.c | 2 -- drivers/media/v4l2-core/videobuf2-dma-contig.c | 7 +++ drivers/media/v4l2

[PATCH 4/9] vb2: Provide helpers for mapping virtual addresses

Provide simple helper functions to map virtual address range into an array of pfns / pages. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-memops.c | 58 ++ include/media/videobuf2-memops.h

[PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_frames(). This removes the knowledge about vmas and mmap_sem locking from exynos driver. Also it fixes a problem that the function has been mapping user provided address without holding mmap_sem. Signed-off-by: Jan Kara --- drivers

[PATCH 7/9] media: vb2: Convert vb2_dc_get_userptr() to use frame vector

Convert vb2_dc_get_userptr() to use frame vector infrastructure. When we are doing that there's no need to allocate page array and some code can be simplified. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-con

[PATCH 8/9] media: vb2: Remove unused functions

Conversion to the use of pinned pfns made some functions unused. Remove them. Also there's no need to lock mmap_sem in __buf_prepare() anymore. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-memops.c

[PATCH 5/9] media: vb2: Convert vb2_dma_sg_get_userptr() to use frame vector

Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-sg.c | 97 +- 1 file changed, 15 insertions(+), 82 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c b/drivers/media/v4l2

[PATCH 0/9 v5] Helper to abstract vma handling in media layer

Hello, I'm sending the fifth version of my patch series to abstract vma handling from the various media drivers. The patches got some review from mm people and testing from device driver guys so unless someone objects, patches will be queued in media tree for the next merge window. After this p

[PATCH 6/9] media: vb2: Convert vb2_vmalloc_get_userptr() to use frame vector

Convert vb2_vmalloc_get_userptr() to use frame vector infrastructure. When we are doing that there's no need to allocate page array and some code can be simplified. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-vmal

[PATCH 2/9] mm: Provide new get_vaddr_frames() helper

belongs to VM_IO | VM_PFNMAP vma, we don't touch page structures. Caller must make sure pfns aren't reused for anything else while he is using them. This function is created for various drivers to simplify handling of their buffers. Acked-by: Mel Gorman Acked-by: Vlastimil Babka Signed-o

Re: [PATCH 2/9] mm: Provide new get_vaddr_frames() helper

On Fri 08-05-15 15:49:22, Mel Gorman wrote: > On Wed, May 06, 2015 at 09:28:09AM +0200, Jan Kara wrote: > > Provide new function get_vaddr_frames(). This function maps virtual > > addresses from given start and fills given array with page frame numbers of > > the correspo

Re: [PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns()

On Wed 06-05-15 12:46:42, Vlastimil Babka wrote: > On 05/06/2015 09:28 AM, Jan Kara wrote: > >Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns() instead of > >hand made mapping of virtual address to physical address. Also the > >function leaked page reference from ge

Re: [PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

On Wed 06-05-15 12:47:35, Vlastimil Babka wrote: > On 05/06/2015 09:28 AM, Jan Kara wrote: > >Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_frames(). > >This removes the knowledge about vmas and mmap_sem locking from exynos > >driver. Also it fixes a problem

Re: [PATCH 2/9] mm: Provide new get_vaddr_frames() helper

On Wed 06-05-15 12:45:51, Vlastimil Babka wrote: > On 05/06/2015 09:28 AM, Jan Kara wrote: > >Provide new function get_vaddr_frames(). This function maps virtual > >addresses from given start and fills given array with page frame numbers of > >the corresponding pages. If giv

[PATCH 2/9] mm: Provide new get_vaddr_frames() helper

belongs to VM_IO | VM_PFNMAP vma, we don't touch page structures. Caller must make sure pfns aren't reused for anything else while he is using them. This function is created for various drivers to simplify handling of their buffers. Signed-off-by: Jan Kara --- include/linux/mm.h | 44 +

[PATCH 1/9] [media] vb2: Push mmap_sem down to memops

into .get_userptr and .put_userptr memops so that the semaphore is acquired for a shorter time and it is clearer what it is needed for. Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-core.c | 2 -- drivers/media/v4l2-core/videobuf2-dma-contig.c | 7 +++ drivers/media/v4l2

[PATCH 8/9] media: vb2: Remove unused functions

Conversion to the use of pinned pfns made some functions unused. Remove them. Also there's no need to lock mmap_sem in __buf_prepare() anymore. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-memops.c

[PATCH 6/9] media: vb2: Convert vb2_vmalloc_get_userptr() to use frame vector

Convert vb2_vmalloc_get_userptr() to use frame vector infrastructure. When we are doing that there's no need to allocate page array and some code can be simplified. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-vmal

[PATCH 7/9] media: vb2: Convert vb2_dc_get_userptr() to use frame vector

Convert vb2_dc_get_userptr() to use frame vector infrastructure. When we are doing that there's no need to allocate page array and some code can be simplified. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-con

[PATCH 5/9] media: vb2: Convert vb2_dma_sg_get_userptr() to use frame vector

Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-sg.c | 97 +- 1 file changed, 15 insertions(+), 82 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c b/drivers/media/v4l2

[PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_frames(). This removes the knowledge about vmas and mmap_sem locking from exynos driver. Also it fixes a problem that the function has been mapping user provided address without holding mmap_sem. Signed-off-by: Jan Kara --- drivers

[PATCH 0/9 v4] Helper to abstract vma handling in media layer

Hello, Sorry for a quick resend but the missing vmalloc include in mm/gup.c is annoying for archs that need it and I was also told to extend CC list a bit. I'm sending the fourth version of my patch series to abstract vma handling from the various media drivers. After this patch set drivers h

[PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns()

: Jan Kara --- drivers/media/platform/omap/omap_vout.c | 67 +++-- 1 file changed, 31 insertions(+), 36 deletions(-) diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c index 17b189a81ec5..d3f6d82ccbc1 100644 --- a/drivers/media

[PATCH 4/9] vb2: Provide helpers for mapping virtual addresses

Provide simple helper functions to map virtual address range into an array of pfns / pages. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-memops.c | 58 ++ include/media/videobuf2-memops.h

[PATCH 0/9 v3] Helper to abstract vma handling in media layer

Hello, I'm sending the third version of my patch series to abstract vma handling from the various media drivers. After this patch set drivers have to know much less details about vmas, their types, and locking. Also quite some code is removed from them. As a bonus drivers get automatically VM_

[PATCH 7/9] media: vb2: Convert vb2_dc_get_userptr() to use frame vector

Convert vb2_dc_get_userptr() to use frame vector infrastructure. When we are doing that there's no need to allocate page array and some code can be simplified. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-con

[PATCH 8/9] media: vb2: Remove unused functions

Conversion to the use of pinned pfns made some functions unused. Remove them. Also there's no need to lock mmap_sem in __buf_prepare() anymore. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-memops.c

[PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_frames()

Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_frames(). This removes the knowledge about vmas and mmap_sem locking from exynos driver. Also it fixes a problem that the function has been mapping user provided address without holding mmap_sem. Signed-off-by: Jan Kara --- drivers

[PATCH 2/9] mm: Provide new get_vaddr_frames() helper

belongs to VM_IO | VM_PFNMAP vma, we don't touch page structures. Caller must make sure pfns aren't reused for anything else while he is using them. This function is created for various drivers to simplify handling of their buffers. Signed-off-by: Jan Kara --- include/linux/mm.h | 44 +

[PATCH 1/9] [media] vb2: Push mmap_sem down to memops

into .get_userptr and .put_userptr memops so that the semaphore is acquired for a shorter time and it is clearer what it is needed for. Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-core.c | 2 -- drivers/media/v4l2-core/videobuf2-dma-contig.c | 7 +++ drivers/media/v4l2

[PATCH 6/9] media: vb2: Convert vb2_vmalloc_get_userptr() to use frame vector

Convert vb2_vmalloc_get_userptr() to use frame vector infrastructure. When we are doing that there's no need to allocate page array and some code can be simplified. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-vmal

[PATCH 4/9] vb2: Provide helpers for mapping virtual addresses

Provide simple helper functions to map virtual address range into an array of pfns / pages. Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-memops.c | 58 ++ include/media/videobuf2-memops.h

[PATCH 5/9] media: vb2: Convert vb2_dma_sg_get_userptr() to use frame vector

Acked-by: Marek Szyprowski Tested-by: Marek Szyprowski Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-sg.c | 97 +- 1 file changed, 15 insertions(+), 82 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c b/drivers/media/v4l2

[PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns()

: Jan Kara --- drivers/media/platform/omap/omap_vout.c | 67 +++-- 1 file changed, 31 insertions(+), 36 deletions(-) diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c index 17b189a81ec5..d3f6d82ccbc1 100644 --- a/drivers/media

Re: [PATCH 2/9] mm: Provide new get_vaddr_pfns() helper

On Thu 30-04-15 16:55:31, Mel Gorman wrote: > On Tue, Mar 17, 2015 at 12:56:32PM +0100, Jan Kara wrote: > > Provide new function get_vaddr_pfns(). This function maps virtual > > addresses from given start and fills given array with page frame numbers of > > the corresponding

Re: [PATCH 1/9] mm: Provide new get_vaddr_pfns() helper

On Mon 17-03-14 20:49:28, Jan Kara wrote: > Provide new function get_vaddr_pfns(). This function maps virtual > addresses from given start and fills given array with page frame numbers of > the corresponding pages. If given start belongs to a normal vma, the function > grabs referenc

Re: [PATCH 0/9 v2] Helper to abstract vma handling in media layer

On Fri 24-04-15 13:07:37, Hans Verkuil wrote: > Hi Marek, > > On 04/24/2015 12:59 PM, Marek Szyprowski wrote: > > Dear All, > > > > On 2015-04-02 17:25, Hans Verkuil wrote: > >> On 04/02/2015 05:02 PM, Jan Kara wrote: > >>> Hello, >

Re: [PATCH 0/9 v2] Helper to abstract vma handling in media layer

Hello, On Tue 17-03-15 12:56:30, Jan Kara wrote: > After a long pause I'm sending second version of my patch series to abstract > vma handling from the various media drivers. After this patch set drivers have > to know much less details about vmas, their types, and locking.

[PATCH 5/9] media: vb2: Convert vb2_dma_sg_get_userptr() to use pinned pfns

Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-sg.c | 97 +- 1 file changed, 15 insertions(+), 82 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-dma-sg.c b/drivers/media/v4l2-core/videobuf2-dma-sg.c index 71510e4f7d7c..cc82c30d02cf

[PATCH 1/9] [media] vb2: Push mmap_sem down to memops

into .get_userptr and .put_userptr memops so that the semaphore is acquired for a shorter time and it is clearer what it is needed for. Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-core.c | 2 -- drivers/media/v4l2-core/videobuf2-dma-contig.c | 7 +++ drivers/media/v4l2

[PATCH 2/9] mm: Provide new get_vaddr_pfns() helper

to VM_IO | VM_PFNMAP vma, we don't touch page structures. Caller should make sure pfns aren't reused for anything else while he is using them. This function is created for various drivers to simplify handling of their buffers. Signed-off-by: Jan Kara --- include/linux/mm.h | 38 +

[PATCH 0/9 v2] Helper to abstract vma handling in media layer

Hello, After a long pause I'm sending second version of my patch series to abstract vma handling from the various media drivers. After this patch set drivers have to know much less details about vmas, their types, and locking. My motivation for the series is that I want to change get_user_page

[PATCH 8/9] media: vb2: Remove unused functions

Conversion to the use of pinned pfns made some functions unused. Remove them. Also there's no need to lock mmap_sem in __buf_prepare() anymore. Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-memops.c | 114 - include/media/videobuf2-mem

[PATCH 7/9] media: vb2: Convert vb2_dc_get_userptr() to use pfns vector

Convert vb2_dc_get_userptr() to use passed vector of pfns. When we are doing that there's no need to allocate page array and some code can be simplified. Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-dma-contig.c | 213 - 1 file changed, 32 inser

[PATCH 9/9] drm/exynos: Convert g2d_userptr_get_dma_addr() to use get_vaddr_pfn()

Convert g2d_userptr_get_dma_addr() to pin pages using get_vaddr_pfn(). This removes the knowledge about vmas and mmap_sem locking from exynos driver. Also it fixes a problem that the function has been mapping user provided address without holding mmap_sem. Signed-off-by: Jan Kara --- drivers

[PATCH 6/9] media: vb2: Convert vb2_vmalloc_get_userptr() to use pfns vector

Convert vb2_vmalloc_get_userptr() to use passed vector of pfns. When we are doing that there's no need to allocate page array and some code can be simplified. Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-vmalloc.c | 94 +++-- 1 file change

[PATCH 4/9] vb2: Provide helpers for mapping virtual addresses

Provide simple helper functions to map virtual address range into an array of pfns. Signed-off-by: Jan Kara --- drivers/media/v4l2-core/videobuf2-memops.c | 57 ++ include/media/videobuf2-memops.h | 4 +++ 2 files changed, 61 insertions(+) diff --git a

[PATCH 3/9] media: omap_vout: Convert omap_vout_uservirt_to_phys() to use get_vaddr_pfns()

: Jan Kara --- drivers/media/platform/omap/omap_vout.c | 67 +++-- 1 file changed, 31 insertions(+), 36 deletions(-) diff --git a/drivers/media/platform/omap/omap_vout.c b/drivers/media/platform/omap/omap_vout.c index ba2d8f973d58..e7d342bb71dd 100644 --- a/drivers/media

Use of mmap_sem in __qbuf_userptr()

#x27;m right, I can prepare patches to do that (and then on top of those rebase patches which will make v4l2 core use some mm helper functions so they don't have to care about details of mm locking, vmas, etc.). Honza -- Jan

Re: [PATCHv2] videobuf2-core: take mmap_sem before calling __qbuf_userptr

d around the call to > __qbuf_userptr. Amazingly nobody noticed this (especially me as the author) > until Jan Kara pointed this out to me. > > Signed-off-by: Hans Verkuil > Reported-by: Jan Kara The patch looks good to me.

Re: [PATCH] videobuf2-core: take mmap_sem before calling __qbuf_userptr

On Fri 22-08-14 18:01:09, Hans Verkuil wrote: > Commit f035eb4e976ef5a059e30bc91cfd310ff030a7d3 (videobuf2: fix lockdep > warning) > unfortunately removed the mmap_sem lock that is needed around the call to > __qbuf_userptr. Amazingly nobody noticed this until Jan Kara pointed this

  1   2   >